173083 2017-06-07 17:59:00 -0700 Crash inside WebKit::PluginView::getAuthenticationInfo 2017-06-09 22:11:43 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rniwa rniwa achristensen andersca cdumez commit-queue darin ddkilzer oldest_to_newest 1316736 0 rniwa 2017-06-07 17:59:00 -0700 Add a null pointer check. 1316737 1 rniwa 2017-06-07 17:59:23 -0700 <rdar://problem/32513144> 1316747 2 312264 rniwa 2017-06-07 18:48:00 -0700 Created attachment 312264 Fixes the bug 1316752 3 312264 cdumez 2017-06-07 19:33:13 -0700 Comment on attachment 312264 Fixes the bug r=me 1316784 4 312264 commit-queue 2017-06-07 20:10:46 -0700 Comment on attachment 312264 Fixes the bug Clearing flags on attachment: 312264 Committed r217914: <http://trac.webkit.org/changeset/217914> 1316785 5 commit-queue 2017-06-07 20:10:48 -0700 All reviewed patches have been landed. Closing bug. 1317180 6 rniwa 2017-06-08 20:16:39 -0700 This is likely a regression from https://trac.webkit.org/changeset/164195. 1317459 7 312264 darin 2017-06-09 09:59:43 -0700 Comment on attachment 312264 Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=312264&action=review > Source/WebKit2/WebProcess/Plugins/PluginView.cpp:1597 > + RefPtr<Document> contentDocument = m_pluginElement->contentDocument(); Why RefPtr? Seems unnecessary if we are just getting a pointer and then immediately dereferencing it. 1317668 8 312264 rniwa 2017-06-09 15:26:25 -0700 Comment on attachment 312264 Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=312264&action=review >> Source/WebKit2/WebProcess/Plugins/PluginView.cpp:1597 >> + RefPtr<Document> contentDocument = m_pluginElement->contentDocument(); > > Why RefPtr? Seems unnecessary if we are just getting a pointer and then immediately dereferencing it. Oh yeah, I don't know why I used RefPtr here. Will fix. 1317859 9 rniwa 2017-06-09 22:11:43 -0700 Addressed the comment in https://trac.webkit.org/changeset/218046. 312264 2017-06-07 18:48:00 -0700 2017-06-07 20:10:46 -0700 Fixes the bug bug-173083-20170607184800.patch text/plain 1782 rniwa SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxNzkxMykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE3LTA2LTA3ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIENyYXNoIGluc2lkZSBXZWJLaXQ6 OlBsdWdpblZpZXc6OmdldEF1dGhlbnRpY2F0aW9uSW5mbworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTczMDgzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkZWQgYSBudWxsIHBvaW50ZXIgY2hlY2suIFRo ZSBjb250ZW50IGRvY3VtZW50IG1heSBoYXZlIHdlbnQgYXdheSBieSB0aGUgdGltZSB3ZSBnZXQg dGhlcmUgZnJvbSBJUEMuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1BsdWdpbnMvUGx1Z2luVmll dy5jcHA6CisgICAgICAgIChXZWJLaXQ6OlBsdWdpblZpZXc6OmdldEF1dGhlbnRpY2F0aW9uSW5m byk6CisKIDIwMTctMDYtMDcgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAg ICAgICAgIGdldFVzZXJNZWRpYSBpcyBwcm9tcHRpbmcgdG9vIG9mdGVuCkluZGV4OiBTb3VyY2Uv V2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUGx1Z2luVmlldy5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1BsdWdpblZpZXcuY3BwCShyZXZpc2lv biAyMTc5MDMpCisrKyBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUGx1Z2luVmll dy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE1OTQsNyArMTU5NCwxMSBAQCB2b2lkIFBsdWdpblZp ZXc6OnNldENvb2tpZXNGb3JVUkwoY29uc3QgCiAKIGJvb2wgUGx1Z2luVmlldzo6Z2V0QXV0aGVu dGljYXRpb25JbmZvKGNvbnN0IFByb3RlY3Rpb25TcGFjZSYgcHJvdGVjdGlvblNwYWNlLCBTdHJp bmcmIHVzZXJuYW1lLCBTdHJpbmcmIHBhc3N3b3JkKQogewotICAgIFN0cmluZyBwYXJ0aXRpb25O YW1lID0gbV9wbHVnaW5FbGVtZW50LT5jb250ZW50RG9jdW1lbnQoKS0+dG9wRG9jdW1lbnQoKS5z ZWN1cml0eU9yaWdpbigpLmRvbWFpbkZvckNhY2hlUGFydGl0aW9uKCk7CisgICAgUmVmUHRyPERv Y3VtZW50PiBjb250ZW50RG9jdW1lbnQgPSBtX3BsdWdpbkVsZW1lbnQtPmNvbnRlbnREb2N1bWVu dCgpOworICAgIGlmICghY29udGVudERvY3VtZW50KQorICAgICAgICByZXR1cm4gZmFsc2U7CisK KyAgICBTdHJpbmcgcGFydGl0aW9uTmFtZSA9IGNvbnRlbnREb2N1bWVudC0+dG9wRG9jdW1lbnQo KS5zZWN1cml0eU9yaWdpbigpLmRvbWFpbkZvckNhY2hlUGFydGl0aW9uKCk7CiAgICAgQ3JlZGVu dGlhbCBjcmVkZW50aWFsID0gQ3JlZGVudGlhbFN0b3JhZ2U6OmRlZmF1bHRDcmVkZW50aWFsU3Rv cmFnZSgpLmdldChwYXJ0aXRpb25OYW1lLCBwcm90ZWN0aW9uU3BhY2UpOwogICAgIGlmIChjcmVk ZW50aWFsLmlzRW1wdHkoKSkKICAgICAgICAgY3JlZGVudGlhbCA9IENyZWRlbnRpYWxTdG9yYWdl OjpkZWZhdWx0Q3JlZGVudGlhbFN0b3JhZ2UoKS5nZXRGcm9tUGVyc2lzdGVudFN0b3JhZ2UocHJv dGVjdGlvblNwYWNlKTsK