173075 2017-06-07 14:57:26 -0700 Restrict the regress-173035.js test to only run on Darwin x86-64. 2017-06-07 15:39:11 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mark.lam mark.lam commit-queue jlewis3 ryanhaddad saam oldest_to_newest 1316656 0 mark.lam 2017-06-07 14:57:26 -0700 This is because the 32-bit x86 build will fail to mmap the 0x3f900000 bytes that this test will require to succeed. Here's an example of this failure: https://build.webkit.org/builders/Apple%20Sierra%2032-bit%20JSC%20%28BuildAndTest%29/builds/866/steps/webkit-32bit-jsc-test/logs/stdio Since the issue is due to allocation of a very large amount of memory, the test will probably fail on iOS and other platforms as well. Hence, we should just skip this test for any platforms that is not Darwin x86-64. 1316657 1 312235 mark.lam 2017-06-07 15:00:11 -0700 Created attachment 312235 proposed patch. 1316683 2 312235 commit-queue 2017-06-07 15:39:09 -0700 Comment on attachment 312235 proposed patch. Clearing flags on attachment: 312235 Committed r217909: <http://trac.webkit.org/changeset/217909> 1316684 3 commit-queue 2017-06-07 15:39:11 -0700 All reviewed patches have been landed. Closing bug. 312235 2017-06-07 15:00:11 -0700 2017-06-07 15:39:09 -0700 proposed patch. bug-173075.patch text/plain 1538 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMTc5MDMpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDIwIEBACisyMDE3LTA2LTA3ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBSZXN0cmljdCB0aGUgcmVncmVzcy0xNzMwMzUuanMgdGVzdCB0byBvbmx5 IHJ1biBvbiBEYXJ3aW4geDg2LTY0LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTczMDc1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgVGhpcyBpcyBiZWNhdXNlIHRoZSAzMi1iaXQgeDg2IGJ1aWxkIHdpbGwg ZmFpbCB0byBtbWFwIHRoZSAweDNmOTAwMDAwIGJ5dGVzIHRoYXQKKyAgICAgICAgdGhpcyB0ZXN0 IHdpbGwgcmVxdWlyZSB0byBzdWNjZWVkLiAgSGVyZSdzIGFuIGV4YW1wbGUgb2YgdGhpcyBmYWls dXJlOgorICAgICAgICBodHRwczovL2J1aWxkLndlYmtpdC5vcmcvYnVpbGRlcnMvQXBwbGUlMjBT aWVycmElMjAzMi1iaXQlMjBKU0MlMjAlMjhCdWlsZEFuZFRlc3QlMjkvYnVpbGRzLzg2Ni9zdGVw cy93ZWJraXQtMzJiaXQtanNjLXRlc3QvbG9ncy9zdGRpbworCisgICAgICAgIFNpbmNlIHRoZSBp c3N1ZSBpcyBkdWUgdG8gYWxsb2NhdGlvbiBvZiBhIHZlcnkgbGFyZ2UgYW1vdW50IG9mIG1lbW9y eSwgdGhlIHRlc3QKKyAgICAgICAgd2lsbCBwcm9iYWJseSBmYWlsIG9uIGlPUyBhbmQgb3RoZXIg cGxhdGZvcm1zIGFzIHdlbGwuICBIZW5jZSwgd2Ugc2hvdWxkIGp1c3QKKyAgICAgICAgc2tpcCB0 aGlzIHRlc3QgZm9yIGFueSBwbGF0Zm9ybXMgdGhhdCBpcyBub3QgRGFyd2luIHg4Ni02NC4KKwor ICAgICAgICAqIHN0cmVzcy9yZWdyZXNzLTE3MzAzNS5qczoKKwogMjAxNy0wNi0wNyAgTWFyayBM YW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAgQVNTRVJUSU9OIGZhaWx1cmU6ICFt YXNxdWVyYWRlc0FzVW5kZWZpbmVkV2F0Y2hwb2ludElzU3RpbGxWYWxpZCgpIHx8ICFpc0tub3du Q2VsbChvcGVyYW5kLm5vZGUoKSkKSW5kZXg6IEpTVGVzdHMvc3RyZXNzL3JlZ3Jlc3MtMTczMDM1 LmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvc3RyZXNzL3JlZ3Jlc3MtMTczMDM1LmpzCShyZXZp c2lvbiAyMTc4OTgpCisrKyBKU1Rlc3RzL3N0cmVzcy9yZWdyZXNzLTE3MzAzNS5qcwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDUgQEAKKy8vQCBza2lwIGlmICgkaG9zdE9TICE9ICIiIHx8ICRh cmNoaXRlY3R1cmUgIT0gIng4Ni02NCIpCisKIHZhciBhID0gW107CiBmb3IgKHZhciBpPTA7IGk8 MHgwNDAwMTAwMDsgaSsrKSBhLnB1c2goaSswLjEpOwogYS5sZW5ndGggPSAweDIwMDAwMDAwOwo=