173066 2017-06-07 10:35:10 -0700 [CMake] Only force response files for Ninja with CMake < 3.2 on Linux 2017-06-07 11:41:14 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=170105 P2 Normal --- 1 loic.yhuel webkit-unassigned bugs-noreply clopez commit-queue mcatanzaro tpopela oldest_to_newest 1316533 0 loic.yhuel 2017-06-07 10:35:10 -0700 [CMake] Only force response files for Ninja with CMake < 3.2 on Linux 1316534 1 312195 loic.yhuel 2017-06-07 10:36:41 -0700 Created attachment 312195 Patch 1316540 2 loic.yhuel 2017-06-07 10:48:52 -0700 CMake uses response files when needed, but the limit was wrong on Linux (https://cmake.org/Bug/view.php?id=14892, fixed in CMake 3.2). It created the original https://bugs.webkit.org/show_bug.cgi?id=129771, with "argument list too long" errors. CMake 3.6 added response file support for compile rules (which created https://bugs.webkit.org/show_bug.cgi?id=168770 since we forced the response files). On Linux, CMake >= 3.2 uses response files as needed (ie only for libWebCore.a). Hopefully platforms which don't support response files (FreeBSD, Apple) have a big enough command line length limit (sysconf(_SC_ARG_MAX)) to avoid them. 1316543 3 312195 mcatanzaro 2017-06-07 10:51:26 -0700 Comment on attachment 312195 Patch Thanks, let's try it! I only wonder if we still need the conditionals to force disable response files when using icecc. Carlos Lopez, Tom, what do you think? 1316552 4 loic.yhuel 2017-06-07 11:09:55 -0700 (In reply to Michael Catanzaro from comment #3) > Comment on attachment 312195 [details] > Patch > > Thanks, let's try it! I only wonder if we still need the conditionals to > force disable response files when using icecc. Carlos Lopez, Tom, what do > you think? The icecc test was only disabling CMAKE_NINJA_FORCE_RESPONSE_FILE for CMake > 3.5, older versions only support response files to link or create archives. The archives are done locally with ar, and for the link icecc probably forwards all arguments to the local CXX. 1316553 5 312195 mcatanzaro 2017-06-07 11:13:13 -0700 Comment on attachment 312195 Patch I'm not sure I understand, but let's try it! 1316556 6 mcatanzaro 2017-06-07 11:14:08 -0700 Ah well yeah, I must have misread the conditionals... clearly this shouldn't affect icecc at all (unless using old CMake). 1316568 7 312195 commit-queue 2017-06-07 11:41:12 -0700 Comment on attachment 312195 Patch Clearing flags on attachment: 312195 Committed r217894: <http://trac.webkit.org/changeset/217894> 1316569 8 commit-queue 2017-06-07 11:41:14 -0700 All reviewed patches have been landed. Closing bug. 312195 2017-06-07 10:36:41 -0700 2017-06-07 11:41:12 -0700 Patch bug-173066-20170607193640.patch text/plain 2123 loic.yhuel U3VidmVyc2lvbiBSZXZpc2lvbjogMjE3ODgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0NvbW1vbi5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCmluZGV4 IDUwZDQwOTQ1OWJhZjNmYzA3ZTQxMTQwOGNjZjNhZmVkOGFiZWUyNGQuLmMwYmVmYTA4NDhkZWIx YjllYmQ2NWQ3MmRmZmI2YjY1ODU5Mjg5OGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRp b25zQ29tbW9uLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCkBA IC0yMTYsMTcgKzIxNiwxMCBAQCBlbmRpZiAoKQogCiAjIFRoZSBOaW5qYSBnZW5lcmF0b3IgZG9l cyBub3QgeWV0IGtub3cgaG93IHRvIGJ1aWxkIGFyY2hpdmVzIGluIHBpZWNlcywgYW5kIHNvIHJl c3BvbnNlCiAjIGZpbGVzIG11c3QgYmUgdXNlZCB0byBkZWFsIHdpdGggdmVyeSBsb25nIGxpbmtl ciBjb21tYW5kIGxpbmVzLgotIyBTZWUgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEyOTc3MQotIyBUaGUgQXBwbGUgVG9vbGNoYWluIGRvZXNuJ3Qgc3VwcG9ydCByZXNw b25zZSBmaWxlcy4KLWlmIChOT1QgQVBQTEUpCi0gICAjIElmIHVzaW5nIE5pbmphIHdpdGggY21h a2UgPj0gMy42LjAgYW5kIGljZWNyZWFtLCB0aGVuIHRoZSBidWlsZCBpcyBicm9rZW4KLSAgICMg aWYgZW5hYmxlIHRoZSByZXNwb25zZSBmaWxlcy4gU2VlIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNjg3NzAKLSAgIGlmIChOT1QgKCgoKCR7Q01BS0VfQ1hYX0NPTVBJ TEVSfSBNQVRDSEVTICIuKmNjYWNoZS4qIikgQU5EICgkRU5We0NDQUNIRV9QUkVGSVh9IE1BVENI RVMgIi4qaWNlY2MuKiIpKQotICAgICAgICBPUiAoJHtDTUFLRV9DWFhfQ09NUElMRVJ9IE1BVENI RVMgIi4qaWNlY2MuKiIpCi0gICAgICAgIE9SICgke0FSX1ZFUlNJT059IE1BVENIRVMgIl5CU0Qg YXIgW14gXSogLSBsaWJhcmNoaXZlIikpCi0gICAgICAgQU5EIChDTUFLRV9HRU5FUkFUT1IgU1RS RVFVQUwgIk5pbmphIikgQU5EICgke0NNQUtFX1ZFUlNJT059IFZFUlNJT05fR1JFQVRFUiAzLjUp KSkKLSAgICAgIHNldChDTUFLRV9OSU5KQV9GT1JDRV9SRVNQT05TRV9GSUxFIDEpCi0gICBlbmRp ZiAoKQorIyBDTWFrZSBkb2VzIHRoaXMgYXV0b21hdGljYWxseSwgYnV0IHRoZSBjb25kaXRpb24g d2FzIHdyb25nIG9uIExpbnV4IHVudGlsIENNYWtlIDMuMi4KKyMgU2VlIGh0dHBzOi8vY21ha2Uu b3JnL0J1Zy92aWV3LnBocD9pZD0xNDg5MgoraWYgKChDTUFLRV9IT1NUX1NZU1RFTV9OQU1FIFNU UkVRVUFMICJMaW51eCIpIEFORCAoQ01BS0VfVkVSU0lPTiBWRVJTSU9OX0xFU1MgMy4yKSkKKyAg ICBzZXQoQ01BS0VfTklOSkFfRk9SQ0VfUkVTUE9OU0VfRklMRSAxKQogZW5kaWYgKCkKIAogIyBN YWNyb3MgZm9yIGRldGVybWluaW5nIEhBVkUgdmFsdWVzLgpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9n IGIvQ2hhbmdlTG9nCmluZGV4IGEyZWNlNWFkMTlmMDFiODI2NTI5MzE3Zjk2ZGQ5NjU0MmRiNTNl ZGUuLmY0ZTBmNWEwYjlmZGU4NmEyNGQ4YmFhMzE5YzIwODU5MTMxNWQxMTQgMTAwNjQ0Ci0tLSBh L0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxNy0wNi0wNyAg TG/Dr2MgWWh1ZWwgIDxsb2ljLnlodWVsQHNvZnRhdGhvbWUuY29tPgorCisgICAgICAgIFtDTWFr ZV0gT25seSBmb3JjZSByZXNwb25zZSBmaWxlcyBmb3IgTmluamEgd2l0aCBDTWFrZSA8IDMuMiBv biBMaW51eAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTczMDY2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Q01ha2UgYXV0b21hdGljYWxseSB1c2VzIHJlc3BvbnNlIGZpbGVzIHdoZW4gbmVlZGVkLCBidXQg dGhlIGxpbWl0IHdhcworICAgICAgICB3cm9uZyBvbiBMaW51eCBiZWZvcmUgMy4yLgorCisgICAg ICAgICogU291cmNlL2NtYWtlL09wdGlvbnNDb21tb24uY21ha2U6CisKIDIwMTctMDYtMDcgIFph biBEb2JlcnNlayAgPHpkb2JlcnNla0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHQ3J5cHRdIFJT QS1QU1Mgc3VwcG9ydAo=