173039 2017-06-06 15:49:11 -0700 ASSERTION FAILED: !m_isolatedWorld->isNormal() || m_wrapper || !m_jsFunction on webrtc/ephemeral-certificates-and-cnames.html 2017-06-08 10:13:21 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jlewis3 cdumez ap cdumez commit-queue eric.carlson ggaren webkit-bug-importer youennf oldest_to_newest 1316287 0 jlewis3 2017-06-06 15:49:11 -0700 webrtc/ephemeral-certificates-and-cnames.html is a flaky crash https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=webrtc%2Fephemeral-certificates-and-cnames.html https://build.webkit.org/builders/Apple%20Sierra%20Debug%20WK2%20(Tests)/builds/1388 https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK2%20(Tests)/r217849%20(1388)/results.html Shows to be happening on Sierra Debug WK2 Added in https://trac.webkit.org/changeset/214690/webkit ASSERTION FAILED: !m_isolatedWorld->isNormal() || m_wrapper || !m_jsFunction /Volumes/Data/slave/sierra-debug/build/Source/WebCore/bindings/js/JSEventListener.h(128) : JSC::JSObject *WebCore::JSEventListener::jsFunction(WebCore::ScriptExecutionContext *) const 1 0x11e391b1d WTFCrash 2 0x11321d0c3 WebCore::JSEventListener::jsFunction(WebCore::ScriptExecutionContext*) const 3 0x113644cae WebCore::JSEventListener::handleEvent(WebCore::ScriptExecutionContext*, WebCore::Event*) 4 0x112add396 WebCore::EventTarget::fireEventListeners(WebCore::Event&, WTF::Vector<WTF::RefPtr<WebCore::RegisteredEventListener>, 1ul, WTF::CrashOnOverflow, 16ul>) 5 0x112adcf5e WebCore::EventTarget::fireEventListeners(WebCore::Event&) 6 0x112adcdf9 WebCore::EventTarget::dispatchEvent(WebCore::Event&) 7 0x1147a0ebc WebCore::RTCPeerConnection::fireEvent(WebCore::Event&) 8 0x1142a1bba WebCore::PeerConnectionBackend::doneGatheringCandidates() 9 0x113efe6a6 WebCore::LibWebRTCMediaEndpoint::OnIceGatheringChange(webrtc::PeerConnectionInterface::IceGatheringState)::$_10::operator()() const 10 0x113efe5a9 WTF::Function<void ()>::CallableWrapper<WebCore::LibWebRTCMediaEndpoint::OnIceGatheringChange(webrtc::PeerConnectionInterface::IceGatheringState)::$_10>::call() 11 0x11e3c19ae WTF::Function<void ()>::operator()() const 12 0x11e3c15e4 WTF::dispatchFunctionsFromMainThread() 13 0x11e3c39b1 WTF::timerFired(__CFRunLoopTimer*, void*) 14 0x7fffa8859e04 __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__ 15 0x7fffa8859a93 __CFRunLoopDoTimer 16 0x7fffa88595ea __CFRunLoopDoTimers 17 0x7fffa8850fc1 __CFRunLoopRun 18 0x7fffa8850544 CFRunLoopRunSpecific 19 0x7fffa7db0ebc RunCurrentEventLoopInMode 20 0x7fffa7db0cf1 ReceiveNextEventCommon 21 0x7fffa7db0b26 _BlockUntilNextEventMatchingListInModeWithFilter 22 0x7fffa6349a54 _DPSNextEvent 23 0x7fffa6ac57ee -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] 24 0x7fffa633e3db -[NSApplication run] 25 0x7fffa6308e0e NSApplicationMain 26 0x7fffbe7e18c7 _xpc_objc_main 27 0x7fffbe7e02e4 xpc_main 28 0x109e5d105 main 29 0x7fffbe588235 start 30 0x1 1316288 1 webkit-bug-importer 2017-06-06 15:50:02 -0700 <rdar://problem/32600412> 1316927 2 ggaren 2017-06-08 09:15:39 -0700 The problem here is that RTCPeerConnection doesn't adopt any of our ActiveDOMObject garbage collection APIs. 1316929 3 cdumez 2017-06-08 09:16:22 -0700 (In reply to Geoffrey Garen from comment #2) > The problem here is that RTCPeerConnection doesn't adopt any of our > ActiveDOMObject garbage collection APIs. Yes, I said so on the radar :) 1316930 4 312309 cdumez 2017-06-08 09:17:29 -0700 Created attachment 312309 Patch 1316953 5 312309 commit-queue 2017-06-08 10:13:20 -0700 Comment on attachment 312309 Patch Clearing flags on attachment: 312309 Committed r217932: <http://trac.webkit.org/changeset/217932> 1316954 6 commit-queue 2017-06-08 10:13:21 -0700 All reviewed patches have been landed. Closing bug. 312309 2017-06-08 09:17:29 -0700 2017-06-08 10:13:20 -0700 Patch bug-173039-20170608091727.patch text/plain 3006 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjE3OTI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmU4OTYzYTk3ODM5ZjQ5 MTY0NGM3NDA5NzY0MmViZjdkODQzYTFiOS4uNWViYmE0YjQ1OGRhZTY0MjQ2Yjg1ZTE5ZjUzMWQz NzcyMDhiYWE4ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE3LTA2LTA4ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQVNTRVJUSU9OIEZBSUxFRDog IW1faXNvbGF0ZWRXb3JsZC0+aXNOb3JtYWwoKSB8fCBtX3dyYXBwZXIgfHwgIW1fanNGdW5jdGlv biBvbiB3ZWJydGMvZXBoZW1lcmFsLWNlcnRpZmljYXRlcy1hbmQtY25hbWVzLmh0bWwKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MzAzOQorICAgICAg ICA8cmRhcjovL3Byb2JsZW0vMzI2MDA0MTI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgUlRDUGVlckNvbm5lY3Rpb24gd2FzIGFuIEFjdGl2ZURPTU9i amVjdCBidXQgZmFpbGVkIHRvIG92ZXJyaWRlIEFjdGl2ZURPTU9iamVjdDo6aGFzUGVuZGluZ0Fj dGl2aXR5KCkKKyAgICAgICAgdG8gbWFrZSBzdXJlIGl0cyBKUyB3cmFwcGVyIHN0YXlzIGFsaXZl IGFzIGxvbmcgYXMgaXQgbmVlZHMgdG8uIEluIHRoaXMgcGF0Y2gsIHdlIG92ZXJyaWRlCisgICAg ICAgIEFjdGl2ZURPTU9iamVjdDo6aGFzUGVuZGluZ0FjdGl2aXR5KCkgYW5kIGhhdmUgaXQgcmV0 dXJuIHRydWUgaWYgIW1faXNTdG9wcGVkLiBJIGJlbGlldmUgdGhpcyBpcworICAgICAgICB0aGUg cmlnaHQgdGhpbmcgdG8gZG8gdG8ga2VlcCB0aGUgd3JhcHBlciBhbGl2ZSBhcyBsb25nIGFzIHRo ZSBjb25uZWN0aW9uIGlzIG5vdCBjbG9zZWQuCisgICAgICAgIFJUQ1BlZXJDb25uZWN0aW9uOjpj bG9zZSgpIGNsb3NlcyB0aGUgY29ubmVjdGlvbiBhbmQgdGhlbiBwb3N0cyBhIHRhc2sgdG8gY2Fs bAorICAgICAgICBSVENQZWVyQ29ubmVjdGlvbjo6ZG9TdG9wKCksIHNldHRpbmcgbV9pc1N0b3Bw ZWQgdG8gdHJ1ZS4KKworICAgICAgICBObyBuZXcgdGVzdHMsIGFscmVhZHkgY292ZXJlZCBieSB3 ZWJydGMvZXBoZW1lcmFsLWNlcnRpZmljYXRlcy1hbmQtY25hbWVzLmh0bWwgd2hpY2gKKyAgICAg ICAgd2FzIGEgZmxha3kgY3Jhc2guCisKKyAgICAgICAgKiBNb2R1bGVzL21lZGlhc3RyZWFtL1JU Q1BlZXJDb25uZWN0aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJUQ1BlZXJDb25uZWN0aW9u OjpjYW5TdXNwZW5kRm9yRG9jdW1lbnRTdXNwZW5zaW9uKToKKyAgICAgICAgKFdlYkNvcmU6OlJU Q1BlZXJDb25uZWN0aW9uOjpoYXNQZW5kaW5nQWN0aXZpdHkpOgorICAgICAgICAqIE1vZHVsZXMv bWVkaWFzdHJlYW0vUlRDUGVlckNvbm5lY3Rpb24uaDoKKwogMjAxNy0wNi0wOCAgTWlndWVsIEdv bWV6ICA8bWFnb21lekBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdW1dQRV1bR1NUUkVBTUVS X0dMXSBDaGFuZ2UgdGhlIGNvbG9yc3BhY2UgdXNlZCBieSB0aGUgdmlkZW8gZnJhbWVzIHByb3Zp ZGVkIGJ5IEdTdHJlYW1lcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRp YXN0cmVhbS9SVENQZWVyQ29ubmVjdGlvbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21l ZGlhc3RyZWFtL1JUQ1BlZXJDb25uZWN0aW9uLmNwcAppbmRleCBkNTM4Nzc2YWVmNjM4OTdiYmFj NDgyZmNjODNkYzFjMDQ0ODVmMDM3Li45NWJiNjA5MjdhNDA1ODhkZjhkMjI1MTE2YWUxMmEzMTc2 N2ZkZTM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL1JU Q1BlZXJDb25uZWN0aW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3Ry ZWFtL1JUQ1BlZXJDb25uZWN0aW9uLmNwcApAQCAtNDMwLDggKzQzMCwxMiBAQCBjb25zdCBjaGFy KiBSVENQZWVyQ29ubmVjdGlvbjo6YWN0aXZlRE9NT2JqZWN0TmFtZSgpIGNvbnN0CiAKIGJvb2wg UlRDUGVlckNvbm5lY3Rpb246OmNhblN1c3BlbmRGb3JEb2N1bWVudFN1c3BlbnNpb24oKSBjb25z dAogewotICAgIC8vIEZJWE1FOiBXZSBzaG91bGQgdHJ5IGFuZCBkbyBiZXR0ZXIgaGVyZS4KLSAg ICByZXR1cm4gZmFsc2U7CisgICAgcmV0dXJuICFoYXNQZW5kaW5nQWN0aXZpdHkoKTsKK30KKwor Ym9vbCBSVENQZWVyQ29ubmVjdGlvbjo6aGFzUGVuZGluZ0FjdGl2aXR5KCkgY29uc3QKK3sKKyAg ICByZXR1cm4gIW1faXNTdG9wcGVkOwogfQogCiB2b2lkIFJUQ1BlZXJDb25uZWN0aW9uOjphZGRU cmFuc2NlaXZlcihSZWY8UlRDUnRwVHJhbnNjZWl2ZXI+JiYgdHJhbnNjZWl2ZXIpCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL1JUQ1BlZXJDb25uZWN0aW9u LmggYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL1JUQ1BlZXJDb25uZWN0aW9u LmgKaW5kZXggZTM2MzdiZjIzZjViMDZmY2JmYzI3ZjFjZjA1NTcwNjY0OTU2MTU4Yy4uMzczYWE2 ZGQ3NWI3ZGJhYjMyMDRhODUyZjdlNjlkNmFlNDNlYjU0MyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9SVENQZWVyQ29ubmVjdGlvbi5oCisrKyBiL1NvdXJj ZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vUlRDUGVlckNvbm5lY3Rpb24uaApAQCAtMTQ3 LDYgKzE0Nyw5IEBAIHB1YmxpYzoKIAogICAgIHZvaWQgY2xlYXJDb250cm9sbGVyKCkgeyBtX2Nv bnRyb2xsZXIgPSBudWxscHRyOyB9CiAKKyAgICAvLyBBY3RpdmVET01PYmplY3QuCisgICAgYm9v bCBoYXNQZW5kaW5nQWN0aXZpdHkoKSBjb25zdCBmaW5hbDsKKwogcHJpdmF0ZToKICAgICBSVENQ ZWVyQ29ubmVjdGlvbihTY3JpcHRFeGVjdXRpb25Db250ZXh0Jik7CiAK