172993 2017-06-06 09:32:33 -0700 [GTK][Wayland] Do not pass value of $DISPLAY to wl_display_connect() 2017-06-06 10:13:05 -0700 1 1 1 Unclassified WebKit WebKitGTK Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aperez aperez bugs-noreply cgarcia clopez commit-queue mcatanzaro zan oldest_to_newest 1316027 0 aperez 2017-06-06 09:32:33 -0700 Currently “Source/WebCore/platform/graphics/wayland/PlatformDisplayWayland.cpp” reads: std::unique_ptr<PlatformDisplay> PlatformDisplayWayland::create() { struct wl_display* display = wl_display_connect(getenv("DISPLAY")); if (!display) return nullptr; return std::make_unique<PlatformDisplayWayland>(display, NativeDisplayOwned::Yes); } The “DISPLAY” environment variable is typically used for X11, and “WAYLAND_DISPLAY” should be used instead. According to the documentation, “wl_display_connect()” will check the value of “WAYLAND_DISPLAY” itself, so it looks like we could just pass a null pointer to it. 1316030 1 312081 aperez 2017-06-06 09:38:04 -0700 Created attachment 312081 Patch 1316035 2 312081 zan 2017-06-06 09:43:58 -0700 Comment on attachment 312081 Patch I think this is fine. I checked if the DISPLAY env is set to anything meaningful in the UIProcess, but that doesn't seem to be the case. 1316051 3 312081 commit-queue 2017-06-06 10:13:04 -0700 Comment on attachment 312081 Patch Clearing flags on attachment: 312081 Committed r217838: <http://trac.webkit.org/changeset/217838> 1316052 4 commit-queue 2017-06-06 10:13:05 -0700 All reviewed patches have been landed. Closing bug. 312081 2017-06-06 09:38:04 -0700 2017-06-06 10:13:04 -0700 Patch bug-172993-20170606193803.patch text/plain 1830 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjE3ODIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDVmZWRhMjE3MGVkNzll NGY3MjExYzhmNGY5ZGMzM2E5NmE0M2VjOS4uZDQ4YjM1MTM0NTMxZTAzNGMyYzRkNGNiMDljOTZi OTNhNjVmNWNmOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE3LTA2LTA2ICBBZHJp YW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS11b V2F5bGFuZF0gRG8gbm90IHBhc3MgdmFsdWUgb2YgJERJU1BMQVkgdG8gd2xfZGlzcGxheV9jb25u ZWN0KCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3 Mjk5MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5v IG5ldyB0ZXN0cyBuZWVkZWQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy93YXlsYW5k L1BsYXRmb3JtRGlzcGxheVdheWxhbmQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGxhdGZvcm1E aXNwbGF5V2F5bGFuZDo6Y3JlYXRlKTogSW5zdGVhZCBvZiB1c2luZyB0aGUgIkRJU1BMQVkiIGVu dmlyb25tZW50IHZhcmlhYmxlIChtZWFudCBmb3IgWDExKSwKKyAgICAgICAgcGFzcyBhIG51bGwg cG9pbnRlciB0byAid2xfZGlzcGxheV9jb25uZWN0KCkiLiBUaGlzIGZ1bmN0aW9uIGNoZWNrcyB0 aGUgdmFsdWUgb2YgdGhlICJXQVlMQU5EX0RJU1BMQVkiIGVudmlyb25tZW50CisgICAgICAgIHZh cmlhYmxlIGl0c2VsZiBhbmQgdGhlcmVmb3JlIHdlIGRvIG5vdCBuZWVkIHRvIHBhc3MgaXQgb3Vy c2VsdmVzLgorCiAyMDE3LTA2LTA1ICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUu Y29tPgogCiAgICAgICAgIFJlZmFjdG9yIC1bV2ViSXRlbVByb3ZpZGVyUGFzdGVib2FyZCB2YWx1 ZXNGb3JQYXN0ZWJvYXJkVHlwZTppbkl0ZW1TZXQ6XSB0byBjaGVjayByZWFkYWJsZSB0eXBlcwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2F5bGFuZC9QbGF0 Zm9ybURpc3BsYXlXYXlsYW5kLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L3dheWxhbmQvUGxhdGZvcm1EaXNwbGF5V2F5bGFuZC5jcHAKaW5kZXggNDIyOTEzOTZmZTdlYTg0 YWIzZTgwNjFiMGQyMGU5NjQxYWEwNmQwYi4uZGFjMDFkODQ2YWEzNmEzMWI2YjVkOWU1MmZmZmE0 ZjZmOWYwMTk5OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv d2F5bGFuZC9QbGF0Zm9ybURpc3BsYXlXYXlsYW5kLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy93YXlsYW5kL1BsYXRmb3JtRGlzcGxheVdheWxhbmQuY3BwCkBAIC01 Miw3ICs1Miw3IEBAIGNvbnN0IHN0cnVjdCB3bF9yZWdpc3RyeV9saXN0ZW5lciBQbGF0Zm9ybURp c3BsYXlXYXlsYW5kOjpzX3JlZ2lzdHJ5TGlzdGVuZXIgPSB7CiAKIHN0ZDo6dW5pcXVlX3B0cjxQ bGF0Zm9ybURpc3BsYXk+IFBsYXRmb3JtRGlzcGxheVdheWxhbmQ6OmNyZWF0ZSgpCiB7Ci0gICAg c3RydWN0IHdsX2Rpc3BsYXkqIGRpc3BsYXkgPSB3bF9kaXNwbGF5X2Nvbm5lY3QoZ2V0ZW52KCJE SVNQTEFZIikpOworICAgIHN0cnVjdCB3bF9kaXNwbGF5KiBkaXNwbGF5ID0gd2xfZGlzcGxheV9j b25uZWN0KG51bGxwdHIpOwogICAgIGlmICghZGlzcGxheSkKICAgICAgICAgcmV0dXJuIG51bGxw dHI7CiAK