172973 2017-06-06 06:04:15 -0700 [GTK] Web Process deadlock when closing the remote inspector frontend 2017-06-06 08:15:20 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply buildbot keith_miller mark.lam msaboff saam zan oldest_to_newest 1315962 0 cgarcia 2017-06-06 06:04:15 -0700 Thread 1 (Thread 0x7f4d2ca92a80 (LWP 14161)): #0 pthread_cond_wait@@GLIBC_2.3.2 () at ../sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S:185 #1 0x00007f4d271c1a1b in WTF::ThreadCondition::timedWait(WTF::Mutex&, double) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18 #2 0x00007f4d2718a983 in WTF::ParkingLot::parkConditionallyImpl(void const*, WTF::ScopedLambda<bool ()> const&, WTF::ScopedLambda<void ()> const&, WTF::TimeWithDynamicClockType const&) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18 #3 0x00007f4d27180a44 in WTF::LockAlgorithm<unsigned char, (unsigned char)1, (unsigned char)2>::lockSlow(WTF::Atomic<unsigned char>&) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18 #4 0x00007f4d271728fd in Inspector::RemoteInspector::updateTarget(Inspector::RemoteControllableTarget*) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18 #5 0x000056402dcea681 in WebCore::PageDebuggable::disconnect(Inspector::FrontendChannel*) () #6 0x00007f4d27173c49 in Inspector::RemoteConnectionToTarget::close() () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18 #7 0x00007f4d27174fbd in Inspector::RemoteInspector::receivedCloseMessage(unsigned int) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18 #8 0x00007f4d27175432 in Inspector::RemoteInspector::{lambda(_GDBusConnection*, char const*, char const*, char const*, char const*, _GVariant*, _GDBusMethodInvocation*, void*)#1}::_FUN(_GDBusConnection*, char const*, char const*, char const*, char const*, _GVariant*, _GDBusMethodInvocation*, void*) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18 #9 0x00007f4d224e01c9 in call_in_idle_cb (user_data=<optimized out>) at gdbusconnection.c:4851 #10 0x00007f4d21f055aa in g_main_dispatch (context=0x5640308d1aa0) at gmain.c:3234 ---Type <return> to continue, or q <return> to quit--- #11 g_main_context_dispatch (context=context@entry=0x5640308d1aa0) at gmain.c:3899 #12 0x00007f4d21f05928 in g_main_context_iterate (context=0x5640308d1aa0, block=block@entry=1, dispatch=dispatch@entry=1, self=<optimized out>) at gmain.c:3972 #13 0x00007f4d21f05c42 in g_main_loop_run (loop=0x56403095e100) at gmain.c:4168 #14 0x00007f4d271c2de0 in WTF::RunLoop::run() () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18 #15 0x00007f4d2a6cc6a2 in int WebKit::ChildProcessMain<WebKit::WebProcess, WebKit::WebProcessMain>(int, char**) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #16 0x00007f4d1cdaf2b1 in __libc_start_main (main=0x56402d40baf0 <main>, argc=2, argv=0x7ffe91537268, init=<optimized out>, fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7ffe91537258) at ../csu/libc-start.c:291 #17 0x000056402d40bc5a in _start () We are taking the remote inspector mutex twice 1315963 1 312069 cgarcia 2017-06-06 06:07:41 -0700 Created attachment 312069 Patch 1315990 2 cgarcia 2017-06-06 08:15:20 -0700 Committed r217830: <http://trac.webkit.org/changeset/217830> 312069 2017-06-06 06:07:41 -0700 2017-06-06 08:07:01 -0700 Patch wk2-remote-inspector-deadlock.diff text/plain 2479 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGEzMDQ5YjY3NjdiLi4xODEzNzk3ZmMyYiAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjAgQEAKIDIwMTctMDYtMDYgIENhcmxv cyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCisgICAgICAgIFtHVEtdIFdl YiBQcm9jZXNzIGRlYWRsb2NrIHdoZW4gY2xvc2luZyB0aGUgcmVtb3RlIGluc3BlY3RvciBmcm9u dGVuZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcy OTczCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2Ug YXJlIHRha2luZyB0aGUgcmVtb3RlIGluc3BlY3RvciBtdXRleCB0d2ljZS4gRmlyc3QgY2xvc2Ug bWVzc2FnZSBpcyByZWNlaXZlZCwgYW5kIHJlY2VpdmVkQ2xvc2VNZXNzYWdlKCkKKyAgICAgICAg dGFrZXMgdGhlIG11dGV4LiBUaGVuIFJlbW90ZUNvbm5lY3Rpb25Ub1RhcmdldDo6Y2xvc2UoKSBp cyBjYWxsZWQgdGhhdCwgd2hlbiBjb25uZWN0ZWQsIGNhbGxzCisgICAgICAgIFBhZ2VEZWJ1Z2dh YmxlOjpkaXNjb25uZWN0KCkgdGhhdCBlbmRzIHVwIGNhbGxpbmcgUmVtb3RlSW5zcGVjdG9yOjp1 cGRhdGVUYXJnZXQoKSB0aGF0IGFsc28gdGFrZXMgdGhlIHJlbW90ZQorICAgICAgICBpbnNwZWN0 b3IgbXV0ZXguIFdlIHNob3VsZCByZWxlYXNlIHRoZSBtdXRleCBiZWZvcmUgY2FsbGluZyBSZW1v dGVDb25uZWN0aW9uVG9UYXJnZXQ6OmNsb3NlKCkuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvcmVt b3RlL2dsaWIvUmVtb3RlSW5zcGVjdG9yR2xpYi5jcHA6CisgICAgICAgIChJbnNwZWN0b3I6OlJl bW90ZUluc3BlY3Rvcjo6cmVjZWl2ZWRDbG9zZU1lc3NhZ2UpOgorCisyMDE3LTA2LTA2ICBDYXJs b3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KKwogICAgICAgICBbR0xJQl0g TWFrZSByZW1vdGUgaW5zcGVjdG9yIERCdXMgcHJvdG9jb2wgY29tbW9uIHRvIGFsbCBnbGliIGJh c2VkIHBvcnRzCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNzI5NzAKIApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9y ZW1vdGUvZ2xpYi9SZW1vdGVJbnNwZWN0b3JHbGliLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9pbnNwZWN0b3IvcmVtb3RlL2dsaWIvUmVtb3RlSW5zcGVjdG9yR2xpYi5jcHAKaW5kZXggMTRj NmJmNDgwMWUuLjY2ODQ3MTEzZDM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv aW5zcGVjdG9yL3JlbW90ZS9nbGliL1JlbW90ZUluc3BlY3RvckdsaWIuY3BwCisrKyBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvcmVtb3RlL2dsaWIvUmVtb3RlSW5zcGVjdG9yR2xp Yi5jcHAKQEAgLTMwNSwxNiArMzA1LDE5IEBAIHZvaWQgUmVtb3RlSW5zcGVjdG9yOjpyZWNlaXZl ZERhdGFNZXNzYWdlKHVuc2lnbmVkIHRhcmdldElkZW50aWZpZXIsIGNvbnN0IGNoYXIqCiAKIHZv aWQgUmVtb3RlSW5zcGVjdG9yOjpyZWNlaXZlZENsb3NlTWVzc2FnZSh1bnNpZ25lZCB0YXJnZXRJ ZGVudGlmaWVyKQogewotICAgIHN0ZDo6bG9ja19ndWFyZDxMb2NrPiBsb2NrKG1fbXV0ZXgpOwot ICAgIFJlbW90ZUNvbnRyb2xsYWJsZVRhcmdldCogdGFyZ2V0ID0gbV90YXJnZXRNYXAuZ2V0KHRh cmdldElkZW50aWZpZXIpOwotICAgIGlmICghdGFyZ2V0KQotICAgICAgICByZXR1cm47CisgICAg UmVmUHRyPFJlbW90ZUNvbm5lY3Rpb25Ub1RhcmdldD4gY29ubmVjdGlvblRvVGFyZ2V0OworICAg IHsKKyAgICAgICAgc3RkOjpsb2NrX2d1YXJkPExvY2s+IGxvY2sobV9tdXRleCk7CisgICAgICAg IFJlbW90ZUNvbnRyb2xsYWJsZVRhcmdldCogdGFyZ2V0ID0gbV90YXJnZXRNYXAuZ2V0KHRhcmdl dElkZW50aWZpZXIpOworICAgICAgICBpZiAoIXRhcmdldCkKKyAgICAgICAgICAgIHJldHVybjsK KworICAgICAgICBjb25uZWN0aW9uVG9UYXJnZXQgPSBtX3RhcmdldENvbm5lY3Rpb25NYXAudGFr ZSh0YXJnZXRJZGVudGlmaWVyKTsKKyAgICAgICAgdXBkYXRlSGFzQWN0aXZlRGVidWdTZXNzaW9u KCk7CisgICAgfQogCi0gICAgYXV0byBjb25uZWN0aW9uVG9UYXJnZXQgPSBtX3RhcmdldENvbm5l Y3Rpb25NYXAudGFrZSh0YXJnZXRJZGVudGlmaWVyKTsKICAgICBpZiAoY29ubmVjdGlvblRvVGFy Z2V0KQogICAgICAgICBjb25uZWN0aW9uVG9UYXJnZXQtPmNsb3NlKCk7Ci0KLSAgICB1cGRhdGVI YXNBY3RpdmVEZWJ1Z1Nlc3Npb24oKTsKIH0KIAogdm9pZCBSZW1vdGVJbnNwZWN0b3I6OnNldHVw KHVuc2lnbmVkIHRhcmdldElkZW50aWZpZXIpCg==