172960 2017-06-05 23:18:04 -0700 ARES-6 incorrectly measures Worst 4 Iterations 2017-06-07 12:14:03 -0700 1 1 1 Unclassified WebKit JavaScriptCore Safari Technology Preview Unspecified Unspecified RESOLVED FIXED P2 Normal --- 172962 1 saam saam benjamin buildbot cdumez fpizlo ggaren gskachkov jfbastien keith_miller mark.lam msaboff rniwa ticaiolima ysuzuki oldest_to_newest 1315921 0 saam 2017-06-05 23:18:04 -0700 It accidentally measures first 4. 1315923 1 312059 saam 2017-06-05 23:22:57 -0700 Created attachment 312059 patch 1315925 2 312059 mark.lam 2017-06-05 23:28:12 -0700 Comment on attachment 312059 patch r=me 1315926 3 312059 rniwa 2017-06-05 23:31:33 -0700 Comment on attachment 312059 patch View in context: https://bugs.webkit.org/attachment.cgi?id=312059&action=review > PerformanceTests/ARES-6/results.js:59 > We should version benchmarks. Otherwise, people can't tell which version of the benchmark they're running. 1316577 4 saam 2017-06-07 12:14:03 -0700 landed in: https://trac.webkit.org/changeset/217897/webkit 312059 2017-06-05 23:22:57 -0700 2017-06-05 23:28:12 -0700 patch c-backup.diff text/plain 2839 saam SW5kZXg6IFBlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFBlcmZvcm1h bmNlVGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMTc4MjApCisrKyBQZXJmb3JtYW5jZVRlc3Rz L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE3LTA2LTA1ICBT YWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAgIEFSRVMtNiBpbmNvcnJl Y3RseSBtZWFzdXJlcyBXb3JzdCA0IEl0ZXJhdGlvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3Mjk2MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEl0IHdhcyBhY2NpZGVudGFsbHkgbWVhc3VyaW5nIHRo ZSBmaXJzdCA0IGl0ZXJhdGlvbnMuCisKKyAgICAgICAgKiBBUkVTLTYvcmVzdWx0cy5qczoKKyAg ICAgICAgKFJlc3VsdHMucHJvdG90eXBlLnJlcG9ydFJlc3VsdCk6CisKIDIwMTctMDYtMDEgIFNh YW0gQmFyYXRpICA8c2JhcmF0aUBhcHBsZS5jb20+CiAKICAgICAgICAgRW5zdXJlIGEgZ29vZCBl eHBlcmllbmNlIGZvciBBUkVTLTYgZXJyb3IgcmVwb3J0aW5nCkluZGV4OiBQZXJmb3JtYW5jZVRl c3RzL0FSRVMtNi9yZXN1bHRzLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFBlcmZvcm1hbmNlVGVzdHMvQVJF Uy02L3Jlc3VsdHMuanMJKHJldmlzaW9uIDIxNzgxOCkKKysrIFBlcmZvcm1hbmNlVGVzdHMvQVJF Uy02L3Jlc3VsdHMuanMJKHdvcmtpbmcgY29weSkKQEAgLTU5LDcgKzU5LDcgQEAgY2xhc3MgUmVz dWx0cyB7CiAKICAgICAgICAgdGhpcy5maXJzdEl0ZXJhdGlvbi5hZGQodGltZXNbMF0pOwogICAg ICAgICBsZXQgc3RlYWR5VGltZXMgPSB0aW1lcy5zbGljZSgxKS5zb3J0KChhLCBiKSA9PiBiIC0g YSk7IC8vIFNvcnQgaW4gcmV2ZXJzZSBvcmRlci4KLSAgICAgICAgdGhpcy5hdmVyYWdlV29yc3RD YXNlLmFkZCgodGltZXNbMF0gKyB0aW1lc1sxXSArIHRpbWVzWzJdICsgdGltZXNbM10pIC8gNCk7 CisgICAgICAgIHRoaXMuYXZlcmFnZVdvcnN0Q2FzZS5hZGQoKHN0ZWFkeVRpbWVzWzBdICsgc3Rl YWR5VGltZXNbMV0gKyBzdGVhZHlUaW1lc1syXSArIHN0ZWFkeVRpbWVzWzNdKSAvIDQpOwogICAg ICAgICB0aGlzLnN0ZWFkeVN0YXRlLmFkZChzdGVhZHlUaW1lcy5yZWR1Y2UoKHByZXZpb3VzLCBj dXJyZW50KSA9PiBwcmV2aW91cyArIGN1cnJlbnQpIC8gc3RlYWR5VGltZXMubGVuZ3RoKTsKICAg ICAgICAgdGhpcy5yZXBvcnREb25lKCk7CiAgICAgfQpJbmRleDogV2Vic2l0ZXMvYnJvd3NlcmJl bmNoLm9yZy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vic2l0ZXMvYnJvd3NlcmJlbmNoLm9y Zy9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxNzgxOCkKKysrIFdlYnNpdGVzL2Jyb3dzZXJiZW5jaC5v cmcvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTctMDYtMDUg IFNhYW0gQmFyYXRpICA8c2JhcmF0aUBhcHBsZS5jb20+CisKKyAgICAgICAgQVJFUy02IGluY29y cmVjdGx5IG1lYXN1cmVzIFdvcnN0IDQgSXRlcmF0aW9ucworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcyOTYwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSXQgd2FzIGFjY2lkZW50YWxseSBtZWFzdXJpbmcg dGhlIGZpcnN0IDQgaXRlcmF0aW9ucy4KKworICAgICAgICAqIEFSRVMtNi9yZXN1bHRzLmpzOgor ICAgICAgICAoUmVzdWx0cy5wcm90b3R5cGUucmVwb3J0UmVzdWx0KToKKwogMjAxNy0wNi0wNSAg U2FhbSBCYXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4KIAogICAgICAgICBVcGRhdGUgaW5kZXgu aHRtbCB0byBpbmNsdWRlIEFSRVMtNi4KSW5kZXg6IFdlYnNpdGVzL2Jyb3dzZXJiZW5jaC5vcmcv QVJFUy02L3Jlc3VsdHMuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vic2l0ZXMvYnJvd3NlcmJlbmNoLm9y Zy9BUkVTLTYvcmVzdWx0cy5qcwkocmV2aXNpb24gMjE3ODE4KQorKysgV2Vic2l0ZXMvYnJvd3Nl cmJlbmNoLm9yZy9BUkVTLTYvcmVzdWx0cy5qcwkod29ya2luZyBjb3B5KQpAQCAtNTksNyArNTks NyBAQCBjbGFzcyBSZXN1bHRzIHsKIAogICAgICAgICB0aGlzLmZpcnN0SXRlcmF0aW9uLmFkZCh0 aW1lc1swXSk7CiAgICAgICAgIGxldCBzdGVhZHlUaW1lcyA9IHRpbWVzLnNsaWNlKDEpLnNvcnQo KGEsIGIpID0+IGIgLSBhKTsgLy8gU29ydCBpbiByZXZlcnNlIG9yZGVyLgotICAgICAgICB0aGlz LmF2ZXJhZ2VXb3JzdENhc2UuYWRkKCh0aW1lc1swXSArIHRpbWVzWzFdICsgdGltZXNbMl0gKyB0 aW1lc1szXSkgLyA0KTsKKyAgICAgICAgdGhpcy5hdmVyYWdlV29yc3RDYXNlLmFkZCgoc3RlYWR5 VGltZXNbMF0gKyBzdGVhZHlUaW1lc1sxXSArIHN0ZWFkeVRpbWVzWzJdICsgc3RlYWR5VGltZXNb M10pIC8gNCk7CiAgICAgICAgIHRoaXMuc3RlYWR5U3RhdGUuYWRkKHN0ZWFkeVRpbWVzLnJlZHVj ZSgocHJldmlvdXMsIGN1cnJlbnQpID0+IHByZXZpb3VzICsgY3VycmVudCkgLyBzdGVhZHlUaW1l cy5sZW5ndGgpOwogICAgICAgICB0aGlzLnJlcG9ydERvbmUoKTsKICAgICB9Cg==