172946 2017-06-05 19:08:24 -0700 Make sure we restore SP when doing calls that could be to JS 2017-06-06 16:06:17 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam benjamin commit-queue fpizlo ggaren gskachkov jfbastien keith_miller mark.lam msaboff ticaiolima webkit-bug-importer ysuzuki oldest_to_newest 1315846 0 saam 2017-06-05 19:08:24 -0700 ... 1315847 1 webkit-bug-importer 2017-06-05 19:10:06 -0700 <rdar://problem/32579026> 1316268 2 312129 saam 2017-06-06 15:14:49 -0700 Created attachment 312129 patch 1316269 3 312129 jfbastien 2017-06-06 15:17:16 -0700 Comment on attachment 312129 patch r=me 1316293 4 312129 commit-queue 2017-06-06 16:06:16 -0700 Comment on attachment 312129 patch Clearing flags on attachment: 312129 Committed r217866: <http://trac.webkit.org/changeset/217866> 1316294 5 commit-queue 2017-06-06 16:06:17 -0700 All reviewed patches have been landed. Closing bug. 312129 2017-06-06 15:14:49 -0700 2017-06-06 16:06:16 -0700 patch c-backup.diff text/plain 4910 saam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMTc4NjApCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE3IEBACisyMDE3LTA2LTA2ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUu Y29tPgorCisgICAgICAgIE1ha2Ugc3VyZSB3ZSByZXN0b3JlIFNQIHdoZW4gZG9pbmcgY2FsbHMg dGhhdCBjb3VsZCBiZSB0byBKUworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTcyOTQ2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zMjU3OTAyNj4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHdhc20vZnVu Y3Rpb24tdGVzdHMvbWFueS1hcmdzLXRhaWwtY2FsbC1zcC1yZXN0b3JlZC5qczogQWRkZWQuCisg ICAgICAgIChpbXBvcnQuQnVpbGRlci5mcm9tLnN0cmluZ19hcHBlYXJlZF9oZXJlLmltcG9ydC5h cy5hc3NlcnQuZnJvbS5zdHJpbmdfYXBwZWFyZWRfaGVyZS5mMSk6CisgICAgICAgIChpbXBvcnQu QnVpbGRlci5mcm9tLnN0cmluZ19hcHBlYXJlZF9oZXJlLmltcG9ydC5hcy5hc3NlcnQuZnJvbS5z dHJpbmdfYXBwZWFyZWRfaGVyZS5lbmQpOgorICAgICAgICAoaW1wb3J0LkJ1aWxkZXIuZnJvbS5z dHJpbmdfYXBwZWFyZWRfaGVyZS5pbXBvcnQuYXMuYXNzZXJ0LmZyb20uc3RyaW5nX2FwcGVhcmVk X2hlcmUuZjIpOgorICAgICAgICAoaW1wb3J0LkJ1aWxkZXIuZnJvbS5zdHJpbmdfYXBwZWFyZWRf aGVyZS5pbXBvcnQuYXMuYXNzZXJ0LmZyb20uc3RyaW5nX2FwcGVhcmVkX2hlcmUubGV0Lmluc3Rh bmNlLm5ldy5XZWJBc3NlbWJseS5JbnN0YW5jZS5uZXcuV2ViQXNzZW1ibHkuTW9kdWxlLmJ1aWxk ZXIuV2ViQXNzZW1ibHkpOgorCiAyMDE3LTA2LTA2ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFy b0BhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCByb2xsb3V0IHIyMTc4MDcuIENhdXNl ZCBhIHRlc3QgdG8gY3Jhc2guCkluZGV4OiBKU1Rlc3RzL3dhc20vZnVuY3Rpb24tdGVzdHMvbWFu eS1hcmdzLXRhaWwtY2FsbC1zcC1yZXN0b3JlZC5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKU1Rlc3RzL3dh c20vZnVuY3Rpb24tdGVzdHMvbWFueS1hcmdzLXRhaWwtY2FsbC1zcC1yZXN0b3JlZC5qcwkobm9u ZXhpc3RlbnQpCisrKyBKU1Rlc3RzL3dhc20vZnVuY3Rpb24tdGVzdHMvbWFueS1hcmdzLXRhaWwt Y2FsbC1zcC1yZXN0b3JlZC5qcwkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDcyIEBACitpbXBv cnQgQnVpbGRlciBmcm9tICcuLi9CdWlsZGVyLmpzJworaW1wb3J0ICogYXMgYXNzZXJ0IGZyb20g Jy4uL2Fzc2VydC5qcycKKworeworICAgIGNvbnN0IGNvdW50ID0gMTAwMDsKKyAgICBjb25zdCBz aWduYXR1cmUgPSBbXTsKKyAgICBmb3IgKGxldCBpID0gMDsgaSA8IGNvdW50OyArK2kpCisgICAg ICAgIHNpZ25hdHVyZS5wdXNoKCJpMzIiKTsKKworICAgIGxldCBidWlsZGVyID0gbmV3IEJ1aWxk ZXIoKQorICAgICAgICAuVHlwZSgpCisgICAgICAgIC5FbmQoKQorICAgICAgICAuSW1wb3J0KCkK KyAgICAgICAgICAgIC5GdW5jdGlvbigiaW1wIiwgImYxIiwge3BhcmFtczpzaWduYXR1cmUsIHJl dDoidm9pZCJ9KQorICAgICAgICAgICAgLkZ1bmN0aW9uKCJpbXAiLCAiZjIiLCB7cGFyYW1zOnNp Z25hdHVyZSwgcmV0OiJ2b2lkIn0pCisgICAgICAgIC5FbmQoKQorICAgICAgICAuRnVuY3Rpb24o KS5FbmQoKQorICAgICAgICAuRXhwb3J0KCkKKyAgICAgICAgICAgIC5GdW5jdGlvbigiZm9vIikK KyAgICAgICAgLkVuZCgpCisgICAgICAgIC5Db2RlKCkKKyAgICAgICAgICAgIC5GdW5jdGlvbigi Zm9vIiwge3BhcmFtczogc2lnbmF0dXJlLCByZXQ6ICJ2b2lkIiB9KTsKKworICAgIGZvciAobGV0 IGkgPSAwOyBpIDwgY291bnQ7ICsraSkKKyAgICAgICAgYnVpbGRlciA9IGJ1aWxkZXIuR2V0TG9j YWwoaSk7CisKKyAgICBidWlsZGVyID0gYnVpbGRlci5DYWxsKDApOworCisgICAgZm9yIChsZXQg aSA9IGNvdW50OyBpLS07ICkKKyAgICAgICAgYnVpbGRlciA9IGJ1aWxkZXIuR2V0TG9jYWwoaSk7 CisKKyAgICBidWlsZGVyID0gYnVpbGRlci5DYWxsKDEpLlJldHVybigpLkVuZCgpLkVuZCgpOwor CisgICAgbGV0IGNhbGxlZEYxID0gZmFsc2U7CisgICAgbGV0IGNhbGxlZEYyID0gZmFsc2U7CisK KyAgICBmdW5jdGlvbiBmMSguLi5hcmdzKSB7CisgICAgICAgIGNhbGxlZEYxID0gdHJ1ZTsKKyAg ICAgICAgbGV0IHJlYWxBcmdzID0gWy4uLmFyZ3MsIC4uLmFyZ3NdOworICAgICAgICByZXR1cm4g ZW5kKC4uLnJlYWxBcmdzKTsKKyAgICB9CisgICAgbm9JbmxpbmUoZjEpOworCisgICAgZnVuY3Rp b24gZW5kKCkge30KKyAgICBub0lubGluZShlbmQpOworCisKKyAgICBmdW5jdGlvbiBmMiguLi5h cmdzKSB7CisgICAgICAgIGNhbGxlZEYyID0gdHJ1ZTsKKyAgICAgICAgbGV0IGNhbGxlZCA9IGZh bHNlOworICAgICAgICBhc3NlcnQuZXEoYXJncy5sZW5ndGgsIGNvdW50KTsKKyAgICAgICAgZm9y IChsZXQgaSA9IDA7IGkgPCBhcmdzLmxlbmd0aDsgKytpKSB7CisgICAgICAgICAgICBhc3NlcnQu ZXEoYXJnc1tpXSwgYXJncy5sZW5ndGggLSBpIC0gMSk7CisgICAgICAgIH0KKyAgICB9CisgICAg bm9JbmxpbmUoZjIpOworCisgICAgbGV0IGluc3RhbmNlID0gbmV3IFdlYkFzc2VtYmx5Lkluc3Rh bmNlKG5ldyBXZWJBc3NlbWJseS5Nb2R1bGUoYnVpbGRlci5XZWJBc3NlbWJseSgpLmdldCgpKSwg e2ltcDoge2YxLCBmMn19KTsKKworICAgIGNvbnN0IGFyZ3MgPSBbXTsKKyAgICBmb3IgKGxldCBp ID0gMDsgaSA8IGNvdW50OyArK2kpCisgICAgICAgIGFyZ3MucHVzaChpKTsKKworICAgIGZvciAo bGV0IGkgPSAwOyBpIDwgNTA7ICsraSkgeworICAgICAgICBpbnN0YW5jZS5leHBvcnRzLmZvbygu Li5hcmdzKTsKKworICAgICAgICBhc3NlcnQuZXEoY2FsbGVkRjEsIHRydWUpOworICAgICAgICBh c3NlcnQuZXEoY2FsbGVkRjIsIHRydWUpOworICAgICAgICBjYWxsZWRGMSA9IGZhbHNlOworICAg ICAgICBjYWxsZWRGMiA9IGZhbHNlOworICAgIH0KK30KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5n ZUxvZwkocmV2aXNpb24gMjE3ODU2KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE3LTA2LTA2ICBTYWFtIEJhcmF0 aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAgIE1ha2Ugc3VyZSB3ZSByZXN0b3JlIFNQ IHdoZW4gZG9pbmcgY2FsbHMgdGhhdCBjb3VsZCBiZSB0byBKUworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcyOTQ2CisgICAgICAgIDxyZGFyOi8vcHJv YmxlbS8zMjU3OTAyNj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBJIHdhcyB3b3JyaWVkIHRoYXQgdGhlcmUgd2FzIGEgYnVnIHdoZXJlIHdlJ2QgY2Fs bCBKUywgSlMgd291bGQgdGFpbCBjYWxsLAorICAgICAgICBhbmQgd2UnZCBlbmQgdXAgd2l0aCBh IGJvZ3VzIFNQLiBIb3dldmVyLCB0aGlzIGJ1ZyBkb2VzIG5vdCBleGlzdCBzaW5jZSB3YXNtCisg ICAgICAgIGFsd2F5cyBjYWxscyB0byBKUyB0aHJvdWdoIGEgc3R1YiwgYW5kIHRoZSBzdHViIHRy ZWF0cyBTUCBhcyBhIGNhbGxlZSBzYXZlLgorICAgICAgICAKKyAgICAgICAgSSB3cm90ZSBhIHRl c3QgZm9yIHRoaXMsIGFuZCBhbHNvIG1hZGUgYSBub3RlIHRoYXQgdGhpcyBpcyB0aGUgbmVlZGVk IEFCSS4KKworICAgICAgICAqIHdhc20vV2FzbUJpbmRpbmcuY3BwOgorICAgICAgICAoSlNDOjpX YXNtOjp3YXNtVG9Kcyk6CisKIDIwMTctMDYtMDYgIEtvbnN0YW50aW4gVG9rYXJldiAgPGFubnVs ZW5AeWFuZGV4LnJ1PgogCiAgICAgICAgIEFkZCBtaXNzaW5nIDxmdW5jdGlvbmFsPiBpbmNsdWRl cwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3dhc20vV2FzbUJpbmRpbmcuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93YXNtL1dhc21CaW5kaW5nLmNwcAkocmV2 aXNpb24gMjE3ODU2KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3dhc20vV2FzbUJpbmRpbmcu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC02MCw2ICs2MCw5IEBAIE1hY3JvQXNzZW1ibGVyQ29kZVJl ZiB3YXNtVG9KcyhWTSogdm0sIEIKICAgICB1bnNpZ25lZCBhcmdDb3VudCA9IHNpZ25hdHVyZS5h cmd1bWVudENvdW50KCk7CiAgICAgSklUIGppdDsKIAorICAgIC8vIE5vdGU6IFdhc21CM0lSR2Vu ZXJhdG9yIGFzc3VtZXMgdGhhdCB0aGlzIHN0dWIgdHJlYXRzIFNQIGFzIGEgY2FsbGVlIHNhdmUu CisgICAgLy8gSWYgd2UgZXZlciBjaGFuZ2UgdGhpcywgd2Ugd2lsbCBhbHNvIG5lZWQgdG8gY2hh bmdlIFdhc21CM0lSR2VuZXJhdG9yLgorCiAgICAgLy8gQmVsb3csIHdlIGFzc3VtZSB0aGF0IHRo ZSBKUyBjYWxsaW5nIGNvbnZlbnRpb24gaXMgYWx3YXlzIG9uIHRoZSBzdGFjay4KICAgICBBU1NF UlQoIWpzQ0MubV9ncHJBcmdzLnNpemUoKSk7CiAgICAgQVNTRVJUKCFqc0NDLm1fZnByQXJncy5z aXplKCkpOwo=