172933 2017-06-05 13:42:16 -0700 [macOS] REGRESSION: Link drag images blend into the background in Sierra and earlier 2017-06-10 11:33:13 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar, Regression P1 Normal --- 1 mitz mitz commit-queue thorton webkit-bug-importer oldest_to_newest 1315763 0 mitz 2017-06-05 13:42:16 -0700 The new link drag images fit well with macOS High Sierra, because the OS gives them a drop shadow that separates them from white backgrounds. In Sierra and El Capitan, there is no shadow, so the images blend into white backgrounds. 1315884 1 webkit-bug-importer 2017-06-05 21:11:33 -0700 <rdar://problem/32580649> 1317905 2 312572 mitz 2017-06-10 10:41:07 -0700 Created attachment 312572 Add a drop shadow 1317906 3 312573 mitz 2017-06-10 10:44:30 -0700 Created attachment 312573 Add a drop shadow 1317914 4 312573 commit-queue 2017-06-10 11:33:11 -0700 Comment on attachment 312573 Add a drop shadow Clearing flags on attachment: 312573 Committed r218052: <http://trac.webkit.org/changeset/218052> 1317915 5 commit-queue 2017-06-10 11:33:13 -0700 All reviewed patches have been landed. Closing bug. 312572 2017-06-10 10:41:07 -0700 2017-06-10 10:42:26 -0700 Add a drop shadow bug-172933-20170610104106.patch text/plain 3308 mitz SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxODA1MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE3LTA2LTEwICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgW21hY09TXSBSRUdSRVNTSU9OOiBM aW5rIGRyYWcgaW1hZ2VzIGJsZW5kIGludG8gdGhlIGJhY2tncm91bmQgaW4gU2llcnJhIGFuZCBl YXJsaWVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NzI5MzMKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzMyNTgwNjQ5PgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vbWFjL0RyYWdJbWFn ZU1hYy5tbToKKyAgICAgICAgKFdlYkNvcmU6OmNyZWF0ZURyYWdJbWFnZUZvckxpbmspOiBXaGVu IHRhcmdldGluZyBtYWNPUyBTaWVycmEgYW5kIGVhcmxpZXIsIGdpdmUgdGhlIGxpbmsKKyAgICAg ICAgICBkcmFnIGltYWdlIGEgZHJvcCBzaGFkb3cgdGhhdCByZXNlbWJsZXMgdGhlIG9uZSB0aGF0 IG1hY09TIEhpZ2ggU2llcnJhIGFwcGxpZXMgdG8gZHJhZworICAgICAgICAgIGltYWdlIGxheWVy cy4KKwogMjAxNy0wNi0xMCAgQW5keSBFc3RlcyAgPGFlc3Rlc0BhcHBsZS5jb20+CiAKICAgICAg ICAgW1F1aWNrTG9va10gUHJldmlld0xvYWRlciBuZWVkcyB0byBjaGVjayBpZiBpdHMgUmVzb3Vy Y2VMb2FkZXIgaGFzIHJlYWNoZWQgdGhlIHRlcm1pbmFsIHN0YXRlIGJlZm9yZSBjYWxsaW5nIGRp ZFJlY2VpdmVSZXNwb25zZSgpIGFuZCBmcmllbmRzCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9tYWMvRHJhZ0ltYWdlTWFjLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL21hYy9EcmFnSW1hZ2VNYWMubW0JKHJldmlzaW9uIDIxODA0MSkKKysrIFNvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL21hYy9EcmFnSW1hZ2VNYWMubW0JKHdvcmtpbmcgY29weSkKQEAgLTE1 NCwxNSArMTU0LDIxIEBAIFJldGFpblB0cjxOU0ltYWdlPiBjcmVhdGVEcmFnSW1hZ2VJY29uRm8K ICAgICByZXR1cm4gW1tOU1dvcmtzcGFjZSBzaGFyZWRXb3Jrc3BhY2VdIGljb25Gb3JGaWxlVHlw ZTpleHRlbnNpb25dOwogfQogCi0KIGNvbnN0IENHRmxvYXQgbGlua0ltYWdlUGFkZGluZyA9IDEw OwogY29uc3QgQ0dGbG9hdCBsaW5rSW1hZ2VEb21haW5CYXNlbGluZVRvVGl0bGVCYXNlbGluZSA9 IDE4OwogY29uc3QgQ0dGbG9hdCBsaW5rSW1hZ2VDb3JuZXJSYWRpdXMgPSA1OwogY29uc3QgQ0dG bG9hdCBsaW5rSW1hZ2VNYXhpbXVtV2lkdGggPSA0MDA7CiBjb25zdCBDR0Zsb2F0IGxpbmtJbWFn ZUZvbnRTaXplID0gMTE7CiBjb25zdCBDRkluZGV4IGxpbmtJbWFnZVRpdGxlTWF4aW11bUxpbmVD b3VudCA9IDI7Ci1jb25zdCBpbnQgbGlua0ltYWdlRHJhZ0Nvcm5lck91dHNldFggPSA2OwotY29u c3QgaW50IGxpbmtJbWFnZURyYWdDb3JuZXJPdXRzZXRZID0gMTA7CisjaWYgX19NQUNfT1NfWF9W RVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMDEzMDAKK2NvbnN0IGludCBsaW5rSW1hZ2VTaGFkb3dS YWRpdXMgPSAwOworY29uc3QgaW50IGxpbmtJbWFnZVNoYWRvd09mZnNldFkgPSAwOworI2Vsc2UK K2NvbnN0IGludCBsaW5rSW1hZ2VTaGFkb3dSYWRpdXMgPSA5OworY29uc3QgaW50IGxpbmtJbWFn ZVNoYWRvd09mZnNldFkgPSAtMzsKKyNlbmRpZgorY29uc3QgaW50IGxpbmtJbWFnZURyYWdDb3Ju ZXJPdXRzZXRYID0gNiAtIGxpbmtJbWFnZVNoYWRvd1JhZGl1czsKK2NvbnN0IGludCBsaW5rSW1h Z2VEcmFnQ29ybmVyT3V0c2V0WSA9IDEwIC0gbGlua0ltYWdlU2hhZG93UmFkaXVzICsgbGlua0lt YWdlU2hhZG93T2Zmc2V0WTsKIAogSW50UG9pbnQgZHJhZ09mZnNldEZvckxpbmtEcmFnSW1hZ2Uo RHJhZ0ltYWdlUmVmIGRyYWdJbWFnZSkKIHsKQEAgLTI4NywxMSArMjkzLDIyIEBAIERyYWdJbWFn ZVJlZiBjcmVhdGVEcmFnSW1hZ2VGb3JMaW5rKEVsZW0KIHsKICAgICBMaW5rSW1hZ2VMYXlvdXQg bGF5b3V0KHVybCwgdGl0bGUpOwogCi0gICAgUmV0YWluUHRyPE5TSW1hZ2U+IGRyYWdJbWFnZSA9 IGFkb3B0TlMoW1tOU0ltYWdlIGFsbG9jXSBpbml0V2l0aFNpemU6bGF5b3V0LmJvdW5kaW5nUmVj dC5zaXplKCldKTsKKyAgICBhdXRvIGltYWdlU2l6ZSA9IGxheW91dC5ib3VuZGluZ1JlY3Quc2l6 ZSgpOworI2lmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPCAxMDEzMDAKKyAgICBp bWFnZVNpemUuZXhwYW5kKDIgKiBsaW5rSW1hZ2VTaGFkb3dSYWRpdXMsIDIgKiBsaW5rSW1hZ2VT aGFkb3dSYWRpdXMgKyAzKTsKKyNlbmRpZgorICAgIFJldGFpblB0cjxOU0ltYWdlPiBkcmFnSW1h Z2UgPSBhZG9wdE5TKFtbTlNJbWFnZSBhbGxvY10gaW5pdFdpdGhTaXplOmltYWdlU2l6ZV0pOwog ICAgIFtkcmFnSW1hZ2UgbG9ja0ZvY3VzXTsKIAogICAgIEdyYXBoaWNzQ29udGV4dCBjb250ZXh0 KChDR0NvbnRleHRSZWYpW05TR3JhcGhpY3NDb250ZXh0IGN1cnJlbnRDb250ZXh0XS5ncmFwaGlj c1BvcnQpOworI2lmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPCAxMDEzMDAKKyAg ICBjb250ZXh0LnRyYW5zbGF0ZShsaW5rSW1hZ2VTaGFkb3dSYWRpdXMsIGxpbmtJbWFnZVNoYWRv d1JhZGl1cyAtIGxpbmtJbWFnZVNoYWRvd09mZnNldFkpOworICAgIGNvbnRleHQuc2V0U2hhZG93 KHsgMCwgbGlua0ltYWdlU2hhZG93T2Zmc2V0WSB9LCBsaW5rSW1hZ2VTaGFkb3dSYWRpdXMsIHsg MC5mLCAwLmYsIDAuZiwgLjI1IH0pOworI2VuZGlmCiAgICAgY29udGV4dC5maWxsUm91bmRlZFJl Y3QoRmxvYXRSb3VuZGVkUmVjdChsYXlvdXQuYm91bmRpbmdSZWN0LCBGbG9hdFJvdW5kZWRSZWN0 OjpSYWRpaShsaW5rSW1hZ2VDb3JuZXJSYWRpdXMpKSwgQ29sb3I6OndoaXRlKTsKKyNpZiBfX01B Q19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEIDwgMTAxMzAwCisgICAgY29udGV4dC5jbGVhclNo YWRvdygpOworI2VuZGlmCiAKICAgICBmb3IgKGNvbnN0IGF1dG8mIGxhYmVsIDogbGF5b3V0Lmxh YmVscykgewogICAgICAgICBHcmFwaGljc0NvbnRleHRTdGF0ZVNhdmVyIHNhdmVyKGNvbnRleHQp Owo= 312573 2017-06-10 10:44:30 -0700 2017-06-10 11:33:11 -0700 Add a drop shadow file_172933.txt text/plain 3403 mitz SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZw0KPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIFNvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjE4MDUwKQ0KKysrIFNvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwkod29ya2luZyBjb3B5KQ0KQEAgLTEsMyArMSwxNiBAQA0KKzIwMTctMDYtMTAgIERh biBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4NCisNCisgICAgICAgIFttYWNPU10gUkVHUkVT U0lPTjogTGluayBkcmFnIGltYWdlcyBibGVuZCBpbnRvIHRoZSBiYWNrZ3JvdW5kIGluIFNpZXJy YSBhbmQgZWFybGllcg0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE3MjkzMw0KKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzMyNTgwNjQ5Pg0KKw0KKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuDQorDQorICAgICAgICAqIHBsYXRmb3Jt L21hYy9EcmFnSW1hZ2VNYWMubW06DQorICAgICAgICAoV2ViQ29yZTo6Y3JlYXRlRHJhZ0ltYWdl Rm9yTGluayk6IFdoZW4gdGFyZ2V0aW5nIG1hY09TIFNpZXJyYSBhbmQgZWFybGllciwgZ2l2ZSB0 aGUgbGluaw0KKyAgICAgICAgICBkcmFnIGltYWdlIGEgZHJvcCBzaGFkb3cgdGhhdCByZXNlbWJs ZXMgdGhlIG9uZSB0aGF0IG1hY09TIEhpZ2ggU2llcnJhIGFwcGxpZXMgdG8gZHJhZw0KKyAgICAg ICAgICBpbWFnZSBsYXllcnMuDQorDQogMjAxNy0wNi0xMCAgQW5keSBFc3RlcyAgPGFlc3Rlc0Bh cHBsZS5jb20+DQogDQogICAgICAgICBbUXVpY2tMb29rXSBQcmV2aWV3TG9hZGVyIG5lZWRzIHRv IGNoZWNrIGlmIGl0cyBSZXNvdXJjZUxvYWRlciBoYXMgcmVhY2hlZCB0aGUgdGVybWluYWwgc3Rh dGUgYmVmb3JlIGNhbGxpbmcgZGlkUmVjZWl2ZVJlc3BvbnNlKCkgYW5kIGZyaWVuZHMNCkluZGV4 OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvRHJhZ0ltYWdlTWFjLm1tDQo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 DQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL0RyYWdJbWFnZU1hYy5tbQkocmV2aXNp b24gMjE4MDQxKQ0KKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9EcmFnSW1hZ2VNYWMu bW0JKHdvcmtpbmcgY29weSkNCkBAIC0xNTQsMTUgKzE1NCwyMSBAQCBSZXRhaW5QdHI8TlNJbWFn ZT4gY3JlYXRlRHJhZ0ltYWdlSWNvbkZvDQogICAgIHJldHVybiBbW05TV29ya3NwYWNlIHNoYXJl ZFdvcmtzcGFjZV0gaWNvbkZvckZpbGVUeXBlOmV4dGVuc2lvbl07DQogfQ0KIA0KLQ0KIGNvbnN0 IENHRmxvYXQgbGlua0ltYWdlUGFkZGluZyA9IDEwOw0KIGNvbnN0IENHRmxvYXQgbGlua0ltYWdl RG9tYWluQmFzZWxpbmVUb1RpdGxlQmFzZWxpbmUgPSAxODsNCiBjb25zdCBDR0Zsb2F0IGxpbmtJ bWFnZUNvcm5lclJhZGl1cyA9IDU7DQogY29uc3QgQ0dGbG9hdCBsaW5rSW1hZ2VNYXhpbXVtV2lk dGggPSA0MDA7DQogY29uc3QgQ0dGbG9hdCBsaW5rSW1hZ2VGb250U2l6ZSA9IDExOw0KIGNvbnN0 IENGSW5kZXggbGlua0ltYWdlVGl0bGVNYXhpbXVtTGluZUNvdW50ID0gMjsNCi1jb25zdCBpbnQg bGlua0ltYWdlRHJhZ0Nvcm5lck91dHNldFggPSA2Ow0KLWNvbnN0IGludCBsaW5rSW1hZ2VEcmFn Q29ybmVyT3V0c2V0WSA9IDEwOw0KKyNpZiBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVE ID49IDEwMTMwMA0KK2NvbnN0IGludCBsaW5rSW1hZ2VTaGFkb3dSYWRpdXMgPSAwOw0KK2NvbnN0 IGludCBsaW5rSW1hZ2VTaGFkb3dPZmZzZXRZID0gMDsNCisjZWxzZQ0KK2NvbnN0IGludCBsaW5r SW1hZ2VTaGFkb3dSYWRpdXMgPSA5Ow0KK2NvbnN0IGludCBsaW5rSW1hZ2VTaGFkb3dPZmZzZXRZ ID0gLTM7DQorI2VuZGlmDQorY29uc3QgaW50IGxpbmtJbWFnZURyYWdDb3JuZXJPdXRzZXRYID0g NiAtIGxpbmtJbWFnZVNoYWRvd1JhZGl1czsNCitjb25zdCBpbnQgbGlua0ltYWdlRHJhZ0Nvcm5l ck91dHNldFkgPSAxMCAtIGxpbmtJbWFnZVNoYWRvd1JhZGl1cyArIGxpbmtJbWFnZVNoYWRvd09m ZnNldFk7DQogDQogSW50UG9pbnQgZHJhZ09mZnNldEZvckxpbmtEcmFnSW1hZ2UoRHJhZ0ltYWdl UmVmIGRyYWdJbWFnZSkNCiB7DQpAQCAtMjg3LDExICsyOTMsMjIgQEAgRHJhZ0ltYWdlUmVmIGNy ZWF0ZURyYWdJbWFnZUZvckxpbmsoRWxlbQ0KIHsNCiAgICAgTGlua0ltYWdlTGF5b3V0IGxheW91 dCh1cmwsIHRpdGxlKTsNCiANCi0gICAgUmV0YWluUHRyPE5TSW1hZ2U+IGRyYWdJbWFnZSA9IGFk b3B0TlMoW1tOU0ltYWdlIGFsbG9jXSBpbml0V2l0aFNpemU6bGF5b3V0LmJvdW5kaW5nUmVjdC5z aXplKCldKTsNCisgICAgYXV0byBpbWFnZVNpemUgPSBsYXlvdXQuYm91bmRpbmdSZWN0LnNpemUo KTsNCisjaWYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA8IDEwMTMwMA0KKyAgICBp bWFnZVNpemUuZXhwYW5kKDIgKiBsaW5rSW1hZ2VTaGFkb3dSYWRpdXMsIDIgKiBsaW5rSW1hZ2VT aGFkb3dSYWRpdXMgLSBsaW5rSW1hZ2VTaGFkb3dPZmZzZXRZKTsNCisjZW5kaWYNCisgICAgUmV0 YWluUHRyPE5TSW1hZ2U+IGRyYWdJbWFnZSA9IGFkb3B0TlMoW1tOU0ltYWdlIGFsbG9jXSBpbml0 V2l0aFNpemU6aW1hZ2VTaXplXSk7DQogICAgIFtkcmFnSW1hZ2UgbG9ja0ZvY3VzXTsNCiANCiAg ICAgR3JhcGhpY3NDb250ZXh0IGNvbnRleHQoKENHQ29udGV4dFJlZilbTlNHcmFwaGljc0NvbnRl eHQgY3VycmVudENvbnRleHRdLmdyYXBoaWNzUG9ydCk7DQorI2lmIF9fTUFDX09TX1hfVkVSU0lP Tl9NSU5fUkVRVUlSRUQgPCAxMDEzMDANCisgICAgY29udGV4dC50cmFuc2xhdGUobGlua0ltYWdl U2hhZG93UmFkaXVzLCBsaW5rSW1hZ2VTaGFkb3dSYWRpdXMgLSBsaW5rSW1hZ2VTaGFkb3dPZmZz ZXRZKTsNCisgICAgY29udGV4dC5zZXRTaGFkb3coeyAwLCBsaW5rSW1hZ2VTaGFkb3dPZmZzZXRZ IH0sIGxpbmtJbWFnZVNoYWRvd1JhZGl1cywgeyAwLmYsIDAuZiwgMC5mLCAuMjUgfSk7DQorI2Vu ZGlmDQogICAgIGNvbnRleHQuZmlsbFJvdW5kZWRSZWN0KEZsb2F0Um91bmRlZFJlY3QobGF5b3V0 LmJvdW5kaW5nUmVjdCwgRmxvYXRSb3VuZGVkUmVjdDo6UmFkaWkobGlua0ltYWdlQ29ybmVyUmFk aXVzKSksIENvbG9yOjp3aGl0ZSk7DQorI2lmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlS RUQgPCAxMDEzMDANCisgICAgY29udGV4dC5jbGVhclNoYWRvdygpOw0KKyNlbmRpZg0KIA0KICAg ICBmb3IgKGNvbnN0IGF1dG8mIGxhYmVsIDogbGF5b3V0LmxhYmVscykgew0KICAgICAgICAgR3Jh cGhpY3NDb250ZXh0U3RhdGVTYXZlciBzYXZlcihjb250ZXh0KTsNCg==