172916 2017-06-05 03:39:29 -0700 [GTK][WPE] Do not force video sample's buffer release when the platformLayerProxy is inactive 2017-06-05 05:33:37 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 magomez magomez bugs-noreply cgarcia commit-queue oldest_to_newest 1315668 0 magomez 2017-06-05 03:39:29 -0700 In bug https://bugs.webkit.org/show_bug.cgi?id=168505 a workaround was added to avoid locking all the available gstreamer buffers inside the plarformLayerProxy in case it was set to display:none. This is not needed anymore since setting the video element to display:none will invalidate the platformLayerProxy, freeing all the buffers. Also, this change is causing problems when using gstreamer-gl and trying to paint video frames through webgl or an accelerated canvas, as the video sample's buffers will be empty and a crash will happen. 1315670 1 312003 magomez 2017-06-05 03:48:39 -0700 Created attachment 312003 Patch 1315679 2 312003 commit-queue 2017-06-05 05:33:35 -0700 Comment on attachment 312003 Patch Clearing flags on attachment: 312003 Committed r217780: <http://trac.webkit.org/changeset/217780> 1315680 3 commit-queue 2017-06-05 05:33:37 -0700 All reviewed patches have been landed. Closing bug. 312003 2017-06-05 03:48:39 -0700 2017-06-05 05:33:35 -0700 Patch bug-172916-20170605124838.patch text/plain 3064 magomez U3VidmVyc2lvbiBSZXZpc2lvbjogMjE3Nzc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmVjMjQxM2Q1MDI3NzI0 ZTc4YzUzNjVhMDlkOGYzMjRjYzhkM2Y4OC4uODBmZjEzYWM3NWQxZGRhZTA1MzE4MDY3M2RiMTVl NDg0ZDJhM2IxNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI2IEBACiAyMDE3LTA2LTA1ICBNaWd1 ZWwgR29tZXogIDxtYWdvbWV6QGlnYWxpYS5jb20+CiAKKyAgICAgICAgW0dUS11bV1BFXSBEbyBu b3QgZm9yY2UgdmlkZW8gc2FtcGxlJ3MgYnVmZmVyIHJlbGVhc2Ugd2hlbiB0aGUgcGxhdGZvcm1M YXllclByb3h5IGlzIGluYWN0aXZlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNzI5MTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBXaGVuIE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2UncyBwbGFy Zm9ybUxheWVyUHJveHkgd2FzIGluYWN0aXZlLCBhIGNvcHkgb2YgdGhlIHZpZGVvIHNhbXBsZQor ICAgICAgICB3YXMgYmVpbmcgZG9uZSAod2l0aG91dCB0aGUgYnVmZmVyKSBhbmQgc2V0LCBjYXVz aW5nIHRoZSBzYW1wbGUncyBidWZmZXIgdG8gZ2V0IGZyZWVkLiBUaGlzIHdhcyBkb25lCisgICAg ICAgIHRvIGF2b2lkIHN0YWxsaW5nIHRoZSBnc3RyZWFtZXIgcGlwZWxpbmUgaW4gc2l0dWF0aW9u cyB3aGVyZSB0aGUgdmlkZW8gd2FzIHNldCB0byBkaXNwbGF5Om5vbmUsIGFzIHRoZQorICAgICAg ICBwbGF0Zm9ybUxheWVyUHJveHkgd291bGQga2VlcCBhbGwgdGhlIGF2YWlsYWJsZSBidWZmZXJz LiBCdXQgdGhpcyBjYW4ndCBoYXBwZW4gbm93YWRheXMgYXMgc2V0dGluZworICAgICAgICB0aGUg dmlkZW8gdG8gZGlzcGxheTpub25lIGludmFsaWRhdGVzIHRoZSBwcm94eSwgY2F1c2luZyBpdCB0 byByZWxlYXNlIHRoZSByZWZlcmVuY2VzIHRvIHRoZQorICAgICAgICBnc3RyZWFtZXIgYnVmZmVy cyBpdCdzIHVzaW5nLiBBbHNvLCB0aGUgY3VycmVudCBjb2RlIGlzIGNhdXNpbmcgYSBjcmFzaCB3 aGVuIHVzaW5nIGdzdHJlYW1lci1nbCBhbmQKKyAgICAgICAgdGhlIHZpZGVvIGlzIGhpZGRlbiBi dXQgaXRzIGNvbnRlbnRzIGFyZSBiZWluZyBwYWludGVkIHRocm91Z2ggd2ViZ2wgb3IgYW4gYWNj ZWxlcmF0ZWQgY2FudmFzLiBTbywKKyAgICAgICAgcmVtb3ZlIHRoaXMgc2FtcGxlIGNvcHkgYXMg aXQncyBub3QgbmVjZXNzYXJ5IGFueW1vcmUuCisKKyAgICAgICAgQ292ZXJlZCBieSBleGlzdGVu dCB0ZXN0cy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBs YXllclByaXZhdGVHU3RyZWFtZXJCYXNlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxh eWVyUHJpdmF0ZUdTdHJlYW1lckJhc2U6OnB1c2hUZXh0dXJlVG9Db21wb3NpdG9yKToKKworMjAx Ny0wNi0wNSAgTWlndWVsIEdvbWV6ICA8bWFnb21lekBpZ2FsaWEuY29tPgorCiAgICAgICAgIFtH VEtdW1dQRV0gRml4IHRoZSBjb25kaXRpb24gdG8gZGVjaWRlIHdoZXRoZXIgdGhlIE1lZGlhUGxh eWVyIGNhbiBiZSByZW5kZXJlZCBhY2NlbGVyYXRlZAogICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcyODUyCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFt ZXJCYXNlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9N ZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlLmNwcAppbmRleCBkZjA2ZTA1MWM0OTNkOGQ2 Nzk1YWFiNGY5NmU2M2Y2OGRjZjRiZDc5Li44ZWZlNjc4ZjQyMTQwZjQ0OTY2YzM4NzQ0MWIyNDdl YzM2YzBmOTQxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9n c3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZS5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdT dHJlYW1lckJhc2UuY3BwCkBAIC03MDksMTYgKzcwOSw4IEBAIHZvaWQgTWVkaWFQbGF5ZXJQcml2 YXRlR1N0cmVhbWVyQmFzZTo6cHVzaFRleHR1cmVUb0NvbXBvc2l0b3IoKQogCiAgICAgTG9ja0hv bGRlciBob2xkZXIobV9wbGF0Zm9ybUxheWVyUHJveHktPmxvY2soKSk7CiAKLSAgICBpZiAoIW1f cGxhdGZvcm1MYXllclByb3h5LT5pc0FjdGl2ZSgpKSB7Ci0gICAgICAgIC8vIENvbnN1bWUgdGhl IGJ1ZmZlciAoc28gaXQgZ2V0cyBldmVudHVhbGx5IHVucmVmZmVkKSBidXQga2VlcCB0aGUgcmVz dCBvZiB0aGUgaW5mby4KLSAgICAgICAgY29uc3QgR3N0U3RydWN0dXJlKiBpbmZvID0gZ3N0X3Nh bXBsZV9nZXRfaW5mbyhtX3NhbXBsZS5nZXQoKSk7Ci0gICAgICAgIEdzdFN0cnVjdHVyZSogaW5m b0NvcHkgPSBudWxscHRyOwotICAgICAgICBpZiAoaW5mbykKLSAgICAgICAgICAgIGluZm9Db3B5 ID0gZ3N0X3N0cnVjdHVyZV9jb3B5KGluZm8pOwotICAgICAgICBtX3NhbXBsZSA9IGFkb3B0R1Jl Zihnc3Rfc2FtcGxlX25ldyhudWxscHRyLCBnc3Rfc2FtcGxlX2dldF9jYXBzKG1fc2FtcGxlLmdl dCgpKSwKLSAgICAgICAgICAgIGdzdF9zYW1wbGVfZ2V0X3NlZ21lbnQobV9zYW1wbGUuZ2V0KCkp LCBpbmZvQ29weSkpOworICAgIGlmICghbV9wbGF0Zm9ybUxheWVyUHJveHktPmlzQWN0aXZlKCkp CiAgICAgICAgIHJldHVybjsKLSAgICB9CiAKICNpZiBVU0UoR1NUUkVBTUVSX0dMKQogICAgIHN0 ZDo6dW5pcXVlX3B0cjxHc3RWaWRlb0ZyYW1lSG9sZGVyPiBmcmFtZUhvbGRlciA9IHN0ZDo6bWFr ZV91bmlxdWU8R3N0VmlkZW9GcmFtZUhvbGRlcj4obV9zYW1wbGUuZ2V0KCksIHRleE1hcEZsYWdG cm9tT3JpZW50YXRpb24obV92aWRlb1NvdXJjZU9yaWVudGF0aW9uKSk7Cg==