172908 2017-06-04 13:45:22 -0700 Fix MediaPlayerPrivateMediaFoundation::naturalSize 2019-06-06 19:43:35 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=198555 https://bugs.webkit.org/show_bug.cgi?id=198640 P2 Normal --- 1 annulen annulen achristensen bfulgham pvollan oldest_to_newest 1315590 0 annulen 2017-06-04 13:45:22 -0700 naturalSize should return size of video frame corrected by PAR, not size of video element. 1315591 1 311972 annulen 2017-06-04 13:49:40 -0700 Created attachment 311972 Patch 1315686 2 311972 achristensen 2017-06-05 07:10:23 -0700 Comment on attachment 311972 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=311972&action=review > Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:1563 > + FloatSize size(width, height); > + size.setWidth(size.width() * parNumerator / parDenominator); > + return size; Can't we just return FloatSize(width * parNumerator / parDenominator, height)? Also, parNumerator and parDenominator could have better names. 1315687 3 311972 annulen 2017-06-05 07:15:13 -0700 Comment on attachment 311972 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=311972&action=review >> Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:1563 >> + return size; > > Can't we just return FloatSize(width * parNumerator / parDenominator, height)? > Also, parNumerator and parDenominator could have better names. I can change it to return FloatSize(float(width) * parNumerator / parDenominator, height) What kind of better names do you have in mind? Expand "par" to "pixelAspectRatio"? 1315751 4 achristensen 2017-06-05 13:09:58 -0700 Sure. I initially thought it was an abbreviation of parameter. 1315790 5 annulen 2017-06-05 14:45:31 -0700 Committed r217795: <http://trac.webkit.org/changeset/217795> 311972 2017-06-04 13:49:40 -0700 2017-06-05 07:10:23 -0700 Patch bug-172908-20170604234939.patch text/plain 5313 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMjE3NzY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjk1NzQ5YTdiNjk0Y2U3 OGVmZTY2NzVjM2NiYzI5ZWI4YjUyZjcwNS4uNTQ3OTlkMzA3MGJlZWM3Nzk5NThkOTMyNzA5MDA2 NmI0M2RiMDFlYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE3LTA2LTA0ICBLb25z dGFudGluIFRva2FyZXYgIDxhbm51bGVuQHlhbmRleC5ydT4KKworICAgICAgICBGaXggTWVkaWFQ bGF5ZXJQcml2YXRlTWVkaWFGb3VuZGF0aW9uOjpuYXR1cmFsU2l6ZQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcyOTA4CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFG b3VuZGF0aW9uOjpuYXR1cmFsU2l6ZSBzaG91bGQgcmV0dXJuIHNpemUgb2YKKyAgICAgICAgdmlk ZW8gZnJhbWUgY29ycmVjdGVkIGJ5IFBBUiwgbm90IHNpemUgb2YgdmlkZW8gZWxlbWVudC4KKwor ICAgICAgICBObyBuZXcgdGVzdHMgbmVlZGVkLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhp Y3Mvd2luL01lZGlhUGxheWVyUHJpdmF0ZU1lZGlhRm91bmRhdGlvbi5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpNZWRpYVBsYXllclByaXZhdGVNZWRpYUZvdW5kYXRpb246OmxvYWQpOgorICAgICAg ICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFGb3VuZGF0aW9uOjpuYXR1cmFsU2l6 ZSk6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllclByaXZhdGVNZWRpYUZvdW5kYXRpb246 OnNldE5hdHVyYWxTaXplKToKKyAgICAgICAgKFdlYkNvcmU6OmNhbGN1bGF0ZU5hdHVyYWxTaXpl KToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZU1lZGlhRm91bmRhdGlvbjo6 Q3VzdG9tVmlkZW9QcmVzZW50ZXI6OnNldE1lZGlhVHlwZSk6CisgICAgICAgICogcGxhdGZvcm0v Z3JhcGhpY3Mvd2luL01lZGlhUGxheWVyUHJpdmF0ZU1lZGlhRm91bmRhdGlvbi5oOgorCiAyMDE3 LTA2LTA0ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgSW1wbGVt ZW50IERPTU1hdHJpeFJlYWRPbmx5LnRyYW5zZm9ybVBvaW50KCkKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9NZWRpYVBsYXllclByaXZhdGVNZWRpYUZv dW5kYXRpb24uY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2luL01lZGlh UGxheWVyUHJpdmF0ZU1lZGlhRm91bmRhdGlvbi5jcHAKaW5kZXggZWQzMmQxOWY3NDE0MTdkNTk2 YTk2MjhiY2M1NzJjNGZiNWNmODhhMC4uMzA3NmUxOTUzZmY3ZmY2ZDA5Njc4ZDY2ZDdiZDkwYjMy ZGQ3MzI4NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2lu L01lZGlhUGxheWVyUHJpdmF0ZU1lZGlhRm91bmRhdGlvbi5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2luL01lZGlhUGxheWVyUHJpdmF0ZU1lZGlhRm91bmRhdGlv bi5jcHAKQEAgLTE2OCw2ICsxNjgsMTEgQEAgTWVkaWFQbGF5ZXI6OlN1cHBvcnRzVHlwZSBNZWRp YVBsYXllclByaXZhdGVNZWRpYUZvdW5kYXRpb246OnN1cHBvcnRzVHlwZShjb25zdAogCiB2b2lk IE1lZGlhUGxheWVyUHJpdmF0ZU1lZGlhRm91bmRhdGlvbjo6bG9hZChjb25zdCBTdHJpbmcmIHVy bCkKIHsKKyAgICB7CisgICAgICAgIExvY2tIb2xkZXIgbG9ja2VyKG1fY2FjaGVkTmF0dXJhbFNp emVMb2NrKTsKKyAgICAgICAgbV9jYWNoZWROYXR1cmFsU2l6ZSA9IEZsb2F0U2l6ZSgpOworICAg IH0KKwogICAgIHN0YXJ0Q3JlYXRlTWVkaWFTb3VyY2UodXJsKTsKIAogICAgIG1fbmV0d29ya1N0 YXRlID0gTWVkaWFQbGF5ZXI6OkxvYWRpbmc7CkBAIC0yMTAsOSArMjE1LDEwIEBAIGJvb2wgTWVk aWFQbGF5ZXJQcml2YXRlTWVkaWFGb3VuZGF0aW9uOjpzdXBwb3J0c0Z1bGxzY3JlZW4oKSBjb25z dAogICAgIHJldHVybiB0cnVlOwogfQogCi1GbG9hdFNpemUgTWVkaWFQbGF5ZXJQcml2YXRlTWVk aWFGb3VuZGF0aW9uOjpuYXR1cmFsU2l6ZSgpIGNvbnN0IAorRmxvYXRTaXplIE1lZGlhUGxheWVy UHJpdmF0ZU1lZGlhRm91bmRhdGlvbjo6bmF0dXJhbFNpemUoKSBjb25zdAogewotICAgIHJldHVy biBtX3NpemU7CisgICAgTG9ja0hvbGRlciBsb2NrZXIobV9jYWNoZWROYXR1cmFsU2l6ZUxvY2sp OworICAgIHJldHVybiBtX2NhY2hlZE5hdHVyYWxTaXplOwogfQogCiBib29sIE1lZGlhUGxheWVy UHJpdmF0ZU1lZGlhRm91bmRhdGlvbjo6aGFzVmlkZW8oKSBjb25zdApAQCAtNzMwLDYgKzczNiwx MiBAQCB2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZU1lZGlhRm91bmRhdGlvbjo6bm90aWZ5RGVsZXRl ZCgpCiAgICAgICAgICgqaXQpLT5vbk1lZGlhUGxheWVyRGVsZXRlZCgpOwogfQogCit2b2lkIE1l ZGlhUGxheWVyUHJpdmF0ZU1lZGlhRm91bmRhdGlvbjo6c2V0TmF0dXJhbFNpemUoY29uc3QgRmxv YXRTaXplJiBzaXplKQoreworICAgIExvY2tIb2xkZXIgbG9ja2VyKG1fY2FjaGVkTmF0dXJhbFNp emVMb2NrKTsKKyAgICBtX2NhY2hlZE5hdHVyYWxTaXplID0gc2l6ZTsKK30KKwogYm9vbCBNZWRp YVBsYXllclByaXZhdGVNZWRpYUZvdW5kYXRpb246OmNyZWF0ZU91dHB1dE5vZGUoQ09NUHRyPElN RlN0cmVhbURlc2NyaXB0b3I+IHNvdXJjZVNELCBDT01QdHI8SU1GVG9wb2xvZ3lOb2RlPiYgbm9k ZSkKIHsKICAgICBpZiAoIU1GQ3JlYXRlVG9wb2xvZ3lOb2RlUHRyKCkgfHwgIU1GQ3JlYXRlQXVk aW9SZW5kZXJlckFjdGl2YXRlUHRyKCkgfHwgIU1GQ3JlYXRlVmlkZW9SZW5kZXJlckFjdGl2YXRl UHRyKCkpCkBAIC0xNTM1LDYgKzE1NDcsMjUgQEAgc3RhdGljIGJvb2wgYXJlTWVkaWFUeXBlc0Vx dWFsKElNRk1lZGlhVHlwZSogdHlwZTEsIElNRk1lZGlhVHlwZSogdHlwZTIpCiAgICAgcmV0dXJu IFNfT0sgPT0gdHlwZTEtPklzRXF1YWwodHlwZTIsICZmbGFncyk7CiB9CiAKK3N0YXRpYyBGbG9h dFNpemUgY2FsY3VsYXRlTmF0dXJhbFNpemUoSU1GTWVkaWFUeXBlKiBtZWRpYVR5cGUpCit7Cisg ICAgVUlOVDMyIHdpZHRoID0gMCwgaGVpZ2h0ID0gMDsKKyAgICBIUkVTVUxUIGhyID0gTUZHZXRB dHRyaWJ1dGVTaXplKG1lZGlhVHlwZSwgTUZfTVRfRlJBTUVfU0laRSwgJndpZHRoLCAmaGVpZ2h0 KTsKKyAgICBpZiAoRkFJTEVEKGhyKSB8fCAhaGVpZ2h0KQorICAgICAgICByZXR1cm4gRmxvYXRT aXplKCk7CisKKyAgICBVSU5UMzIgcGFyTnVtZXJhdG9yID0gMDsKKyAgICBVSU5UMzIgcGFyRGVu b21pbmF0b3IgPSAwOworICAgIGhyID0gTUZHZXRBdHRyaWJ1dGVSYXRpbyhtZWRpYVR5cGUsIE1G X01UX1BJWEVMX0FTUEVDVF9SQVRJTywgJnBhck51bWVyYXRvciwgJnBhckRlbm9taW5hdG9yKTsK KyAgICBpZiAoU1VDQ0VFREVEKGhyKSAmJiBwYXJOdW1lcmF0b3IgJiYgcGFyRGVub21pbmF0b3Ip IHsKKyAgICAgICAgRmxvYXRTaXplIHNpemUod2lkdGgsIGhlaWdodCk7CisgICAgICAgIHNpemUu c2V0V2lkdGgoc2l6ZS53aWR0aCgpICogcGFyTnVtZXJhdG9yIC8gcGFyRGVub21pbmF0b3IpOwor ICAgICAgICByZXR1cm4gc2l6ZTsKKyAgICB9CisKKyAgICByZXR1cm4gRmxvYXRTaXplKCk7Cit9 CisKIEhSRVNVTFQgTWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFGb3VuZGF0aW9uOjpDdXN0b21WaWRl b1ByZXNlbnRlcjo6c2V0TWVkaWFUeXBlKElNRk1lZGlhVHlwZSogbWVkaWFUeXBlKQogewogICAg IGlmICghbWVkaWFUeXBlKSB7CkBAIC0xNTkyLDYgKzE2MjMsMTAgQEAgSFJFU1VMVCBNZWRpYVBs YXllclByaXZhdGVNZWRpYUZvdW5kYXRpb246OkN1c3RvbVZpZGVvUHJlc2VudGVyOjpzZXRNZWRp YVR5cGUoSU0KICAgICAgICAgbV9zY2hlZHVsZXIuc2V0RnJhbWVSYXRlKGRlZmF1bHRGcmFtZVJh dGUpOwogICAgIH0KIAorICAgIC8vIFVwZGF0ZSBuYXR1cmFsIHNpemUKKyAgICBpZiAobV9tZWRp YVBsYXllcikKKyAgICAgICAgbV9tZWRpYVBsYXllci0+c2V0TmF0dXJhbFNpemUoY2FsY3VsYXRl TmF0dXJhbFNpemUobWVkaWFUeXBlKSk7CisKICAgICBBU1NFUlQobWVkaWFUeXBlKTsKICAgICBt X21lZGlhVHlwZSA9IG1lZGlhVHlwZTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3Mvd2luL01lZGlhUGxheWVyUHJpdmF0ZU1lZGlhRm91bmRhdGlvbi5oIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2luL01lZGlhUGxheWVyUHJpdmF0ZU1l ZGlhRm91bmRhdGlvbi5oCmluZGV4IGY3OGZjY2M1NmFiMTUxZjY3NjFjYjljNDE5ZDkwOTYyMzVm NDllMGQuLjliMGYxY2RiZGY4MjYxNDE5NWQ4MzJjNjBkN2UxM2M3MmYxMWRiNGIgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9NZWRpYVBsYXllclByaXZh dGVNZWRpYUZvdW5kYXRpb24uaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy93aW4vTWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFGb3VuZGF0aW9uLmgKQEAgLTEyMCw2ICsxMjAs OSBAQCBwcml2YXRlOgogICAgIEhhc2hTZXQ8TWVkaWFQbGF5ZXJMaXN0ZW5lcio+IG1fbGlzdGVu ZXJzOwogICAgIExvY2sgbV9tdXRleExpc3RlbmVyczsKIAorICAgIEZsb2F0U2l6ZSBtX2NhY2hl ZE5hdHVyYWxTaXplOworICAgIG11dGFibGUgTG9jayBtX2NhY2hlZE5hdHVyYWxTaXplTG9jazsK KwogICAgIFdlYWtQdHJGYWN0b3J5PE1lZGlhUGxheWVyUHJpdmF0ZU1lZGlhRm91bmRhdGlvbj4g bV93ZWFrUHRyRmFjdG9yeTsKICAgICBDT01QdHI8SU1GTWVkaWFTZXNzaW9uPiBtX21lZGlhU2Vz c2lvbjsKICAgICBDT01QdHI8SU1GU291cmNlUmVzb2x2ZXI+IG1fc291cmNlUmVzb2x2ZXI7CkBA IC0xNTcsNiArMTYwLDcgQEAgcHJpdmF0ZToKIAogICAgIHZvaWQgYWRkTGlzdGVuZXIoTWVkaWFQ bGF5ZXJMaXN0ZW5lciopOwogICAgIHZvaWQgcmVtb3ZlTGlzdGVuZXIoTWVkaWFQbGF5ZXJMaXN0 ZW5lciopOworICAgIHZvaWQgc2V0TmF0dXJhbFNpemUoY29uc3QgRmxvYXRTaXplJik7CiAgICAg dm9pZCBub3RpZnlEZWxldGVkKCk7CiAKICAgICBzdGF0aWMgTFJFU1VMVCBDQUxMQkFDSyBWaWRl b1ZpZXdXbmRQcm9jKEhXTkQgaFduZCwgVUlOVCBtZXNzYWdlLCBXUEFSQU0gd1BhcmFtLCBMUEFS QU0gbFBhcmFtKTsK