172887 2017-06-02 18:13:59 -0700 ASSERTION FAILED: m_currentScriptCallbackID in UIScriptContext::requestUIScriptCompletion(JSStringRef) running fast/events/ios/autocorrect-with-range-selection.html 2017-06-05 08:42:34 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton sam simon.fraser oldest_to_newest 1315324 0 thorton 2017-06-02 18:13:59 -0700 ASSERTION FAILED: m_currentScriptCallbackID in UIScriptContext::requestUIScriptCompletion(JSStringRef) running fast/events/ios/autocorrect-with-range-selection.html 1315325 1 311895 thorton 2017-06-02 18:14:27 -0700 Created attachment 311895 Patch 1315470 2 311895 sam 2017-06-03 13:11:40 -0700 Comment on attachment 311895 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=311895&action=review > Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:487 > + // applyAutocorrection can call its completion handler synchronously, > + // which makes UIScriptController unhappy (see bug 172884). Should we change applyAutocorrection? Are we consistent about whether completionHandlers can call back synchronously? 1315511 3 thorton 2017-06-03 21:09:03 -0700 (In reply to Sam Weinig from comment #2) > Comment on attachment 311895 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=311895&action=review > > > Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:487 > > + // applyAutocorrection can call its completion handler synchronously, > > + // which makes UIScriptController unhappy (see bug 172884). > > Should we change applyAutocorrection? I don't think we can (it is the way it is for a reason: <rdar://problem/16207002>) yet. > Are we consistent about whether > completionHandlers can call back synchronously? I think the API is fairly consistent, but this is not API, this is our implementation of an internal UIKit method. 1315694 4 thorton 2017-06-05 08:42:34 -0700 http://trac.webkit.org/changeset/217781/webkit 311895 2017-06-02 18:14:27 -0700 2017-06-03 13:11:40 -0700 Patch bug-172887-20170602181426.patch text/plain 2031 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjE3NzIwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzU3MzMxNDY4YjE1MjI4MmJmYzc3Yjg4MzkxMTk1OTMz YmFkZmIwMy4uMzY4N2QxNzc0OWViM2EwNzA4NDY4NmFlMGYyZmEzODU2NTdkZDJiYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDE3LTA2LTAyICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgor CisgICAgICAgIEFTU0VSVElPTiBGQUlMRUQ6IG1fY3VycmVudFNjcmlwdENhbGxiYWNrSUQgaW4g VUlTY3JpcHRDb250ZXh0OjpyZXF1ZXN0VUlTY3JpcHRDb21wbGV0aW9uKEpTU3RyaW5nUmVmKSBy dW5uaW5nIGZhc3QvZXZlbnRzL2lvcy9hdXRvY29ycmVjdC13aXRoLXJhbmdlLXNlbGVjdGlvbi5o dG1sCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzI4 ODcKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzMyNTQ2MDYxPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9pb3MvVUlT Y3JpcHRDb250cm9sbGVySU9TLm1tOgorICAgICAgICAoV1RSOjpVSVNjcmlwdENvbnRyb2xsZXI6 OmFwcGx5QXV0b2NvcnJlY3Rpb24pOgorICAgICAgICBhcHBseUF1dG9jb3JyZWN0aW9uIGNhbiBj YWxsIGl0cyBjb21wbGV0aW9uIGhhbmRsZXIgc3luY2hyb25vdXNseSwKKyAgICAgICAgd2hpY2gg bWFrZXMgVUlTY3JpcHRDb250cm9sbGVyIHVuaGFwcHkgKHNlZSBidWcgMTcyODg0KS4KKwogMjAx Ny0wNi0wMiAgWmFuIERvYmVyc2VrICA8emRvYmVyc2VrQGlnYWxpYS5jb20+CiAKICAgICAgICAg W1dQRV0gRW5hYmxlIFNVQlRMRV9DUllQVE8KZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RS dW5uZXIvaW9zL1VJU2NyaXB0Q29udHJvbGxlcklPUy5tbSBiL1Rvb2xzL1dlYktpdFRlc3RSdW5u ZXIvaW9zL1VJU2NyaXB0Q29udHJvbGxlcklPUy5tbQppbmRleCBkYjFmZmEwMDNhNzU1NWNiZjAw MWVmODA4MTRhNWQ3MjcyOTA4YWI3Li5kOTRlNWNmM2UzNGVmZTE3YzI0YzRkM2NhM2M0NjExZGEx MmVkNzY5IDEwMDY0NAotLS0gYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL2lvcy9VSVNjcmlwdENv bnRyb2xsZXJJT1MubW0KKysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9pb3MvVUlTY3JpcHRD b250cm9sbGVySU9TLm1tCkBAIC00ODMsOSArNDgzLDEzIEBAIHZvaWQgVUlTY3JpcHRDb250cm9s bGVyOjphcHBseUF1dG9jb3JyZWN0aW9uKEpTU3RyaW5nUmVmIG5ld1N0cmluZywgSlNTdHJpbmdS ZWYKIAogICAgIFRlc3RSdW5uZXJXS1dlYlZpZXcgKndlYlZpZXcgPSBUZXN0Q29udHJvbGxlcjo6 c2luZ2xldG9uKCkubWFpbldlYlZpZXcoKS0+cGxhdGZvcm1WaWV3KCk7CiAgICAgW3dlYlZpZXcg YXBwbHlBdXRvY29ycmVjdGlvbjp0b1dURlN0cmluZyh0b1dLKG5ld1N0cmluZykpIHRvU3RyaW5n OnRvV1RGU3RyaW5nKHRvV0sob2xkU3RyaW5nKSkgd2l0aENvbXBsZXRpb25IYW5kbGVyOl4gewot ICAgICAgICBpZiAoIW1fY29udGV4dCkKLSAgICAgICAgICAgIHJldHVybjsKLSAgICAgICAgbV9j b250ZXh0LT5hc3luY1Rhc2tDb21wbGV0ZShjYWxsYmFja0lEKTsKKyAgICAgICAgLy8gYXBwbHlB dXRvY29ycmVjdGlvbiBjYW4gY2FsbCBpdHMgY29tcGxldGlvbiBoYW5kbGVyIHN5bmNocm9ub3Vz bHksCisgICAgICAgIC8vIHdoaWNoIG1ha2VzIFVJU2NyaXB0Q29udHJvbGxlciB1bmhhcHB5IChz ZWUgYnVnIDE3Mjg4NCkuCisgICAgICAgIGRpc3BhdGNoX2FzeW5jKGRpc3BhdGNoX2dldF9tYWlu X3F1ZXVlKCksIF4geworICAgICAgICAgICAgaWYgKCFtX2NvbnRleHQpCisgICAgICAgICAgICAg ICAgcmV0dXJuOworICAgICAgICAgICAgbV9jb250ZXh0LT5hc3luY1Rhc2tDb21wbGV0ZShjYWxs YmFja0lEKTsKKyAgICAgICAgfSk7CiAgICAgfV07CiB9CiAK