172885 2017-06-02 18:04:05 -0700 Defer installing mach breakpoint handler until watchdog is actually called 2017-06-02 18:10:04 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 keith_miller keith_miller benjamin buildbot cdumez cmarcelo dbates mark.lam msaboff saam oldest_to_newest 1315318 0 keith_miller 2017-06-02 18:04:05 -0700 Defer installing mach breakpoint handler until watchdog is actually called 1315320 1 311894 keith_miller 2017-06-02 18:06:01 -0700 Created attachment 311894 Patch 1315321 2 311894 saam 2017-06-02 18:09:27 -0700 Comment on attachment 311894 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=311894&action=review r=me > Source/WTF/wtf/threads/Signals.cpp:202 > + dataLogLn("Handled an exception"); remove these logs please 1315322 3 keith_miller 2017-06-02 18:10:04 -0700 Committed r217745: <http://trac.webkit.org/changeset/217745> 311894 2017-06-02 18:06:01 -0700 2017-06-02 18:09:27 -0700 Patch bug-172885-20170602180600.patch text/plain 3459 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjE3NzQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA1 MWU5ZWU5ODdlNDI3ZjczMWYwMGI4M2Q4ODQ1YjRjYzc5NzI3NGJiLi5hM2RmMzc2ZDFmZTAyMjA0 ZmI3NmM1YzIwZTdiZTI5MTIzN2M2OTJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxNy0wNi0wMiAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBEZWZlciBpbnN0YWxsaW5nIG1hY2ggYnJlYWtwb2ludCBoYW5kbGVy IHVudGlsIHdhdGNoZG9nIGlzIGFjdHVhbGx5IGNhbGxlZAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcyODg1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRWFnZXJseSBpbnN0YWxsaW5nIHRoZSBtYWNoIGJy ZWFrcG9pbnQgaGFuZGxlciBjYXVzZXMgaXNzdWVzIHdpdGggWGNvZGUgR1VJIGRlYnVnZ2luZy4K KyAgICAgICAgVGhpcyBoaWRlcyB0aGUgaXNzdWUsIHNvIGl0IHdvbid0IG9jY3VyIGFzIG9mdGVu LgorCisgICAgICAgICogcnVudGltZS9WTVRyYXBzLmNwcDoKKyAgICAgICAgKEpTQzo6Vk1UcmFw czo6U2lnbmFsU2VuZGVyOjpzZW5kKToKKyAgICAgICAgKEpTQzo6Vk1UcmFwczo6Vk1UcmFwcyk6 IERlbGV0ZWQuCisgICAgICAgICogcnVudGltZS9WTVRyYXBzLmg6CisKIDIwMTctMDYtMDIgIEZp bGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAgICBBdG9taWNzLmxvYWQgYW5k IEF0b21pY3Muc3RvcmUgbmVlZCB0byBiZSBmdWxseSBmZW5jZWQKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKaW5kZXggMDUxY2Y2MGRjNmE1 NzFlOGNhMmFlOWQwNjJjZjhkNDU4ZjlkNjQwMC4uYTY1YzdlNDhjZDg2ZTQ5MDY5NjVmNzg1OWM3 NTFhZjI4MjRmYjc0ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsNSArMSw0IEBACiAyMDE3LTA2LTAyICBTdGVwaGFuIFN6 YWJvICA8c3RlcGhhbi5zemFib0BhbS5zb255LmNvbT4KLQogICAgICAgICBbSlNDT25seV0gQnVp bGQgc3RhdGljIGpzYy5leGUgb24gV2luZG93cwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcyODMzCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL1ZNVHJhcHMuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvVk1UcmFwcy5jcHAKaW5kZXggOGM1N2M0NTZhZTQzNjhhZGYyOGVhMGE2NDU4ZTdjMDM5YTk3 MGVlOS4uNTFmMjhkM2U5Y2Q3MWZmMTQyNmNkOGY4Yjg5YzIxMjc4NjE2Njg2ZiAxMDA2NDQKLS0t IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvVk1UcmFwcy5jcHAKKysrIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvVk1UcmFwcy5jcHAKQEAgLTMzOCwxOCArMzM4LDYgQEAg dm9pZCBWTVRyYXBzOjppbnZhbGlkYXRlQ29kZUJsb2Nrc09uU3RhY2soTG9ja2VyPExvY2s+Jiwg RXhlY1N0YXRlKiB0b3BDYWxsRnJhbWUKIAogI2VuZGlmIC8vIEVOQUJMRShTSUdOQUxfQkFTRURf Vk1fVFJBUFMpCiAKLVZNVHJhcHM6OlZNVHJhcHMoKQotewotI2lmIEVOQUJMRShTSUdOQUxfQkFT RURfVk1fVFJBUFMpCi0gICAgaWYgKCFPcHRpb25zOjp1c2VQb2xsaW5nVHJhcHMoKSkgewotICAg ICAgICBzdGF0aWMgc3RkOjpvbmNlX2ZsYWcgb25jZTsKLSAgICAgICAgc3RkOjpjYWxsX29uY2Uo b25jZSwgW10gewotICAgICAgICAgICAgaW5zdGFsbFNpZ25hbEhhbmRsZXIoKTsKLSAgICAgICAg fSk7Ci0gICAgfQotI2VuZGlmCi19Ci0KIHZvaWQgVk1UcmFwczo6d2lsbERlc3Ryb3lWTSgpCiB7 CiAgICAgbV9pc1NodXR0aW5nRG93biA9IHRydWU7CkBAIC0zOTQsNiArMzgyLDExIEBAIHZvaWQg Vk1UcmFwczo6U2lnbmFsU2VuZGVyOjp3aWxsRGVzdHJveVZNKCkKIAogdm9pZCBWTVRyYXBzOjpT aWduYWxTZW5kZXI6OnNlbmQoKQogeworICAgIHN0YXRpYyBzdGQ6Om9uY2VfZmxhZyBvbmNlOwor ICAgIHN0ZDo6Y2FsbF9vbmNlKG9uY2UsIFtdIHsKKyAgICAgICAgaW5zdGFsbFNpZ25hbEhhbmRs ZXIoKTsKKyAgICB9KTsKKwogICAgIHdoaWxlICh0cnVlKSB7CiAgICAgICAgIC8vIFdlIG5lZWQg YSBuZXN0ZWQgc2NvcGUgc28gdGhhdCB3ZSdsbCByZWxlYXNlIHRoZSBsb2NrIGJlZm9yZSB3ZSBz bGVlcCBiZWxvdy4KICAgICAgICAgewpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L3J1bnRpbWUvVk1UcmFwcy5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvVk1UcmFw cy5oCmluZGV4IDU0MjViMTg4MzMyN2ZhZDgzZWM2MDI0MjZhZTk2ODEzNWZjYjA1ODEuLjliNzI2 NDdhYjI2MjNlYjFjODgyZTAyNjM2ZjRiMWMwYjJhMDIzZjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9ydW50aW1lL1ZNVHJhcHMuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvcnVudGltZS9WTVRyYXBzLmgKQEAgLTg2LDcgKzg2LDYgQEAgcHVibGljOgogICAgICAgICBC aXRGaWVsZCBtX21hc2s7CiAgICAgfTsKIAotICAgIFZNVHJhcHMoKTsKICAgICB+Vk1UcmFwcygp CiAgICAgewogI2lmIEVOQUJMRShTSUdOQUxfQkFTRURfVk1fVFJBUFMpCmRpZmYgLS1naXQgYS9T b3VyY2UvV1RGL3d0Zi90aHJlYWRzL1NpZ25hbHMuY3BwIGIvU291cmNlL1dURi93dGYvdGhyZWFk cy9TaWduYWxzLmNwcAppbmRleCA3ZjI0NzA2NWVlZDVjMWYwYjAzNTM4YTM4MWI1ODkzMDUwNWUy MjIwLi45ZTdkZjg2ZDFhNTZlZjEzN2RlNTIzYWExODk3NjNhOGRhYzIyMjg3IDEwMDY0NAotLS0g YS9Tb3VyY2UvV1RGL3d0Zi90aHJlYWRzL1NpZ25hbHMuY3BwCisrKyBiL1NvdXJjZS9XVEYvd3Rm L3RocmVhZHMvU2lnbmFscy5jcHAKQEAgLTE5OCw4ICsxOTgsMTIgQEAga2Vybl9yZXR1cm5fdCBj YXRjaF9tYWNoX2V4Y2VwdGlvbl9yYWlzZV9zdGF0ZSgKICAgICAgICAgZGlkSGFuZGxlIHw9IGhh bmRsZXJSZXN1bHQgPT0gU2lnbmFsQWN0aW9uOjpIYW5kbGVkOwogICAgIH0pOwogCi0gICAgaWYg KGRpZEhhbmRsZSkKKyAgICBpZiAoZGlkSGFuZGxlKSB7CisgICAgICAgIGRhdGFMb2dMbigiSGFu ZGxlZCBhbiBleGNlcHRpb24iKTsKICAgICAgICAgcmV0dXJuIEtFUk5fU1VDQ0VTUzsKKyAgICB9 CisKKyAgICBkYXRhTG9nTG4oIkRpZG4ndCBoYW5kbGUgYW4gZXhjZXB0aW9uICIsIGV4Y2VwdGlv blR5cGUpOwogICAgIHJldHVybiBLRVJOX0ZBSUxVUkU7CiB9CiAK