172879 2017-06-02 16:32:41 -0700 LayoutTest webrtc/video-unmute.html is a flaky timeout 2018-09-27 10:03:56 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=172771 InRadar P2 Normal --- 1 ryanhaddad youennf achristensen commit-queue eric.carlson jer.noble jlewis3 webkit-bug-importer youennf oldest_to_newest 1315275 0 ryanhaddad 2017-06-02 16:32:41 -0700 LayoutTest webrtc/video-unmute.html is a flaky timeout https://build.webkit.org/results/Apple%20iOS%2010%20Simulator%20Debug%20WK2%20(Tests)/r217735%20(1790)/results.html https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=webrtc%2Fvideo-unmute.html 1315276 1 ryanhaddad 2017-06-02 16:34:40 -0700 This test was added with http://trac.webkit.org/changeset/217624 1315302 2 webkit-bug-importer 2017-06-02 17:12:16 -0700 <rdar://problem/32548738> 1319752 3 jlewis3 2017-06-15 15:54:49 -0700 Marked test as flaky: https://trac.webkit.org/changeset/218366/webkit 1387881 4 jlewis3 2018-01-10 14:51:42 -0800 This in now happening on macOS WK2 as well. current test example: https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r226729%20(2162)/results.html diff: --- /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/webrtc/video-unmute-expected.txt +++ /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/webrtc/video-unmute-actual.txt @@ -1,6 +1,5 @@ - +#PID UNRESPONSIVE - com.apple.WebKit.WebContent.Development (pid 13426) +FAIL: Timed out waiting for notifyDone to be called -PASS Setting video exchange -PASS Track is disabled, video should be black -PASS Track is enabled, video should not be black - +#EOF +#EOF I was able to reproduce the timeout with run-webkit-tests --no-retry-failure --verbose --debug webrtc/video-unmute.html --iterations=50 Marked as skipped for now due to timeouts in: https://trac.webkit.org/changeset/226737/webkit 1461157 5 350156 youennf 2018-09-19 15:58:20 -0700 Created attachment 350156 Patch 1464020 6 350156 commit-queue 2018-09-27 10:03:55 -0700 Comment on attachment 350156 Patch Clearing flags on attachment: 350156 Committed r236555: <https://trac.webkit.org/changeset/236555> 1464021 7 commit-queue 2018-09-27 10:03:56 -0700 All reviewed patches have been landed. Closing bug. 350156 2018-09-19 15:58:20 -0700 2018-09-27 10:03:55 -0700 Patch bug-172879-20180919155820.patch text/plain 4783 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2MjEyCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMDVjMGFhMjZiMWNmOTQxYzljZGYw Y2Q5MmM3ODU4NzQ5MmM3MDQ5Mi4uNzhjY2ZkZTcwNmRlNGFmMzhmOTAyZDdjOTIwYWRjNGU1YjFm ZWJmMCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE4LTA5LTE5ICBZb3Vlbm4gRmFibGV0ICA8 eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBMYXlvdXRUZXN0IHdlYnJ0Yy92aWRlby11bm11 dGUuaHRtbCBpcyBhIGZsYWt5IHRpbWVvdXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE3Mjg3OQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzI1NDg3 Mzg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBw bGF0Zm9ybS9pb3Mtd2syL1Rlc3RFeHBlY3RhdGlvbnM6CisgICAgICAgICogcGxhdGZvcm0vbWFj LXdrMi9UZXN0RXhwZWN0YXRpb25zOgorICAgICAgICAqIHdlYnJ0Yy92aWRlby11bm11dGUuaHRt bDoKKyAgICAgICAgUmVzb3J0IG9uIHJvdXRpbmVzLmpzIGJsYWNrIGZyYW1lIHJvdXRpbmUuCisg ICAgICAgIFJlZW5hYmxlIHRlc3QgaW4gbWFjIGFuZCBpb3MuCisKIDIwMTgtMDktMTkgIFlvdWVu biBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIExheW91dCBUZXN0IHdlYnJ0 Yy92aWRlby1tdXRlLmh0bWwgaXMgZmxha3kuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9pb3Mtd2syL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9pb3Mt d2syL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggOWMwYjFjYTE3OTg2NGQ0NWYyYTdmOTI1MWIwYTYz ZTExMmQ4NTUyMS4uMDQ0ZDQ3NDExNzQ1MzA4YTVlOTk3NzFhZDFjYmU5NjI1NjU5MTEzZCAxMDA2 NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vaW9zLXdrMi9UZXN0RXhwZWN0YXRpb25zCisr KyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2lvcy13azIvVGVzdEV4cGVjdGF0aW9ucwpAQCAtMTI0 NSw4ICsxMjQ1LDYgQEAgd2Via2l0Lm9yZy9iLzE4MTE2NyBpbXBvcnRlZC93M2Mvd2ViLXBsYXRm b3JtLXRlc3RzL3NlcnZpY2Utd29ya2Vycy9zZXJ2aWNlLXdvcmsKIAogd2Via2l0Lm9yZy9iLzE4 MTM5MiBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL3NlcnZpY2Utd29ya2Vycy9zZXJ2 aWNlLXdvcmtlci9mZXRjaC13YWl0cy1mb3ItYWN0aXZhdGUuaHR0cHMuaHRtbCBbIFBhc3MgRmFp bHVyZSBdCiAKLXdlYmtpdC5vcmcvYi8xNzI4Nzkgd2VicnRjL3ZpZGVvLXVubXV0ZS5odG1sIFsg U2tpcCBdCi0KIHdlYmtpdC5vcmcvYi8xODE5NTcgWyBSZWxlYXNlIF0gaHR0cC90ZXN0cy9taXNj L3Jlc291cmNlLXRpbWluZy1yZXNvbHV0aW9uLmh0bWwgWyBQYXNzIEZhaWx1cmUgXQogCiB3ZWJr aXQub3JnL2IvMTgxODIxIGZhc3QvdmlzdWFsLXZpZXdwb3J0L2lvcy9jYXJldC1hZnRlci1mb2N1 cy1pbi1maXhlZC5odG1sIFsgUGFzcyBGYWlsdXJlIF0KZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L3BsYXRmb3JtL21hYy13azIvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3Jt L21hYy13azIvVGVzdEV4cGVjdGF0aW9ucwppbmRleCBjZjA0OGY0Yjc1ZDZjN2RlYjczYmU2OTVl NzFjYjUxMmM2N2IwNzJlLi5iZDZmMzU5MGE0ZGM3OGY3ODA1MTU3MWFjNjJiMjBmNDA3MjNjNzE2 IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2syL1Rlc3RFeHBlY3RhdGlv bnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi9UZXN0RXhwZWN0YXRpb25zCkBA IC03OTUsOCArNzk1LDYgQEAgd2Via2l0Lm9yZy9iLzE4MTE2NyBpbXBvcnRlZC93M2Mvd2ViLXBs YXRmb3JtLXRlc3RzL3NlcnZpY2Utd29ya2Vycy9zZXJ2aWNlLXdvcmsKIAogd2Via2l0Lm9yZy9i LzE4MTEwNyBodHRwL3dwdC9jYWNoZS1zdG9yYWdlL2NhY2hlLXB1dC1zdHJlYW0uaHR0cHMuYW55 Lmh0bWwgWyBQYXNzIEZhaWx1cmUgXQogCi13ZWJraXQub3JnL2IvMTcyODc5IHdlYnJ0Yy92aWRl by11bm11dGUuaHRtbCBbIFNraXAgXQotCiB3ZWJraXQub3JnL2IvMTgxNTAyIHN3aXBlL3B1c2hz dGF0ZS13aXRoLW1hbnVhbC1zY3JvbGxyZXN0b3JhdGlvbi5odG1sIFsgRmFpbHVyZSBdCiAKIHdl YmtpdC5vcmcvYi8xODE3NTAgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9zZXJ2aWNl LXdvcmtlcnMvc2VydmljZS13b3JrZXIvZmV0Y2gtcmVxdWVzdC1yZWRpcmVjdC5odHRwcy5odG1s IFsgRHVtcEpTQ29uc29sZUxvZ0luU3RkRXJyIFBhc3MgRmFpbHVyZSBdCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy93ZWJydGMvdmlkZW8tdW5tdXRlLmh0bWwgYi9MYXlvdXRUZXN0cy93ZWJydGMv dmlkZW8tdW5tdXRlLmh0bWwKaW5kZXggMDE1YWMyOWQwMGE3NmIzYjk0ZWFjMWNhOTEyZDA0YWE2 N2NhMmMxNy4uNWY5MTU4NTEyOWM1M2JkYzc2YTIzNzZhZWUyMjBhM2M5YzU5NDQ0ZSAxMDA2NDQK LS0tIGEvTGF5b3V0VGVzdHMvd2VicnRjL3ZpZGVvLXVubXV0ZS5odG1sCisrKyBiL0xheW91dFRl c3RzL3dlYnJ0Yy92aWRlby11bm11dGUuaHRtbApAQCAtMTEsNDkgKzExLDggQEAKICAgICAgICAg PHZpZGVvIGlkPSJ2aWRlbyIgYXV0b3BsYXkgcGxheXNJbmxpbmUgd2lkdGg9IjMyMCIgaGVpZ2h0 PSIyNDAiPjwvdmlkZW8+CiAgICAgICAgIDxjYW52YXMgaWQ9ImNhbnZhczEiIHdpZHRoPSIzMjAi IGhlaWdodD0iMjQwIj48L2NhbnZhcz4KICAgICAgICAgPGNhbnZhcyBpZD0iY2FudmFzMiIgd2lk dGg9IjMyMCIgaGVpZ2h0PSIyNDAiPjwvY2FudmFzPgotICAgICAgICA8Y2FudmFzIGlkPSJjYW52 YXMzIiB3aWR0aD0iMzIwIiBoZWlnaHQ9IjI0MCI+PC9jYW52YXM+CiAgICAgICAgIDxzY3JpcHQg c3JjID0icm91dGluZXMuanMiPjwvc2NyaXB0PgogICAgICAgICA8c2NyaXB0PgotZnVuY3Rpb24g aXNWaWRlb0JsYWNrKGlkKQotewotICAgIHZhciBjYW52YXMgPSBkb2N1bWVudC5nZXRFbGVtZW50 QnlJZChpZCk7Ci0gICAgY2FudmFzLndpZHRoID0gdmlkZW8udmlkZW9XaWR0aDsKLSAgICBjYW52 YXMuaGVpZ2h0ID0gdmlkZW8udmlkZW9IZWlnaHQ7Ci0gICAgY2FudmFzLmdldENvbnRleHQoJzJk JykuZHJhd0ltYWdlKHZpZGVvLCAwLCAwLCBjYW52YXMud2lkdGgsIGNhbnZhcy5oZWlnaHQpOwot Ci0gICAgaW1hZ2VEYXRhID0gY2FudmFzLmdldENvbnRleHQoJzJkJykuZ2V0SW1hZ2VEYXRhKDAs IDAsIGNhbnZhcy53aWR0aCwgY2FudmFzLmhlaWdodCk7Ci0gICAgZGF0YSA9IGltYWdlRGF0YS5k YXRhOwotICAgIGZvciAodmFyIGNwdHIgPSAwOyBjcHRyIDwgY2FudmFzLndpZHRoICogY2FudmFz LmhlaWdodDsgKytjcHRyKSB7Ci0gICAgICAgIC8vIEFwcHJveGltYXRpdmVseSBibGFjayBwaXhl bHMuCi0gICAgICAgIGlmIChkYXRhWzQgKiBjcHRyXSA+IDEwIHx8IGRhdGFbNCAqIGNwdHIgKyAx XSA+IDEwIHx8IGRhdGFbNCAqIGNwdHIgKyAyXSA+IDEwKQotICAgICAgICAgICAgcmV0dXJuIGZh bHNlOwotICAgIH0KLSAgICByZXR1cm4gdHJ1ZTsKLX0KLQotZnVuY3Rpb24gcG9sbFZpZGVvQmxh Y2tDaGVjayhleHBlY3RlZCwgaWQsIHJlc29sdmUsIHJlamVjdCwgY291bnRlcikKLXsKLSAgICBp ZiAoaXNWaWRlb0JsYWNrKGlkKSA9PT0gZXhwZWN0ZWQpIHsKLSAgICAgICAgcmVzb2x2ZSgpOwot ICAgICAgICByZXR1cm47Ci0gICAgfQotCi0gICAgaWYgKCFjb3VudGVyKQotICAgICAgICBjb3Vu dGVyID0gMDsKLSAgICBlbHNlIGlmICgrK2NvdW50ZXIgPiA0MCkgewotICAgICAgICByZWplY3Qo InRlc3QgZm9yICIgKyBpZCArICIgdGltZWQgb3V0Iik7Ci0gICAgICAgIHJldHVybjsKLSAgICB9 Ci0gICAgc2V0VGltZW91dCgoKSA9PiBwb2xsVmlkZW9CbGFja0NoZWNrKGV4cGVjdGVkLCBpZCwg cmVzb2x2ZSwgcmVqZWN0LCBjb3VudGVyKSwgMTAwKTsKLX0KLQotZnVuY3Rpb24gY2hlY2tWaWRl b0JsYWNrKGV4cGVjdGVkLCBpZCkKLXsKLSAgICByZXR1cm4gbmV3IFByb21pc2UoKHJlc29sdmUs IHJlamVjdCkgPT4gewotICAgICAgICBwb2xsVmlkZW9CbGFja0NoZWNrKGV4cGVjdGVkLCBpZCwg cmVzb2x2ZSwgcmVqZWN0KTsKLSAgICB9KTsKLX0KLQogdmFyIHRyYWNrOwogdmFyIHJlbW90ZVRy YWNrOwogcHJvbWlzZV90ZXN0KCh0ZXN0KSA9PiB7CkBAIC04MiwxMiArNDEsMTIgQEAgcHJvbWlz ZV90ZXN0KCh0ZXN0KSA9PiB7CiB9LCAiU2V0dGluZyB2aWRlbyBleGNoYW5nZSIpOwogCiBwcm9t aXNlX3Rlc3QoKHRlc3QpID0+IHsKLSAgICByZXR1cm4gY2hlY2tWaWRlb0JsYWNrKHRydWUsICJj YW52YXMxIik7CisgICAgcmV0dXJuIGNoZWNrVmlkZW9CbGFjayh0cnVlLCBjYW52YXMxLCB2aWRl byk7CiB9LCAiVHJhY2sgaXMgZGlzYWJsZWQsIHZpZGVvIHNob3VsZCBiZSBibGFjayIpOwogCiBw cm9taXNlX3Rlc3QoKHRlc3QpID0+IHsKICAgICB0cmFjay5lbmFibGVkID0gdHJ1ZTsKLSAgICBy ZXR1cm4gY2hlY2tWaWRlb0JsYWNrKGZhbHNlLCAiY2FudmFzMiIpOworICAgIHJldHVybiBjaGVj a1ZpZGVvQmxhY2soZmFsc2UsIGNhbnZhczIsIHZpZGVvKTsKIH0sICJUcmFjayBpcyBlbmFibGVk LCB2aWRlbyBzaG91bGQgbm90IGJlIGJsYWNrIik7CiAKICAgICAgICAgPC9zY3JpcHQ+Cg==