172862 2017-06-02 10:09:00 -0700 [JSCOnly] Support building jsc.exe with dynamic JSC library on Windows 2024-01-26 17:24:15 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 172144 1 stephan.szabo don.olmstead don.olmstead lforschler vladimir webkit-bug-importer oldest_to_newest 1315086 0 stephan.szabo 2017-06-02 10:09:00 -0700 We've gotten statically linked jsc.exe on Windows from JSCOnly build, but need to support dynamically linked version as well. 1328888 1 315461 vladimir 2017-07-14 11:20:14 -0700 Created attachment 315461 fix shared jsc shell builds on windows The reason for this is that the JSCOnly builds expect a static WTF (but don't define WTF_LIBRARY_TYPE, fixed that) that's compiled in to JavaScriptCore, but they still make WTF as part of the cmake target library dependencies. Additionally, the -DSTATICALLY_LINKED_WITH_WTF gets propagated down to the jsc shell, which is also not correct. The library thing (jscore.dll needs to link with WTF, but it should *not* tell downstream dependants that they need to link with WTF.lib) I fixed by introducing a public/private target_link_libraries split in WEBKIT_FRAMEWORK, and adding WTF to the private libs for jscore as appropriate. The STATICALLY_LINKED_WITH_WTF define was done the same way, by adding it to the PRIVATE defines for JavaScriptCore if WTF is static. The static linking of WTF also causes some problems because we don't actually get the WTF includes or WTF's own dependant libs (like winmm). I hacked around that in the shell CMakeLists, but I'm not very happy about it. With this, both static and shared JSCOnly builds work on Windows. I have not tested any other config or any other platform, though. 2008010 2 don.olmstead 2024-01-26 12:17:34 -0800 Pull request: https://github.com/WebKit/WebKit/pull/23324 2008087 3 ews-feeder 2024-01-26 17:23:59 -0800 Committed 273589@main (9c4ef355f719): <https://commits.webkit.org/273589@main> Reviewed commits have been landed. Closing PR #23324 and removing active labels. 2008088 4 webkit-bug-importer 2024-01-26 17:24:15 -0800 <rdar://problem/121702710> 315461 2017-07-14 11:20:14 -0700 2017-07-14 11:20:14 -0700 fix shared jsc shell builds on windows shared-jsc-win.patch text/plain 4360 vladimir ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DTWFrZUxpc3RzLnR4dCBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9DTWFrZUxpc3RzLnR4dAppbmRleCBiMGFiNDFlMzcyYi4uYzU2ZGI0 ZGY3NGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DTWFrZUxpc3RzLnR4dAor KysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ01ha2VMaXN0cy50eHQKQEAgLTEwNzQsMTEgKzEw NzQsMTYgQEAgc2V0KEphdmFTY3JpcHRDb3JlX09CSkVDVF9MVVRfU09VUkNFUwogKQogCiBzZXQo SmF2YVNjcmlwdENvcmVfTElCUkFSSUVTCi0gICAgV1RGJHtERUJVR19TVUZGSVh9CiAgICAgJHtJ Q1VfSTE4Tl9MSUJSQVJJRVN9CiAgICAgJHtMTFZNX0xJQlJBUklFU30KICkKIAoraWYoIiR7V1RG X0xJQlJBUllfVFlQRX0iIFNUUkVRVUFMICJTVEFUSUMiKQorICBzZXQoSmF2YVNjcmlwdENvcmVf UFJJVkFURV9MSUJSQVJJRVMgV1RGJHtERUJVR19TVUZGSVh9KQorZWxzZSgpCisgIGxpc3QoQVBQ RU5EIEphdmFTY3JpcHRDb3JlX0xJQlJBUklFUyBXVEYke0RFQlVHX1NVRkZJWH0pCitlbmRpZigp CisKIHNldChKYXZhU2NyaXB0Q29yZV9TQ1JJUFRTX1NPVVJDRVNfRElSICIke0pBVkFTQ1JJUFRD T1JFX0RJUn0vU2NyaXB0cyIpCiAKICMgR2xvYmJpbmcgcmVsaWVzIG9uIHRoZSBmYWN0IHRoYXQg Z2VuZXJhdG9yLXNwZWNpZmljIGZpbGUgbmFtZXMgYXJlIHByZWZpeGVkIHdpdGggdGhlaXIgZGly ZWN0b3J5LgpAQCAtMTU3NCw2ICsxNTc5LDEwIEBAIGlmIChOT1QgIiR7UE9SVH0iIFNUUkVRVUFM ICJNYWMiKQogICAgIGVuZGlmICgpCiBlbmRpZiAoKQogCitpZigiJHtXVEZfTElCUkFSWV9UWVBF fSIgU1RSRVFVQUwgIlNUQVRJQyIpCisgIHRhcmdldF9jb21waWxlX2RlZmluaXRpb25zKEphdmFT Y3JpcHRDb3JlIFBSSVZBVEUgLURTVEFUSUNBTExZX0xJTktFRF9XSVRIX1dURikKK2VuZGlmKCkK KwogIyBGb3JjZSBzdGFnaW5nIG9mIHNoYXJlZCBzY3JpcHRzLCBldmVuIGlmIHRoZXkgYXJlbid0 IGRpcmVjdGx5IHVzZWQgdG8gYnVpbGQgSmF2YVNjcmlwdENvcmUuCiAKIGFkZF9jdXN0b21fdGFy Z2V0KHN0YWdlU2hhcmVkU2NyaXB0cyBERVBFTkRTICR7SmF2YVNjcmlwdENvcmVfU0NSSVBUU30p CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvUGxhdGZvcm1KU0NPbmx5LmNtYWtl IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL1BsYXRmb3JtSlNDT25seS5jbWFrZQppbmRleCA3ZTNj MmZlNDhiMi4uMzRhZGY4NmRkZTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9Q bGF0Zm9ybUpTQ09ubHkuY21ha2UKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL1BsYXRmb3Jt SlNDT25seS5jbWFrZQpAQCAtMSw1ICsxLDMgQEAKLWFkZF9kZWZpbml0aW9ucygtRFNUQVRJQ0FM TFlfTElOS0VEX1dJVEhfV1RGKQotCiBpZiAoVVNFX0dMSUIpCiAgICAgbGlzdChBUFBFTkQgSmF2 YVNjcmlwdENvcmVfU1lTVEVNX0lOQ0xVREVfRElSRUNUT1JJRVMKICAgICAgICAgJHtHTElCX0lO Q0xVREVfRElSU30KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9zaGVsbC9DTWFr ZUxpc3RzLnR4dCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9zaGVsbC9DTWFrZUxpc3RzLnR4dApp bmRleCA4MGVhNjgzMTA2Mi4uNTY4MmIwYjA2M2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9zaGVsbC9DTWFrZUxpc3RzLnR4dAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv c2hlbGwvQ01ha2VMaXN0cy50eHQKQEAgLTUsNyArNSw2IEBAIHNldChKU0NfU09VUkNFUwogc2V0 KEpTQ19MSUJSQVJJRVMKICAgICAke0NNQUtFX0RMX0xJQlN9CiAgICAgSmF2YVNjcmlwdENvcmUk e0RFQlVHX1NVRkZJWH0KLSAgICBXVEYke0RFQlVHX1NVRkZJWH0KICkKIAogaWYgKFdURl9PU19N QUNfT1NfWCkKQEAgLTM2LDggKzM1LDIwIEBAIFdFQktJVF9XUkFQX1NPVVJDRUxJU1QoJHtKU0Nf U09VUkNFU30pCiBXRUJLSVRfV1JBUF9TT1VSQ0VMSVNUKCR7VEVTVEFQSV9TT1VSQ0VTfSkKIGlu Y2x1ZGVfZGlyZWN0b3JpZXMoLi8gJHtKYXZhU2NyaXB0Q29yZV9JTkNMVURFX0RJUkVDVE9SSUVT fSkKIGluY2x1ZGVfZGlyZWN0b3JpZXMoU1lTVEVNICR7SmF2YVNjcmlwdENvcmVfU1lTVEVNX0lO Q0xVREVfRElSRUNUT1JJRVN9KQorCisjIEEgYml0IG9mIGEgaGFjayB0byBtYWtlIHN1cmUgd2Ug YWx3YXlzIGhhdmUgdGhlIFdURiBpbmNsdWRlcywKKyMgcmVnYXJkbGVzcyBpZiBXVEYgaXMgY29t aW5nIHRvIHVzIHZpYSBXVEYgZGlyZWN0bHkgb3Igc3RhdGljYWxseSBmcm9tCisjIGEgc3RhdGlj IFdURiBpbiBhIHNoYXJlZCBKYXZhU2NyaXB0Q29yZQorZ2V0X3RhcmdldF9wcm9wZXJ0eSh3dGZp bmNsdWRlcyBXVEYgSU5URVJGQUNFX0lOQ0xVREVfRElSRUNUT1JJRVMpCitpbmNsdWRlX2RpcmVj dG9yaWVzKCR7d3RmaW5jbHVkZXN9KQorIyBBbm90aGVyIGJpdCBvZiBhIGhhY2s7IHRoaXMgaXMg cGFydCBvZiBXVEYncyBsaWJzLCBidXQgd2UgbWlnaHQgbm90CisjIGJlIGFjdHVhbGx5IGRlcGVu ZGluZyBvbiB0aGUgV1RGIHRhcmdldCBpZiBXVEYgaXMgc3RhdGljIGluc2lkZSBKU0NvcmUKK2lm IChNU1ZDKQorICBsaW5rX2xpYnJhcmllcyh3aW5tbSkKK2VuZGlmKCkKKwogYWRkX2V4ZWN1dGFi bGUoanNjICR7SlNDX1NPVVJDRVN9KQotdGFyZ2V0X2xpbmtfbGlicmFyaWVzKGpzYyAke0pTQ19M SUJSQVJJRVN9KQordGFyZ2V0X2xpbmtfbGlicmFyaWVzKGpzYyAke0pTQ19MSUJSQVJJRVN9ICR7 V1RGX0xJQlJBUklFU30pCiAKIGlmIChKU0NfT1VUUFVUX05BTUUpCiAgICAgc2V0X3RhcmdldF9w cm9wZXJ0aWVzKGpzYyBQUk9QRVJUSUVTIE9VVFBVVF9OQU1FICR7SlNDX09VVFBVVF9OQU1FfSkK ZGlmZiAtLWdpdCBhL1NvdXJjZS9jbWFrZS9PcHRpb25zSlNDT25seS5jbWFrZSBiL1NvdXJjZS9j bWFrZS9PcHRpb25zSlNDT25seS5jbWFrZQppbmRleCBlN2JjNzcwNzg0ZC4uMzM0NmFlODVlYjgg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zSlNDT25seS5jbWFrZQorKysgYi9Tb3Vy Y2UvY21ha2UvT3B0aW9uc0pTQ09ubHkuY21ha2UKQEAgLTQ1LDExICs0NSw4IEBAIGlmIChXVEZf Q1BVX1g4NiBPUiBXVEZfQ1BVX1g4Nl82NCkKICAgICBTRVRfQU5EX0VYUE9TRV9UT19CVUlMRChV U0VfVURJUzg2IDEpCiBlbmRpZiAoKQogCi0jIEZJWE1FOiBKU0NPbmx5IG9uIFdJTjMyIHNlZW1z IHRvIG9ubHkgd29yayB3aXRoIGZ1bGx5IHN0YXRpYyBidWlsZAotIyBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcyODYyCi1pZiAoRU5BQkxFX1NUQVRJQ19KU0MgT1Ig V0lOMzIpCi0gICAgc2V0KEphdmFTY3JpcHRDb3JlX0xJQlJBUllfVFlQRSBTVEFUSUMpCi1lbmRp ZiAoKQorIyBBbHdheXMgYnVpbGQgV1RGIHN0YXRpYyBmb3IganNjb25seSBidWlsZHMKK3NldChX VEZfTElCUkFSWV9UWVBFIFNUQVRJQykKIAogaWYgKFdJTjMyKQogICAgIGFkZF9kZWZpbml0aW9u cygtRE5PTUlOTUFYKQpkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlL1dlYktpdE1hY3Jvcy5jbWFr ZSBiL1NvdXJjZS9jbWFrZS9XZWJLaXRNYWNyb3MuY21ha2UKaW5kZXggOWUxYmI3ZDk1NGIuLmFm MGEyMmU0ZTAwIDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvV2ViS2l0TWFjcm9zLmNtYWtlCisr KyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRNYWNyb3MuY21ha2UKQEAgLTI4OCw3ICsyODgsOCBAQCBt YWNybyhXRUJLSVRfRlJBTUVXT1JLIF90YXJnZXQpCiAgICAgKQogICAgIHRhcmdldF9pbmNsdWRl X2RpcmVjdG9yaWVzKCR7X3RhcmdldH0gUFVCTElDICIkPEJVSUxEX0lOVEVSRkFDRTokeyR7X3Rh cmdldH1fSU5DTFVERV9ESVJFQ1RPUklFU30+IikKICAgICB0YXJnZXRfaW5jbHVkZV9kaXJlY3Rv cmllcygke190YXJnZXR9IFBSSVZBVEUgIiQ8QlVJTERfSU5URVJGQUNFOiR7JHtfdGFyZ2V0fV9Q UklWQVRFX0lOQ0xVREVfRElSRUNUT1JJRVN9PiIpCi0gICAgdGFyZ2V0X2xpbmtfbGlicmFyaWVz KCR7X3RhcmdldH0gJHske190YXJnZXR9X0xJQlJBUklFU30pCisgICAgdGFyZ2V0X2xpbmtfbGli cmFyaWVzKCR7X3RhcmdldH0gUFVCTElDICR7JHtfdGFyZ2V0fV9MSUJSQVJJRVN9KQorICAgIHRh cmdldF9saW5rX2xpYnJhcmllcygke190YXJnZXR9IFBSSVZBVEUgJHske190YXJnZXR9X1BSSVZB VEVfTElCUkFSSUVTfSkKICAgICBzZXRfdGFyZ2V0X3Byb3BlcnRpZXMoJHtfdGFyZ2V0fSBQUk9Q RVJUSUVTIENPTVBJTEVfREVGSU5JVElPTlMgIkJVSUxESU5HXyR7X3RhcmdldH0iKQogCiAgICAg aWYgKCR7X3RhcmdldH1fT1VUUFVUX05BTUUpCg==