172852 2017-06-02 03:09:18 -0700 [GTK][WPE] Fix the condition to decide whether the MediaPlayer can be rendered accelerated 2017-06-05 00:45:17 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 magomez magomez bugs-noreply commit-queue mcatanzaro oldest_to_newest 1315008 0 magomez 2017-06-02 03:09:18 -0700 The current condition will return false if the video doesn't have a renderer. This is an error because the video may be hidden, but that doesn't mean that the rendering cannot be accelerated. For example, when gstreamer-gl is enabled, if we are copying the video frames to webgl and the video element is hidden we will perform the copies using the sw path, because the check about whether the media player can be accelerated will return false. Also, during the loading of the page, if the condition gets checked before the video renderer is created, it will return false as well. 1315016 1 311814 magomez 2017-06-02 03:25:07 -0700 Created attachment 311814 Patch 1315645 2 311814 commit-queue 2017-06-05 00:45:16 -0700 Comment on attachment 311814 Patch Clearing flags on attachment: 311814 Committed r217777: <http://trac.webkit.org/changeset/217777> 1315646 3 commit-queue 2017-06-05 00:45:17 -0700 All reviewed patches have been landed. Closing bug. 311814 2017-06-02 03:25:07 -0700 2017-06-05 00:45:16 -0700 Patch bug-172852-20170602122506.patch text/plain 2634 magomez U3VidmVyc2lvbiBSZXZpc2lvbjogMjE3NzA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmUwYzI3ZTZkNjcwNGZk YzExMTFiM2U3Y2Y1YmU5MDhmNGUyOWUyOS4uZTY2OGYwOTI4ZmI5YWJhMzg5YzAyM2Q5MjE0Y2E3 Yzg3MGU3NDJlOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE3LTA2LTAyICBNaWd1 ZWwgR29tZXogIDxtYWdvbWV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS11bV1BFXSBGaXgg dGhlIGNvbmRpdGlvbiB0byBkZWNpZGUgd2hldGhlciB0aGUgTWVkaWFQbGF5ZXIgY2FuIGJlIHJl bmRlcmVkIGFjY2VsZXJhdGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNzI4NTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBCZWZvcmUgdGhpcyBjaGFuZ2UsIGluIG9yZGVyIHRvIGRldGVybWluZSB3aGV0 aGVyIHRoZSBNZWRpYVBsYXllciByZW5kZXJpbmcgY291bGQgYmUgYWNjZWxlcmF0ZWQgd2UKKyAg ICAgICAgbmVlZGVkIHRoZSBwbGF5ZXIgdG8gaGF2ZSBhIHJlbmRlcmVyIG9yIGl0IHdvdWxkIHJl dHVybiBmYWxzZS4gVGhlIHJlbmRlcmVyIHdhcyBuZWVkZWQgaW4gb3JkZXIgdG8KKyAgICAgICAg YWNjZXNzIHRoZSBSZW5kZXJMYXllckNvbXBvc2l0b3IgYW5kIGNoZWNrIHdoZXRoZXIgdGhlIGNo cm9tZSB3b3VsZCBiZSBvdmVyd3JpdGluZyB0aGUgYWNjZWxlcmF0ZWQKKyAgICAgICAgY29tcG9z aXRpbmcgc2V0dGluZy4gQnV0IHdlIGRvbid0IGhhdmUgdGhhdCBvcHRpb24gaW4gV2ViS2l0R1RL KyBvciBXUEUsIHNvIHdlIGNhbiBqdXN0IGNoZWNrIHRoZQorICAgICAgICBhY2NlbGVyYXRlZCBj b21wb3NpdGluZyBzZXR0aW5nIGRpcmVjdGx5LgorCisgICAgICAgIEFub3RoZXIgcHJvYmxlbXMg d2l0aCB0aGUgYXBwcm9hY2ggYmVmb3JlIHRoaXMgY2hhbmdlIGlzIHRoYXQgYWNjZWxlcmF0ZWQg cmVuZGVyaW5nIHdhcyBiZWluZyBkaXNhYmxlZAorICAgICAgICB3aGVuIHRoZSB2aWRlbyBlbGVt ZW50IHdhcyBub3QgdmlzaWJsZSwgYXMgdGhlcmUncyBubyB2aWRlbyByZW5kZXJlci4gRHVlIHRv IHRoaXMsIGNhc2VzIHdoZXJlIHRoZSB2aWRlbworICAgICAgICBpcyBwYWludGVkIHRocm91Z2gg YW4gYWNjZWxlcmF0ZWQgY2FudmFzIG9yIHdlYmdsIHdvdWxkIG5vdCBiZSB1c2luZyBoYXJkd2Fy ZSBhY2NlbGVyYXRlZCBjb3BpZXMuCisKKyAgICAgICAgQ292ZXJlZCBieSBleGlzdGVudCB0ZXN0 cy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclBy aXZhdGVHU3RyZWFtZXJCYXNlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJp dmF0ZUdTdHJlYW1lckJhc2U6OmFjY2VsZXJhdGVkUmVuZGVyaW5nU3RhdGVDaGFuZ2VkKToKKwog MjAxNy0wNi0wMSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAK ICAgICAgICAgW0dUS10gQ2FjaGUgUmVuZGVyVGhlbWVHYWRnZXQgaGllcmFyY2hpZXMgZm9yIHJl bmRlcmluZyB0aGVtZWQgZWxlbWVudHMgd2l0aCBHVEsrIDMuMjArCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRl R1N0cmVhbWVyQmFzZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3Ry ZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZS5jcHAKaW5kZXggYTZkNzFjNTVk MzFmNzdlYTIyZTY2Yzg2OTE1ZjU4ODUxY2Y5NjY1ZC4uZGYwNmUwNTFjNDkzZDhkNjc5NWFhYjRm OTZlNjNmNjhkY2Y0YmQ3OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2UuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclBy aXZhdGVHU3RyZWFtZXJCYXNlLmNwcApAQCAtNjUwLDcgKzY1MCw3IEBAIHZvaWQgTWVkaWFQbGF5 ZXJQcml2YXRlR1N0cmVhbWVyQmFzZTo6bXV0ZUNoYW5nZWRDYWxsYmFjayhNZWRpYVBsYXllclBy aXZhdGVHU3RyCiAKIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZTo6YWNjZWxl cmF0ZWRSZW5kZXJpbmdTdGF0ZUNoYW5nZWQoKQogewotICAgIG1fcmVuZGVyaW5nQ2FuQmVBY2Nl bGVyYXRlZCA9IG1fcGxheWVyICYmIG1fcGxheWVyLT5jbGllbnQoKS5tZWRpYVBsYXllckFjY2Vs ZXJhdGVkQ29tcG9zaXRpbmdFbmFibGVkKCkgJiYgbV9wbGF5ZXItPmNsaWVudCgpLm1lZGlhUGxh eWVyUmVuZGVyaW5nQ2FuQmVBY2NlbGVyYXRlZChtX3BsYXllcik7CisgICAgbV9yZW5kZXJpbmdD YW5CZUFjY2VsZXJhdGVkID0gbV9wbGF5ZXIgJiYgbV9wbGF5ZXItPmNsaWVudCgpLm1lZGlhUGxh eWVyQWNjZWxlcmF0ZWRDb21wb3NpdGluZ0VuYWJsZWQoKTsKIH0KIAogI2lmIFVTRShURVhUVVJF X01BUFBFUl9HTCkK