172818 2017-06-01 09:06:54 -0700 webkitpy: Do not send 0 or -1 as a pid to kill_process 2017-06-01 09:36:03 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard ap buildbot commit-queue darin dbates glenn lforschler webkit-bug-importer oldest_to_newest 1314637 0 jbedard 2017-06-01 09:06:54 -0700 0 and -1 do have meaning when killing a process, but if they are sent to executive.kill_process(...), this indicates a bug. executive.kill_process(...) is intended to be used to kill a single process. Throw an exception when a pid which is undefined, 0 or negative is passed into executive.kill_process(...). We should also fix the existing case where we know kill_process(...) could receive an illegal pid. 1314638 1 webkit-bug-importer 2017-06-01 09:08:25 -0700 <rdar://problem/32512215> 1314642 2 311710 jbedard 2017-06-01 09:17:13 -0700 Created attachment 311710 Patch 1314650 3 311710 commit-queue 2017-06-01 09:36:02 -0700 Comment on attachment 311710 Patch Clearing flags on attachment: 311710 Committed r217658: <http://trac.webkit.org/changeset/217658> 1314651 4 commit-queue 2017-06-01 09:36:03 -0700 All reviewed patches have been landed. Closing bug. 311710 2017-06-01 09:17:13 -0700 2017-06-01 09:36:02 -0700 Patch bug-172818-20170601091712.patch text/plain 3329 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIxNzY1NikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIyIEBACisyMDE3LTA2LTAxICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICB3ZWJraXRweTogRG8gbm90IHNlbmQgMCBvciAtMSBhcyBhIHBpZCB0byBr aWxsX3Byb2Nlc3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE3MjgxOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFNlbmRpbmcgYSBzaWduYWwgdG8gcHJvY2VzcyAwIHdpbGwgcmVzdWx0IGluIGFsbCBwcm9j ZXNzZXMgaW4gdGhlIGdyb3VwIHJlY2VpdmluZyAKKyAgICAgICAgdGhlIHNpZ25hbC4gU2VuZGlu ZyBhIHNpZ25hbCB0byBwcm9jZXNzIC0xIHdpbGwgcmVzdWx0IGluIGFsbCBub24tc3lzdGVtIHBy b2Nlc3NlcworICAgICAgICByZWNlaXZpbmcgdGhlIHNpZ25hbC4gQm90aCBFeGVjdXRpdmUua2ls bF9wcm9jZXNzIGFuZCBFeGVjdXRpdmUuY2hlY2tfcnVubmluZ19waWQKKyAgICAgICAgc2hvdWxk IGNvbnNpZGVyIHRoZXNlIGNhc2VzCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1v bi9zeXN0ZW0vZXhlY3V0aXZlLnB5OgorICAgICAgICAoRXhlY3V0aXZlLmtpbGxfcHJvY2Vzcyk6 IFRocm93IGV4Y2VwdGlvbiBpZiBwaWQgaXMgdW5kZWZpbmVkLCAwIG9yIG5lZ2F0aXZlLgorICAg ICAgICAoRXhlY3V0aXZlLmNoZWNrX3J1bm5pbmdfcGlkKTogQW4gdW5kZWZpbmVkIHBpZCwgcGlk IDAgb3IgYSBuZWdhdGl2ZSBwaWQgd2lsbAorICAgICAgICBuZXZlciBiZSBydW5uaW5nLCBhbHRo b3VnaCBvcy5raWxsIG1heSBzdWNjZWVkLgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvcG9y dC9zaW11bGF0b3JfcHJvY2Vzcy5weToKKyAgICAgICAgKFNpbXVsYXRvclByb2Nlc3Muc3RvcCk6 IERvIG5vdCBraWxsIHByb2Nlc3MgaWYgaXQgaXMgdW5kZWZpbmVkLgorCiAyMDE3LTA1LTI2ICBN YXR0aGV3IEhhbnNvbiAgPG1hdHRoZXdfaGFuc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBDaGVy cnktcGljayByMjE3Mjk2LiByZGFyOi8vcHJvYmxlbS8zMjQxNDM2MwpJbmRleDogVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL2V4ZWN1dGl2ZS5weQo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBU b29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vZXhlY3V0aXZlLnB5CShyZXZpc2lv biAyMTc1NTUpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vZXhlY3V0 aXZlLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0xODUsNiArMTg1LDEzIEBAIGNsYXNzIEV4ZWN1dGl2 ZShvYmplY3QpOgogICAgICAgICByZXR1cm4gW3NjcmlwdF9wYXRoXQogCiAgICAgZGVmIGtpbGxf cHJvY2VzcyhzZWxmLCBwaWQpOgorICAgICAgICAjIEtpbGxpbmcgYSBwcm9jZXNzIHdpdGggYSBw aWQgb2YgMCBvciBhIG5lZ2F0aXZlIHBpZCBpcyBhIHZhbGlkIGNvbW1hbmQsIGJ1dAorICAgICAg ICAjIHdpbGwga2lsbCBhbGwgcHJvY2Vzc2VzIGluIHRoaXMgcHJvY2VzcycgZ3JvdXAgKGlmIDAp IG9yIGFsbCBub24tc3lzdGVtIHByb2Nlc3NlcworICAgICAgICAjIChpZiAtMSkgKGtpbGwoMikp LiBUaHJvdyBhbiBleGNlcHRpb24gaWYgdGhpcyBpcyB0aGUgYmVoYXZpb3IgcmVxdWVzdGVkLCB0 aGlzCisgICAgICAgICMgY2xhc3MgaXMgbm90IGRlc2lnbmVkIHRvIHByb3ZpZGUgdGhpcyBmdW5j dGlvbmFsaXR5LgorICAgICAgICBpZiBwaWQgaXMgTm9uZSBvciBwaWQgPD0gMDoKKyAgICAgICAg ICAgIHJhaXNlIFJ1bnRpbWVFcnJvcignQ2Fubm90IGtpbGwgcHJvY2VzcyB3aXRoIGludmFsaWQg cGlkIG9mIHt9Jy5mb3JtYXQocGlkKSkKKwogICAgICAgICAiIiJBdHRlbXB0cyB0byBraWxsIHRo ZSBnaXZlbiBwaWQuCiAgICAgICAgIFdpbGwgZmFpbCBzaWxlbnRseSBpZiBwaWQgZG9lcyBub3Qg ZXhpc3Qgb3IgaW5zdWZmaWNpZW50IHBlcm1pc3NzaW9ucy4iIiIKICAgICAgICAgaWYgc3lzLnBs YXRmb3JtLnN0YXJ0c3dpdGgoJ3dpbjMyJyk6CkBAIC0yNjcsNiArMjc0LDEwIEBAIGNsYXNzIEV4 ZWN1dGl2ZShvYmplY3QpOgogICAgICAgICByZXR1cm4gcmVzdWx0CiAKICAgICBkZWYgY2hlY2tf cnVubmluZ19waWQoc2VsZiwgcGlkKToKKyAgICAgICAgIyBBbiB1bmRlZmluZWQgcHJvY2VzcyBv ciBhIG5lZ2F0aXZlIHByb2Nlc3MgYXJlIG5ldmVyIHJ1bm5pbmcuCisgICAgICAgIGlmIHBpZCBp cyBOb25lIG9yIHBpZCA8PSAwOgorICAgICAgICAgICAgcmV0dXJuIEZhbHNlCisKICAgICAgICAg IiIiUmV0dXJuIFRydWUgaWYgcGlkIGlzIGFsaXZlLCBvdGhlcndpc2UgcmV0dXJuIEZhbHNlLiIi IgogICAgICAgICBpZiBzeXMucGxhdGZvcm0uc3RhcnRzd2l0aCgnd2luJyk6CiAgICAgICAgICAg ICByZXR1cm4gc2VsZi5fd2luMzJfY2hlY2tfcnVubmluZ19waWQocGlkKQpJbmRleDogVG9vbHMv U2NyaXB0cy93ZWJraXRweS9wb3J0L3NpbXVsYXRvcl9wcm9jZXNzLnB5Cj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9zaW11bGF0b3JfcHJvY2Vzcy5weQkocmV2aXNp b24gMjE3NTU1KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L3NpbXVsYXRvcl9wcm9j ZXNzLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0xMjAsNiArMTIwLDYgQEAgY2xhc3MgU2ltdWxhdG9y UHJvY2VzcyhTZXJ2ZXJQcm9jZXNzKToKICAgICAgICAgc2VsZi5fcHJvYyA9IFNpbXVsYXRvclBy b2Nlc3MuUG9wZW4oc2VsZi5fcGlkLCBzdGRpbiwgc3Rkb3V0LCBzdGRlcnIsIHNlbGYuX3Rhcmdl dF9ob3N0KQogCiAgICAgZGVmIHN0b3Aoc2VsZiwgdGltZW91dF9zZWNzPTMuMCk6Ci0gICAgICAg IGlmIHNlbGYuX3Byb2M6CisgICAgICAgIGlmIHNlbGYuX3Byb2MgYW5kIHNlbGYuX3Byb2MucGlk OgogICAgICAgICAgICAgc2VsZi5fdGFyZ2V0X2hvc3QuZXhlY3V0aXZlLmtpbGxfcHJvY2Vzcyhz ZWxmLl9wcm9jLnBpZCkKICAgICAgICAgcmV0dXJuIHN1cGVyKFNpbXVsYXRvclByb2Nlc3MsIHNl bGYpLnN0b3AodGltZW91dF9zZWNzKQo=