172813 2017-06-01 08:40:46 -0700 fast/events/touch/document-create-touch.html is failing since r217390 2017-08-28 09:52:53 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 magomez Ms2ger ap bugs-noreply commit-queue mcatanzaro Ms2ger oldest_to_newest 1314624 0 magomez 2017-06-01 08:40:46 -0700 There were some updates in the tests in r217390 and this started to fail there. fast/events/touch/document-create-touch.html [ Failure ] 1314640 1 ap 2017-06-01 09:15:11 -0700 What does the failure look like? 1314647 2 mcatanzaro 2017-06-01 09:30:52 -0700 Thanks Miguel! Let's try to post text diffs, or links to image diffs, when convenient: --- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/fast/events/touch/document-create-touch-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/fast/events/touch/document-create-touch-actual.txt @@ -1,4 +1,4 @@ -CONSOLE MESSAGE: line 39: TypeError: Argument 1 ('window') to Document.createTouch must be an instance of DOMWindow +CONSOLE MESSAGE: line 53: TypeError: Argument 1 ('window') to Document.createTouch must be an instance of DOMWindow This tests support for the document.createTouch API. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". 1314648 3 mcatanzaro 2017-06-01 09:32:43 -0700 I think we should just update the expectation as it's expected that line numbers will change after that revision. 1342827 4 319178 Ms2ger 2017-08-28 07:21:22 -0700 Created attachment 319178 Patch 1342849 5 319178 commit-queue 2017-08-28 09:52:51 -0700 Comment on attachment 319178 Patch Clearing flags on attachment: 319178 Committed r221261: <http://trac.webkit.org/changeset/221261> 1342850 6 commit-queue 2017-08-28 09:52:53 -0700 All reviewed patches have been landed. Closing bug. 319178 2017-08-28 07:21:22 -0700 2017-08-28 09:52:51 -0700 Patch bug-172813-20170828162121.patch text/plain 6939 Ms2ger U3VidmVyc2lvbiBSZXZpc2lvbjogMjIxMjM0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYTk1ZTQ3MzVlYTM5ZGYzZTc4ZDY4 ZGZiNzI3ZWVjOTZhZGY3ZWYxNS4uZDc1ZTMxYWI2NDliZDYzMmM2YjU5ZDYzMjFjN2FkNzQzMmMx NTFjMCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE3LTA4LTI4ICBNczJnZXIgIDxNczJnZXJA aWdhbGlhLmNvbT4KKworICAgICAgICBGaXggZG9jdW1lbnQtY3JlYXRlLXRvdWNoLmh0bWwuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzI4MTMKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgZG9jdW1l bnQuY3JlYXRlVG91Y2goKSBjYWxsIGlzIHN1cHBvc2VkIHRvIHRocm93IGFuIGV4Y2VwdGlvbiAo YXMKKyAgICAgICAgZGVmaW5lZCBieSBXZWJJREwpLiBJdCBoYXMgYmVlbiBkb2luZyB0aGlzIHNp bmNlIHIyMDM5NDEsIGJ1dCB0aGlzCisgICAgICAgIHdhc24ndCBub3RpY2VkIGJlY2F1c2UgdGhl IGVudGlyZSBmYXN0L2V2ZW50cy90b3VjaCBmb2xkZXIgaXMgc2tpcHBlZAorICAgICAgICBvbiBt YWMsIGlvcyBhbmQgd2luLgorCisgICAgICAgICogZmFzdC9ldmVudHMvdG91Y2gvZG9jdW1lbnQt Y3JlYXRlLXRvdWNoLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBmYXN0L2V2ZW50cy90b3VjaC9k b2N1bWVudC1jcmVhdGUtdG91Y2guaHRtbDoKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvVGVzdEV4 cGVjdGF0aW9uczoKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvZmFzdC9ldmVudHMvdG91Y2gvZG9j dW1lbnQtY3JlYXRlLXRvdWNoLWV4cGVjdGVkLnR4dDogUmVtb3ZlZC4KKyAgICAgICAgKiBwbGF0 Zm9ybS93cGUvVGVzdEV4cGVjdGF0aW9uczoKKwogMjAxNy0wOC0yNyAgV2Vuc29uIEhzaWVoICA8 d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBQaWNraW5nIGFuIGVtb2ppIHZpYSB0 aGUgZW1vamkgZGlhbG9nIChDdHJsK0NtZCtTcGFjZSkgZmlyZXMgaW5jb25zaXN0ZW50IGJlZm9y ZWlucHV0IGV2ZW50cy4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL3RvdWNo L2RvY3VtZW50LWNyZWF0ZS10b3VjaC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2V2 ZW50cy90b3VjaC9kb2N1bWVudC1jcmVhdGUtdG91Y2gtZXhwZWN0ZWQudHh0CmluZGV4IDllZDFm MTZkYWRhMDNlYmZhNDhlOThiNTk3YmY5NjY4ZTExZDBkZjQuLmM0NDYzNzZhOGE3YTNlOTQwNTg5 ZmI1ODM2MWMzNjMwYTIyYmU4YjYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRz L3RvdWNoL2RvY3VtZW50LWNyZWF0ZS10b3VjaC1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVz dHMvZmFzdC9ldmVudHMvdG91Y2gvZG9jdW1lbnQtY3JlYXRlLXRvdWNoLWV4cGVjdGVkLnR4dApA QCAtMjYsMTcgKzI2LDkgQEAgUEFTUyBlbXB0eVRvdWNoLndlYmtpdFJhZGl1c1ggaXMgMAogUEFT UyBlbXB0eVRvdWNoLndlYmtpdFJhZGl1c1kgaXMgMAogUEFTUyBlbXB0eVRvdWNoLndlYmtpdFJv dGF0aW9uQW5nbGUgaXMgTmFOCiBQQVNTIGVtcHR5VG91Y2gud2Via2l0Rm9yY2UgaXMgTmFOCi1Q QVNTIGJhZFBhcmFtc1RvdWNoIGlzIG5vbi1udWxsLgotUEFTUyBiYWRQYXJhbXNUb3VjaC50YXJn ZXQgaXMgbnVsbAotUEFTUyBiYWRQYXJhbXNUb3VjaC5pZGVudGlmaWVyIGlzIDAKLVBBU1MgYmFk UGFyYW1zVG91Y2gucGFnZVggaXMgMAotUEFTUyBiYWRQYXJhbXNUb3VjaC5wYWdlWSBpcyAwCi1Q QVNTIGJhZFBhcmFtc1RvdWNoLnNjcmVlblggaXMgMAotUEFTUyBiYWRQYXJhbXNUb3VjaC5zY3Jl ZW5ZIGlzIDEwNAotUEFTUyBiYWRQYXJhbXNUb3VjaC53ZWJraXRSYWRpdXNYIGlzIDAKLVBBU1Mg YmFkUGFyYW1zVG91Y2gud2Via2l0UmFkaXVzWSBpcyAwCi1QQVNTIGJhZFBhcmFtc1RvdWNoLndl YmtpdFJvdGF0aW9uQW5nbGUgaXMgTmFOCi1QQVNTIGJhZFBhcmFtc1RvdWNoLndlYmtpdEZvcmNl IGlzIE5hTgorUEFTUyBmdW5jdGlvbiAoKSB7CisgIGRvY3VtZW50LmNyZWF0ZVRvdWNoKGZ1bmN0 aW9uKHgpIHsgcmV0dXJuIHg7IH0sIDEyLCAnYScsICdiJywgJ2MnLCBmdW5jdGlvbih4KSB7IHJl dHVybiB4OyB9LCAxMDQsICdhJywgJ2InLCAnYycsICdkJyk7Cit9IHRocmV3IGV4Y2VwdGlvbiBU eXBlRXJyb3I6IEFyZ3VtZW50IDEgKCd3aW5kb3cnKSB0byBEb2N1bWVudC5jcmVhdGVUb3VjaCBt dXN0IGJlIGFuIGluc3RhbmNlIG9mIERPTVdpbmRvdy4KIFBBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2Vk IGlzIHRydWUKIAogVEVTVCBDT01QTEVURQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9l dmVudHMvdG91Y2gvZG9jdW1lbnQtY3JlYXRlLXRvdWNoLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0 L2V2ZW50cy90b3VjaC9kb2N1bWVudC1jcmVhdGUtdG91Y2guaHRtbAppbmRleCAzODUzNGY2NzY4 YjBkMDZlMjljZDEwNGJiNWU5OGExZTI4MzMyMzg4Li4yNzAyYjdjNTVlMTBkMTkyMTQ0YzY2MTNl NWM5YzgxNWZkOTY5YTkwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy90b3Vj aC9kb2N1bWVudC1jcmVhdGUtdG91Y2guaHRtbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50 cy90b3VjaC9kb2N1bWVudC1jcmVhdGUtdG91Y2guaHRtbApAQCAtNTAsMTggKzUwLDkgQEAgc2hv dWxkQmVOYU4oImVtcHR5VG91Y2gud2Via2l0Um90YXRpb25BbmdsZSIpOwogc2hvdWxkQmVOYU4o ImVtcHR5VG91Y2gud2Via2l0Rm9yY2UiKTsKIAogLy8gVHJ5IGludm9raW5nIHdpdGggaW5jb3Jy ZWN0IHBhcmFtZXRlciB0eXBlcy4KLXZhciBiYWRQYXJhbXNUb3VjaCA9IGRvY3VtZW50LmNyZWF0 ZVRvdWNoKGZ1bmN0aW9uKHgpIHsgcmV0dXJuIHg7IH0sIDEyLCAnYScsICdiJywgJ2MnLCBmdW5j dGlvbih4KSB7IHJldHVybiB4OyB9LCAxMDQsICdhJywgJ2InLCAnYycsICdkJyk7Ci1zaG91bGRC ZU5vbk51bGwoImJhZFBhcmFtc1RvdWNoIik7Ci1zaG91bGRCZU51bGwoImJhZFBhcmFtc1RvdWNo LnRhcmdldCIpOwotc2hvdWxkQmUoImJhZFBhcmFtc1RvdWNoLmlkZW50aWZpZXIiLCAiMCIpOwot c2hvdWxkQmUoImJhZFBhcmFtc1RvdWNoLnBhZ2VYIiwgIjAiKTsKLXNob3VsZEJlKCJiYWRQYXJh bXNUb3VjaC5wYWdlWSIsICIwIik7Ci1zaG91bGRCZSgiYmFkUGFyYW1zVG91Y2guc2NyZWVuWCIs ICIwIik7Ci1zaG91bGRCZSgiYmFkUGFyYW1zVG91Y2guc2NyZWVuWSIsICIxMDQiKTsKLXNob3Vs ZEJlKCJiYWRQYXJhbXNUb3VjaC53ZWJraXRSYWRpdXNYIiwgIjAiKTsKLXNob3VsZEJlKCJiYWRQ YXJhbXNUb3VjaC53ZWJraXRSYWRpdXNZIiwgIjAiKTsKLXNob3VsZEJlTmFOKCJiYWRQYXJhbXNU b3VjaC53ZWJraXRSb3RhdGlvbkFuZ2xlIik7Ci1zaG91bGRCZU5hTigiYmFkUGFyYW1zVG91Y2gu d2Via2l0Rm9yY2UiKTsKK3Nob3VsZFRocm93KGZ1bmN0aW9uKCkgeworICBkb2N1bWVudC5jcmVh dGVUb3VjaChmdW5jdGlvbih4KSB7IHJldHVybiB4OyB9LCAxMiwgJ2EnLCAnYicsICdjJywgZnVu Y3Rpb24oeCkgeyByZXR1cm4geDsgfSwgMTA0LCAnYScsICdiJywgJ2MnLCAnZCcpOworfSwgIlwi VHlwZUVycm9yOiBBcmd1bWVudCAxICgnd2luZG93JykgdG8gRG9jdW1lbnQuY3JlYXRlVG91Y2gg bXVzdCBiZSBhbiBpbnN0YW5jZSBvZiBET01XaW5kb3dcIiIpOwogaXNTdWNjZXNzZnVsbHlQYXJz ZWQoKTsKIDwvc2NyaXB0PgogPC9ib2R5PgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZv cm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4 cGVjdGF0aW9ucwppbmRleCA3ZTY1NGRmNWUzMTcxMGY4NTlhODIzZDQ0YmRjZDA4YzVmZTdmZjhh Li4zMDg3MTQ3YzY2MDk3YjU2YWI4OWVkYzJkMjcxZGQ2NzQyNTg1YzNlIDEwMDY0NAotLS0gYS9M YXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucwpAQCAtMzMyNCw4ICszMzI0LDYgQEAgd2Vi a2l0Lm9yZy9iLzE3MjgxMSBmYXN0L2Zvcm1zL251bWJlci9udW1iZXItYXBwZWFyYW5jZS1zcGlu YnV0dG9uLWxheWVyLmh0bWwgWwogCiB3ZWJraXQub3JnL2IvMTcyODEyIGZhc3QvY2FudmFzL3dl YmdsL2xvc2UtY29udGV4dC1vbi1zdGF0dXMtZmFpbHVyZS5odG1sIFsgRmFpbHVyZSBdCiAKLXdl YmtpdC5vcmcvYi8xNzI4MTMgZmFzdC9ldmVudHMvdG91Y2gvZG9jdW1lbnQtY3JlYXRlLXRvdWNo Lmh0bWwgWyBGYWlsdXJlIF0KLQogd2Via2l0Lm9yZy9iLzE3MjgxNCBtZWRpYS9yZXN0cmljdGVk LWF1ZGlvLXBsYXliYWNrLXdpdGgtbXVsdGlwbGUtc2V0dGltZW91dHMuaHRtbCBbIEZhaWx1cmUg XQogCiB3ZWJraXQub3JnL2IvMTczNDEwIGZhc3QvY2FudmFzL2NhbnZhcy1jcmVhdGVQYXR0ZXJu LXZpZGVvLWxvYWRpbmcuaHRtbCBbIEZhaWx1cmUgXQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv cGxhdGZvcm0vZ3RrL2Zhc3QvZXZlbnRzL3RvdWNoL2RvY3VtZW50LWNyZWF0ZS10b3VjaC1leHBl Y3RlZC50eHQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvZmFzdC9ldmVudHMvdG91Y2gvZG9j dW1lbnQtY3JlYXRlLXRvdWNoLWV4cGVjdGVkLnR4dApkZWxldGVkIGZpbGUgbW9kZSAxMDA2NDQK aW5kZXggNmNkNGMyOTc3NzlkOTRhODVkODVlMDk1OTE4NTA0ZWFjZDUzY2E2ZC4uMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9y bS9ndGsvZmFzdC9ldmVudHMvdG91Y2gvZG9jdW1lbnQtY3JlYXRlLXRvdWNoLWV4cGVjdGVkLnR4 dAorKysgL2Rldi9udWxsCkBAIC0xLDMwICswLDAgQEAKLUNPTlNPTEUgTUVTU0FHRTogbGluZSAz OTogVHlwZUVycm9yOiBBcmd1bWVudCAxICgnd2luZG93JykgdG8gRG9jdW1lbnQuY3JlYXRlVG91 Y2ggbXVzdCBiZSBhbiBpbnN0YW5jZSBvZiBET01XaW5kb3cKLVRoaXMgdGVzdHMgc3VwcG9ydCBm b3IgdGhlIGRvY3VtZW50LmNyZWF0ZVRvdWNoIEFQSS4KLQotT24gc3VjY2VzcywgeW91IHdpbGwg c2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExF VEUiLgotCi0KLVBBU1MgImNyZWF0ZVRvdWNoIiBpbiBkb2N1bWVudCBpcyB0cnVlCi1QQVNTIHRv dWNoIGlzIG5vbi1udWxsLgotUEFTUyB0b3VjaC50YXJnZXQgaXMgYm94Ci1QQVNTIHRvdWNoLmlk ZW50aWZpZXIgaXMgMQotUEFTUyB0b3VjaC5wYWdlWCBpcyAxMDAKLVBBU1MgdG91Y2gucGFnZVkg aXMgMTAxCi1QQVNTIHRvdWNoLnNjcmVlblggaXMgMTAyCi1QQVNTIHRvdWNoLnNjcmVlblkgaXMg MTAzCi1QQVNTIHRvdWNoLndlYmtpdFJhZGl1c1ggaXMgNQotUEFTUyB0b3VjaC53ZWJraXRSYWRp dXNZIGlzIDMKLVBBU1MgdG91Y2gud2Via2l0Um90YXRpb25BbmdsZSBpcyAxMAotUEFTUyB0b3Vj aC53ZWJraXRGb3JjZSBpcyAxMAotUEFTUyBlbXB0eVRvdWNoIGlzIG5vbi1udWxsLgotUEFTUyBl bXB0eVRvdWNoLnRhcmdldCBpcyBudWxsCi1QQVNTIGVtcHR5VG91Y2guaWRlbnRpZmllciBpcyAw Ci1QQVNTIGVtcHR5VG91Y2gucGFnZVggaXMgMAotUEFTUyBlbXB0eVRvdWNoLnBhZ2VZIGlzIDAK LVBBU1MgZW1wdHlUb3VjaC5zY3JlZW5YIGlzIDAKLVBBU1MgZW1wdHlUb3VjaC5zY3JlZW5ZIGlz IDAKLVBBU1MgZW1wdHlUb3VjaC53ZWJraXRSYWRpdXNYIGlzIDAKLVBBU1MgZW1wdHlUb3VjaC53 ZWJraXRSYWRpdXNZIGlzIDAKLVBBU1MgZW1wdHlUb3VjaC53ZWJraXRSb3RhdGlvbkFuZ2xlIGlz IE5hTgotUEFTUyBlbXB0eVRvdWNoLndlYmtpdEZvcmNlIGlzIE5hTgotCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9wbGF0Zm9ybS93cGUvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3Bs YXRmb3JtL3dwZS9UZXN0RXhwZWN0YXRpb25zCmluZGV4IDAwMzM0NzA4ZTI2MjBmNGUxZTRkY2Zh M2NmYWFhYWQyMzJiZWM5ZmUuLmUwNjA2NDExY2NkYzI3NTJlY2IyM2NjNTY4YWJkY2E5N2U1Njg2 MjggMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL3dwZS9UZXN0RXhwZWN0YXRpb25z CisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3dwZS9UZXN0RXhwZWN0YXRpb25zCkBAIC01MTMs NyArNTEzLDYgQEAgd2Via2l0Lm9yZy9iLzE3MzQxOSBmYXN0L2V2ZW50cy90YWJpbmRleC1mb2N1 cy1ibHVyLWFsbC5odG1sIFsgRmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMTczNDE5IGZhc3QvZXZl bnRzL3RvdWNoL2Jhc2ljLW11bHRpLXRvdWNoLWV2ZW50cy1saW1pdGVkLmh0bWwgWyBGYWlsdXJl IF0KIHdlYmtpdC5vcmcvYi8xNzM0MTkgZmFzdC9ldmVudHMvdG91Y2gvYmFzaWMtbXVsdGktdG91 Y2gtZXZlbnRzLmh0bWwgWyBGYWlsdXJlIF0KIHdlYmtpdC5vcmcvYi8xNzM0MTkgZmFzdC9ldmVu dHMvdG91Y2gvZG9jdW1lbnQtY3JlYXRlLXRvdWNoLWxpc3QuaHRtbCBbIEZhaWx1cmUgXQotd2Vi a2l0Lm9yZy9iLzE3MzQxOSBmYXN0L2V2ZW50cy90b3VjaC9kb2N1bWVudC1jcmVhdGUtdG91Y2gu aHRtbCBbIEZhaWx1cmUgXQogd2Via2l0Lm9yZy9iLzE3MzQxOSBmYXN0L2V2ZW50cy90b3VjaC9l bXVsYXRlLXRvdWNoLWV2ZW50cy5odG1sIFsgRmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMTczNDE5 IGZhc3QvZXZlbnRzL3RvdWNoL3RvdWNoLWJlZm9yZS1wcmVzc2luZy1zcGluLWJ1dHRvbi5odG1s IFsgRmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMTczNDE5IGZhc3QvZXZlbnRzL3dlYmtpdC1tZWRp YS1rZXktZXZlbnRzLWNvbnN0cnVjdG9yLmh0bWwgWyBGYWlsdXJlIF0K