172782 2017-05-31 15:49:53 -0700 CodeGeneratorJS's InstanceNeedsVisitChildren should not return true just because a class is / extends EventTarget. 2017-05-31 17:12:56 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam cdumez commit-queue ryanhaddad saam sam webkit-bug-importer ysuzuki oldest_to_newest 1314385 0 mark.lam 2017-05-31 15:49:53 -0700 The other conditions for generating visitChildren() are adequate if the class needs its own visitChildren. Currently, we're generating some visitChildren() methods that only call its Base::visitChildren(). Removing the "is / extends EventTarget" conditions removes those unneeded visitChildren() overrides. 1314390 1 webkit-bug-importer 2017-05-31 15:56:04 -0700 <rdar://problem/32498266> 1314398 2 mark.lam 2017-05-31 16:07:37 -0700 Ditto for the IsJSBuiltinConstructor condition, which is not used to emit any additional code in the visitChildren override. 1314411 3 311651 mark.lam 2017-05-31 16:17:22 -0700 Created attachment 311651 proposed patch. Let's test this on the EWS first. 1314427 4 311651 cdumez 2017-05-31 16:41:18 -0700 Comment on attachment 311651 proposed patch. r=me as long as bots are happy. 1314432 5 mark.lam 2017-05-31 16:43:03 -0700 Thanks for the review. 1314456 6 311651 commit-queue 2017-05-31 17:12:55 -0700 Comment on attachment 311651 proposed patch. Clearing flags on attachment: 311651 Committed r217642: <http://trac.webkit.org/changeset/217642> 1314457 7 commit-queue 2017-05-31 17:12:56 -0700 All reviewed patches have been landed. Closing bug. 311651 2017-05-31 16:17:22 -0700 2017-05-31 17:12:55 -0700 proposed patch. bug-172782.patch text/plain 10258 mark.lam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxNzYzNSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDQwIEBACisyMDE3LTA1LTMxICBNYXJrIExh bSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBDb2RlR2VuZXJhdG9ySlMncyBJbnN0 YW5jZU5lZWRzVmlzaXRDaGlsZHJlbiBzaG91bGQgbm90IHJldHVybiB0cnVlIGp1c3QgYmVjYXVz ZSBhIGNsYXNzIGlzIC8gZXh0ZW5kcyBFdmVudFRhcmdldC4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3Mjc4MgorICAgICAgICA8cmRhcjovL3Byb2Js ZW0vMzI0OTgyNjY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgTm8gbmV3IHRlc3RzIG5lZWRlZC4gIFRoaXMgY2hhbmdlIGlzIGNvdmVyZWQgYnkgZXhp c3RpbmcgYmluZGluZyB0ZXN0cy4KKworICAgICAgICBJbnN0YW5jZU5lZWRzVmlzaXRDaGlsZHJl biBzaG91bGQgYWxzbyBub3QgY2hlY2sgdGhlIElzSlNCdWlsdGluQ29uc3RydWN0b3IKKyAgICAg ICAgY29uZGl0aW9uLCB3aGljaCBpcyBub3QgdXNlZCB0byBlbWl0IGFueSBhZGRpdGlvbmFsIGNv ZGUgaW4gdGhlIHZpc2l0Q2hpbGRyZW4KKyAgICAgICAgb3ZlcnJpZGUuCisKKyAgICAgICAgVGhl IG90aGVyIGNvbmRpdGlvbnMgZm9yIGdlbmVyYXRpbmcgdmlzaXRDaGlsZHJlbigpIGFyZSBhZGVx dWF0ZSBpZiB0aGUgY2xhc3MKKyAgICAgICAgbmVlZHMgdG8gb3ZlcnJpZGUgdmlzaXRDaGlsZHJl bi4gIEN1cnJlbnRseSwgd2UncmUgZ2VuZXJhdGluZyBzb21lIHZpc2l0Q2hpbGRyZW4oKQorICAg ICAgICBtZXRob2RzIHRoYXQgb25seSBjYWxsIGl0cyBCYXNlOjp2aXNpdENoaWxkcmVuKCkuICBS ZW1vdmluZyB0aGUgImlzIC8gZXh0ZW5kcworICAgICAgICBFdmVudFRhcmdldCIgY29uZGl0aW9u cyByZW1vdmVzIHRob3NlIHVubmVlZGVkIHZpc2l0Q2hpbGRyZW4gb3ZlcnJpZGVzLgorCisgICAg ICAgICogYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG06CisgICAgICAgIChJbnN0 YW5jZU5lZWRzVmlzaXRDaGlsZHJlbik6CisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy90ZXN0 L0pTL0pTVGVzdENsYXNzV2l0aEpTQnVpbHRpbkNvbnN0cnVjdG9yLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkpTVGVzdENsYXNzV2l0aEpTQnVpbHRpbkNvbnN0cnVjdG9yOjp2aXNpdENoaWxkcmVu KTogRGVsZXRlZC4KKyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL3Rlc3QvSlMvSlNUZXN0Q2xh c3NXaXRoSlNCdWlsdGluQ29uc3RydWN0b3IuaDoKKyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRz L3Rlc3QvSlMvSlNUZXN0RE9NSklULmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkpTVGVzdERPTUpJ VDo6dmlzaXRDaGlsZHJlbik6IERlbGV0ZWQuCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy90 ZXN0L0pTL0pTVGVzdERPTUpJVC5oOgorICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvdGVzdC9K Uy9KU1Rlc3RFdmVudFRhcmdldC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpKU1Rlc3RFdmVudFRh cmdldDo6dmlzaXRDaGlsZHJlbik6IERlbGV0ZWQuCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0 cy90ZXN0L0pTL0pTVGVzdEV2ZW50VGFyZ2V0Lmg6CisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0 cy90ZXN0L0pTL0pTVGVzdEpTQnVpbHRpbkNvbnN0cnVjdG9yLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkpTVGVzdEpTQnVpbHRpbkNvbnN0cnVjdG9yOjp2aXNpdENoaWxkcmVuKTogRGVsZXRlZC4K KyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL3Rlc3QvSlMvSlNUZXN0SlNCdWlsdGluQ29uc3Ry dWN0b3IuaDoKKyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL3Rlc3QvSlMvSlNUZXN0Tm9kZS5j cHA6CisgICAgICAgIChXZWJDb3JlOjpKU1Rlc3ROb2RlOjp2aXNpdENoaWxkcmVuKTogRGVsZXRl ZC4KKyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL3Rlc3QvSlMvSlNUZXN0Tm9kZS5oOgorCiAy MDE3LTA1LTMxICBBbmR5IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW5h bWUgRU5BQkxFX0FQUExFX1BBWV9ERUxFR0FURSB0byBFTkFCTEVfQVBQTEVfUEFZX1NFU1NJT05f VjMgYW5kIGJ1bXAgdGhlIHN1cHBvcnRlZCB2ZXJzaW9uIG51bWJlcgpJbmRleDogU291cmNlL1dl YkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG0KPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG0JKHJldmlz aW9uIDIxNzYyOCkKKysrIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVy YXRvckpTLnBtCSh3b3JraW5nIGNvcHkpCkBAIC0xMzU4LDEwICsxMzU4LDcgQEAgc3ViIEluc3Rh bmNlTmVlZHNWaXNpdENoaWxkcmVuCiAgICAgfQogCiAgICAgcmV0dXJuIDEgaWYgJGludGVyZmFj ZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57SlNDdXN0b21NYXJrRnVuY3Rpb259OwotICAgIHJldHVy biAxIGlmICRjb2RlR2VuZXJhdG9yLT5Jbmhlcml0c0ludGVyZmFjZSgkaW50ZXJmYWNlLCAiRXZl bnRUYXJnZXQiKTsKLSAgICByZXR1cm4gMSBpZiAkaW50ZXJmYWNlLT50eXBlLT5uYW1lIGVxICJF dmVudFRhcmdldCI7CiAgICAgcmV0dXJuIDEgaWYgJGludGVyZmFjZS0+ZXh0ZW5kZWRBdHRyaWJ1 dGVzLT57UmVwb3J0RXh0cmFNZW1vcnlDb3N0fTsKLSAgICByZXR1cm4gMSBpZiBJc0pTQnVpbHRp bkNvbnN0cnVjdG9yKCRpbnRlcmZhY2UpOwogICAgIHJldHVybiAwOwogfQogCkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvSlMvSlNUZXN0Q2xhc3NXaXRoSlNCdWls dGluQ29uc3RydWN0b3IuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3NjcmlwdHMvdGVzdC9KUy9KU1Rlc3RDbGFzc1dpdGhKU0J1aWx0aW5Db25zdHJ1Y3Rvci5jcHAJ KHJldmlzaW9uIDIxNzYyOCkKKysrIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVz dC9KUy9KU1Rlc3RDbGFzc1dpdGhKU0J1aWx0aW5Db25zdHJ1Y3Rvci5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTE1OCwxMyArMTU4LDYgQEAgYm9vbCBzZXRKU1Rlc3RDbGFzc1dpdGhKU0J1aWx0aW5D b25zdHJ1YwogICAgIHJldHVybiBwcm90b3R5cGUtPnB1dERpcmVjdChzdGF0ZS0+dm0oKSwgc3Rh dGUtPnByb3BlcnR5TmFtZXMoKS5jb25zdHJ1Y3RvciwgSlNWYWx1ZTo6ZGVjb2RlKGVuY29kZWRW YWx1ZSkpOwogfQogCi12b2lkIEpTVGVzdENsYXNzV2l0aEpTQnVpbHRpbkNvbnN0cnVjdG9yOjp2 aXNpdENoaWxkcmVuKEpTQ2VsbCogY2VsbCwgU2xvdFZpc2l0b3ImIHZpc2l0b3IpCi17Ci0gICAg YXV0byogdGhpc09iamVjdCA9IGpzQ2FzdDxKU1Rlc3RDbGFzc1dpdGhKU0J1aWx0aW5Db25zdHJ1 Y3Rvcio+KGNlbGwpOwotICAgIEFTU0VSVF9HQ19PQkpFQ1RfSU5IRVJJVFModGhpc09iamVjdCwg aW5mbygpKTsKLSAgICBCYXNlOjp2aXNpdENoaWxkcmVuKHRoaXNPYmplY3QsIHZpc2l0b3IpOwot fQotCiBib29sIEpTVGVzdENsYXNzV2l0aEpTQnVpbHRpbkNvbnN0cnVjdG9yT3duZXI6OmlzUmVh Y2hhYmxlRnJvbU9wYXF1ZVJvb3RzKEpTQzo6SGFuZGxlPEpTQzo6VW5rbm93bj4gaGFuZGxlLCB2 b2lkKiwgU2xvdFZpc2l0b3ImIHZpc2l0b3IpCiB7CiAgICAgVU5VU0VEX1BBUkFNKGhhbmRsZSk7 CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvSlMvSlNUZXN0Q2xh c3NXaXRoSlNCdWlsdGluQ29uc3RydWN0b3IuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvSlMvSlNUZXN0Q2xhc3NXaXRoSlNCdWlsdGluQ29uc3Ry dWN0b3IuaAkocmV2aXNpb24gMjE3NjI4KQorKysgU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2Ny aXB0cy90ZXN0L0pTL0pTVGVzdENsYXNzV2l0aEpTQnVpbHRpbkNvbnN0cnVjdG9yLmgJKHdvcmtp bmcgY29weSkKQEAgLTQ5LDggKzQ5LDYgQEAgcHVibGljOgogICAgIH0KIAogICAgIHN0YXRpYyBK U0M6OkpTVmFsdWUgZ2V0Q29uc3RydWN0b3IoSlNDOjpWTSYsIGNvbnN0IEpTQzo6SlNHbG9iYWxP YmplY3QqKTsKLSAgICBzdGF0aWMgdm9pZCB2aXNpdENoaWxkcmVuKEpTQ2VsbCosIEpTQzo6U2xv dFZpc2l0b3ImKTsKLQogcHJvdGVjdGVkOgogICAgIEpTVGVzdENsYXNzV2l0aEpTQnVpbHRpbkNv bnN0cnVjdG9yKEpTQzo6U3RydWN0dXJlKiwgSlNET01HbG9iYWxPYmplY3QmLCBSZWY8VGVzdENs YXNzV2l0aEpTQnVpbHRpbkNvbnN0cnVjdG9yPiYmKTsKIApJbmRleDogU291cmNlL1dlYkNvcmUv YmluZGluZ3Mvc2NyaXB0cy90ZXN0L0pTL0pTVGVzdERPTUpJVC5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0pTL0pTVGVzdERPTUpJVC5jcHAJ KHJldmlzaW9uIDIxNzYyOCkKKysrIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVz dC9KUy9KU1Rlc3RET01KSVQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMjg2LDEyICsxMjg2LDUg QEAgSlNDOjpFbmNvZGVkSlNWYWx1ZSBKSVRfT1BFUkFUSU9OIHVuc2FmZQogICAgIHJldHVybiBK U1ZhbHVlOjplbmNvZGUodG9KUzxJRExJbnRlcmZhY2U8Tm9kZUxpc3Q+Pigqc3RhdGUsICpjYXN0 ZWRUaGlzLT5nbG9iYWxPYmplY3QoKSwgaW1wbC5nZXRFbGVtZW50c0J5TmFtZShXVEZNb3ZlKGVs ZW1lbnROYW1lKSkpKTsKIH0KIAotdm9pZCBKU1Rlc3RET01KSVQ6OnZpc2l0Q2hpbGRyZW4oSlND ZWxsKiBjZWxsLCBTbG90VmlzaXRvciYgdmlzaXRvcikKLXsKLSAgICBhdXRvKiB0aGlzT2JqZWN0 ID0ganNDYXN0PEpTVGVzdERPTUpJVCo+KGNlbGwpOwotICAgIEFTU0VSVF9HQ19PQkpFQ1RfSU5I RVJJVFModGhpc09iamVjdCwgaW5mbygpKTsKLSAgICBCYXNlOjp2aXNpdENoaWxkcmVuKHRoaXNP YmplY3QsIHZpc2l0b3IpOwotfQotCiAKIH0KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3NjcmlwdHMvdGVzdC9KUy9KU1Rlc3RET01KSVQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvSlMvSlNUZXN0RE9NSklULmgJKHJldmlzaW9uIDIx NzYyOCkKKysrIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9KUy9KU1Rlc3RE T01KSVQuaAkod29ya2luZyBjb3B5KQpAQCAtNDgsOCArNDgsNiBAQCBwdWJsaWM6CiAgICAgfQog CiAgICAgc3RhdGljIEpTQzo6SlNWYWx1ZSBnZXRDb25zdHJ1Y3RvcihKU0M6OlZNJiwgY29uc3Qg SlNDOjpKU0dsb2JhbE9iamVjdCopOwotICAgIHN0YXRpYyB2b2lkIHZpc2l0Q2hpbGRyZW4oSlND ZWxsKiwgSlNDOjpTbG90VmlzaXRvciYpOwotCiAgICAgVGVzdERPTUpJVCYgd3JhcHBlZCgpIGNv bnN0CiAgICAgewogICAgICAgICByZXR1cm4gc3RhdGljX2Nhc3Q8VGVzdERPTUpJVCY+KEJhc2U6 OndyYXBwZWQoKSk7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3Qv SlMvSlNUZXN0RXZlbnRUYXJnZXQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL3NjcmlwdHMvdGVzdC9KUy9KU1Rlc3RFdmVudFRhcmdldC5jcHAJKHJldmlzaW9uIDIx NzYyOCkKKysrIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9KUy9KU1Rlc3RF dmVudFRhcmdldC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIyMywxMyArMjIzLDYgQEAgRW5jb2Rl ZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBqc1Rlc3RFdmVudAogICAgIHJldHVybiBJRExPcGVyYXRp b248SlNUZXN0RXZlbnRUYXJnZXQ+OjpjYWxsPGpzVGVzdEV2ZW50VGFyZ2V0UHJvdG90eXBlRnVu Y3Rpb25JdGVtQm9keT4oKnN0YXRlLCAiaXRlbSIpOwogfQogCi12b2lkIEpTVGVzdEV2ZW50VGFy Z2V0Ojp2aXNpdENoaWxkcmVuKEpTQ2VsbCogY2VsbCwgU2xvdFZpc2l0b3ImIHZpc2l0b3IpCi17 Ci0gICAgYXV0byogdGhpc09iamVjdCA9IGpzQ2FzdDxKU1Rlc3RFdmVudFRhcmdldCo+KGNlbGwp OwotICAgIEFTU0VSVF9HQ19PQkpFQ1RfSU5IRVJJVFModGhpc09iamVjdCwgaW5mbygpKTsKLSAg ICBCYXNlOjp2aXNpdENoaWxkcmVuKHRoaXNPYmplY3QsIHZpc2l0b3IpOwotfQotCiAjaWYgRU5B QkxFKEJJTkRJTkdfSU5URUdSSVRZKQogI2lmIFBMQVRGT1JNKFdJTikKICNwcmFnbWEgd2Fybmlu ZyhkaXNhYmxlOiA0NDgzKQpJbmRleDogU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90 ZXN0L0pTL0pTVGVzdEV2ZW50VGFyZ2V0LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUv YmluZGluZ3Mvc2NyaXB0cy90ZXN0L0pTL0pTVGVzdEV2ZW50VGFyZ2V0LmgJKHJldmlzaW9uIDIx NzYyOCkKKysrIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9KUy9KU1Rlc3RF dmVudFRhcmdldC5oCSh3b3JraW5nIGNvcHkpCkBAIC01Miw4ICs1Miw2IEBAIHB1YmxpYzoKIAog ICAgIHN0YXRpYyB2b2lkIGdldE93blByb3BlcnR5TmFtZXMoSlNDOjpKU09iamVjdCosIEpTQzo6 RXhlY1N0YXRlKiwgSlNDOjpQcm9wZXJ0eU5hbWVBcnJheSYsIEpTQzo6RW51bWVyYXRpb25Nb2Rl ID0gSlNDOjpFbnVtZXJhdGlvbk1vZGUoKSk7CiAgICAgc3RhdGljIEpTQzo6SlNWYWx1ZSBnZXRD b25zdHJ1Y3RvcihKU0M6OlZNJiwgY29uc3QgSlNDOjpKU0dsb2JhbE9iamVjdCopOwotICAgIHN0 YXRpYyB2b2lkIHZpc2l0Q2hpbGRyZW4oSlNDZWxsKiwgSlNDOjpTbG90VmlzaXRvciYpOwotCiAg ICAgVGVzdEV2ZW50VGFyZ2V0JiB3cmFwcGVkKCkgY29uc3QKICAgICB7CiAgICAgICAgIHJldHVy biBzdGF0aWNfY2FzdDxUZXN0RXZlbnRUYXJnZXQmPihCYXNlOjp3cmFwcGVkKCkpOwpJbmRleDog U291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0pTL0pTVGVzdEpTQnVpbHRpbkNv bnN0cnVjdG9yLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3Jp cHRzL3Rlc3QvSlMvSlNUZXN0SlNCdWlsdGluQ29uc3RydWN0b3IuY3BwCShyZXZpc2lvbiAyMTc2 MjgpCisrKyBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvSlMvSlNUZXN0SlNC dWlsdGluQ29uc3RydWN0b3IuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMjksMTIgKzIyOSw1IEBA IEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwganNUZXN0SlNCdWkKICAgICByZXR1cm4gSURM T3BlcmF0aW9uPEpTVGVzdEpTQnVpbHRpbkNvbnN0cnVjdG9yPjo6Y2FsbDxqc1Rlc3RKU0J1aWx0 aW5Db25zdHJ1Y3RvclByb3RvdHlwZUZ1bmN0aW9uVGVzdEN1c3RvbUZ1bmN0aW9uQm9keT4oKnN0 YXRlLCAidGVzdEN1c3RvbUZ1bmN0aW9uIik7CiB9CiAKLXZvaWQgSlNUZXN0SlNCdWlsdGluQ29u c3RydWN0b3I6OnZpc2l0Q2hpbGRyZW4oSlNDZWxsKiBjZWxsLCBTbG90VmlzaXRvciYgdmlzaXRv cikKLXsKLSAgICBhdXRvKiB0aGlzT2JqZWN0ID0ganNDYXN0PEpTVGVzdEpTQnVpbHRpbkNvbnN0 cnVjdG9yKj4oY2VsbCk7Ci0gICAgQVNTRVJUX0dDX09CSkVDVF9JTkhFUklUUyh0aGlzT2JqZWN0 LCBpbmZvKCkpOwotICAgIEJhc2U6OnZpc2l0Q2hpbGRyZW4odGhpc09iamVjdCwgdmlzaXRvcik7 Ci19Ci0KIAogfQpJbmRleDogU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0pT L0pTVGVzdEpTQnVpbHRpbkNvbnN0cnVjdG9yLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNv cmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0pTL0pTVGVzdEpTQnVpbHRpbkNvbnN0cnVjdG9yLmgJ KHJldmlzaW9uIDIxNzYyOCkKKysrIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVz dC9KUy9KU1Rlc3RKU0J1aWx0aW5Db25zdHJ1Y3Rvci5oCSh3b3JraW5nIGNvcHkpCkBAIC00Niw4 ICs0Niw2IEBAIHB1YmxpYzoKICAgICB9CiAKICAgICBzdGF0aWMgSlNDOjpKU1ZhbHVlIGdldENv bnN0cnVjdG9yKEpTQzo6Vk0mLCBjb25zdCBKU0M6OkpTR2xvYmFsT2JqZWN0Kik7Ci0gICAgc3Rh dGljIHZvaWQgdmlzaXRDaGlsZHJlbihKU0NlbGwqLCBKU0M6OlNsb3RWaXNpdG9yJik7Ci0KIAog ICAgIC8vIEN1c3RvbSBhdHRyaWJ1dGVzCiAgICAgSlNDOjpKU1ZhbHVlIHRlc3RBdHRyaWJ1dGVD dXN0b20oSlNDOjpFeGVjU3RhdGUmKSBjb25zdDsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL3NjcmlwdHMvdGVzdC9KUy9KU1Rlc3ROb2RlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvSlMvSlNUZXN0Tm9kZS5jcHAJKHJldmlzaW9u IDIxNzYyOCkKKysrIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9KUy9KU1Rl c3ROb2RlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzM1LDEzICszMzUsNiBAQCBFbmNvZGVkSlNW YWx1ZSBKU0NfSE9TVF9DQUxMIGpzVGVzdE5vZGVQCiAgICAgcmV0dXJuIElETE9wZXJhdGlvbjxK U1Rlc3ROb2RlPjo6Y2FsbDxqc1Rlc3ROb2RlUHJvdG90eXBlRnVuY3Rpb25Ub0pTT05Cb2R5Pigq c3RhdGUsICJ0b0pTT04iKTsKIH0KIAotdm9pZCBKU1Rlc3ROb2RlOjp2aXNpdENoaWxkcmVuKEpT Q2VsbCogY2VsbCwgU2xvdFZpc2l0b3ImIHZpc2l0b3IpCi17Ci0gICAgYXV0byogdGhpc09iamVj dCA9IGpzQ2FzdDxKU1Rlc3ROb2RlKj4oY2VsbCk7Ci0gICAgQVNTRVJUX0dDX09CSkVDVF9JTkhF UklUUyh0aGlzT2JqZWN0LCBpbmZvKCkpOwotICAgIEJhc2U6OnZpc2l0Q2hpbGRyZW4odGhpc09i amVjdCwgdmlzaXRvcik7Ci19Ci0KICNpZiBFTkFCTEUoQklORElOR19JTlRFR1JJVFkpCiAjaWYg UExBVEZPUk0oV0lOKQogI3ByYWdtYSB3YXJuaW5nKGRpc2FibGU6IDQ0ODMpCkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvSlMvSlNUZXN0Tm9kZS5oCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9KUy9KU1Rlc3ROb2Rl LmgJKHJldmlzaW9uIDIxNzYyOCkKKysrIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMv dGVzdC9KUy9KU1Rlc3ROb2RlLmgJKHdvcmtpbmcgY29weSkKQEAgLTQ4LDggKzQ4LDYgQEAgcHVi bGljOgogCiAgICAgc3RhdGljIEpTQzo6SlNWYWx1ZSBnZXRDb25zdHJ1Y3RvcihKU0M6OlZNJiwg Y29uc3QgSlNDOjpKU0dsb2JhbE9iamVjdCopOwogICAgIHN0YXRpYyBKU0M6OkpTT2JqZWN0KiBz ZXJpYWxpemUoSlNDOjpFeGVjU3RhdGUqLCBKU1Rlc3ROb2RlKiB0aGlzT2JqZWN0LCBKU0M6OlRo cm93U2NvcGUmKTsKLSAgICBzdGF0aWMgdm9pZCB2aXNpdENoaWxkcmVuKEpTQ2VsbCosIEpTQzo6 U2xvdFZpc2l0b3ImKTsKLQogICAgIFRlc3ROb2RlJiB3cmFwcGVkKCkgY29uc3QKICAgICB7CiAg ICAgICAgIHJldHVybiBzdGF0aWNfY2FzdDxUZXN0Tm9kZSY+KEJhc2U6OndyYXBwZWQoKSk7Cg==