172763 2017-05-31 11:35:35 -0700 [WK2] Fix bad assertion in BackgroundProcessResponsivenessTimer::scheduleNextResponsivenessCheck() 2017-05-31 12:17:33 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez commit-queue ggaren kling zalan oldest_to_newest 1314238 0 cdumez 2017-05-31 11:35:35 -0700 Fix bad assertion in BackgroundProcessResponsivenessTimer::scheduleNextResponsivenessCheck(). It gets hit when a process becomes unresponsive: ASSERTION FAILED: !m_timeoutTimer.isActive() /Users/akinsley/OpenSource/Source/WebKit2/UIProcess/BackgroundProcessResponsivenessTimer.cpp(151) : void WebKit::BackgroundProcessResponsivenessTimer::scheduleNextResponsivenessCheck() 1 0x11072d29d WTFCrash 2 0x107efa183 WebKit::BackgroundProcessResponsivenessTimer::scheduleNextResponsivenessCheck() 3 0x107ef9e07 WebKit::BackgroundProcessResponsivenessTimer::timeoutTimerFired() 4 0x107efacd5 WTF::RunLoop::Timer<WebKit::BackgroundProcessResponsivenessTimer>::fired() 5 0x11077c261 WTF::RunLoop::TimerBase::timerFired(__CFRunLoopTimer*, void*) 6 0x7fff7cba5c54 __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__ 7 0x7fff7cba58df __CFRunLoopDoTimer 8 0x7fff7cba543a __CFRunLoopDoTimers 9 0x7fff7cb9cb81 __CFRunLoopRun 10 0x7fff7cb9c114 CFRunLoopRunSpecific 11 0x7fff7c0fdebc RunCurrentEventLoopInMode 12 0x7fff7c0fdcf1 ReceiveNextEventCommon 13 0x7fff7c0fdb26 _BlockUntilNextEventMatchingListInModeWithFilter 14 0x7fff7a698bf8 _DPSNextEvent 15 0x7fff7ae1484e -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] 16 0x7fff7a68d57f -[NSApplication run] 17 0x7fff7a657fb2 NSApplicationMain 18 0x7fff92331235 start 19 0x1 Segmentation fault: 11 1314239 1 311614 cdumez 2017-05-31 11:37:14 -0700 Created attachment 311614 Patch 1314260 2 311614 commit-queue 2017-05-31 12:17:31 -0700 Comment on attachment 311614 Patch Clearing flags on attachment: 311614 Committed r217617: <http://trac.webkit.org/changeset/217617> 1314261 3 commit-queue 2017-05-31 12:17:33 -0700 All reviewed patches have been landed. Closing bug. 311614 2017-05-31 11:37:14 -0700 2017-05-31 12:17:31 -0700 Patch bug-172763-20170531113713.patch text/plain 1888 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjE3NTc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZmNhOTY5ZDRlMTVjMGZh YzkwYjQ4NGM4Njg3MGQ4MjNhYmRjZmRiYy4uOTQ2OGZhMWE2ZmI5Nzc2MDNmMWM4ZDdjNDZiNDdk Yzg3MjE2NTM3YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE3LTA1LTMxICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgW1dLMl0gRml4IGJhZCBhc3Nl cnRpb24gaW4gQmFja2dyb3VuZFByb2Nlc3NSZXNwb25zaXZlbmVzc1RpbWVyOjpzY2hlZHVsZU5l eHRSZXNwb25zaXZlbmVzc0NoZWNrKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE3Mjc2MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEZpeCBiYWQgYXNzZXJ0aW9uIGluIEJhY2tncm91bmRQcm9jZXNzUmVz cG9uc2l2ZW5lc3NUaW1lcjo6c2NoZWR1bGVOZXh0UmVzcG9uc2l2ZW5lc3NDaGVjaygpLgorICAg ICAgICBJdCBnZXRzIGhpdCB3aGVuIGEgcHJvY2VzcyBiZWNvbWVzIHVucmVzcG9uc2l2ZS4gVGhl IHJlYXNvbiBpcyB0aGF0IFJ1bkxvb3A6OlRpbWVyOjppc0FjdGl2ZSgpCisgICAgICAgIHN0aWxs IHJldHVybnMgdHJ1ZSB3aGlsZSB0aGUgdGltZXJGaXJlZCgpIGNhbGxiYWNrIGlzIGNhbGxlZC4K KworICAgICAgICAqIFVJUHJvY2Vzcy9CYWNrZ3JvdW5kUHJvY2Vzc1Jlc3BvbnNpdmVuZXNzVGlt ZXIuY3BwOgorICAgICAgICAoV2ViS2l0OjpCYWNrZ3JvdW5kUHJvY2Vzc1Jlc3BvbnNpdmVuZXNz VGltZXI6OnNjaGVkdWxlTmV4dFJlc3BvbnNpdmVuZXNzQ2hlY2spOgorCiAyMDE3LTA1LTMwICBD aHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTihyMjE1 OTQ2KTogQ2FuJ3QgcmVmZXJlbmNlIGEgdGFibGUgY2VsbCBpbiBHb29nbGUgc3ByZWFkc2hlZXQK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9CYWNrZ3JvdW5kUHJvY2Vzc1Jl c3BvbnNpdmVuZXNzVGltZXIuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0JhY2tncm91 bmRQcm9jZXNzUmVzcG9uc2l2ZW5lc3NUaW1lci5jcHAKaW5kZXggMWU5NTAxODEzNmJmODJhNzhl Nzg5Yzc5YjI5ZmVlZTQ0OTdmMjg1NS4uYzgxNDRlMTliOGJlZGM5NzdiY2QzN2Q0ZmRiOTNhNDg5 Y2E5MTgwMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0JhY2tncm91bmRQ cm9jZXNzUmVzcG9uc2l2ZW5lc3NUaW1lci5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0JhY2tncm91bmRQcm9jZXNzUmVzcG9uc2l2ZW5lc3NUaW1lci5jcHAKQEAgLTE0OCw3ICsx NDgsNiBAQCB2b2lkIEJhY2tncm91bmRQcm9jZXNzUmVzcG9uc2l2ZW5lc3NUaW1lcjo6c2NoZWR1 bGVOZXh0UmVzcG9uc2l2ZW5lc3NDaGVjaygpCiB7CiAgICAgLy8gRXhwb25lbnRpYWwgYmFja29m ZiB0byBhdm9pZCB3YWtpbmcgdXAgdGhlIHByb2Nlc3MgdG9vIG9mdGVuLgogICAgIEFTU0VSVCgh bV9yZXNwb25zaXZlbmVzc0NoZWNrVGltZXIuaXNBY3RpdmUoKSk7Ci0gICAgQVNTRVJUKCFtX3Rp bWVvdXRUaW1lci5pc0FjdGl2ZSgpKTsKICAgICBtX2NoZWNraW5nSW50ZXJ2YWwgPSBzdGQ6Om1p bihtX2NoZWNraW5nSW50ZXJ2YWwgKiAyLCBtYXhpbXVtQ2hlY2tpbmdJbnRlcnZhbCk7CiAgICAg bV9yZXNwb25zaXZlbmVzc0NoZWNrVGltZXIuc3RhcnRPbmVTaG90KG1fY2hlY2tpbmdJbnRlcnZh bCk7CiB9Cg==