172757 2017-05-31 09:01:51 -0700 [GTK][WPE] run-javascriptcore-tests should use the jhbuild 2017-05-31 09:14:09 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P1 Normal --- 1 clopez clopez achristensen bugs-noreply buildbot calvaris dbates fpizlo lforschler simon.fraser ysuzuki zan oldest_to_newest 1314178 0 clopez 2017-05-31 09:01:51 -0700 It turns out that run-javascriptcore-tests is not using the jhbuild. This went undetected so far because the jsc binary don't links without that much libraries (pretty much only libicu). So this is currently not an issue for the WPE port as libicu is not included on the jhbuild. For the GTK+ port we are including it, and on Debian 8 the jsc binary included the rpath to the library so the linker was able to resolve the right path without needing the jhbuild trick of setting LD_LIBRARY_PATH. On Debian 9 it seems this is not longer the case (no idea why). In any case the fix is clear: run-javascriptcore-tests should use the jhbuild wrapper for the ports that use jhbuild. This is currently causing thousands of jsc test failures on the GTK+ bots (I upgraded them today to debian 9) 1314180 1 311598 clopez 2017-05-31 09:05:20 -0700 Created attachment 311598 Patch 1314181 2 311598 calvaris 2017-05-31 09:09:20 -0700 Comment on attachment 311598 Patch Nit: it would be nice a quick explanation on the changelog 1314182 3 clopez 2017-05-31 09:14:09 -0700 Committed r217605: <http://trac.webkit.org/changeset/217605> 311598 2017-05-31 09:05:20 -0700 2017-05-31 09:09:20 -0700 Patch bug-172757-20170531180519.patch text/plain 2239 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMjE3NjAxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOTU5ODk2NmQ5ZmY5MzMwMTdlZWQ4YzllNTk4NzI0ZmNl NGU1ODI4Yy4uZGJjYjRhNzUwYjNiZTI4Nzk4NjZiYTgzZWFkNzczNmEwYzZmNWE0NCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE3LTA1LTMxICBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtHVEtdW1dQRV0gcnVuLWphdmFzY3JpcHRjb3JlLXRlc3RzIHNo b3VsZCB1c2UgdGhlIGpoYnVpbGQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE3Mjc1NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogU2NyaXB0cy9ydW4tamF2YXNjcmlwdGNvcmUtdGVzdHM6CisgICAgICAg IChydW5KU0NTdHJlc3NUZXN0cyk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRkaXJzLnBtOgor ICAgICAgICAoc2hvdWxkVXNlSmhidWlsZCk6CisKIDIwMTctMDUtMzAgIFRpbSBIb3J0b24gIDx0 aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAKICAgICAgICAgS2V5Ym9hcmQgYXV0b2NvcnJlY3Rp b25zIGRvIG5vdCBhcHBseSB3aXRoIGFuIGFjdGl2ZSBzZWxlY3Rpb24gKGJ1dCBrZXlib2FyZCBh Y3RzIGxpa2UgdGhleSBkaWQpCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3J1bi1qYXZhc2Ny aXB0Y29yZS10ZXN0cyBiL1Rvb2xzL1NjcmlwdHMvcnVuLWphdmFzY3JpcHRjb3JlLXRlc3RzCmlu ZGV4IDg1N2MyNzQyZDk1MzI2NzFkMGRiOGRmMDk5ZDdlMGQ3OThjZGZjMTMuLmQwNzJhODYxYzY0 NDg4NDYwZjZmZDI4MDVlOGY5ZTIzMTczMjBkOTIgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMv cnVuLWphdmFzY3JpcHRjb3JlLXRlc3RzCisrKyBiL1Rvb2xzL1NjcmlwdHMvcnVuLWphdmFzY3Jp cHRjb3JlLXRlc3RzCkBAIC0yMzAsNiArMjMwLDcgQEAgaWYgKCRydW5UZXN0QVBJKSB7CiAgICAg Y2hkaXIoJHByb2R1Y3REaXIpIG9yIGRpZSAiRmFpbGVkIHRvIHN3aXRjaCBkaXJlY3RvcnkgdG8g JyRwcm9kdWN0RGlyJ1xuIjsKICAgICBteSBAY29tbWFuZCA9ICh0ZXN0YXBpUGF0aCgkcHJvZHVj dERpcikpOwogICAgIHVuc2hpZnQgQGNvbW1hbmQsICgieGNydW4iLCAiLXNkayIsIHhjb2RlU0RL KCksICJzaW0iKSBpZiB3aWxsVXNlSU9TU2ltdWxhdG9yU0RLKCk7CisgICAgdW5zaGlmdCBAY29t bWFuZCwgd3JhcHBlclByZWZpeElmTmVlZGVkKCkgaWYgc2hvdWxkVXNlSmhidWlsZCgpOwogCiAg ICAgaWYgKCRlbnZWYXJzIG5lICIiKSB7CiAgICAgICAgIGZvcmVhY2ggbXkgJHZhciAoc3BsaXQo L1xzKy8sICRlbnZWYXJzKSkgewpAQCAtMzYyLDYgKzM2Myw4IEBAIHN1YiBydW5KU0NTdHJlc3NU ZXN0cwogICAgICAgICBwdXNoKEBqc2NTdHJlc3NEcml2ZXJDbWQsICRmaWx0ZXIpOwogICAgIH0K IAorICAgIHVuc2hpZnQgQGpzY1N0cmVzc0RyaXZlckNtZCwgd3JhcHBlclByZWZpeElmTmVlZGVk KCkgaWYgc2hvdWxkVXNlSmhidWlsZCgpOworCiAgICAgIyBFbmQgb3B0aW9uIHByb2Nlc3Npbmcs IHRoZSByZXN0IG9mIHRoZSBhcmd1bWVudHMgYXJlIHRlc3RzCiAgICAgcHVzaChAanNjU3RyZXNz RHJpdmVyQ21kLCAiLS0iKTsKIApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJz LnBtIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCmluZGV4IGEyOGMwMzlkYjY2OTAwNGEz NDM1YTg4MzNhYmRhYTUyMzUyYjBhY2IuLmU0ODI5M2Y0OTg5MDM2NmZlOWRhZGE3ZGJmM2Q1YzI5 YzZmNWI5ZGIgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQorKysgYi9U b29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KQEAgLTE5MDAsNiArMTkwMCwxMSBAQCBzdWIgd3Jh cHBlclByZWZpeElmTmVlZGVkKCkKICAgICByZXR1cm4gKCk7CiB9CiAKK3N1YiBzaG91bGRVc2VK aGJ1aWxkKCkKK3sKKyAgICByZXR1cm4gKChpc0d0aygpIG9yIGlzV1BFKCkpIGFuZCAtZSBnZXRK aGJ1aWxkUGF0aCgpKTsKK30KKwogc3ViIGNtYWtlQ2FjaGVQYXRoKCkKIHsKICAgICByZXR1cm4g RmlsZTo6U3BlYy0+Y2F0ZGlyKGJhc2VQcm9kdWN0RGlyKCksIGNvbmZpZ3VyYXRpb24oKSwgIkNN YWtlQ2FjaGUudHh0Iik7Cg==