172751 2017-05-31 08:13:13 -0700 Get rid of more HIGH_DPI_CANVAS leftovers 2017-06-01 02:02:08 -0700 1 1 1 Unclassified WebKit Canvas WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 annulen annulen buildbot cdumez commit-queue dino esprehn+autocc gyuyoung.kim mitz simon.fraser oldest_to_newest 1314158 0 annulen 2017-05-31 08:13:13 -0700 Get rid of convertLogicalToDevice() and convertDeviceToLogical() that are no longer needed, as canvas doesn't use device scale factor anymore. 1314162 1 311590 annulen 2017-05-31 08:19:33 -0700 Created attachment 311590 Patch 1314560 2 311590 commit-queue 2017-06-01 02:02:07 -0700 Comment on attachment 311590 Patch Clearing flags on attachment: 311590 Committed r217651: <http://trac.webkit.org/changeset/217651> 1314561 3 commit-queue 2017-06-01 02:02:08 -0700 All reviewed patches have been landed. Closing bug. 311590 2017-05-31 08:19:33 -0700 2017-06-01 02:02:07 -0700 Patch bug-172751-20170531181932.patch text/plain 5234 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMjE3NTU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzk3YTM4MDk1YzI3ZjMx YTRlMGJhMWIxY2VhZWJhOTA0ZmRjNmI3My4uNTk1MDZmODY0OTA2YmMzNzg4NzIwNzczMzI3ZDRh N2VlOWY1YzYwYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE3LTA1LTMxICBLb25z dGFudGluIFRva2FyZXYgIDxhbm51bGVuQHlhbmRleC5ydT4KKworICAgICAgICBHZXQgcmlkIG9m IG1vcmUgSElHSF9EUElfQ0FOVkFTIGxlZnRvdmVycworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcyNzUxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgR2V0IHJpZCBvZiBIVE1MQ2FudmFzRWxlbWVudDo6Y29u dmVydExvZ2ljYWxUb0RldmljZSgpIGFuZAorICAgICAgICBIVE1MQ2FudmFzRWxlbWVudDo6Y29u dmVydERldmljZVRvTG9naWNhbCgpIHRoYXQgYXJlIG5vIGxvbmdlciBuZWVkZWQsCisgICAgICAg IGFzIGNhbnZhcyBkb2Vzbid0IHVzZSBkZXZpY2Ugc2NhbGUgZmFjdG9yIGFueW1vcmUuCisKKyAg ICAgICAgTm8gbmV3IHRlc3RzIG5lZWRlZC4KKworICAgICAgICAqIGh0bWwvSFRNTENhbnZhc0Vs ZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTENhbnZhc0VsZW1lbnQ6OmNyZWF0ZUlt YWdlQnVmZmVyKTogVXNlIGludGVnZXIgd2lkdGgoKQorICAgICAgICBhbmQgaGVpZ2h0KCkgaW5z dGVhZCBvZiBmbG9hdGluZy1wb2ludCB0ZW1wb3JhcnkgZGV2aWNlU2l6ZSB2YXJpYWJsZS4KKyAg ICAgICAgKFdlYkNvcmU6OkhUTUxDYW52YXNFbGVtZW50OjpiYXNlVHJhbnNmb3JtKTogUmV0dXJu IHVubW9kaWZpZWQKKyAgICAgICAgYmFzZVRyYW5zZm9ybSBvZiB1bmRlcmx5aW5nIEltYWdlQnVm ZmVyLgorICAgICAgICAqIGh0bWwvSFRNTENhbnZhc0VsZW1lbnQuaDogUmVtb3ZlZCBkZWNsYXJh dGlvbnMgb2YgdW51c2VkIG1ldGhvZHMuCisKIDIwMTctMDUtMzAgIEJyZW50IEZ1bGdoYW0gIDxi ZnVsZ2hhbUBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTihyMjE3NTE1KTogQ29ycmVj dCBpdGVyYXRvciBpbnZhbGlkYXRpb24gYnVnIChBR0FJTikKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2h0bWwvSFRNTENhbnZhc0VsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9I VE1MQ2FudmFzRWxlbWVudC5jcHAKaW5kZXggNTg3MTIxYjVmNjkzMmFhNmQwMDZhMmMwNmRmN2U5 ODQ2M2FiZWVmYy4uMzljZWRkMTU5OTlmMjEzOWU3Nzg5N2RhYThkZjA5Nzc5YTRiM2JmYyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQ2FudmFzRWxlbWVudC5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQ2FudmFzRWxlbWVudC5jcHAKQEAgLTYxMSwzNiArNjEx LDYgQEAgRXhjZXB0aW9uT3I8UmVmPE1lZGlhU3RyZWFtPj4gSFRNTENhbnZhc0VsZW1lbnQ6OmNh cHR1cmVTdHJlYW0oU2NyaXB0RXhlY3V0aW9uQ28KIH0KICNlbmRpZgogCi1GbG9hdFJlY3QgSFRN TENhbnZhc0VsZW1lbnQ6OmNvbnZlcnRMb2dpY2FsVG9EZXZpY2UoY29uc3QgRmxvYXRSZWN0JiBs b2dpY2FsUmVjdCkgY29uc3QKLXsKLSAgICBGbG9hdFJlY3QgZGV2aWNlUmVjdChsb2dpY2FsUmVj dCk7Ci0KLSAgICBmbG9hdCB4ID0gZmxvb3JmKGRldmljZVJlY3QueCgpKTsKLSAgICBmbG9hdCB5 ID0gZmxvb3JmKGRldmljZVJlY3QueSgpKTsKLSAgICBmbG9hdCB3ID0gY2VpbGYoZGV2aWNlUmVj dC5tYXhYKCkgLSB4KTsKLSAgICBmbG9hdCBoID0gY2VpbGYoZGV2aWNlUmVjdC5tYXhZKCkgLSB5 KTsKLSAgICBkZXZpY2VSZWN0LnNldFgoeCk7Ci0gICAgZGV2aWNlUmVjdC5zZXRZKHkpOwotICAg IGRldmljZVJlY3Quc2V0V2lkdGgodyk7Ci0gICAgZGV2aWNlUmVjdC5zZXRIZWlnaHQoaCk7Ci0K LSAgICByZXR1cm4gZGV2aWNlUmVjdDsKLX0KLQotRmxvYXRTaXplIEhUTUxDYW52YXNFbGVtZW50 Ojpjb252ZXJ0TG9naWNhbFRvRGV2aWNlKGNvbnN0IEZsb2F0U2l6ZSYgbG9naWNhbFNpemUpIGNv bnN0Ci17Ci0gICAgZmxvYXQgd2lkdGggPSBjZWlsZihsb2dpY2FsU2l6ZS53aWR0aCgpKTsKLSAg ICBmbG9hdCBoZWlnaHQgPSBjZWlsZihsb2dpY2FsU2l6ZS5oZWlnaHQoKSk7Ci0gICAgcmV0dXJu IEZsb2F0U2l6ZSh3aWR0aCwgaGVpZ2h0KTsKLX0KLQotRmxvYXRTaXplIEhUTUxDYW52YXNFbGVt ZW50Ojpjb252ZXJ0RGV2aWNlVG9Mb2dpY2FsKGNvbnN0IEZsb2F0U2l6ZSYgZGV2aWNlU2l6ZSkg Y29uc3QKLXsKLSAgICBmbG9hdCB3aWR0aCA9IGNlaWxmKGRldmljZVNpemUud2lkdGgoKSk7Ci0g ICAgZmxvYXQgaGVpZ2h0ID0gY2VpbGYoZGV2aWNlU2l6ZS5oZWlnaHQoKSk7Ci0gICAgcmV0dXJu IEZsb2F0U2l6ZSh3aWR0aCwgaGVpZ2h0KTsKLX0KLQogU2VjdXJpdHlPcmlnaW4qIEhUTUxDYW52 YXNFbGVtZW50OjpzZWN1cml0eU9yaWdpbigpIGNvbnN0CiB7CiAgICAgcmV0dXJuICZkb2N1bWVu dCgpLnNlY3VyaXR5T3JpZ2luKCk7CkBAIC03MzUsMTIgKzcwNSw4IEBAIHZvaWQgSFRNTENhbnZh c0VsZW1lbnQ6OmNyZWF0ZUltYWdlQnVmZmVyKCkgY29uc3QKICAgICBtX2hhc0NyZWF0ZWRJbWFn ZUJ1ZmZlciA9IHRydWU7CiAgICAgbV9kaWRDbGVhckltYWdlQnVmZmVyID0gdHJ1ZTsKIAotICAg IEZsb2F0U2l6ZSBsb2dpY2FsU2l6ZSA9IHNpemUoKTsKLSAgICBGbG9hdFNpemUgZGV2aWNlU2l6 ZSA9IGNvbnZlcnRMb2dpY2FsVG9EZXZpY2UobG9naWNhbFNpemUpOwotICAgIGlmICghZGV2aWNl U2l6ZS5pc0V4cHJlc3NpYmxlQXNJbnRTaXplKCkpCi0gICAgICAgIHJldHVybjsKLQotICAgIGlm IChkZXZpY2VTaXplLndpZHRoKCkgKiBkZXZpY2VTaXplLmhlaWdodCgpID4gbWF4Q2FudmFzQXJl YSkgeworICAgIC8vIFBlcmZvcm0gbXVsdGlwbGljYXRpb24gYXMgZmxvYXRpbmcgcG9pbnQgdG8g YXZvaWQgb3ZlcmZsb3cKKyAgICBpZiAoZmxvYXQod2lkdGgoKSkgKiBoZWlnaHQoKSA+IG1heENh bnZhc0FyZWEpIHsKICAgICAgICAgU3RyaW5nQnVpbGRlciBzdHJpbmdCdWlsZGVyOwogICAgICAg ICBzdHJpbmdCdWlsZGVyLmFwcGVuZExpdGVyYWwoIkNhbnZhcyBhcmVhIGV4Y2VlZHMgdGhlIG1h eGltdW0gbGltaXQgKHdpZHRoICogaGVpZ2h0ID4gIik7CiAgICAgICAgIHN0cmluZ0J1aWxkZXIu YXBwZW5kTnVtYmVyKG1heENhbnZhc0FyZWEpOwpAQCAtNzYwLDExICs3MjYsMTAgQEAgdm9pZCBI VE1MQ2FudmFzRWxlbWVudDo6Y3JlYXRlSW1hZ2VCdWZmZXIoKSBjb25zdAogICAgICAgICByZXR1 cm47CiAgICAgfQogCi0gICAgSW50U2l6ZSBidWZmZXJTaXplKGRldmljZVNpemUud2lkdGgoKSwg ZGV2aWNlU2l6ZS5oZWlnaHQoKSk7Ci0gICAgaWYgKCFidWZmZXJTaXplLndpZHRoKCkgfHwgIWJ1 ZmZlclNpemUuaGVpZ2h0KCkpCisgICAgaWYgKCF3aWR0aCgpIHx8ICFoZWlnaHQoKSkKICAgICAg ICAgcmV0dXJuOwogCi0gICAgUmVuZGVyaW5nTW9kZSByZW5kZXJpbmdNb2RlID0gc2hvdWxkQWNj ZWxlcmF0ZShidWZmZXJTaXplKSA/IEFjY2VsZXJhdGVkIDogVW5hY2NlbGVyYXRlZDsKKyAgICBS ZW5kZXJpbmdNb2RlIHJlbmRlcmluZ01vZGUgPSBzaG91bGRBY2NlbGVyYXRlKHNpemUoKSkgPyBB Y2NlbGVyYXRlZCA6IFVuYWNjZWxlcmF0ZWQ7CiAKICAgICBzZXRJbWFnZUJ1ZmZlcihJbWFnZUJ1 ZmZlcjo6Y3JlYXRlKHNpemUoKSwgcmVuZGVyaW5nTW9kZSkpOwogICAgIGlmICghbV9pbWFnZUJ1 ZmZlcikKQEAgLTg0NiwxMyArODExLDcgQEAgdm9pZCBIVE1MQ2FudmFzRWxlbWVudDo6Y2xlYXJD b3BpZWRJbWFnZSgpCiBBZmZpbmVUcmFuc2Zvcm0gSFRNTENhbnZhc0VsZW1lbnQ6OmJhc2VUcmFu c2Zvcm0oKSBjb25zdAogewogICAgIEFTU0VSVChtX2hhc0NyZWF0ZWRJbWFnZUJ1ZmZlcik7Ci0g ICAgRmxvYXRTaXplIHVuc2NhbGVkU2l6ZSA9IHNpemUoKTsKLSAgICBGbG9hdFNpemUgZGV2aWNl U2l6ZSA9IGNvbnZlcnRMb2dpY2FsVG9EZXZpY2UodW5zY2FsZWRTaXplKTsKLSAgICBJbnRTaXpl IHNpemUoZGV2aWNlU2l6ZS53aWR0aCgpLCBkZXZpY2VTaXplLmhlaWdodCgpKTsKLSAgICBBZmZp bmVUcmFuc2Zvcm0gdHJhbnNmb3JtOwotICAgIGlmIChzaXplLndpZHRoKCkgJiYgc2l6ZS5oZWln aHQoKSkKLSAgICAgICAgdHJhbnNmb3JtLnNjYWxlTm9uVW5pZm9ybShzaXplLndpZHRoKCkgLyB1 bnNjYWxlZFNpemUud2lkdGgoKSwgc2l6ZS5oZWlnaHQoKSAvIHVuc2NhbGVkU2l6ZS5oZWlnaHQo KSk7Ci0gICAgcmV0dXJuIG1faW1hZ2VCdWZmZXItPmJhc2VUcmFuc2Zvcm0oKSAqIHRyYW5zZm9y bTsKKyAgICByZXR1cm4gbV9pbWFnZUJ1ZmZlci0+YmFzZVRyYW5zZm9ybSgpOwogfQogCiB9CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxDYW52YXNFbGVtZW50LmggYi9Tb3Vy Y2UvV2ViQ29yZS9odG1sL0hUTUxDYW52YXNFbGVtZW50LmgKaW5kZXggMGZhYzRhMTAxOGRiOWI4 YmI5ZmVjYTM0NTAzM2FhNmEzMWUzMmJjZC4uZjk2MzM2MjVjNWJmNzk5ODRhMzk3MDlmMWZlNGJh MGYzNmVhNGI5ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQ2FudmFzRWxl bWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTENhbnZhc0VsZW1lbnQuaApAQCAt MTMzLDExICsxMzMsNiBAQCBwdWJsaWM6CiAgICAgdm9pZCBtYWtlUHJlc2VudGF0aW9uQ29weSgp OwogICAgIHZvaWQgY2xlYXJQcmVzZW50YXRpb25Db3B5KCk7CiAKLSAgICBGbG9hdFJlY3QgY29u dmVydExvZ2ljYWxUb0RldmljZShjb25zdCBGbG9hdFJlY3QmKSBjb25zdDsKLSAgICBGbG9hdFNp emUgY29udmVydExvZ2ljYWxUb0RldmljZShjb25zdCBGbG9hdFNpemUmKSBjb25zdDsKLQotICAg IEZsb2F0U2l6ZSBjb252ZXJ0RGV2aWNlVG9Mb2dpY2FsKGNvbnN0IEZsb2F0U2l6ZSYpIGNvbnN0 OwotCiAgICAgU2VjdXJpdHlPcmlnaW4qIHNlY3VyaXR5T3JpZ2luKCkgY29uc3Q7CiAgICAgdm9p ZCBzZXRPcmlnaW5UYWludGVkKCkgeyBtX29yaWdpbkNsZWFuID0gZmFsc2U7IH0KICAgICBib29s IG9yaWdpbkNsZWFuKCkgY29uc3QgeyByZXR1cm4gbV9vcmlnaW5DbGVhbjsgfQo=