172750 2017-05-31 07:56:06 -0700 [CMake] Do not pass -Wno-expansion-to-defined to Clang <4.0.0 2017-05-31 12:54:27 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aperez aperez cgarcia clopez lforschler mcatanzaro zan oldest_to_newest 1314154 0 aperez 2017-05-31 07:56:06 -0700 As per Carlos López's comment on bug #167643: > I get thousands of warnings printed like this: > warning: unknown warning option '-Wno-expansion-to-defined'; did you mean '-Wno-macro-redefined'? [-Wunknown-warning-option] > > Using clang-3.8 with ccache. With Clang 4.0 there is no such warning. 1314157 1 311589 aperez 2017-05-31 08:10:19 -0700 Created attachment 311589 Patch 1314274 2 311589 mcatanzaro 2017-05-31 12:44:03 -0700 Comment on attachment 311589 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=311589&action=review > Source/cmake/OptionsCommon.cmake:37 > + if (NOT(COMPILER_IS_CLANG AND "${CLANG_VERSION}" VERSION_LESS 4.0.0)) Style: add one space after the NOT 1314279 3 aperez 2017-05-31 12:54:27 -0700 Committed r217618: <http://trac.webkit.org/changeset/217618> 311589 2017-05-31 08:10:19 -0700 2017-05-31 12:44:03 -0700 Patch bug-172750-20170531181018.patch text/plain 1778 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjE3NjAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0NvbW1vbi5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCmluZGV4 IDU1ZTc0MDQ1ZWQ1NDA2ZGE5ODQ1OGQ4ODQxNmI0YWNmYjExN2Q1ZjQuLjNhNDcyNDM2NjBhZWQ1 MmM3ZDgwNzdlZDc5NWM1MDdhMTUxZjAzNWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRp b25zQ29tbW9uLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCkBA IC0zMSwxMSArMzEsMTMgQEAgc2V0X3Byb3BlcnR5KEdMT0JBTCBQUk9QRVJUWSBVU0VfRk9MREVS UyBPTikKIGRlZmluZV9wcm9wZXJ0eShUQVJHRVQgUFJPUEVSVFkgRk9MREVSIElOSEVSSVRFRCBC UklFRl9ET0NTICJmb2xkZXIiIEZVTExfRE9DUyAiSURFIGZvbGRlciBuYW1lIikKIAogaWYgKENP TVBJTEVSX0lTX0dDQ19PUl9DTEFORykKLSAgICBzZXQoQ01BS0VfQ19GTEFHUyAiJHtDTUFLRV9D X0ZMQUdTfSAtV25vLWV4cGFuc2lvbi10by1kZWZpbmVkIikKICAgICBzZXQoQ01BS0VfQ19GTEFH UyAiJHtDTUFLRV9DX0ZMQUdTfSAtZm5vLWV4Y2VwdGlvbnMgLWZuby1zdHJpY3QtYWxpYXNpbmci KQotICAgIHNldChDTUFLRV9DWFhfRkxBR1MgIiR7Q01BS0VfQ1hYX0ZMQUdTfSAtV25vLWV4cGFu c2lvbi10by1kZWZpbmVkIikKICAgICBzZXQoQ01BS0VfQ1hYX0ZMQUdTICIke0NNQUtFX0NYWF9G TEFHU30gLWZuby1leGNlcHRpb25zIC1mbm8tc3RyaWN0LWFsaWFzaW5nIC1mbm8tcnR0aSIpCiAg ICAgc2V0KENNQUtFX0NYWF9GTEFHUyAiJHtDTUFLRV9DWFhfRkxBR1N9IC1zdGQ9YysrMXkiKQor ICAgIGlmIChOT1QoQ09NUElMRVJfSVNfQ0xBTkcgQU5EICIke0NMQU5HX1ZFUlNJT059IiBWRVJT SU9OX0xFU1MgNC4wLjApKQorICAgICAgICBzZXQoQ01BS0VfQ19GTEFHUyAiJHtDTUFLRV9DX0ZM QUdTfSAtV25vLWV4cGFuc2lvbi10by1kZWZpbmVkIikKKyAgICAgICAgc2V0KENNQUtFX0NYWF9G TEFHUyAiJHtDTUFLRV9DWFhfRkxBR1N9IC1Xbm8tZXhwYW5zaW9uLXRvLWRlZmluZWQiKQorICAg IGVuZGlmICgpCiBlbmRpZiAoKQogCiBpZiAoQ01BS0VfR0VORVJBVE9SIFNUUkVRVUFMICJOaW5q YSIpCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggMjI0ZDA3ZDZmOGQ4 YzhjNTFkYWNiMDk4OWM3ZWE1YjdjMmQ4YmM5MS4uNTQ2ZmExMDIyY2U1OTY0NDQ0ZGQyYjI2NDkx NzcxM2E4ZmY3ODRjZiAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAt MSw1ICsxLDE0IEBACiAyMDE3LTA1LTMxICBBZHJpYW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6 QGlnYWxpYS5jb20+CiAKKyAgICAgICAgW0NNYWtlXSBEbyBub3QgcGFzcyAtV25vLWV4cGFuc2lv bi10by1kZWZpbmVkIHRvIENsYW5nIDw0LjAuMAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcyNzUwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvT3B0aW9uc0NvbW1vbi5jbWFrZToK KworMjAxNy0wNS0zMSAgQWRyaWFuIFBlcmV6IGRlIENhc3RybyAgPGFwZXJlekBpZ2FsaWEuY29t PgorCiAgICAgICAgIENvbnNpZGVyIGVuYWJsaW5nIC1Xbm8tZXhwYW5zaW9uLXRvLWRlZmluZWQg Zm9yIGdjYyA3CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNjc2NDMKIAo=