172731 2017-05-30 14:28:30 -0700 Fix compilation with !ENABLE(SVG_FONTS) 2017-06-06 12:51:09 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 annulen annulen commit-queue darin mcatanzaro mmaxfield ossy oldest_to_newest 1313878 0 annulen 2017-05-30 14:28:30 -0700 Fix compilation with !ENABLE(SVG_FONTS) 1313881 1 311542 annulen 2017-05-30 14:29:45 -0700 Created attachment 311542 Patch 1313888 2 mmaxfield 2017-05-30 14:53:55 -0700 I have been thinking of enabling this flag for everyone. Is the fact that it is disabled in your configuration intentional? 1313894 3 annulen 2017-05-30 15:00:19 -0700 AFAIK, SVG fonts is not a widely used feature, and content that uses it usually provides alternatives as WOFF(2) or TTF. That's why I believe it's acceptable to disable it on some embedded systems in order to reduce binary size. Are SVG fonts an essential part of Web platform these days? 1316179 4 311542 commit-queue 2017-06-06 12:51:07 -0700 Comment on attachment 311542 Patch Clearing flags on attachment: 311542 Committed r217849: <http://trac.webkit.org/changeset/217849> 1316180 5 commit-queue 2017-06-06 12:51:09 -0700 All reviewed patches have been landed. Closing bug. 311542 2017-05-30 14:29:45 -0700 2017-06-06 12:51:07 -0700 Patch bug-172731-20170531002944.patch text/plain 1906 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMjE3NTU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzk3YTM4MDk1YzI3ZjMx YTRlMGJhMWIxY2VhZWJhOTA0ZmRjNmI3My4uMzZlOGVlOWM4NWQ0YzUzNDgwMTBkNmYxOTk3NDNl MjBiYzYxMzZlZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE3LTA1LTMwICBLb25z dGFudGluIFRva2FyZXYgIDxhbm51bGVuQHlhbmRleC5ydT4KKworICAgICAgICBGaXggY29tcGls YXRpb24gd2l0aCAhRU5BQkxFKFNWR19GT05UUykKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MjczMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBuZWVkZWQuCisKKyAgICAgICAgKiBj c3MvQ1NTRm9udEZhY2VTb3VyY2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q1NTRm9udEZhY2VT b3VyY2U6OmxvYWQpOgorCiAyMDE3LTA1LTMwICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBw bGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjIxNzUxNSk6IENvcnJlY3QgaXRlcmF0b3Ig aW52YWxpZGF0aW9uIGJ1ZyAoQUdBSU4pCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3Mv Q1NTRm9udEZhY2VTb3VyY2UuY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU0ZvbnRGYWNlU291 cmNlLmNwcAppbmRleCAwODJjYjQ0NTEyZDQ0ZmFhM2JlYjY4Y2VlNjE4YzY0NDZmMTE3NDljLi5i N2NmMDMyZmNmZDdmNmQ5ZjUwMzgzOTJjNjVlZjE1Yzc1NzRiYzE3IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9jc3MvQ1NTRm9udEZhY2VTb3VyY2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2Nzcy9DU1NGb250RmFjZVNvdXJjZS5jcHAKQEAgLTEzNyw2ICsxMzcsNyBAQCB2b2lkIENTU0Zv bnRGYWNlU291cmNlOjpsb2FkKENTU0ZvbnRTZWxlY3RvciogZm9udFNlbGVjdG9yKQogICAgICAg ICBmb250U2VsZWN0b3ItPmJlZ2luTG9hZGluZ0ZvbnRTb29uKCptX2ZvbnQpOwogICAgIH0gZWxz ZSB7CiAgICAgICAgIGJvb2wgc3VjY2VzcyA9IGZhbHNlOworI2lmIEVOQUJMRShTVkdfRk9OVFMp CiAgICAgICAgIGlmIChtX3N2Z0ZvbnRGYWNlRWxlbWVudCkgewogICAgICAgICAgICAgaWYgKGlz PFNWR0ZvbnRFbGVtZW50PihtX3N2Z0ZvbnRGYWNlRWxlbWVudC0+cGFyZW50Tm9kZSgpKSkgewog ICAgICAgICAgICAgICAgIEFTU0VSVCghbV9pbkRvY3VtZW50Q3VzdG9tUGxhdGZvcm1EYXRhKTsK QEAgLTE0OCw3ICsxNDksOSBAQCB2b2lkIENTU0ZvbnRGYWNlU291cmNlOjpsb2FkKENTU0ZvbnRT ZWxlY3RvciogZm9udFNlbGVjdG9yKQogICAgICAgICAgICAgICAgICAgICBzdWNjZXNzID0gc3Rh dGljX2Nhc3Q8Ym9vbD4obV9pbkRvY3VtZW50Q3VzdG9tUGxhdGZvcm1EYXRhKTsKICAgICAgICAg ICAgICAgICB9CiAgICAgICAgICAgICB9Ci0gICAgICAgIH0gZWxzZSBpZiAobV9pbW1lZGlhdGVT b3VyY2UpIHsKKyAgICAgICAgfSBlbHNlCisjZW5kaWYKKyAgICAgICAgaWYgKG1faW1tZWRpYXRl U291cmNlKSB7CiAgICAgICAgICAgICBBU1NFUlQoIW1faW1tZWRpYXRlRm9udEN1c3RvbVBsYXRm b3JtRGF0YSk7CiAgICAgICAgICAgICBib29sIHdyYXBwaW5nOwogICAgICAgICAgICAgUmVmUHRy PFNoYXJlZEJ1ZmZlcj4gYnVmZmVyID0gU2hhcmVkQnVmZmVyOjpjcmVhdGUoc3RhdGljX2Nhc3Q8 Y29uc3QgY2hhcio+KG1faW1tZWRpYXRlU291cmNlLT5iYXNlQWRkcmVzcygpKSwgbV9pbW1lZGlh dGVTb3VyY2UtPmJ5dGVMZW5ndGgoKSk7Cg==