172722 2017-05-30 09:07:38 -0700 REGRESSION(r217515): Correct iterator invalidation bug (AGAIN) 2017-05-30 10:48:14 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham bfulgham buildbot cdumez commit-queue dbates japhet webkit-bug-importer zalan oldest_to_newest 1313742 0 bfulgham 2017-05-30 09:07:38 -0700 I reintroduced a bug involving an invalidated iterator in r217515. This returns this code to the "copy" behavior used prior to r217515. 1313743 1 webkit-bug-importer 2017-05-30 09:09:13 -0700 <rdar://problem/32462876> 1313744 2 311509 bfulgham 2017-05-30 09:13:45 -0700 Created attachment 311509 Patch 1313752 3 311509 commit-queue 2017-05-30 09:57:24 -0700 Comment on attachment 311509 Patch Clearing flags on attachment: 311509 Committed r217558: <http://trac.webkit.org/changeset/217558> 1313753 4 commit-queue 2017-05-30 09:57:25 -0700 All reviewed patches have been landed. Closing bug. 1313757 5 311509 cdumez 2017-05-30 10:15:46 -0700 Comment on attachment 311509 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=311509&action=review > Source/WebCore/loader/ResourceLoadObserver.cpp:158 > + // We must make a copy here, because later calls to 'ensureResourceStatisticsForPrimaryDomain' will invalidate the returned reference:: Extra ':'. 1313769 6 bfulgham 2017-05-30 10:48:14 -0700 Rats! Typo fixed in: Committed r217561: <http://trac.webkit.org/changeset/217561> 311509 2017-05-30 09:13:45 -0700 2017-05-30 09:57:24 -0700 Patch bug-172722-20170530091344.patch text/plain 2399 bfulgham SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxNzU1NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE3LTA1LTMwICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04ocjIxNzUx NSk6IENvcnJlY3QgaXRlcmF0b3IgaW52YWxpZGF0aW9uIGJ1ZyAoQUdBSU4pCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzI3MjIKKyAgICAgICAgPHJk YXI6Ly9wcm9ibGVtLzMyNDYyODc2PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIE92ZXItZW50aHVzaWFzdGljIGNsZWFuLXVwIGR1cmluZyByMjE3NTE1 IHJlLWludHJvZHVjZWQgYSBidWcgY2F1c2VkIGJ5IGhvbGRpbmcgYSByZWZlcmVuY2UKKyAgICAg ICAgdG8gYW4gaXRlcmF0b3IgdGhhdCBnZXRzIGludmFsaWRhdGVkIHdoaWxlIGhhbmRsaW5nIHRo ZSBmcmFtZSBuYXZpZ2F0aW9uLiBUaGlzIHBhdGNoIHJldHVybnMKKyAgICAgICAgdG8gdGhlIGNv cHkvc2V0IGJlaGF2aW9yIHVzZWQgcHJpb3IgdG8gcjIxNzUxNS4gCisKKyAgICAgICAgKiBsb2Fk ZXIvUmVzb3VyY2VMb2FkT2JzZXJ2ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VM b2FkT2JzZXJ2ZXI6OmxvZ0ZyYW1lTmF2aWdhdGlvbik6IE1ha2UgYSBjb3B5IG9mIHRoZSByZXR1 cm5lZCB2YWx1ZSwgc2luY2UKKyAgICAgICAgdGhlIGl0ZXJhdG9yIHdpbGwgYmUgaW52YWxpZGF0 ZWQgZHVyaW5nIHRoZSBmdW5jdGlvbiBjYWxsLiBUaGVuIHNldCB0aGUgY29weSBiYWNrIGluIHRo ZSBkYXRhCisgICAgICAgIHN0b3JlIHdpdGggdGhlIHVwZGF0ZWQgY291bnRzLgorCiAyMDE3LTA1 LTMwICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgogCiAgICAgICAg IFtXaW5DYWlyb10gVGVzdFdlYktpdEFQSTogU0hPVUxEIE5FVkVSIEJFIFJFQUNIRUQgaW4gV2Vi Q29yZTo6Y2Fpcm9TdXJmYWNlU2l6ZQpJbmRleDogU291cmNlL1dlYkNvcmUvbG9hZGVyL1Jlc291 cmNlTG9hZE9ic2VydmVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9sb2FkZXIv UmVzb3VyY2VMb2FkT2JzZXJ2ZXIuY3BwCShyZXZpc2lvbiAyMTc1MTUpCisrKyBTb3VyY2UvV2Vi Q29yZS9sb2FkZXIvUmVzb3VyY2VMb2FkT2JzZXJ2ZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0x NTUsNyArMTU1LDggQEAgdm9pZCBSZXNvdXJjZUxvYWRPYnNlcnZlcjo6bG9nRnJhbWVOYXZpZwog ICAgICAgICAKICAgICAgICAgewogICAgICAgICBhdXRvIGxvY2tlciA9IGhvbGRMb2NrKG1fc3Rv cmUtPnN0YXRpc3RpY3NMb2NrKCkpOwotICAgICAgICBhdXRvJiB0YXJnZXRTdGF0aXN0aWNzID0g bV9zdG9yZS0+ZW5zdXJlUmVzb3VyY2VTdGF0aXN0aWNzRm9yUHJpbWFyeURvbWFpbih0YXJnZXRQ cmltYXJ5RG9tYWluKTsKKyAgICAgICAgLy8gV2UgbXVzdCBtYWtlIGEgY29weSBoZXJlLCBiZWNh dXNlIGxhdGVyIGNhbGxzIHRvICdlbnN1cmVSZXNvdXJjZVN0YXRpc3RpY3NGb3JQcmltYXJ5RG9t YWluJyB3aWxsIGludmFsaWRhdGUgdGhlIHJldHVybmVkIHJlZmVyZW5jZTo6CisgICAgICAgIGF1 dG8gdGFyZ2V0U3RhdGlzdGljcyA9IG1fc3RvcmUtPmVuc3VyZVJlc291cmNlU3RhdGlzdGljc0Zv clByaW1hcnlEb21haW4odGFyZ2V0UHJpbWFyeURvbWFpbik7CiAKICAgICAgICAgLy8gQWx3YXlz IGZpcmUgaWYgd2UgaGF2ZSBwcmV2aW91c2x5IHJlbW92ZWQgZGF0YSByZWNvcmRzIGZvciB0aGlz IGRvbWFpbgogICAgICAgICBzaG91bGRGaXJlRGF0YU1vZGlmaWNhdGlvbkhhbmRsZXIgPSB0YXJn ZXRTdGF0aXN0aWNzLmRhdGFSZWNvcmRzUmVtb3ZlZCA+IDA7CkBAIC0yMDUsNiArMjA2LDggQEAg dm9pZCBSZXNvdXJjZUxvYWRPYnNlcnZlcjo6bG9nRnJhbWVOYXZpZwogICAgICAgICAgICAgICAg IH0KICAgICAgICAgICAgIH0KICAgICAgICAgfQorICAgICAgICAgICAgCisgICAgICAgIG1fc3Rv cmUtPnNldFJlc291cmNlU3RhdGlzdGljc0ZvclByaW1hcnlEb21haW4odGFyZ2V0UHJpbWFyeURv bWFpbiwgV1RGTW92ZSh0YXJnZXRTdGF0aXN0aWNzKSk7CiAgICAgICAgIH0gLy8gUmVsZWFzZSBs b2NrCiAgICAgICAgIAogICAgICAgICBpZiAoc2hvdWxkRmlyZURhdGFNb2RpZmljYXRpb25IYW5k bGVyKQo=