172709 2017-05-30 05:55:11 -0700 [Win] fast/shadow-dom/fullscreen-in-slot-fullscreenElement.html is flaky. 2017-05-30 20:17:56 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan achristensen bfulgham lforschler webkit-bug-importer oldest_to_newest 1313678 0 pvollan 2017-05-30 05:55:11 -0700 We should make sure we exit from fullscreen mode after a fullscreen test. 1313679 1 311500 pvollan 2017-05-30 05:59:52 -0700 Created attachment 311500 Patch 1313690 2 311500 bfulgham 2017-05-30 07:00:30 -0700 Comment on attachment 311500 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=311500&action=review R=me but please make a new IWebViewPrivate5 interface to avoid breaking existing COM interface users. > Source/WebKit/win/Interfaces/IWebViewPrivate.idl:350 > + HRESULT exitFullscreenIfNeeded(); Sadly, we need to make an IWebViewPrivate5 here, because IWebViewPrivate4 already shipped to users, and we will break them if we modify the COM interface. 1313720 3 pvollan 2017-05-30 08:03:21 -0700 (In reply to Brent Fulgham from comment #2) > Comment on attachment 311500 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=311500&action=review > > R=me but please make a new IWebViewPrivate5 interface to avoid breaking > existing COM interface users. > > > Source/WebKit/win/Interfaces/IWebViewPrivate.idl:350 > > + HRESULT exitFullscreenIfNeeded(); > > Sadly, we need to make an IWebViewPrivate5 here, because IWebViewPrivate4 > already shipped to users, and we will break them if we modify the COM > interface. Thanks for reviewing! I will make an IWebViewPrivate5 interface before landing. 1313734 4 pvollan 2017-05-30 08:42:39 -0700 Committed <https://trac.webkit.org/changeset/217557/webkit> 1313990 5 webkit-bug-importer 2017-05-30 20:17:56 -0700 <rdar://problem/32479628> 311500 2017-05-30 05:59:52 -0700 2017-05-30 07:00:30 -0700 Patch bug-172709-20170530055953.patch text/plain 4951 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxNzUzMikKKysrIFNvdXJjZS9XZWJLaXQv d2luL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE3LTA1LTMw ICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2luXSBm YXN0L3NoYWRvdy1kb20vZnVsbHNjcmVlbi1pbi1zbG90LWZ1bGxzY3JlZW5FbGVtZW50Lmh0bWwg aXMgZmxha3kuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNzI3MDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBZGQgbWV0aG9kIHRvIGV4aXQgZnVsbHNjcmVlbiBtb2RlLgorCisgICAgICAgICogSW50ZXJm YWNlcy9JV2ViVmlld1ByaXZhdGUuaWRsOgorICAgICAgICAqIFdlYlZpZXcuY3BwOgorICAgICAg ICAoV2ViVmlldzo6ZXhpdEZ1bGxzY3JlZW5JZk5lZWRlZCk6CisgICAgICAgICogV2ViVmlldy5o OgorCiAyMDE3LTA1LTI0ICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KIAog ICAgICAgICBbV2luXSBDcmVhdGUgdW5pcXVlIG5ldHdvcmsgc3RvcmFnZSBzZXNzaW9uIGZvciBl YWNoIERSVC4KSW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL1dlYlZpZXcuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJLaXQvd2luL1dlYlZpZXcuY3BwCShyZXZpc2lvbiAyMTc1MzIpCisrKyBT b3VyY2UvV2ViS2l0L3dpbi9XZWJWaWV3LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzgzMywzICs3 ODMzLDEwIEBAIEhSRVNVTFQgV2ViVmlldzo6c2V0VmlzaWJpbGl0eVN0YXRlKFdlYlAKIAogICAg IHJldHVybiBTX09LOwogfQorCitIUkVTVUxUIFdlYlZpZXc6OmV4aXRGdWxsc2NyZWVuSWZOZWVk ZWQoKQoreworICAgIGlmIChmdWxsU2NyZWVuQ29udHJvbGxlcigpICYmIGZ1bGxTY3JlZW5Db250 cm9sbGVyKCktPmlzRnVsbFNjcmVlbigpKQorICAgICAgICBmdWxsU2NyZWVuQ29udHJvbGxlcigp LT5jbG9zZSgpOworICAgIHJldHVybiBTX09LOworfQpJbmRleDogU291cmNlL1dlYktpdC93aW4v V2ViVmlldy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvd2luL1dlYlZpZXcuaAkocmV2 aXNpb24gMjE3NTMyKQorKysgU291cmNlL1dlYktpdC93aW4vV2ViVmlldy5oCSh3b3JraW5nIGNv cHkpCkBAIC00MDEsNiArNDAxLDcgQEAgcHVibGljOgogCiAgICAgLy8gSVdlYlZpZXdQcml2YXRl NAogICAgIEhSRVNVTFQgU1RETUVUSE9EQ0FMTFRZUEUgc2V0VmlzaWJpbGl0eVN0YXRlKFdlYlBh Z2VWaXNpYmlsaXR5U3RhdGUpOworICAgIEhSRVNVTFQgU1RETUVUSE9EQ0FMTFRZUEUgZXhpdEZ1 bGxzY3JlZW5JZk5lZWRlZCgpOwogCiAgICAgLy8gV2ViVmlldwogICAgIGJvb2wgc2hvdWxkVXNl RW1iZWRkZWRWaWV3KGNvbnN0IFdURjo6U3RyaW5nJiBtaW1lVHlwZSkgY29uc3Q7CkluZGV4OiBT b3VyY2UvV2ViS2l0L3dpbi9JbnRlcmZhY2VzL0lXZWJWaWV3UHJpdmF0ZS5pZGwKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYktpdC93aW4vSW50ZXJmYWNlcy9JV2ViVmlld1ByaXZhdGUuaWRsCShy ZXZpc2lvbiAyMTc1MzIpCisrKyBTb3VyY2UvV2ViS2l0L3dpbi9JbnRlcmZhY2VzL0lXZWJWaWV3 UHJpdmF0ZS5pZGwJKHdvcmtpbmcgY29weSkKQEAgLTM0Nyw0ICszNDcsNSBAQCB0eXBlZGVmIGVu dW0gewogaW50ZXJmYWNlIElXZWJWaWV3UHJpdmF0ZTQgOiBJV2ViVmlld1ByaXZhdGUzCiB7CiAg ICAgSFJFU1VMVCBzZXRWaXNpYmlsaXR5U3RhdGUoW2luXSBXZWJQYWdlVmlzaWJpbGl0eVN0YXRl KTsKKyAgICBIUkVTVUxUIGV4aXRGdWxsc2NyZWVuSWZOZWVkZWQoKTsKIH0KSW5kZXg6IFRvb2xz L0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxNzU1 MCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisy MDE3LTA1LTMwICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAg ICBbV2luXSBmYXN0L3NoYWRvdy1kb20vZnVsbHNjcmVlbi1pbi1zbG90LWZ1bGxzY3JlZW5FbGVt ZW50Lmh0bWwgaXMgZmxha3kuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNzI3MDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBFeGl0IGZ1bGxzY3JlZW4gbW9kZSBhZnRlciBhIGZ1bGxzY3JlZW4gdGVzdC4K KworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL3dpbi9EdW1wUmVuZGVyVHJlZS5jcHA6CisgICAg ICAgIChyZXNldFdlYlZpZXdUb0NvbnNpc3RlbnRTdGF0ZUJlZm9yZVRlc3RpbmcpOgorCiAyMDE3 LTA1LTI5ICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KIAogICAgICAgICBV bnJldmlld2VkLiBCdW1waW5nIHRoZSBXUEVCYWNrZW5kLW1lc2EgZGVwZW5kZW5jeSB2ZXJzaW9u LgpJbmRleDogVG9vbHMvRHVtcFJlbmRlclRyZWUvd2luL0R1bXBSZW5kZXJUcmVlLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBUb29scy9EdW1wUmVuZGVyVHJlZS93aW4vRHVtcFJlbmRlclRyZWUuY3BwCShy ZXZpc2lvbiAyMTc1MzIpCisrKyBUb29scy9EdW1wUmVuZGVyVHJlZS93aW4vRHVtcFJlbmRlclRy ZWUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMDEzLDYgKzEwMTMsOSBAQCBzdGF0aWMgdm9pZCBy ZXNldFdlYlZpZXdUb0NvbnNpc3RlbnRTdGF0CiAgICAgQ09NUHRyPElXZWJGcmFtZVByaXZhdGU+ IGZyYW1lUHJpdmF0ZTsKICAgICBpZiAoU1VDQ0VFREVEKGZyYW1lLT5RdWVyeUludGVyZmFjZSgm ZnJhbWVQcml2YXRlKSkpCiAgICAgICAgIGZyYW1lUHJpdmF0ZS0+Y2xlYXJPcGVuZXIoKTsKKwor ICAgIENPTVB0cjxJV2ViVmlld1ByaXZhdGU0PiB3ZWJWaWV3UHJpdmF0ZTQoUXVlcnksIHdlYlZp ZXcpOworICAgIHdlYlZpZXdQcml2YXRlNC0+ZXhpdEZ1bGxzY3JlZW5JZk5lZWRlZCgpOwogfQog CiBzdGF0aWMgdm9pZCBzaXplV2ViVmlld0ZvckN1cnJlbnRUZXN0KCkKSW5kZXg6IExheW91dFRl c3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlz aW9uIDIxNzUzNCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAt MSwzICsxLDEyIEBACisyMDE3LTA1LTMwICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxl LmNvbT4KKworICAgICAgICBbV2luXSBmYXN0L3NoYWRvdy1kb20vZnVsbHNjcmVlbi1pbi1zbG90 LWZ1bGxzY3JlZW5FbGVtZW50Lmh0bWwgaXMgZmxha3kuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzI3MDkKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL3dpbi9UZXN0RXhwZWN0YXRpb25z OgorCiAyMDE3LTA1LTI5ICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KIAog ICAgICAgICBVbnJldmlld2VkIFdpbmRvd3MgdGVzdCBnYXJkZW5pbmcsIHVwZGF0ZSBleHBlY3Rl ZCByZXN1bHRzIGFmdGVyIHIyMTc0MTguCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS93aW4v VGVzdEV4cGVjdGF0aW9ucwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS93aW4v VGVzdEV4cGVjdGF0aW9ucwkocmV2aXNpb24gMjE3NTMyKQorKysgTGF5b3V0VGVzdHMvcGxhdGZv cm0vd2luL1Rlc3RFeHBlY3RhdGlvbnMJKHdvcmtpbmcgY29weSkKQEAgLTM5OTQsNyArMzk5NCw2 IEBAIGh0dHAvdGVzdHMvd2Vic29ja2V0L3Rlc3RzL2h5YmkvaW5zcGVjdG8KIGh0dHAvdGVzdHMv d2Vic29ja2V0L3Rlc3RzL2h5YmkvaW5zcGVjdG9yL3NlbmQtYW5kLXJlY2VpdmUuaHRtbCBbIFNr aXAgXQogaHR0cC90ZXN0cy93ZWJzb2NrZXQvdGVzdHMvaHliaS9pbnNwZWN0b3Ivc2VydmVyLWNs b3NlLmh0bWwgWyBTa2lwIF0KICMgVW5leHBlY3RlZCBmbGFraW5lc3MgdHJhY2tlZCBpbiB3ZWJr aXQub3JnL2IvMTcyNDM3LgotZmFzdC9zaGFkb3ctZG9tL2Z1bGxzY3JlZW4taW4tc2xvdC1mdWxs c2NyZWVuRWxlbWVudC5odG1sIFsgRmFpbHVyZSBQYXNzIF0KIGltcG9ydGVkL3czYy93ZWItcGxh dGZvcm0tdGVzdHMvZmV0Y2gvYXBpL2NvcnMvY29ycy1jb29raWVzLmFueS53b3JrZXIuaHRtbCBb IEZhaWx1cmUgUGFzcyBdCiBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2ZldGNoL2Fw aS9jcmVkZW50aWFscy9jb29raWVzLmFueS5odG1sIFsgRmFpbHVyZSBQYXNzIF0KIGltcG9ydGVk L3czYy93ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9zZW1hbnRpY3MvZW1iZWRkZWQtY29udGVudC90 aGUtYXJlYS1lbGVtZW50L2FyZWEtc2hhcGUuaHRtbCBbIEZhaWx1cmUgUGFzcyBdCg==