172690 2017-05-28 19:31:00 -0700 [JSC] Provide better type information of toLength and tighten bytecode 2017-05-30 20:19:32 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 153738 1 ysuzuki ysuzuki buildbot keith_miller mark.lam msaboff saam sam webkit-bug-importer oldest_to_newest 1313518 0 ysuzuki 2017-05-28 19:31:00 -0700 [JSC] Provide better type information of toLength and tighten bytecode 1313519 1 311449 ysuzuki 2017-05-28 19:39:10 -0700 Created attachment 311449 Patch 1313531 2 311449 sam 2017-05-28 21:57:28 -0700 Comment on attachment 311449 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=311449&action=review > Source/JavaScriptCore/ChangeLog:15 > + operator+ emits to_number bytecode. What this bytecode does is the same > + to @Number() call. It is more efficient, and it is smaller bytecode > + than @Number() call (load global variable @Number, set up arguments, and > + call it). Should we remove @Number()? Alternatively, should we make @Number() transform into to_number (maybe via your bytecode re-writer )? 1313535 3 311449 ysuzuki 2017-05-28 22:08:09 -0700 Comment on attachment 311449 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=311449&action=review Thanks! >> Source/JavaScriptCore/ChangeLog:15 >> + call it). > > Should we remove @Number()? Alternatively, should we make @Number() transform into to_number (maybe via your bytecode re-writer )? I've just checked and found some WebCore code still uses @Number(). Maybe, they also can be converted to +. Filed it separately https://bugs.webkit.org/show_bug.cgi?id=172692. 1313536 4 ysuzuki 2017-05-28 22:09:21 -0700 Committed r217530: <http://trac.webkit.org/changeset/217530> 1313998 5 webkit-bug-importer 2017-05-30 20:19:32 -0700 <rdar://problem/32479650> 311449 2017-05-28 19:39:10 -0700 2017-05-28 21:57:28 -0700 Patch bug-172690-20170529113909.patch text/plain 3678 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjE3NTI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA4 NjBhMTk1MWVlNGYzMjM2Y2UzODdkOTAwNGFiZmQ5ZTFiNmQ5ZjU2Li41ZTg4NzY4Zjc2MmNjMDY1 OWY1MjUyNjRlYzFhODlkOWE1NGM4MGVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSw1MSBAQAogMjAxNy0wNS0yOCAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWls LmNvbT4KIAorICAgICAgICBbSlNDXSBQcm92aWRlIGJldHRlciB0eXBlIGluZm9ybWF0aW9uIG9m IHRvTGVuZ3RoIGFuZCB0aWdodGVuIGJ5dGVjb2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzI2OTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBJbiB0aGlzIHBhdGNoLCB3ZSBjYXJlZnVsbHkgbGV2ZXJh Z2Ugb3BlcmF0b3IgKyBpbiBvcmRlciB0bworCisgICAgICAgIDEuIHRpZ2h0ZW4gYnl0ZWNvZGUK KworICAgICAgICBvcGVyYXRvcisgZW1pdHMgdG9fbnVtYmVyIGJ5dGVjb2RlLiBXaGF0IHRoaXMg Ynl0ZWNvZGUgZG9lcyBpcyB0aGUgc2FtZQorICAgICAgICB0byBATnVtYmVyKCkgY2FsbC4gSXQg aXMgbW9yZSBlZmZpY2llbnQsIGFuZCBpdCBpcyBzbWFsbGVyIGJ5dGVjb2RlCisgICAgICAgIHRo YW4gQE51bWJlcigpIGNhbGwgKGxvYWQgZ2xvYmFsIHZhcmlhYmxlIEBOdW1iZXIsIHNldCB1cCBh cmd1bWVudHMsIGFuZAorICAgICAgICBjYWxsIGl0KS4KKworICAgICAgICAyLiBvZmZlciBiZXR0 ZXIgdHlwZSBwcmVkaWN0aW9uIGRhdGEKKworICAgICAgICBOb3csIHdlIGhhdmUgY29kZSBsaWtl CisKKyAgICAgICAgICAgIGxlbmd0aCA+IDAgPyAobGVuZ3RoIDwgQE1BWF9TQUZFX0lOVEVHRVIg PyBsZW5ndGggOiBATUFYX1NBRkVfSU5URUdFUikgOiAwCisKKyAgICAgICAgVGhpcyBpcyBub3Qg Z29vZCBiZWNhdXNlIERGRyBwcmVkaWN0aW9uIHByb3BhZ2F0aW9uIHBoYXNlIHByZWRpY3RzIGFz IERvdWJsZQorICAgICAgICBzaW5jZSBATUFYX1NBRkVfSU5URUdFUiBpcyBkb3VibGUuIEJ1dCBh Y3R1YWxseSBpdCByYXJlbHkgYmVjb21lcyBEb3VibGUuCisgICAgICAgIFVzdWFsbHksIHRoZSBy ZXN1bHQgYmVjb21lcyBJbnQzMi4gVGhpcyBwYXRjaCBsZXZlcmFnZXMgdG9fbnVtYmVyIGluIGEg Yml0CisgICAgICAgIGludGVyZXN0aW5nIHdheTogdG9fbnVtYmVyIGhhcyB2YWx1ZSBwcm9maWxp bmcgdG8gb2ZmZXIgYmV0dGVyIHR5cGUgcHJlZGljdGlvbi4KKyAgICAgICAgVGhpcyB2YWx1ZSBw cm9maWxpbmcgY2FuIG9mZmVyIGEgY2hhbmNlIHRvIGNoYW5nZSB0aGUgcHJlZGljdGlvbiB0byBJ bnQzMiBlZmZpY2llbnRseS4KKyAgICAgICAgSXQgaXMgYSBiaXQgdHJpY2t5LiBCdXQgaXQgaXMg d29ydGggZG9pbmcgdG8gc3BlZWQgdXAgb3VyIGJ1aWx0aW4gZnVuY3Rpb25zLAorICAgICAgICB3 aGljaCBzaG91bGQgbGV2ZXJhZ2UgYWxsIHRoZSBKU0MncyB0cmlja3kgdGhpbmdzIHRvIGJlIG9w dGltaXplZC4KKworICAgICAgICBSZWxhdGVkIG1pY3JvYmVuY2htYXJrcyBzaG93IHBlcmZvcm1h bmNlIGltcHJvdmVtZW50LgorCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGJhc2VsaW5lICAgICAgICAgICAgICAgICAgcGF0Y2hlZAorCisgICAgICAg ICAgICBhcnJheS1wcm90b3R5cGUtZm9yRWFjaCAgICAgICAgICAgNTAuMjM0OCstMi4yMzMxICAg ICAgICAgICA0OS43NTY4Ky0yLjM1MDcKKyAgICAgICAgICAgIGFycmF5LXByb3RvdHlwZS1tYXAg ICAgICAgICAgICAgICA1MS4wNTc0Ky0xLjgxNjYgICAgICAgICAgIDQ3Ljk1MzErLTIuMTY1MyAg ICAgICAgICBtaWdodCBiZSAxLjA2NDd4IGZhc3RlcgorICAgICAgICAgICAgYXJyYXktcHJvdG90 eXBlLXNvbWUgICAgICAgICAgICAgIDUyLjM5MjYrLTEuODg4MiAgICAgXiAgICAgNDguMzYzMist Mi4wODUyICAgICAgICBeIGRlZmluaXRlbHkgMS4wODMzeCBmYXN0ZXIKKyAgICAgICAgICAgIGFy cmF5LXByb3RvdHlwZS1ldmVyeSAgICAgICAgICAgICA1Mi43Mzk0Ky0yLjA3MTIgICAgICAgICAg IDUwLjI4OTYrLTIuMTQ4MCAgICAgICAgICBtaWdodCBiZSAxLjA0ODd4IGZhc3RlcgorICAgICAg ICAgICAgYXJyYXktcHJvdG90eXBlLXJlZHVjZSAgICAgICAgICAgIDU0Ljk5OTQrLTIuMzYzOCAg ICAgICAgICAgNTEuODcxNistMi42MjUzICAgICAgICAgIG1pZ2h0IGJlIDEuMDYwM3ggZmFzdGVy CisgICAgICAgICAgICBhcnJheS1wcm90b3R5cGUtcmVkdWNlUmlnaHQgICAgICAyMDkuNzU5NCst OS4yNTk0ICAgICBeICAgICA1MS41ODY3Ky0yLjU3NDUgICAgICAgIF4gZGVmaW5pdGVseSA0LjA2 NjJ4IGZhc3RlcgorCisKKyAgICAgICAgKiBidWlsdGlucy9HbG9iYWxPcGVyYXRpb25zLmpzOgor ICAgICAgICAoZ2xvYmFsUHJpdmF0ZS50b0ludGVnZXIpOgorICAgICAgICAoZ2xvYmFsUHJpdmF0 ZS50b0xlbmd0aCk6CisKKzIwMTctMDUtMjggIFl1c3VrZSBTdXp1a2kgIDx1dGF0YW5lLnRlYUBn bWFpbC5jb20+CisKICAgICAgICAgVW5yZXZpZXdlZCwgYnVpbGQgZml4IGZvciBXaW5kb3dzCiAg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzI0MTMKIApk aWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2J1aWx0aW5zL0dsb2JhbE9wZXJhdGlv bnMuanMgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnVpbHRpbnMvR2xvYmFsT3BlcmF0aW9ucy5q cwppbmRleCAyMjIyMGNmMmVhYjI0MThmODM2MmQ2MWQwMjgxYzgxMDljZDJkNWIwLi5iYTk3YjY1 ODRlODYyMmFiZjA3YzVlOWQ1MDFkNWU5MDFjYmVjMTVjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvYnVpbHRpbnMvR2xvYmFsT3BlcmF0aW9ucy5qcworKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvYnVpbHRpbnMvR2xvYmFsT3BlcmF0aW9ucy5qcwpAQCAtMzAsNyArMzAsNyBA QCBmdW5jdGlvbiB0b0ludGVnZXIodGFyZ2V0KQogewogICAgICJ1c2Ugc3RyaWN0IjsKIAotICAg IHZhciBudW1iZXJWYWx1ZSA9IEBOdW1iZXIodGFyZ2V0KTsKKyAgICB2YXIgbnVtYmVyVmFsdWUg PSArdGFyZ2V0OwogCiAgICAgLy8gaXNOYU4obnVtYmVyVmFsdWUpCiAgICAgaWYgKG51bWJlclZh bHVlICE9PSBudW1iZXJWYWx1ZSkKQEAgLTQ1LDcgKzQ1LDcgQEAgZnVuY3Rpb24gdG9MZW5ndGgo dGFyZ2V0KQogCiAgICAgdmFyIGxlbmd0aCA9IEB0b0ludGVnZXIodGFyZ2V0KTsKICAgICAvLyBv cmlnaW5hbGx5IE1hdGgubWluKE1hdGgubWF4KGxlbmd0aCwgMCksIG1heFNhZmVJbnRlZ2VyKSk7 Ci0gICAgcmV0dXJuIGxlbmd0aCA+IDAgPyAobGVuZ3RoIDwgQE1BWF9TQUZFX0lOVEVHRVIgPyBs ZW5ndGggOiBATUFYX1NBRkVfSU5URUdFUikgOiAwOworICAgIHJldHVybiArKGxlbmd0aCA+IDAg PyAobGVuZ3RoIDwgQE1BWF9TQUZFX0lOVEVHRVIgPyBsZW5ndGggOiBATUFYX1NBRkVfSU5URUdF UikgOiAwKTsKIH0KIAogQGdsb2JhbFByaXZhdGUK