<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>172685</bug_id>
          
          <creation_ts>2017-05-28 04:27:30 -0700</creation_ts>
          <short_desc>[JSC] Move WebCore jsDynamicDowncast mechanism to JSC</short_desc>
          <delta_ts>2018-04-01 12:26:12 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>183449</dup_id>
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Yusuke Suzuki">ysuzuki</reporter>
          <assigned_to name="Yusuke Suzuki">ysuzuki</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1313474</commentid>
    <comment_count>0</comment_count>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2017-05-28 04:27:30 -0700</bug_when>
    <thetext>We have bunch of adhoc functions, like, isSymbol, asSymbol, isJSMap etc.
We may easily miss the chance to use optimized casting.

For example,

jsDynamicCast&lt;JSMap*&gt;(vm, iterable)

If we do not have a fast overloading function (checking type() == JSMapType), it falls back to the usual slow inherits() code.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1410969</commentid>
    <comment_count>1</comment_count>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2018-04-01 12:26:12 -0700</bug_when>
    <thetext>We already did it.

*** This bug has been marked as a duplicate of bug 183449 ***</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>