17267 2008-02-09 19:21:28 -0800 [GTK] Primary selection/clipboard support 2009-05-12 10:14:27 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) All All RESOLVED DUPLICATE 25685 Gtk P2 Major --- 1 alp webkit-unassigned alp a.renevier christian lethalman88 martin.sourada ori pierre-luc.beaudoin pochu27 oldest_to_newest 69986 0 alp 2008-02-09 19:21:28 -0800 We already have clipboard support, but it doesn't work with the primary clipboard on X. We need to support (a) selections for pasting from WebKit into other applications (b) middle-click for pasting from the primary clipboard into editable WebKit areas On platforms without a primary clipboard, GTK+ automatically makes this a no-op, so we don't need to add any conditional/X-specific code to support this. 84063 1 21872 christian 2008-06-22 05:09:52 -0700 Created attachment 21872 Attempt at primary clipboard support I do not know too well about WebCore's clipboard support, but at some point I really needed primary clipboard support. So here is my attempt. It works for all I want. 84065 2 21872 oliver 2008-06-22 05:35:05 -0700 Comment on attachment 21872 Attempt at primary clipboard support r-, the shouldBlah methods are callbacks made to the api to query whether something is allowed, not that is has already happened. EditorClient methods are (by and large) just present to allow WebCore's behaviour to be controlled through the platforms API, so all these methods should just map through to your API implementation. The WebKit/GTK API's default implementation for didChangeSelectedRange (or whatever, definitely not shouldChangeSelectedRange) would probably be something along these lines. 88248 3 alp 2008-08-11 16:26:50 -0700 The performance hit/memory fragmentation of converting HTML to text every time a large selection is changed would be too great, and would rule out the possibility of content negotiation (copy and paste as HTML, text, rich text, Pango markup etc.) I think we need to avoid copying the inner text of the selection every time it changes, instead responding to a primary selection request when it happens (Qt does the former and I don't like it.) 90763 4 23321 alp 2008-09-10 08:32:50 -0700 Created attachment 23321 Primary clipboard copy support The behaviour of this patch is intended to match GtkTextView (which is slightly different to the selection support in Firefox and OpenOffice and fits in better with GTK+ applications). 90795 5 23321 alp 2008-09-10 13:32:09 -0700 Comment on attachment 23321 Primary clipboard copy support Landed in r36323. Still need paste support to close this bug. 96806 6 24698 sergio_gcg 2008-10-27 15:47:21 -0700 Created attachment 24698 Copy link locations to the primary selection This patch makes WebCore::Pasteboard::writeURL use the primary selection as well as the clipboard selection. 97158 7 alp 2008-10-30 13:41:09 -0700 (In reply to comment #6) > Created an attachment (id=24698) [edit] > Copy link locations to the primary selection > > This patch makes WebCore::Pasteboard::writeURL use the primary selection as > well as the clipboard selection. > Thanks, this is a reasonable feature to add. I'll review this one in a bit. There are a few interactions that need to be checked before getting this in. 100758 8 24698 jmalonzo 2008-11-29 23:52:52 -0800 Comment on attachment 24698 Copy link locations to the primary selection Alp to review.. 105443 9 a.butenka 2009-01-12 21:36:56 -0800 'Primary clipboard copy support' is already landed. i applied 'Copy link locations to the primary selection' patch but still cant paste nothing to editable areas in webkit. 107421 10 27129 sergio_gcg 2009-01-28 15:46:33 -0800 Created attachment 27129 Preliminary primary selection paste support Here is my attempt to support middle-click pasting. The target editable area must be selected, so it only works when the selection comes from an external application or when a clipboard manager is running (and then the selection comes from an external application, too). 107424 11 27129 sergio_gcg 2009-01-28 15:56:00 -0800 Comment on attachment 27129 Preliminary primary selection paste support >Index: WebKit/gtk/ChangeLog >=================================================================== >--- WebKit/gtk/ChangeLog (revision 40327) >+++ WebKit/gtk/ChangeLog (working copy) >@@ -1,3 +1,13 @@ >+2009-01-28 Sergio García-Cuevas <sergio_gcg@hotmail.com> >+ >+ https://bugs.webkit.org/show_bug.cgi?id=17267 >+ >+ Implement primary selection support (pasting into editable regions). >+ >+ * WebCoreSupport/EditorClientGtk.cpp: >+ (WebKit::EditorClient::buttonPressed): >+ (WebKit::EditorClient::EditorClient): >+ > 2009-01-27 Brady Eidson <beidson@apple.com> > > Reviewed by Dan Bernstein >Index: WebKit/gtk/WebCoreSupport/EditorClientGtk.cpp >=================================================================== >--- WebKit/gtk/WebCoreSupport/EditorClientGtk.cpp (revision 40327) >+++ WebKit/gtk/WebCoreSupport/EditorClientGtk.cpp (working copy) >@@ -37,6 +37,23 @@ using namespace WebCore; > > namespace WebKit { > >+static void buttonPressed(GtkWidget* widget, GdkEventButton* event, EditorClient* client) >+{ >+ if (event->button == 2 && event->type == GDK_BUTTON_PRESS) { >+ Frame* frame = core(client->m_webView)->focusController()->focusedOrMainFrame(); >+ Editor* editor = frame->editor(); >+ if (editor->canPaste()) { >+ GtkClipboard* clipboard = gtk_widget_get_clipboard(GTK_WIDGET(client->m_webView), GDK_SELECTION_PRIMARY); >+ gchar* utf8 = gtk_clipboard_wait_for_text(clipboard); >+ if (utf8) { >+ String text = String::fromUTF8(utf8); >+ g_free(utf8); >+ editor->insertText(text, 0); >+ } >+ } >+ } >+} >+ > static void imContextCommitted(GtkIMContext* context, const gchar* str, EditorClient* client) > { > Frame* targetFrame = core(client->m_webView)->focusController()->focusedOrMainFrame(); >@@ -470,6 +490,7 @@ EditorClient::EditorClient(WebKitWebView > WebKitWebViewPrivate* priv = m_webView->priv; > g_signal_connect(priv->imContext, "commit", G_CALLBACK(imContextCommitted), this); > g_signal_connect(priv->imContext, "preedit-changed", G_CALLBACK(imContextPreeditChanged), this); >+ g_signal_connect_after(m_webView, "button-press-event", G_CALLBACK(buttonPressed), this); > } > > EditorClient::~EditorClient() 107428 12 sergio_gcg 2009-01-28 16:09:09 -0800 (In reply to comment #11) I misplaced the braces in my latest patch. Then I tried to correct it in an obviously wrong way. I think I should have some rest. 118469 13 24698 gustavo 2009-04-22 19:38:07 -0700 Comment on attachment 24698 Copy link locations to the primary selection > + WARNING: NO TEST CASES ADDED OR CHANGED This warning should be removed. There is no behavior change for webcore; we could probably add GTK+ unit tests for this, though, in WebKit/gtk. > +GtkClipboard* PasteboardHelperGtk::getPrimary(Frame* frame) const { > + WebKitWebView* webView = webkit_web_frame_get_web_view(kit(frame)); > + return gtk_widget_get_clipboard(GTK_WIDGET (webView), > + GDK_SELECTION_PRIMARY); > +} > + I believe the only problem with this patch is the incorrect placement of braces here. Whoever lands, please fix this, and rs=me on a second commit to fix the other braces in this file. I wonder if we should review the PasteBoard files placements as a whole, sometime. 118781 14 24698 jmalonzo 2009-04-24 17:07:30 -0700 Comment on attachment 24698 Copy link locations to the primary selection Landed in r42855. Style fixes landed in r42866. Clearing review flag. 120162 15 27129 gustavo 2009-05-06 14:54:48 -0700 Comment on attachment 27129 Preliminary primary selection paste support > +static void buttonPressed(GtkWidget* widget, GdkEventButton* event, EditorClient* client) > +{ > + if (event->button == 2 && event->type == GDK_BUTTON_PRESS) > + { > + Frame* frame = core(client->m_webView)->focusController()->focusedOrMainFrame(); > + Editor* editor = frame->editor(); > + if (editor->canPaste()) > + { The patch looks right, but the if braces are bad. They should look like this: if (a) { blahblah(); } Also, we should return early, where possible, so I would change that if to: if (!editor->canPaste()) return; I thought about suggesting making only 1 early-return if, but I believe we may want to use this callback for other features in the future, so it makes sense this way. r=me with those changes. 120179 16 27129 gustavo 2009-05-06 16:49:04 -0700 Comment on attachment 27129 Preliminary primary selection paste support Actually, this does not seem to work. The entries do not generate a button-press-event for the view. 120889 17 gustavo 2009-05-12 10:14:27 -0700 *** This bug has been marked as a duplicate of 25685 *** 21872 2008-06-22 05:09:52 -0700 2008-06-22 05:35:05 -0700 Attempt at primary clipboard support webkitclipboard.diff text/plain 1102 christian ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRWRpdG9yQ2xpZW50R3RrLmNw cCBiL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRWRpdG9yQ2xpZW50R3RrLmNwcAppbmRleCBl M2Q5MzVhLi5hODM3NzE3IDEwMDY0NAotLS0gYS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0Vk aXRvckNsaWVudEd0ay5jcHAKKysrIGIvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9FZGl0b3JD bGllbnRHdGsuY3BwCkBAIC0yOSw2ICsyOSw3IEBACiAjaW5jbHVkZSAiTm90SW1wbGVtZW50ZWQu aCIKICNpbmNsdWRlICJQYWdlLmgiCiAjaW5jbHVkZSAiUGxhdGZvcm1LZXlib2FyZEV2ZW50Lmgi CisjaW5jbHVkZSAiQ1N0cmluZy5oIgogI2luY2x1ZGUgIndlYmtpdHByaXZhdGUuaCIKIAogdXNp bmcgbmFtZXNwYWNlIFdlYkNvcmU7CkBAIC0xMzYsNyArMTM3LDE0IEBAIGJvb2wgRWRpdG9yQ2xp ZW50OjpzaG91bGRJbnNlcnRUZXh0KGNvbnN0IFN0cmluZyYsIFJhbmdlKiwgRWRpdG9ySW5zZXJ0 QWN0aW9uKQogCiBib29sIEVkaXRvckNsaWVudDo6c2hvdWxkQ2hhbmdlU2VsZWN0ZWRSYW5nZShS YW5nZSosIFJhbmdlKiwgRUFmZmluaXR5LCBib29sKQogewotICAgIG5vdEltcGxlbWVudGVkKCk7 CisgICAgRnJhbWUqIGZyYW1lID0gY29yZShtX3dlYlZpZXcpLT5mb2N1c0NvbnRyb2xsZXIoKS0+ Zm9jdXNlZE9yTWFpbkZyYW1lKCk7CisgICAgaWYgKGZyYW1lLT5zZWxlY3RlZFRleHQoKS5sZW5n dGgoKSkgeworICAgICAgICBHZGtEaXNwbGF5KiBkaXNwbGF5ID0gZ3RrX3dpZGdldF9nZXRfZGlz cGxheShHVEtfV0lER0VUKG1fd2ViVmlldykpOworICAgICAgICBHdGtDbGlwYm9hcmQqIGNsaXBi b2FyZCA9IGd0a19jbGlwYm9hcmRfZ2V0X2Zvcl9kaXNwbGF5KGRpc3BsYXksIEdES19TRUxFQ1RJ T05fUFJJTUFSWSk7CisgICAgICAgIGdjaGFyKiB0ZXh0ID0gZ19zdHJkdXAoZnJhbWUtPnNlbGVj dGVkVGV4dCgpLnV0ZjgoKS5kYXRhKCkpOworICAgICAgICBndGtfY2xpcGJvYXJkX3NldF90ZXh0 KGNsaXBib2FyZCwgdGV4dCwgLTEpOworICAgICAgICBnX2ZyZWUodGV4dCk7CisgICAgfQogICAg IHJldHVybiB0cnVlOwogfQogCg== 23321 2008-09-10 08:32:50 -0700 2008-09-10 13:32:09 -0700 Primary clipboard copy support nuanti-clipboard-sep10-2.patch text/plain 4030 alp SW5kZXg6IFdlYktpdC9ndGsvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9ndGsvQ2hh bmdlTG9nCShyZXZpc2lvbiAzNjMxOCkKKysrIFdlYktpdC9ndGsvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDgtMDktMTAgIEFscCBUb2tlciAgPGFscEBudWFu dGkuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzI2NworICAgICAgICBb R1RLXSBQcmltYXJ5IHNlbGVjdGlvbi9jbGlwYm9hcmQgc3VwcG9ydAorCisgICAgICAgIEltcGxl bWVudCBwcmltYXJ5IHNlbGVjdGlvbiBzdXBwb3J0IChjb3B5aW5nIG9ubHksIG5vIHBhc3RlIHll dCkuCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9FZGl0b3JDbGllbnRHdGsuY3BwOgorICAg ICAgICAoV2ViS2l0OjpjbGlwYm9hcmRfZ2V0X2NvbnRlbnRzX2NiKToKKyAgICAgICAgKFdlYktp dDo6Y2xpcGJvYXJkX2NsZWFyX2NvbnRlbnRzX2NiKToKKyAgICAgICAgKFdlYktpdDo6RWRpdG9y Q2xpZW50OjpyZXNwb25kVG9DaGFuZ2VkU2VsZWN0aW9uKToKKwogMjAwOC0wOS0wNyAgQ2FtZXJv biBad2FyaWNoICA8Y3d6d2FyaWNoQHV3YXRlcmxvby5jYT4KIAogICAgICAgICBSZXZpZXdlZCBi eSBNYWNpZWogU3RhY2hvd2lhay4KSW5kZXg6IFdlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRWRp dG9yQ2xpZW50R3RrLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0 L0VkaXRvckNsaWVudEd0ay5jcHAJKHJldmlzaW9uIDM2MzEyKQorKysgV2ViS2l0L2d0ay9XZWJD b3JlU3VwcG9ydC9FZGl0b3JDbGllbnRHdGsuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMCw2ICsy MCw3IEBACiAjaW5jbHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAiRWRpdG9yQ2xpZW50R3RrLmgi CiAKKyNpbmNsdWRlICJDU3RyaW5nLmgiCiAjaW5jbHVkZSAiRWRpdENvbW1hbmQuaCIKICNpbmNs dWRlICJFZGl0b3IuaCIKICNpbmNsdWRlICJGb2N1c0NvbnRyb2xsZXIuaCIKQEAgLTI5LDYgKzMw LDcgQEAKICNpbmNsdWRlICJOb3RJbXBsZW1lbnRlZC5oIgogI2luY2x1ZGUgIlBhZ2UuaCIKICNp bmNsdWRlICJQbGF0Zm9ybUtleWJvYXJkRXZlbnQuaCIKKyNpbmNsdWRlICJtYXJrdXAuaCIKICNp bmNsdWRlICJ3ZWJraXRwcml2YXRlLmgiCiAKIHVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwpAQCAt MTYyLDE3ICsxNjQsNTggQEAgdm9pZCBFZGl0b3JDbGllbnQ6OnJlc3BvbmRUb0NoYW5nZWRDb250 ZQogICAgIG5vdEltcGxlbWVudGVkKCk7CiB9CiAKKyNpZiBHVEtfQ0hFQ0tfVkVSU0lPTigyLDEw LDApCitzdGF0aWMgdm9pZCBjbGlwYm9hcmRfZ2V0X2NvbnRlbnRzX2NiKEd0a0NsaXBib2FyZCog Y2xpcGJvYXJkLCBHdGtTZWxlY3Rpb25EYXRhKiBzZWxlY3Rpb25fZGF0YSwgZ3VpbnQgaW5mbywg Z3BvaW50ZXIgZGF0YSkgeworICAgIFdlYktpdFdlYlZpZXcqIG1fd2ViVmlldyA9IHJlaW50ZXJw cmV0X2Nhc3Q8V2ViS2l0V2ViVmlldyo+KGRhdGEpOworICAgIEZyYW1lKiBmcmFtZSA9IGNvcmUo bV93ZWJWaWV3KS0+Zm9jdXNDb250cm9sbGVyKCktPmZvY3VzZWRPck1haW5GcmFtZSgpOworICAg IFBhc3NSZWZQdHI8UmFuZ2U+IHNlbGVjdGVkUmFuZ2UgPSBmcmFtZS0+c2VsZWN0aW9uKCktPnRv UmFuZ2UoKTsKKworICAgIGlmICgoZ2ludClpbmZvID09IFdFQktJVF9XRUJfVklFV19UQVJHRVRf SU5GT19IVE1MKSB7CisgICAgICAgIFN0cmluZyBtYXJrdXAgPSBjcmVhdGVNYXJrdXAoc2VsZWN0 ZWRSYW5nZS5nZXQoKSwgMCwgQW5ub3RhdGVGb3JJbnRlcmNoYW5nZSk7CisgICAgICAgIGd0a19z ZWxlY3Rpb25fZGF0YV9zZXQoc2VsZWN0aW9uX2RhdGEsIHNlbGVjdGlvbl9kYXRhLT50YXJnZXQs IDgsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmVpbnRlcnByZXRfY2FzdDxjb25z dCBndWNoYXIqPihtYXJrdXAudXRmOCgpLmRhdGEoKSksIG1hcmt1cC51dGY4KCkubGVuZ3RoKCkp OworICAgIH0gZWxzZSB7CisgICAgICAgIFN0cmluZyB0ZXh0ID0gc2VsZWN0ZWRSYW5nZS0+dGV4 dCgpOworICAgICAgICBndGtfc2VsZWN0aW9uX2RhdGFfc2V0X3RleHQoc2VsZWN0aW9uX2RhdGEs IHRleHQudXRmOCgpLmRhdGEoKSwgdGV4dC51dGY4KCkubGVuZ3RoKCkpOworICAgIH0KK30KKwor c3RhdGljIHZvaWQgY2xpcGJvYXJkX2NsZWFyX2NvbnRlbnRzX2NiKEd0a0NsaXBib2FyZCogY2xp cGJvYXJkLCBncG9pbnRlciBkYXRhKSB7CisgICAgV2ViS2l0V2ViVmlldyogbV93ZWJWaWV3ID0g cmVpbnRlcnByZXRfY2FzdDxXZWJLaXRXZWJWaWV3Kj4oZGF0YSk7CisgICAgRnJhbWUqIGZyYW1l ID0gY29yZShtX3dlYlZpZXcpLT5mb2N1c0NvbnRyb2xsZXIoKS0+Zm9jdXNlZE9yTWFpbkZyYW1l KCk7CisKKyAgICAvLyBDb2xsYXBzZSB0aGUgc2VsZWN0aW9uIHdpdGhvdXQgY2xlYXJpbmcgaXQK KyAgICBmcmFtZS0+c2VsZWN0aW9uKCktPnNldEJhc2UoZnJhbWUtPnNlbGVjdGlvbigpLT5leHRl bnQoKSwgZnJhbWUtPnNlbGVjdGlvbigpLT5hZmZpbml0eSgpKTsKK30KKyNlbmRpZgorCiB2b2lk IEVkaXRvckNsaWVudDo6cmVzcG9uZFRvQ2hhbmdlZFNlbGVjdGlvbigpCiB7CiAgICAgV2ViS2l0 V2ViVmlld1ByaXZhdGUqIHByaXYgPSBtX3dlYlZpZXctPnByaXY7Ci0KICAgICBGcmFtZSogdGFy Z2V0RnJhbWUgPSBjb3JlKG1fd2ViVmlldyktPmZvY3VzQ29udHJvbGxlcigpLT5mb2N1c2VkT3JN YWluRnJhbWUoKTsKLSAgICBpZiAoIXRhcmdldEZyYW1lIHx8ICF0YXJnZXRGcmFtZS0+ZWRpdG9y KCktPmhhc0NvbXBvc2l0aW9uKCkpCisKKyAgICBpZiAoIXRhcmdldEZyYW1lKQogICAgICAgICBy ZXR1cm47CiAKICAgICBpZiAodGFyZ2V0RnJhbWUtPmVkaXRvcigpLT5pZ25vcmVDb21wb3NpdGlv blNlbGVjdGlvbkNoYW5nZSgpKQogICAgICAgICByZXR1cm47CiAKKyNpZiBHVEtfQ0hFQ0tfVkVS U0lPTigyLDEwLDApCisgICAgR3RrQ2xpcGJvYXJkKiBjbGlwYm9hcmQgPSBndGtfd2lkZ2V0X2dl dF9jbGlwYm9hcmQoR1RLX1dJREdFVChtX3dlYlZpZXcpLCBHREtfU0VMRUNUSU9OX1BSSU1BUlkp OworICAgIGlmICh0YXJnZXRGcmFtZS0+c2VsZWN0aW9uKCktPmlzUmFuZ2UoKSkgeworICAgICAg ICBHdGtUYXJnZXRMaXN0KiB0cyA9IHdlYmtpdF93ZWJfdmlld19nZXRfY29weV90YXJnZXRfbGlz dChtX3dlYlZpZXcpOworICAgICAgICBnaW50IG5fdGFyZ2V0czsKKyAgICAgICAgR3RrVGFyZ2V0 RW50cnkqIHRhcmdldHMgPSBndGtfdGFyZ2V0X3RhYmxlX25ld19mcm9tX2xpc3QodHMsICZuX3Rh cmdldHMpOworICAgICAgICBndGtfY2xpcGJvYXJkX3NldF93aXRoX293bmVyKGNsaXBib2FyZCwg dGFyZ2V0cywgbl90YXJnZXRzLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IGNsaXBib2FyZF9nZXRfY29udGVudHNfY2IsIGNsaXBib2FyZF9jbGVhcl9jb250ZW50c19jYiwg R19PQkpFQ1QobV93ZWJWaWV3KSk7CisgICAgICAgIGd0a190YXJnZXRfdGFibGVfZnJlZSh0YXJn ZXRzLCBuX3RhcmdldHMpOworICAgIH0gZWxzZSBpZiAoZ3RrX2NsaXBib2FyZF9nZXRfb3duZXIo Y2xpcGJvYXJkKSA9PSBHX09CSkVDVChtX3dlYlZpZXcpKQorICAgICAgICBndGtfY2xpcGJvYXJk X2NsZWFyKGNsaXBib2FyZCk7CisjZW5kaWYKKworICAgIGlmICghdGFyZ2V0RnJhbWUtPmVkaXRv cigpLT5oYXNDb21wb3NpdGlvbigpKQorICAgICAgICByZXR1cm47CisKICAgICB1bnNpZ25lZCBz dGFydDsKICAgICB1bnNpZ25lZCBlbmQ7CiAgICAgaWYgKCF0YXJnZXRGcmFtZS0+ZWRpdG9yKCkt PmdldENvbXBvc2l0aW9uU2VsZWN0aW9uKHN0YXJ0LCBlbmQpKSB7Cg== 24698 2008-10-27 15:47:21 -0700 2009-04-24 17:07:30 -0700 Copy link locations to the primary selection WebKit-Gtk-copy_link_location_to_the_primary_selection.patch text/plain 4429 sergio_gcg SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzNzkwNikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjAgQEAKKzIwMDgtMTAtMjcgIFNlcmdpbyBHYXJjw61hLUN1ZXZhcyAgPHNlcmdp b19nY2dAdGVsZWZvbmljYS5uZXQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgV0FSTklORzogTk8gVEVTVCBDQVNFUyBBRERFRCBPUiBDSEFOR0VECisK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MjY3Cisg ICAgICAgIFtHVEtdIFByaW1hcnkgc2VsZWN0aW9uL2NsaXBib2FyZCBzdXBwb3J0CisKKyAgICAg ICAgQ29weSB0aGUgbGluayBsb2NhdGlvbiB0byB0aGUgcHJpbWFyeSBzZWxlY3Rpb24gYXMgd2Vs bCBhcyB0aGUKKyAgICAgICAgY2xpcGJvYXJkIHNlbGVjdGlvbiB3aGVuIHVzaW5nIHRoZSAiY29w eSBsaW5rIHNlbGVjdGlvbiIgY29udGV4dAorICAgICAgICBtZW51IGVudHJ5LgorCisgICAgICAg ICogcGxhdGZvcm0vZ3RrL1Bhc3RlYm9hcmRHdGsuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGFz dGVib2FyZDo6d3JpdGVVUkwpOgorICAgICAgICAqIHBsYXRmb3JtL2d0ay9QYXN0ZWJvYXJkSGVs cGVyLmg6CisKIDIwMDgtMTAtMjcgIEtldmluIFdhdHRlcnMgIDxrZXZpbndhdHRlcnNAZ21haWwu Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtldmluIE9sbGl2aWVyLgpJbmRleDogV2ViQ29y ZS9wbGF0Zm9ybS9ndGsvUGFzdGVib2FyZEd0ay5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9w bGF0Zm9ybS9ndGsvUGFzdGVib2FyZEd0ay5jcHAJKHJldmlzaW9uIDM3OTAxKQorKysgV2ViQ29y ZS9wbGF0Zm9ybS9ndGsvUGFzdGVib2FyZEd0ay5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEyNCw3 ICsxMjQsOSBAQCB2b2lkIFBhc3RlYm9hcmQ6OndyaXRlVVJMKGNvbnN0IEtVUkwmIHVyCiAgICAg ICAgIHJldHVybjsKIAogICAgIEd0a0NsaXBib2FyZCogY2xpcGJvYXJkID0gbV9oZWxwZXItPmdl dENsaXBib2FyZChmcmFtZSk7CisgICAgR3RrQ2xpcGJvYXJkKiBwcmltYXJ5ID0gbV9oZWxwZXIt PmdldFByaW1hcnkoZnJhbWUpOwogICAgIGd0a19jbGlwYm9hcmRfc2V0X3RleHQoY2xpcGJvYXJk LCB1cmwuc3RyaW5nKCkudXRmOCgpLmRhdGEoKSwgdXJsLnN0cmluZygpLnV0ZjgoKS5sZW5ndGgo KSk7CisgICAgZ3RrX2NsaXBib2FyZF9zZXRfdGV4dChwcmltYXJ5LCB1cmwuc3RyaW5nKCkudXRm OCgpLmRhdGEoKSwgdXJsLnN0cmluZygpLnV0ZjgoKS5sZW5ndGgoKSk7CiB9CiAKIHZvaWQgUGFz dGVib2FyZDo6d3JpdGVJbWFnZShOb2RlKiBub2RlLCBjb25zdCBLVVJMJiwgY29uc3QgU3RyaW5n JikKSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vZ3RrL1Bhc3RlYm9hcmRIZWxwZXIuaAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2d0ay9QYXN0ZWJvYXJkSGVscGVyLmgJKHJldmlzaW9u IDM3OTAxKQorKysgV2ViQ29yZS9wbGF0Zm9ybS9ndGsvUGFzdGVib2FyZEhlbHBlci5oCSh3b3Jr aW5nIGNvcHkpCkBAIC0zOCw2ICszOCw3IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIH5QYXN0ZWJv YXJkSGVscGVyKCkge307CiAKICAgICB2aXJ0dWFsIEd0a0NsaXBib2FyZCogZ2V0Q2xpcGJvYXJk KEZyYW1lKikgY29uc3QgPSAwOworICAgIHZpcnR1YWwgR3RrQ2xpcGJvYXJkKiBnZXRQcmltYXJ5 KEZyYW1lKikgY29uc3QgPSAwOwogICAgIHZpcnR1YWwgR3RrVGFyZ2V0TGlzdCogZ2V0Q29weVRh cmdldExpc3QoRnJhbWUqKSBjb25zdCA9IDA7CiAgICAgdmlydHVhbCBHdGtUYXJnZXRMaXN0KiBn ZXRQYXN0ZVRhcmdldExpc3QoRnJhbWUqKSBjb25zdCA9IDA7CiB9OwpJbmRleDogV2ViS2l0L2d0 ay9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2d0ay9DaGFuZ2VMb2cJKHJldmlzaW9u IDM3OTA2KQorKysgV2ViS2l0L2d0ay9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyAr MSwxOCBAQAorMjAwOC0xMC0yNyAgU2VyZ2lvIEdhcmPDrWEtQ3VldmFzICA8c2VyZ2lvX2djZ0B0 ZWxlZm9uaWNhLm5ldD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcyNjcKKyAg ICAgICAgW0dUS10gUHJpbWFyeSBzZWxlY3Rpb24vY2xpcGJvYXJkIHN1cHBvcnQKKworICAgICAg ICBBZGQgYSBtZXRob2QgZm9yIGdldHRpbmcgdGhlIHByaW1hcnkgc2VsZWN0aW9uLgorCisgICAg ICAgICogV2ViQ29yZVN1cHBvcnQvUGFzdGVib2FyZEhlbHBlckd0ay5jcHA6CisgICAgICAgIChX ZWJLaXQ6OlBhc3RlYm9hcmRIZWxwZXJHdGs6OmdldFByaW1hcnkpOiBOZXcgbWV0aG9kIHRoYXQg cmV0dXJucyB0aGUKKyAgICAgICAgcHJpbWFyeSBzZWxlY3Rpb24ganVzdCBsaWtlIFdlYktpdDo6 UGFzdGVib2FyZEhlbHBlckd0azo6Z2V0Q2xpcGJvYXJkCisgICAgICAgIHJldHVybnMgdGhlIGNs aXBib2FyZCBzZWxlY3Rpb24uCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvUGFzdGVib2FyZEhl bHBlckd0ay5oOgorCiAyMDA4LTEwLTI3ICBNaWNoYWVsIFRyb3NzICA8bWljaGFlbEB0cm9zcy5v cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWxwIFRva2VyLiBMYW5kZWQgYnkgSmFuIEFsb256 by4KSW5kZXg6IFdlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvUGFzdGVib2FyZEhlbHBlckd0ay5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9QYXN0ZWJvYXJkSGVs cGVyR3RrLmNwcAkocmV2aXNpb24gMzc5MDEpCisrKyBXZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0 L1Bhc3RlYm9hcmRIZWxwZXJHdGsuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNyw2ICszNywxMiBA QCBHdGtDbGlwYm9hcmQqIFBhc3RlYm9hcmRIZWxwZXJHdGs6OmdldENsCiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBHREtfU0VMRUNUSU9OX0NMSVBCT0FSRCk7CiB9CiAKK0d0 a0NsaXBib2FyZCogUGFzdGVib2FyZEhlbHBlckd0azo6Z2V0UHJpbWFyeShGcmFtZSogZnJhbWUp IGNvbnN0IHsKKyAgICBXZWJLaXRXZWJWaWV3KiB3ZWJWaWV3ID0gd2Via2l0X3dlYl9mcmFtZV9n ZXRfd2ViX3ZpZXcoa2l0KGZyYW1lKSk7CisgICAgcmV0dXJuIGd0a193aWRnZXRfZ2V0X2NsaXBi b2FyZChHVEtfV0lER0VUICh3ZWJWaWV3KSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIEdES19TRUxFQ1RJT05fUFJJTUFSWSk7Cit9CisKIEd0a1RhcmdldExpc3QqIFBhc3Rl Ym9hcmRIZWxwZXJHdGs6OmdldENvcHlUYXJnZXRMaXN0KEZyYW1lKiBmcmFtZSkgY29uc3Qgewog ICAgIFdlYktpdFdlYlZpZXcqIHdlYlZpZXcgPSB3ZWJraXRfd2ViX2ZyYW1lX2dldF93ZWJfdmll dyhraXQoZnJhbWUpKTsKICAgICByZXR1cm4gd2Via2l0X3dlYl92aWV3X2dldF9jb3B5X3Rhcmdl dF9saXN0KHdlYlZpZXcpOwpJbmRleDogV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9QYXN0ZWJv YXJkSGVscGVyR3RrLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9Q YXN0ZWJvYXJkSGVscGVyR3RrLmgJKHJldmlzaW9uIDM3OTAxKQorKysgV2ViS2l0L2d0ay9XZWJD b3JlU3VwcG9ydC9QYXN0ZWJvYXJkSGVscGVyR3RrLmgJKHdvcmtpbmcgY29weSkKQEAgLTQwLDYg KzQwLDcgQEAgY2xhc3MgUGFzdGVib2FyZEhlbHBlckd0ayA6IHB1YmxpYyBQYXN0ZQogcHVibGlj OgogICAgIFBhc3RlYm9hcmRIZWxwZXJHdGsoKSB7IH0KICAgICB2aXJ0dWFsIEd0a0NsaXBib2Fy ZCogZ2V0Q2xpcGJvYXJkKEZyYW1lKikgY29uc3Q7CisgICAgdmlydHVhbCBHdGtDbGlwYm9hcmQq IGdldFByaW1hcnkoRnJhbWUqKSBjb25zdDsKICAgICB2aXJ0dWFsIEd0a1RhcmdldExpc3QqIGdl dENvcHlUYXJnZXRMaXN0KEZyYW1lKikgY29uc3Q7CiAgICAgdmlydHVhbCBHdGtUYXJnZXRMaXN0 KiBnZXRQYXN0ZVRhcmdldExpc3QoRnJhbWUqKSBjb25zdDsKIH07Cg== 27129 2009-01-28 15:46:33 -0800 2009-05-06 16:49:04 -0700 Preliminary primary selection paste support WebKit-primary_selection_paste.patch text/plain 2302 sergio_gcg SW5kZXg6IFdlYktpdC9ndGsvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9ndGsvQ2hh bmdlTG9nCShyZXZpc2lvbiA0MDMyNykKKysrIFdlYktpdC9ndGsvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMDEtMjggIFNlcmdpbyBHYXJjw61hLUN1ZXZh cyA8c2VyZ2lvX2djZ0Bob3RtYWlsLmNvbT4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcyNjcKKworICAgICAgICBJbXBsZW1lbnQgcHJpbWFyeSBz ZWxlY3Rpb24gc3VwcG9ydCAocGFzdGluZyBpbnRvIGVkaXRhYmxlIHJlZ2lvbnMpLgorCisgICAg ICAgICogV2ViQ29yZVN1cHBvcnQvRWRpdG9yQ2xpZW50R3RrLmNwcDoKKyAgICAgICAgKFdlYktp dDo6RWRpdG9yQ2xpZW50OjpidXR0b25QcmVzc2VkKToKKyAgICAgICAgKFdlYktpdDo6RWRpdG9y Q2xpZW50OjpFZGl0b3JDbGllbnQpOgorCiAyMDA5LTAxLTI3ICBCcmFkeSBFaWRzb24gIDxiZWlk c29uQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYW4gQmVybnN0ZWluCkluZGV4 OiBXZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0VkaXRvckNsaWVudEd0ay5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9FZGl0b3JDbGllbnRHdGsuY3BwCShyZXZp c2lvbiA0MDMyNykKKysrIFdlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRWRpdG9yQ2xpZW50R3Rr LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzcsNiArMzcsMjYgQEAgdXNpbmcgbmFtZXNwYWNlIFdl YkNvcmU7CiAKIG5hbWVzcGFjZSBXZWJLaXQgewogCitzdGF0aWMgdm9pZCBidXR0b25QcmVzc2Vk KEd0a1dpZGdldCogd2lkZ2V0LCBHZGtFdmVudEJ1dHRvbiogZXZlbnQsIEVkaXRvckNsaWVudCog Y2xpZW50KQoreworICAgIGlmIChldmVudC0+YnV0dG9uID09IDIgJiYgZXZlbnQtPnR5cGUgPT0g R0RLX0JVVFRPTl9QUkVTUykKKyAgICB7CisgICAgICAgIEZyYW1lKiBmcmFtZSA9IGNvcmUoY2xp ZW50LT5tX3dlYlZpZXcpLT5mb2N1c0NvbnRyb2xsZXIoKS0+Zm9jdXNlZE9yTWFpbkZyYW1lKCk7 CisgICAgICAgIEVkaXRvciogZWRpdG9yID0gZnJhbWUtPmVkaXRvcigpOworICAgICAgICBpZiAo ZWRpdG9yLT5jYW5QYXN0ZSgpKQorICAgICAgICB7CisgICAgICAgICAgICBHdGtDbGlwYm9hcmQq IGNsaXBib2FyZCA9IGd0a193aWRnZXRfZ2V0X2NsaXBib2FyZChHVEtfV0lER0VUKGNsaWVudC0+ bV93ZWJWaWV3KSwgR0RLX1NFTEVDVElPTl9QUklNQVJZKTsKKyAgICAgICAgICAgIGdjaGFyKiB1 dGY4ID0gZ3RrX2NsaXBib2FyZF93YWl0X2Zvcl90ZXh0KGNsaXBib2FyZCk7CisgICAgICAgICAg ICBpZiAodXRmOCkKKyAgICAgICAgICAgIHsKKyAgICAgICAgICAgICAgICBTdHJpbmcgdGV4dCA9 IFN0cmluZzo6ZnJvbVVURjgodXRmOCk7CisgICAgICAgICAgICAgICAgZ19mcmVlKHV0ZjgpOwor ICAgICAgICAgICAgICAgIGVkaXRvci0+aW5zZXJ0VGV4dCh0ZXh0LCAwKTsKKyAgICAgICAgICAg IH0KKyAgICAgICAgfQorICAgIH0KK30KKwogc3RhdGljIHZvaWQgaW1Db250ZXh0Q29tbWl0dGVk KEd0a0lNQ29udGV4dCogY29udGV4dCwgY29uc3QgZ2NoYXIqIHN0ciwgRWRpdG9yQ2xpZW50KiBj bGllbnQpCiB7CiAgICAgRnJhbWUqIHRhcmdldEZyYW1lID0gY29yZShjbGllbnQtPm1fd2ViVmll dyktPmZvY3VzQ29udHJvbGxlcigpLT5mb2N1c2VkT3JNYWluRnJhbWUoKTsKQEAgLTQ3MCw2ICs0 OTAsNyBAQCBFZGl0b3JDbGllbnQ6OkVkaXRvckNsaWVudChXZWJLaXRXZWJWaWV3CiAgICAgV2Vi S2l0V2ViVmlld1ByaXZhdGUqIHByaXYgPSBtX3dlYlZpZXctPnByaXY7CiAgICAgZ19zaWduYWxf Y29ubmVjdChwcml2LT5pbUNvbnRleHQsICJjb21taXQiLCBHX0NBTExCQUNLKGltQ29udGV4dENv bW1pdHRlZCksIHRoaXMpOwogICAgIGdfc2lnbmFsX2Nvbm5lY3QocHJpdi0+aW1Db250ZXh0LCAi cHJlZWRpdC1jaGFuZ2VkIiwgR19DQUxMQkFDSyhpbUNvbnRleHRQcmVlZGl0Q2hhbmdlZCksIHRo aXMpOworICAgIGdfc2lnbmFsX2Nvbm5lY3RfYWZ0ZXIobV93ZWJWaWV3LCAiYnV0dG9uLXByZXNz LWV2ZW50IiwgR19DQUxMQkFDSyhidXR0b25QcmVzc2VkKSwgdGhpcyk7CiB9CiAKIEVkaXRvckNs aWVudDo6fkVkaXRvckNsaWVudCgpCg==