172667 2017-05-26 15:24:44 -0700 Don't use designated initializers in WebBackForwardListProxy.cpp 2017-06-29 21:12:39 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 174003 1 annulen annulen achristensen andersca basuke cdumez commit-queue don.olmstead ggaren mcatanzaro sam thorton webkit-bug-importer oldest_to_newest 1313274 0 annulen 2017-05-26 15:24:44 -0700 Designated initializers are not defined by C++ standard, and are not supported by MSVC. 1313275 1 311382 annulen 2017-05-26 15:25:54 -0700 Created attachment 311382 Patch 1313440 2 sam 2017-05-27 16:01:41 -0700 WebKit2 does not support MSVC at this time, so I don't really see the point of this. 1313454 3 don.olmstead 2017-05-27 18:48:32 -0700 (In reply to Sam Weinig from comment #2) > WebKit2 does not support MSVC at this time, so I don't really see the point > of this. We have some devs who have started preliminary work on WK2 for Windows. The Qt port has some of this functionality so we'd like to start landing it for WinCairo. 1313464 4 sam 2017-05-27 20:58:13 -0700 We explicitly removed support for Windows a little while ago, so I think a discussion on the mailing list is probably warranted to consider bringing it back. 1313468 5 annulen 2017-05-28 00:55:55 -0700 (In reply to Sam Weinig from comment #4) > We explicitly removed support for Windows a little while ago, so I think a > discussion on the mailing list is probably warranted to consider bringing it > back. I think there is a big difference between upstreaming Windows support in WK2, and just making port-independent code standards-compliant so people can use it in downstreams. 1313623 6 mcatanzaro 2017-05-29 19:08:10 -0700 (In reply to Konstantin Tokarev from comment #5) > I think there is a big difference between upstreaming Windows support in > WK2, and just making port-independent code standards-compliant so people can > use it in downstreams. Yeah, Sam has a good point here regarding Windows support, but this patch seems good to me anyway as it is valuable to avoid nonstandard compiler features when they are unnecessary. (FWIW: there are lots of projects that are missing Windows support for WebKitGTK+ and would love to have it -- e.g. Pidgen, GIMP, GnuCash -- but I doubt Igalia would be interested in maintaining it.) 1313664 7 annulen 2017-05-30 02:32:37 -0700 (In reply to Michael Catanzaro from comment #6) > (In reply to Konstantin Tokarev from comment #5) > > I think there is a big difference between upstreaming Windows support in > > WK2, and just making port-independent code standards-compliant so people can > > use it in downstreams. > > Yeah, Sam has a good point here regarding Windows support, but this patch > seems good to me anyway as it is valuable to avoid nonstandard compiler > features when they are unnecessary. > > (FWIW: there are lots of projects that are missing Windows support for > WebKitGTK+ and would love to have it -- e.g. Pidgen, GIMP, GnuCash -- but I > doubt Igalia would be interested in maintaining it.) Note that Windows IPC works fine in my branch, so it maintaining WK2 for Igalia would be a matter of maintaining GTK-specific changes 1313780 8 311382 achristensen 2017-05-30 11:05:48 -0700 Comment on attachment 311382 Patch I think we should be ok with upstreaming this patch and others like it. We should definitely discuss on webkit-dev before resurrecting or writing anew lots of Windows WK2 code. 1313792 9 311382 commit-queue 2017-05-30 11:34:58 -0700 Comment on attachment 311382 Patch Clearing flags on attachment: 311382 Committed r217564: <http://trac.webkit.org/changeset/217564> 1313793 10 commit-queue 2017-05-30 11:35:00 -0700 All reviewed patches have been landed. Closing bug. 1314011 11 webkit-bug-importer 2017-05-30 20:20:49 -0700 <rdar://problem/32479690> 311382 2017-05-26 15:25:54 -0700 2017-05-30 11:34:58 -0700 Patch bug-172667-20170527012553.patch text/plain 2042 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMjE3NTAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZjEzNGJiZjgxNWZlNTdj ZDkxMGEyYTYxNzFiMDM4MzU5ODBmODNkYy4uYTM3OWQwYTMwYWYwODI3NzI3N2RiYzIwNGUxYWM5 YmViMTQ1Zjk5MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE3LTA1LTI2ICBLb25z dGFudGluIFRva2FyZXYgIDxhbm51bGVuQHlhbmRleC5ydT4KKworICAgICAgICBEb24ndCB1c2Ug ZGVzaWduYXRlZCBpbml0aWFsaXplcnMgaW4gV2ViQmFja0ZvcndhcmRMaXN0UHJveHkuY3BwCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzI2NjcKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYlByb2Nl c3MvV2ViUGFnZS9XZWJCYWNrRm9yd2FyZExpc3RQcm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6 OldlYkJhY2tGb3J3YXJkTGlzdFByb3h5OjphZGRJdGVtRnJvbVVJUHJvY2Vzcyk6CisgICAgICAg IChXZWJLaXQ6OldlYkJhY2tGb3J3YXJkTGlzdFByb3h5OjphZGRJdGVtKToKKwogMjAxNy0wNS0y NiAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5y ZXZpZXdlZCwgcm9sbGluZyBvdXQgcjIxNzQ3OS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQy L1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJCYWNrRm9yd2FyZExpc3RQcm94eS5jcHAgYi9Tb3VyY2Uv V2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViQmFja0ZvcndhcmRMaXN0UHJveHkuY3BwCmlu ZGV4IGYyZThlY2Q2MDE5YzBkMDRjNGE1NDE1NDNkZTZiNTYyZDI1N2FiMWUuLmRmNzUwM2QyNzI3 ZWU4MzMyZDRiZjg3MTM5OTY2NzFiYjY4OGFhOWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQy L1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJCYWNrRm9yd2FyZExpc3RQcm94eS5jcHAKKysrIGIvU291 cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYkJhY2tGb3J3YXJkTGlzdFByb3h5LmNw cApAQCAtMTAwLDcgKzEwMCw3IEBAIHZvaWQgV2ViQmFja0ZvcndhcmRMaXN0UHJveHk6OmFkZEl0 ZW1Gcm9tVUlQcm9jZXNzKHVpbnQ2NF90IGl0ZW1JRCwgUmVmPEhpc3RvcnlJCiAgICAgQVNTRVJU KCFoaXN0b3J5SXRlbVRvSURNYXAoKS5jb250YWlucyhpdGVtLnB0cigpKSk7CiAgICAgQVNTRVJU KCFpZFRvSGlzdG9yeUl0ZW1NYXAoKS5jb250YWlucyhpdGVtSUQpKTsKIAotICAgIGhpc3RvcnlJ dGVtVG9JRE1hcCgpLnNldDxJdGVtQW5kUGFnZUlEPihpdGVtLnB0cigpLCB7IC5pdGVtSUQgPSBp dGVtSUQsIC5wYWdlSUQgPSBwYWdlSUQgfSk7CisgICAgaGlzdG9yeUl0ZW1Ub0lETWFwKCkuc2V0 PEl0ZW1BbmRQYWdlSUQ+KGl0ZW0ucHRyKCksIHsgaXRlbUlELCBwYWdlSUQgfSk7CiAgICAgaWRU b0hpc3RvcnlJdGVtTWFwKCkuc2V0KGl0ZW1JRCwgaXRlbS5wdHIoKSk7CiB9CiAKQEAgLTE1Miw3 ICsxNTIsNyBAQCB2b2lkIFdlYkJhY2tGb3J3YXJkTGlzdFByb3h5OjphZGRJdGVtKFJlZjxIaXN0 b3J5SXRlbT4mJiBpdGVtKQogCiAgICAgQVNTRVJUKCFpZFRvSGlzdG9yeUl0ZW1NYXAoKS5jb250 YWlucyhpdGVtSUQpKTsKIAotICAgIGhpc3RvcnlJdGVtVG9JRE1hcCgpLnNldDxJdGVtQW5kUGFn ZUlEPihpdGVtLnB0cigpLCB7IC5pdGVtSUQgPSBpdGVtSUQsIC5wYWdlSUQgPSBtX3BhZ2UtPnBh Z2VJRCgpIH0pOworICAgIGhpc3RvcnlJdGVtVG9JRE1hcCgpLnNldDxJdGVtQW5kUGFnZUlEPihp dGVtLnB0cigpLCB7IGl0ZW1JRCwgbV9wYWdlLT5wYWdlSUQoKSB9KTsKICAgICBpZFRvSGlzdG9y eUl0ZW1NYXAoKS5zZXQoaXRlbUlELCBpdGVtLnB0cigpKTsKIAogICAgIHVwZGF0ZUJhY2tGb3J3 YXJkSXRlbShpdGVtSUQsIG1fcGFnZS0+cGFnZUlEKCksIGl0ZW0ucHRyKCkpOwo=