172654 2017-05-26 12:28:33 -0700 REEGRESSION(r217459): testapi fails in JSExportTest's wrapperForNSObjectisObject(). 2017-05-30 20:21:09 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam keith_miller buildbot commit-queue keith_miller msaboff saam webkit-bug-importer oldest_to_newest 1313195 0 mark.lam 2017-05-26 12:28:33 -0700 After r217459, we get: ... 2017-05-26 12:15:07.775 testapi[92608:83259983] TEST: "Should not throw an exception when wrapping NSObject and Object has been changed": FAILED ... FAIL: Some tests failed. 1313283 1 311386 keith_miller 2017-05-26 15:47:10 -0700 Created attachment 311386 Patch 1313288 2 311386 mark.lam 2017-05-26 15:56:27 -0700 Comment on attachment 311386 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=311386&action=review r=me with suggestion. > Source/JavaScriptCore/ChangeLog:8 > + Fix the test to make sure we don't not check for an exception. How about rephrasing this as: The test's intent is to assert that an exception has not been thrown (as indicated by the message string), but the test was erroneously checking for the opposite condition. This is now fixed. 1313339 3 311386 keith_miller 2017-05-26 18:45:54 -0700 Comment on attachment 311386 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=311386&action=review >> Source/JavaScriptCore/ChangeLog:8 >> + Fix the test to make sure we don't not check for an exception. > > How about rephrasing this as: > The test's intent is to assert that an exception has not been thrown (as indicated by the message string), but the test was erroneously checking for the opposite condition. This is now fixed. I changed it to: "The test's intent is to assert that an exception has not been thrown (as indicated by the message string), but the test was erroneously checking for !! the condition. This is now fixed." gotta preserve my pun.. 1313340 4 keith_miller 2017-05-26 18:49:37 -0700 Actually, make that: The test's intent is to assert that an exception has not been thrown (as indicated by the message string), but the test was erroneously checking for ! the right condition. This is now fixed. 1313342 5 311402 keith_miller 2017-05-26 18:54:54 -0700 Created attachment 311402 Patch for landing 1313345 6 311402 commit-queue 2017-05-26 19:33:12 -0700 Comment on attachment 311402 Patch for landing Clearing flags on attachment: 311402 Committed r217517: <http://trac.webkit.org/changeset/217517> 1313346 7 commit-queue 2017-05-26 19:33:14 -0700 All reviewed patches have been landed. Closing bug. 1314018 8 webkit-bug-importer 2017-05-30 20:21:09 -0700 <rdar://problem/32479700> 311386 2017-05-26 15:47:10 -0700 2017-05-26 18:54:53 -0700 Patch bug-172654-20170526154710.patch text/plain 1627 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjE3NTA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBi NjQ2YTE1MWI5MzU1M2YzMTA1NDdjNmY5NWFiMDA2NWViOTFjODA4Li4wZTIzNjlhZWM4N2E2ZThh NGM3ZWM3NWFjYWJhNmNkNjQ2MzM5ZWE2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxNy0wNS0yNiAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBSRUVHUkVTU0lPTihyMjE3NDU5KTogdGVzdGFwaSBmYWlscyBpbiBK U0V4cG9ydFRlc3QncyB3cmFwcGVyRm9yTlNPYmplY3Rpc09iamVjdCgpLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcyNjU0CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IHRoZSB0ZXN0IHRvIG1ha2Ug c3VyZSB3ZSBkb24ndCBub3QgY2hlY2sgZm9yIGFuIGV4Y2VwdGlvbi4KKworICAgICAgICAqIEFQ SS90ZXN0cy9KU0V4cG9ydFRlc3RzLm1tOgorICAgICAgICAod3JhcHBlckZvck5TT2JqZWN0aXNP YmplY3QpOgorCiAyMDE3LTA1LTI2ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KIAog ICAgICAgICBUZW1wb3JhcmlseSBjb21tZW50aW5nIG91dCBhIEpTRXhwb3J0VGVzdCB0ZXN0IHVu dGlsIHdlYmtpdC5vcmcvYi8xNzI2NTQgaXMgZml4ZWQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQVBJL3Rlc3RzL0pTRXhwb3J0VGVzdHMubW0gYi9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQVBJL3Rlc3RzL0pTRXhwb3J0VGVzdHMubW0KaW5kZXggYzhhYTBmOTA4MGY0MGVlODU4 MWQ3OWM2MGJkMDFhNTNjMDFmZTBiYi4uODQ3NmYxZmQ2MGJkNDVhMTIzM2RmOTk2ZmZkYjZmZmEy ODVmYmI4ZiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS90ZXN0cy9KU0V4 cG9ydFRlc3RzLm1tCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvdGVzdHMvSlNFeHBv cnRUZXN0cy5tbQpAQCAtMTYxLDggKzE2MSw3IEBAIHN0YXRpYyB2b2lkIHdyYXBwZXJGb3JOU09i amVjdGlzT2JqZWN0KCkKICAgICAgICAgY29udGV4dC5leGNlcHRpb24gPSBuaWw7CiAKICAgICAg ICAgY29udGV4dFtAIkEiXSA9IE5TT2JqZWN0LmNsYXNzOwotICAgICAgICAvLyBGSVhNRTogaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MjY1NAotICAgICAgICAvLyBj aGVja1Jlc3VsdChAIlNob3VsZCBub3QgdGhyb3cgYW4gZXhjZXB0aW9uIHdoZW4gd3JhcHBpbmcg TlNPYmplY3QgYW5kIE9iamVjdCBoYXMgYmVlbiBjaGFuZ2VkIiwgW2NvbnRleHQgZXhjZXB0aW9u XSk7CisgICAgICAgIGNoZWNrUmVzdWx0KEAiU2hvdWxkIG5vdCB0aHJvdyBhbiBleGNlcHRpb24g d2hlbiB3cmFwcGluZyBOU09iamVjdCBhbmQgT2JqZWN0IGhhcyBiZWVuIGNoYW5nZWQiLCAhW2Nv bnRleHQgZXhjZXB0aW9uXSk7CiAgICAgfQogfQogCg== 311402 2017-05-26 18:54:54 -0700 2017-05-26 19:33:12 -0700 Patch for landing bug-172654-20170526185453.patch text/plain 1767 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjE3NTA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBi NjQ2YTE1MWI5MzU1M2YzMTA1NDdjNmY5NWFiMDA2NWViOTFjODA4Li4yNTA4Njc4NTc4NTM0M2Qx MWMwOTIyZDA4NzNlZDE1MGQ0MTUxYjI4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxNy0wNS0yNiAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBSRUVHUkVTU0lPTihyMjE3NDU5KTogdGVzdGFwaSBmYWlscyBpbiBK U0V4cG9ydFRlc3QncyB3cmFwcGVyRm9yTlNPYmplY3Rpc09iamVjdCgpLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcyNjU0CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTWFyayBMYW0uCisKKyAgICAgICAgVGhlIHRlc3QncyBpbnRlbnQgaXMgdG8gYXNz ZXJ0IHRoYXQgYW4gZXhjZXB0aW9uIGhhcyBub3QgYmVlbgorICAgICAgICB0aHJvd24gKGFzIGlu ZGljYXRlZCBieSB0aGUgbWVzc2FnZSBzdHJpbmcpLCBidXQgdGhlIHRlc3Qgd2FzCisgICAgICAg IGVycm9uZW91c2x5IGNoZWNraW5nIGZvciAhIHRoZSByaWdodCBjb25kaXRpb24uIFRoaXMgaXMg bm93IGZpeGVkLgorCisgICAgICAgICogQVBJL3Rlc3RzL0pTRXhwb3J0VGVzdHMubW06CisgICAg ICAgICh3cmFwcGVyRm9yTlNPYmplY3Rpc09iamVjdCk6CisKIDIwMTctMDUtMjYgIE1hcmsgTGFt ICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAgIFRlbXBvcmFyaWx5IGNvbW1lbnRpbmcg b3V0IGEgSlNFeHBvcnRUZXN0IHRlc3QgdW50aWwgd2Via2l0Lm9yZy9iLzE3MjY1NCBpcyBmaXhl ZC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvdGVzdHMvSlNFeHBvcnRU ZXN0cy5tbSBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvdGVzdHMvSlNFeHBvcnRUZXN0cy5t bQppbmRleCBjOGFhMGY5MDgwZjQwZWU4NTgxZDc5YzYwYmQwMWE1M2MwMWZlMGJiLi44NDc2ZjFm ZDYwYmQ0NWExMjMzZGY5OTZmZmRiNmZmYTI4NWZiYjhmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQVBJL3Rlc3RzL0pTRXhwb3J0VGVzdHMubW0KKysrIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL0FQSS90ZXN0cy9KU0V4cG9ydFRlc3RzLm1tCkBAIC0xNjEsOCArMTYxLDcgQEAg c3RhdGljIHZvaWQgd3JhcHBlckZvck5TT2JqZWN0aXNPYmplY3QoKQogICAgICAgICBjb250ZXh0 LmV4Y2VwdGlvbiA9IG5pbDsKIAogICAgICAgICBjb250ZXh0W0AiQSJdID0gTlNPYmplY3QuY2xh c3M7Ci0gICAgICAgIC8vIEZJWE1FOiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTcyNjU0Ci0gICAgICAgIC8vIGNoZWNrUmVzdWx0KEAiU2hvdWxkIG5vdCB0aHJvdyBh biBleGNlcHRpb24gd2hlbiB3cmFwcGluZyBOU09iamVjdCBhbmQgT2JqZWN0IGhhcyBiZWVuIGNo YW5nZWQiLCBbY29udGV4dCBleGNlcHRpb25dKTsKKyAgICAgICAgY2hlY2tSZXN1bHQoQCJTaG91 bGQgbm90IHRocm93IGFuIGV4Y2VwdGlvbiB3aGVuIHdyYXBwaW5nIE5TT2JqZWN0IGFuZCBPYmpl Y3QgaGFzIGJlZW4gY2hhbmdlZCIsICFbY29udGV4dCBleGNlcHRpb25dKTsKICAgICB9CiB9CiAK