172651 2017-05-26 11:23:49 -0700 REGRESSION(216914): testCFStrings encounters an invalid ExecState callee pointer. 2017-05-30 20:21:12 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam buildbot keith_miller msaboff saam webkit-bug-importer ysuzuki oldest_to_newest 1313179 0 mark.lam 2017-05-26 11:23:49 -0700 This is because the assertion utility functions used in testCFStrings() expects to get the JSGlobalContextRef from the global context variable. However, testCFStrings() creates its own JSGlobalContextRef but does not set the global context variable to it. 1313182 1 311363 mark.lam 2017-05-26 11:28:37 -0700 Created attachment 311363 proposed patch. 1313186 2 mark.lam 2017-05-26 11:46:25 -0700 Thanks for the review. Landed in r217498: <http://trac.webkit.org/r217498>. 1314019 3 webkit-bug-importer 2017-05-30 20:21:12 -0700 <rdar://problem/32479707> 311363 2017-05-26 11:28:37 -0700 2017-05-26 11:37:43 -0700 proposed patch. bug-172651.patch text/plain 2054 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjE3NDk3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA CisyMDE3LTA1LTI2ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBS RUdSRVNTSU9OKDIxNjkxNCk6IHRlc3RDRlN0cmluZ3MgZW5jb3VudGVycyBhbiBpbnZhbGlkIEV4 ZWNTdGF0ZSBjYWxsZWUgcG9pbnRlci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE3MjY1MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFRoaXMgaXMgYmVjYXVzZSB0aGUgYXNzZXJ0aW9uIHV0aWxpdHkgZnVu Y3Rpb25zIHVzZWQgaW4gdGVzdENGU3RyaW5ncygpIGV4cGVjdHMKKyAgICAgICAgdG8gZ2V0IHRo ZSBKU0dsb2JhbENvbnRleHRSZWYgZnJvbSB0aGUgZ2xvYmFsIGNvbnRleHQgdmFyaWFibGUuICBI b3dldmVyLAorICAgICAgICB0ZXN0Q0ZTdHJpbmdzKCkgY3JlYXRlcyBpdHMgb3duIEpTR2xvYmFs Q29udGV4dFJlZiBidXQgZG9lcyBub3Qgc2V0IHRoZSBnbG9iYWwKKyAgICAgICAgY29udGV4dCB2 YXJpYWJsZSB0byBpdC4KKworICAgICAgICBUaGUgZml4IGlzIHRvIG1ha2UgdGVzdENGU3RyaW5n cygpIGluaXRpYWxpemUgdGhlIGdsb2JhbCBjb250ZXh0IHZhcmlhYmxlIHByb3Blcmx5LgorCisg ICAgICAgICogQVBJL3Rlc3RzL3Rlc3RhcGkuYzoKKyAgICAgICAgKHRlc3RDRlN0cmluZ3MpOgor CiAyMDE3LTA1LTI2ICBZdXN1a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgogCiAg ICAgICAgIEdpdmUgTW9kdWxlUHJvZ3JhbSB0aGUgc2FtZSB0cmVhdG1lbnQgdGhhdCB3ZSBkaWQg Zm9yIFByb2dyYW1Db2RlIGluIGJ1ZyMxNjc3MjUKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9BUEkvdGVzdHMvdGVzdGFwaS5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9BUEkvdGVzdHMvdGVzdGFwaS5jCShyZXZpc2lvbiAyMTc0NzEpCisrKyBTb3VyY2UvSmF2YVNj cmlwdENvcmUvQVBJL3Rlc3RzL3Rlc3RhcGkuYwkod29ya2luZyBjb3B5KQpAQCAtMTIzOSw3ICsx MjM5LDEwIEBAIHN0YXRpYyB2b2lkIHRlc3RNYXJraW5nQ29uc3RyYWludHNBbmRIZWEKICNpZiBV U0UoQ0YpCiBzdGF0aWMgdm9pZCB0ZXN0Q0ZTdHJpbmdzKHZvaWQpCiB7Ci0gICAgSlNHbG9iYWxD b250ZXh0UmVmIGNvbnRleHQgPSBKU0dsb2JhbENvbnRleHRDcmVhdGUoMCk7CisgICAgLyogVGhl IGFzc2VydGlvbiB1dGlsaXR5IGZ1bmN0aW9ucyB3ZSB1c2UgYmVsb3cgZXhwZWN0cyB0byBnZXQg dGhlIEpTR2xvYmFsQ29udGV4dFJlZgorICAgICAgIGZyb20gdGhlIGdsb2JhbCBjb250ZXh0IHZh cmlhYmxlLiAqLworICAgIEpTR2xvYmFsQ29udGV4dFJlZiBvbGRDb250ZXh0ID0gY29udGV4dDsK KyAgICBjb250ZXh0ID0gSlNHbG9iYWxDb250ZXh0Q3JlYXRlKDApOwogCiAgICAgVW5pQ2hhciBz aW5nbGVVbmlDaGFyID0gNjU7IC8vIENhcGl0YWwgQQogICAgIENGTXV0YWJsZVN0cmluZ1JlZiBj ZlN0cmluZyA9IENGU3RyaW5nQ3JlYXRlTXV0YWJsZVdpdGhFeHRlcm5hbENoYXJhY3RlcnNOb0Nv cHkoa0NGQWxsb2NhdG9yRGVmYXVsdCwgJnNpbmdsZVVuaUNoYXIsIDEsIDEsIGtDRkFsbG9jYXRv ck51bGwpOwpAQCAtMTMzMiw2ICsxMzM1LDcgQEAgc3RhdGljIHZvaWQgdGVzdENGU3RyaW5ncyh2 b2lkKQogICAgIENGUmVsZWFzZShjZkVtcHR5U3RyaW5nKTsKIAogICAgIEpTR2xvYmFsQ29udGV4 dFJlbGVhc2UoY29udGV4dCk7CisgICAgY29udGV4dCA9IG9sZENvbnRleHQ7CiB9CiAjZW5kaWYK IAo=