<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>172649</bug_id>
          
          <creation_ts>2017-05-26 10:18:33 -0700</creation_ts>
          <short_desc>webrtc/peer-connection-audio-mute.html is sometimes flaky</short_desc>
          <delta_ts>2017-09-27 12:51:42 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Media</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=172827</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="youenn fablet">youennf</reporter>
          <assigned_to name="youenn fablet">youennf</assigned_to>
          <cc>achristensen</cc>
    
    <cc>cdumez</cc>
    
    <cc>commit-queue</cc>
    
    <cc>darin</cc>
    
    <cc>jlewis3</cc>
    
    <cc>jonlee</cc>
    
    <cc>ryanhaddad</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1313168</commentid>
    <comment_count>0</comment_count>
    <who name="youenn fablet">youennf</who>
    <bug_when>2017-05-26 10:18:33 -0700</bug_when>
    <thetext>webrtc/peer-connection-audio-mute.html is sometimes flaky</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1313170</commentid>
    <comment_count>1</comment_count>
      <attachid>311360</attachid>
    <who name="youenn fablet">youennf</who>
    <bug_when>2017-05-26 10:19:49 -0700</bug_when>
    <thetext>Created attachment 311360
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1313172</commentid>
    <comment_count>2</comment_count>
      <attachid>311360</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2017-05-26 10:27:18 -0700</bug_when>
    <thetext>Comment on attachment 311360
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311360&amp;action=review

&gt; LayoutTests/webrtc/peer-connection-audio-mute.html:13
&gt; +    function ensureHumIsAsExpected(remoteStream, heardHum, count)

I think we should rename heardHum here to shouldHeadHum since this is an expected result, not a result.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1313180</commentid>
    <comment_count>3</comment_count>
      <attachid>311362</attachid>
    <who name="youenn fablet">youennf</who>
    <bug_when>2017-05-26 11:27:30 -0700</bug_when>
    <thetext>Created attachment 311362
Fixing according comments</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1313181</commentid>
    <comment_count>4</comment_count>
    <who name="youenn fablet">youennf</who>
    <bug_when>2017-05-26 11:28:13 -0700</bug_when>
    <thetext>Thanks for the review.

(In reply to Chris Dumez from comment #2)
&gt; Comment on attachment 311360 [details]
&gt; Patch
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=311360&amp;action=review
&gt; 
&gt; &gt; LayoutTests/webrtc/peer-connection-audio-mute.html:13
&gt; &gt; +    function ensureHumIsAsExpected(remoteStream, heardHum, count)
&gt; 
&gt; I think we should rename heardHum here to shouldHeadHum since this is an
&gt; expected result, not a result.

Done</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1313183</commentid>
    <comment_count>5</comment_count>
      <attachid>311362</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-05-26 11:28:45 -0700</bug_when>
    <thetext>Comment on attachment 311362
Fixing according comments

Rejecting attachment 311362 from commit-queue.

Failed to run &quot;[&apos;/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch&apos;, &apos;--status-host=webkit-queues.webkit.org&apos;, &apos;--bot-id=webkit-cq-02&apos;, &apos;apply-attachment&apos;, &apos;--no-update&apos;, &apos;--non-interactive&apos;, 311362, &apos;--port=mac&apos;]&quot; exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
/Scripts/svn-apply&apos;, &apos;--force&apos;]&quot; exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 2 diffs from patch file(s).
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/webrtc/peer-connection-audio-mute.html
Hunk #1 FAILED at 10.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/webrtc/peer-connection-audio-mute.html.rej

Failed to run &quot;[u&apos;/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply&apos;, &apos;--force&apos;]&quot; exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/3822924</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1314228</commentid>
    <comment_count>6</comment_count>
    <who name="Ryan Haddad">ryanhaddad</who>
    <bug_when>2017-05-31 11:16:05 -0700</bug_when>
    <thetext>Can we get this updated and landed? This test is flaky on EWS.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1314944</commentid>
    <comment_count>7</comment_count>
    <who name="Ryan Haddad">ryanhaddad</who>
    <bug_when>2017-06-01 20:54:00 -0700</bug_when>
    <thetext>Marked test as flaky in http://trac.webkit.org/projects/webkit/changeset/217670</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1348961</commentid>
    <comment_count>8</comment_count>
    <who name="Matt Lewis">jlewis3</who>
    <bug_when>2017-09-14 13:30:54 -0700</bug_when>
    <thetext>This test has recently started to crash as well. See Radar: &lt;rdar://problem/33712305&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1351363</commentid>
    <comment_count>9</comment_count>
    <who name="Ryan Haddad">ryanhaddad</who>
    <bug_when>2017-09-21 13:37:23 -0700</bug_when>
    <thetext>This test is still a flaky failure: 

https://build.webkit.org/results/Apple%20Sierra%20Release%20WK2%20(Tests)/r222338%20(4463)/results.html

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&amp;tests=webrtc%2Fpeer-connection-audio-mute.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1351364</commentid>
    <comment_count>10</comment_count>
    <who name="Ryan Haddad">ryanhaddad</who>
    <bug_when>2017-09-21 13:40:28 -0700</bug_when>
    <thetext>Marked test as flaky again in https://trac.webkit.org/r222345</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1351470</commentid>
    <comment_count>11</comment_count>
      <attachid>321495</attachid>
    <who name="youenn fablet">youennf</who>
    <bug_when>2017-09-21 17:03:59 -0700</bug_when>
    <thetext>Created attachment 321495
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1352211</commentid>
    <comment_count>12</comment_count>
      <attachid>321495</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-09-25 09:01:51 -0700</bug_when>
    <thetext>Comment on attachment 321495
Patch

Clearing flags on attachment: 321495

Committed r222447: &lt;http://trac.webkit.org/changeset/222447&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1352212</commentid>
    <comment_count>13</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-09-25 09:01:53 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1353690</commentid>
    <comment_count>14</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2017-09-27 12:51:42 -0700</bug_when>
    <thetext>&lt;rdar://problem/34694160&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>311360</attachid>
            <date>2017-05-26 10:19:49 -0700</date>
            <delta_ts>2017-05-26 11:27:29 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-172649-20170526101948.patch</filename>
            <type>text/plain</type>
            <size>2713</size>
            <attacher name="youenn fablet">youennf</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjE3NDg5CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu
Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMWUwOWQ4ZDVlY2RhYjczMjg1ODJj
ZTFlNWRmOGNkYzg0ZGE3Yjg2Yy4uYTM0NWU2OWZmNTdiZmQ4YzdlOGYzMTg4Y2JkMmJjN2EyNDhj
YjAzNyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz
L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE3LTA1LTI2ICBZb3Vlbm4gRmFibGV0ICA8
eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICB3ZWJydGMvcGVlci1jb25uZWN0aW9uLWF1ZGlv
LW11dGUuaHRtbCBpcyBzb21ldGltZXMgZmxha3kKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp
dC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MjY0OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E
WSAoT09QUyEpLgorCisgICAgICAgICogd2VicnRjL3BlZXItY29ubmVjdGlvbi1hdWRpby1tdXRl
Lmh0bWw6IFJlZG9pbmcgYW5hbHlzaXMgdW50aWwKKyAgICAgICAgdGltaW5nIG91dCBvciBnZXR0
aW5nIGV4cGVjdGVkIHJlc3VsdC4KKwogMjAxNy0wNS0yNiAgQ2xhdWRpbyBTYWF2ZWRyYSAgPGNz
YWF2ZWRyYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtXUEVdIE1hcmsgYW5pbWF0aW9ucy9hbmlt
YXRpb24tZGVsYXktY2hhbmdlZC5odG0gYXMgZmxha3kKZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz
L3dlYnJ0Yy9wZWVyLWNvbm5lY3Rpb24tYXVkaW8tbXV0ZS5odG1sIGIvTGF5b3V0VGVzdHMvd2Vi
cnRjL3BlZXItY29ubmVjdGlvbi1hdWRpby1tdXRlLmh0bWwKaW5kZXggMTk5YzU5MTM2NzA4NDkx
YTdkYjViMzlkMDMwNzdmNzkyNjUyNjYxOC4uYmE1Y2QxOGQ2YjJiYzhiYzExNzdkOGRkOTI5ZWNi
YTlmZDQwMWRiMyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvd2VicnRjL3BlZXItY29ubmVjdGlv
bi1hdWRpby1tdXRlLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvd2VicnRjL3BlZXItY29ubmVjdGlv
bi1hdWRpby1tdXRlLmh0bWwKQEAgLTEwLDYgKzEwLDE5IEBACiAgICAgPHNjcmlwdCBzcmMgPSJy
b3V0aW5lcy5qcyI+PC9zY3JpcHQ+CiAgICAgPHNjcmlwdD4KICAgICB2YXIgY29udGV4dCA9IG5l
dyB3ZWJraXRBdWRpb0NvbnRleHQoKTsKKyAgICBmdW5jdGlvbiBlbnN1cmVIdW1Jc0FzRXhwZWN0
ZWQocmVtb3RlU3RyZWFtLCBoZWFyZEh1bSwgY291bnQpCisgICAgeworICAgICAgICBpZiAoY291
bnQgPT09IHVuZGVmaW5lZCkKKyAgICAgICAgICAgIGNvdW50ID0gMDsKKyAgICAgICAgIHJldHVy
biBhbmFseXNlQXVkaW8ocmVtb3RlU3RyZWFtLCA1MDAsIGNvbnRleHQpLnRoZW4oKHJlc3VsdHMp
ID0+IHsKKyAgICAgICAgICAgIGlmIChyZXN1bHRzLmhlYXJkSHVtID09PSBoZWFyZEh1bSkKKyAg
ICAgICAgICAgICAgICByZXR1cm47CisgICAgICAgICAgICBpZiAoKytjb3VudCA9PT0gNSkKKyAg
ICAgICAgICAgICAgICByZXR1cm4gUHJvbWlzZS5yZWplY3QoImFuYWx5c2UgQXVkaW8gdGVzdCBm
YWlsZWQsIGV4cGVjdGVkIGlzTXV0ZWQ9IiArIGlzTXV0ZWQpOworICAgICAgICAgICAgcmV0dXJu
IGVuc3VyZUh1bUlzQXNFeHBlY3RlZChyZW1vdGVTdHJlYW0sIGhlYXJkSHVtLCBjb3VudCk7Cisg
ICAgICAgIH0pOworICAgIH0KKwogICAgIHByb21pc2VfdGVzdCgodGVzdCkgPT4gewogICAgICAg
ICBpZiAod2luZG93LnRlc3RSdW5uZXIpCiAgICAgICAgICAgICB0ZXN0UnVubmVyLnNldFVzZXJN
ZWRpYVBlcm1pc3Npb24odHJ1ZSk7CkBAIC0yOCwxOCArNDEsMTAgQEAKICAgICAgICAgICAgICAg
ICAgICAgfTsKICAgICAgICAgICAgICAgICB9KTsKICAgICAgICAgICAgIH0pLnRoZW4oKCkgPT4g
ewotICAgICAgICAgICAgICAgIHJldHVybiB3YWl0Rm9yKDUwMCk7Ci0gICAgICAgICAgICB9KS50
aGVuKCgpID0+IHsKLSAgICAgICAgICAgICAgICByZXR1cm4gYW5hbHlzZUF1ZGlvKHJlbW90ZVN0
cmVhbSwgNTAwLCBjb250ZXh0KS50aGVuKChyZXN1bHRzKSA9PiB7Ci0gICAgICAgICAgICAgICAg
ICAgIGFzc2VydF90cnVlKHJlc3VsdHMuaGVhcmRIdW0sICJoZWFyZCBodW0gZnJvbSByZW1vdGUg
ZW5hYmxlZCB0cmFjayIpOwotICAgICAgICAgICAgICAgIH0pOworICAgICAgICAgICAgICAgIHJl
dHVybiBlbnN1cmVIdW1Jc0FzRXhwZWN0ZWQocmVtb3RlU3RyZWFtLCB0cnVlKTsKICAgICAgICAg
ICAgIH0pLnRoZW4oKCkgPT4gewogICAgICAgICAgICAgICAgIGxvY2FsVHJhY2suZW5hYmxlZCA9
IGZhbHNlOwotICAgICAgICAgICAgICAgIHJldHVybiB3YWl0Rm9yKDUwMCk7Ci0gICAgICAgICAg
ICB9KS50aGVuKCgpID0+IHsKLSAgICAgICAgICAgICAgICByZXR1cm4gYW5hbHlzZUF1ZGlvKHJl
bW90ZVN0cmVhbSwgNTAwLCBjb250ZXh0KS50aGVuKChyZXN1bHRzKSA9PiB7Ci0gICAgICAgICAg
ICAgICAgICAgIGFzc2VydF9mYWxzZShyZXN1bHRzLmhlYXJkSHVtLCAibm90IGhlYXJkIGh1bSBm
cm9tIHJlbW90ZSBkaXNhYmxlZCB0cmFjayIpOwotICAgICAgICAgICAgICAgIH0pOworICAgICAg
ICAgICAgICAgIHJldHVybiBlbnN1cmVIdW1Jc0FzRXhwZWN0ZWQocmVtb3RlU3RyZWFtLCBmYWxz
ZSk7CiAgICAgICAgICAgICB9KS50aGVuKCgpID0+IHsKICAgICAgICAgICAgICAgICByZXR1cm4g
Y29udGV4dC5jbG9zZSgpOwogICAgICAgICAgICAgfSk7Cg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>311362</attachid>
            <date>2017-05-26 11:27:30 -0700</date>
            <delta_ts>2017-09-21 17:03:57 -0700</delta_ts>
            <desc>Fixing according comments</desc>
            <filename>bug-172649-20170526112730.patch</filename>
            <type>text/plain</type>
            <size>1850</size>
            <attacher name="youenn fablet">youennf</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjE3NDg5CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu
Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMWUwOWQ4ZDVlY2RhYjczMjg1ODJj
ZTFlNWRmOGNkYzg0ZGE3Yjg2Yy4uYTAzNzZmZTY5NzM3YjUxNzQwODIzMjU3N2VjOGQ0NTA5MTQz
N2I3MCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz
L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE3LTA1LTI2ICBZb3Vlbm4gRmFibGV0ICA8
eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICB3ZWJydGMvcGVlci1jb25uZWN0aW9uLWF1ZGlv
LW11dGUuaHRtbCBpcyBzb21ldGltZXMgZmxha3kKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp
dC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MjY0OQorCisgICAgICAgIFVucmV2aWV3ZWQuCisKKyAg
ICAgICAgKiB3ZWJydGMvcGVlci1jb25uZWN0aW9uLWF1ZGlvLW11dGUuaHRtbDogQWRkcmVzc2lu
ZyByZXZpZXcgY29tbWVudCBhYm91dCBjaGFuZ2luZyB2YXJpYWJsZSBuYW1lLgorCiAyMDE3LTA1
LTI2ICBDbGF1ZGlvIFNhYXZlZHJhICA8Y3NhYXZlZHJhQGlnYWxpYS5jb20+CiAKICAgICAgICAg
W1dQRV0gTWFyayBhbmltYXRpb25zL2FuaW1hdGlvbi1kZWxheS1jaGFuZ2VkLmh0bSBhcyBmbGFr
eQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvd2VicnRjL3BlZXItY29ubmVjdGlvbi1hdWRpby1t
dXRlLmh0bWwgYi9MYXlvdXRUZXN0cy93ZWJydGMvcGVlci1jb25uZWN0aW9uLWF1ZGlvLW11dGUu
aHRtbAppbmRleCBiYTVjZDE4ZDZiMmJjOGJjMTE3N2Q4ZGQ5MjllY2JhOWZkNDAxZGIzLi4zMThl
MzI2NDI0NjBhMDMxNjQ2YWE1ZTNkOWRjMDcyZjU2YjlkYTA1IDEwMDY0NAotLS0gYS9MYXlvdXRU
ZXN0cy93ZWJydGMvcGVlci1jb25uZWN0aW9uLWF1ZGlvLW11dGUuaHRtbAorKysgYi9MYXlvdXRU
ZXN0cy93ZWJydGMvcGVlci1jb25uZWN0aW9uLWF1ZGlvLW11dGUuaHRtbApAQCAtMTAsMTYgKzEw
LDE2IEBACiAgICAgPHNjcmlwdCBzcmMgPSJyb3V0aW5lcy5qcyI+PC9zY3JpcHQ+CiAgICAgPHNj
cmlwdD4KICAgICB2YXIgY29udGV4dCA9IG5ldyB3ZWJraXRBdWRpb0NvbnRleHQoKTsKLSAgICBm
dW5jdGlvbiBlbnN1cmVIdW1Jc0FzRXhwZWN0ZWQocmVtb3RlU3RyZWFtLCBoZWFyZEh1bSwgY291
bnQpCisgICAgZnVuY3Rpb24gZW5zdXJlSHVtSXNBc0V4cGVjdGVkKHJlbW90ZVN0cmVhbSwgc2hv
dWxkSGVhcmRIdW0sIGNvdW50KQogICAgIHsKICAgICAgICAgaWYgKGNvdW50ID09PSB1bmRlZmlu
ZWQpCiAgICAgICAgICAgICBjb3VudCA9IDA7CiAgICAgICAgICByZXR1cm4gYW5hbHlzZUF1ZGlv
KHJlbW90ZVN0cmVhbSwgNTAwLCBjb250ZXh0KS50aGVuKChyZXN1bHRzKSA9PiB7Ci0gICAgICAg
ICAgICBpZiAocmVzdWx0cy5oZWFyZEh1bSA9PT0gaGVhcmRIdW0pCisgICAgICAgICAgICBpZiAo
cmVzdWx0cy5oZWFyZEh1bSA9PT0gc2hvdWxkSGVhcmRIdW0pCiAgICAgICAgICAgICAgICAgcmV0
dXJuOwogICAgICAgICAgICAgaWYgKCsrY291bnQgPT09IDUpCiAgICAgICAgICAgICAgICAgcmV0
dXJuIFByb21pc2UucmVqZWN0KCJhbmFseXNlIEF1ZGlvIHRlc3QgZmFpbGVkLCBleHBlY3RlZCBp
c011dGVkPSIgKyBpc011dGVkKTsKLSAgICAgICAgICAgIHJldHVybiBlbnN1cmVIdW1Jc0FzRXhw
ZWN0ZWQocmVtb3RlU3RyZWFtLCBoZWFyZEh1bSwgY291bnQpOworICAgICAgICAgICAgcmV0dXJu
IGVuc3VyZUh1bUlzQXNFeHBlY3RlZChyZW1vdGVTdHJlYW0sIHNob3VsZEhlYXJkSHVtLCBjb3Vu
dCk7CiAgICAgICAgIH0pOwogICAgIH0KIAo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>321495</attachid>
            <date>2017-09-21 17:03:59 -0700</date>
            <delta_ts>2017-09-25 09:01:51 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-172649-20170921170358.patch</filename>
            <type>text/plain</type>
            <size>5588</size>
            <attacher name="youenn fablet">youennf</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyMzI1CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu
Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNjRkMjUwZjJjZTM2N2M4OGI0Njhl
MzEyZjA2YzY2ZGViMmIxZDQ1Yy4uNzk1YWJlMjUxMjQ4YjU5MzQ1NzY5MjY4MmEzMGIyYjE5ZTBk
MDllZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz
L0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDE3LTA5LTIxICBZb3Vlbm4gRmFibGV0ICA8
eW91ZW5uQGFwcGxlLmNvbT4KIAorICAgICAgICB3ZWJydGMvcGVlci1jb25uZWN0aW9uLWF1ZGlv
LW11dGUuaHRtbCBpcyBzb21ldGltZXMgZmxha3kKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp
dC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MjY0OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E
WSAoT09QUyEpLgorCisgICAgICAgIEl0ZXJhdGluZyB1bnRpbCBnZXR0aW5nIHRoZSBleHBlY3Rl
ZCByZXN1bHQgdG8gbWFrZSB0ZXN0IG1vcmUgc3RhYmxlLgorCisgICAgICAgICogd2VicnRjL3Bl
ZXItY29ubmVjdGlvbi1hdWRpby1tdXRlLmh0bWw6CisgICAgICAgICogd2VicnRjL3BlZXItY29u
bmVjdGlvbi1yZW1vdGUtYXVkaW8tbXV0ZS5odG1sOgorCisyMDE3LTA5LTIxICBZb3Vlbm4gRmFi
bGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKwogICAgICAgICBMYXlvdXRUZXN0IHdlYnJ0Yy92aWRl
by1tdXRlLmh0bWwgaXMgdmVyeSBvZnRlbiBmYWlsaW5nCiAgICAgICAgIGh0dHBzOi8vYnVncy53
ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzczMzEKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz
dHMvd2VicnRjL3BlZXItY29ubmVjdGlvbi1hdWRpby1tdXRlLmh0bWwgYi9MYXlvdXRUZXN0cy93
ZWJydGMvcGVlci1jb25uZWN0aW9uLWF1ZGlvLW11dGUuaHRtbAppbmRleCAxOTljNTkxMzY3MDg0
OTFhN2RiNWIzOWQwMzA3N2Y3OTI2NTI2NjE4Li4wZjIwYzM5ODRjODNhNmJmM2MxY2YwN2NlMTg3
NTFhYWVlMWI1YzIyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy93ZWJydGMvcGVlci1jb25uZWN0
aW9uLWF1ZGlvLW11dGUuaHRtbAorKysgYi9MYXlvdXRUZXN0cy93ZWJydGMvcGVlci1jb25uZWN0
aW9uLWF1ZGlvLW11dGUuaHRtbApAQCAtMTQsMTAgKzE0LDI1IEBACiAgICAgICAgIGlmICh3aW5k
b3cudGVzdFJ1bm5lcikKICAgICAgICAgICAgIHRlc3RSdW5uZXIuc2V0VXNlck1lZGlhUGVybWlz
c2lvbih0cnVlKTsKIAorICAgICAgICB2YXIgcmVtb3RlU3RyZWFtOworICAgICAgICBhc3luYyBm
dW5jdGlvbiBjaGVja0ZvclNvdW5kKGV4cGVjdGVkLCBtZXNzYWdlLCBjb3VudCkKKyAgICAgICAg
eworICAgICAgICAgICAgaWYgKGNvdW50ID09PSB1bmRlZmluZWQpCisgICAgICAgICAgICAgICAg
Y291bnQgPSAwOworCisgICAgICAgICAgICB2YXIgcmVzdWx0cyA9IGF3YWl0IGFuYWx5c2VBdWRp
byhyZW1vdGVTdHJlYW0sIDIwMCwgY29udGV4dCk7CisgICAgICAgICAgICBpZiAocmVzdWx0cy5o
ZWFyZEh1bSA9PT0gZXhwZWN0ZWQpCisgICAgICAgICAgICAgICAgcmV0dXJuOworICAgICAgICAg
ICAgaWYgKGNvdW50ID4gNTApCisgICAgICAgICAgICAgICAgcmV0dXJuIFByb21pc2UucmVqZWN0
KCJjaGVja0ZvclNvdW5kIHRpbWVkIG91dCB3aGVuIHRlc3Rpbmc6ICIgKyBtZXNzYWdlKTsKKwor
ICAgICAgICAgICAgYXdhaXQgd2FpdEZvcigxMDApOworICAgICAgICAgICAgcmV0dXJuIGNoZWNr
Rm9yU291bmQoZXhwZWN0ZWQsIG1lc3NhZ2UsICsrY291bnQpOworICAgICAgICB9CisKICAgICAg
ICAgdmFyIGxvY2FsVHJhY2s7CiAgICAgICAgIHJldHVybiBuYXZpZ2F0b3IubWVkaWFEZXZpY2Vz
LmdldFVzZXJNZWRpYSh7YXVkaW86IHRydWV9KS50aGVuKChsb2NhbFN0cmVhbSkgPT4gewogICAg
ICAgICAgICAgbG9jYWxUcmFjayA9IGxvY2FsU3RyZWFtLmdldEF1ZGlvVHJhY2tzKClbMF07Ci0g
ICAgICAgICAgICB2YXIgcmVtb3RlU3RyZWFtOwogICAgICAgICAgICAgcmV0dXJuIG5ldyBQcm9t
aXNlKChyZXNvbHZlLCByZWplY3QpID0+IHsKICAgICAgICAgICAgICAgICBjcmVhdGVDb25uZWN0
aW9ucygoZmlyc3RDb25uZWN0aW9uKSA9PiB7CiAgICAgICAgICAgICAgICAgICAgIGZpcnN0Q29u
bmVjdGlvbi5hZGRUcmFjayhsb2NhbFRyYWNrLCBsb2NhbFN0cmVhbSk7CkBAIC0yOCwxOCArNDMs
MTIgQEAKICAgICAgICAgICAgICAgICAgICAgfTsKICAgICAgICAgICAgICAgICB9KTsKICAgICAg
ICAgICAgIH0pLnRoZW4oKCkgPT4gewotICAgICAgICAgICAgICAgIHJldHVybiB3YWl0Rm9yKDUw
MCk7Ci0gICAgICAgICAgICB9KS50aGVuKCgpID0+IHsKLSAgICAgICAgICAgICAgICByZXR1cm4g
YW5hbHlzZUF1ZGlvKHJlbW90ZVN0cmVhbSwgNTAwLCBjb250ZXh0KS50aGVuKChyZXN1bHRzKSA9
PiB7Ci0gICAgICAgICAgICAgICAgICAgIGFzc2VydF90cnVlKHJlc3VsdHMuaGVhcmRIdW0sICJo
ZWFyZCBodW0gZnJvbSByZW1vdGUgZW5hYmxlZCB0cmFjayIpOwotICAgICAgICAgICAgICAgIH0p
OworICAgICAgICAgICAgICAgIHJldHVybiBjaGVja0ZvclNvdW5kKHRydWUsICJzaG91bGQgaGVh
ciBodW0gZnJvbSByZW1vdGUgZW5hYmxlZCB0cmFjayIpOwogICAgICAgICAgICAgfSkudGhlbigo
KSA9PiB7CiAgICAgICAgICAgICAgICAgbG9jYWxUcmFjay5lbmFibGVkID0gZmFsc2U7Ci0gICAg
ICAgICAgICAgICAgcmV0dXJuIHdhaXRGb3IoNTAwKTsKKyAgICAgICAgICAgICAgICByZXR1cm4g
d2FpdEZvcigxMDApOwogICAgICAgICAgICAgfSkudGhlbigoKSA9PiB7Ci0gICAgICAgICAgICAg
ICAgcmV0dXJuIGFuYWx5c2VBdWRpbyhyZW1vdGVTdHJlYW0sIDUwMCwgY29udGV4dCkudGhlbigo
cmVzdWx0cykgPT4gewotICAgICAgICAgICAgICAgICAgICBhc3NlcnRfZmFsc2UocmVzdWx0cy5o
ZWFyZEh1bSwgIm5vdCBoZWFyZCBodW0gZnJvbSByZW1vdGUgZGlzYWJsZWQgdHJhY2siKTsKLSAg
ICAgICAgICAgICAgICB9KTsKKyAgICAgICAgICAgICAgICByZXR1cm4gY2hlY2tGb3JTb3VuZChm
YWxzZSwgInNob3VsZCBub3QgaGVhciBodW0gZnJvbSByZW1vdGUgZW5hYmxlZCB0cmFjayIpOwog
ICAgICAgICAgICAgfSkudGhlbigoKSA9PiB7CiAgICAgICAgICAgICAgICAgcmV0dXJuIGNvbnRl
eHQuY2xvc2UoKTsKICAgICAgICAgICAgIH0pOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvd2Vi
cnRjL3BlZXItY29ubmVjdGlvbi1yZW1vdGUtYXVkaW8tbXV0ZS5odG1sIGIvTGF5b3V0VGVzdHMv
d2VicnRjL3BlZXItY29ubmVjdGlvbi1yZW1vdGUtYXVkaW8tbXV0ZS5odG1sCmluZGV4IDU5NDU2
YzY0NzBiOTE1YmU5NzJiMzAxYjIyNWMxMTc5NTJiODA0ODcuLjYwMjRjNGQ4MjhhNTA5YTg0ZWQ2
YmZhYmRjZmU5ZDM0ZjY1OWNlNDQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3dlYnJ0Yy9wZWVy
LWNvbm5lY3Rpb24tcmVtb3RlLWF1ZGlvLW11dGUuaHRtbAorKysgYi9MYXlvdXRUZXN0cy93ZWJy
dGMvcGVlci1jb25uZWN0aW9uLXJlbW90ZS1hdWRpby1tdXRlLmh0bWwKQEAgLTksMTQgKzksMzAg
QEAKIDxib2R5PgogICAgIDxzY3JpcHQgc3JjID0icm91dGluZXMuanMiPjwvc2NyaXB0PgogICAg
IDxzY3JpcHQ+CisKICAgICB2YXIgY29udGV4dCA9IG5ldyB3ZWJraXRBdWRpb0NvbnRleHQoKTsK
KyAgICB2YXIgcmVtb3RlU3RyZWFtOworICAgIGFzeW5jIGZ1bmN0aW9uIGNoZWNrRm9yU291bmQo
ZXhwZWN0ZWQsIG1lc3NhZ2UsIGNvdW50KQorICAgIHsKKyAgICAgICAgaWYgKGNvdW50ID09PSB1
bmRlZmluZWQpCisgICAgICAgICAgICBjb3VudCA9IDA7CisKKyAgICAgICAgdmFyIHJlc3VsdHMg
PSBhd2FpdCBhbmFseXNlQXVkaW8ocmVtb3RlU3RyZWFtLCAyMDAsIGNvbnRleHQpOworICAgICAg
ICBpZiAocmVzdWx0cy5oZWFyZEh1bSA9PT0gZXhwZWN0ZWQpCisgICAgICAgICAgICByZXR1cm47
CisgICAgICAgIGlmIChjb3VudCA+IDUwKQorICAgICAgICAgICAgcmV0dXJuIFByb21pc2UucmVq
ZWN0KCJjaGVja0ZvclNvdW5kIHRpbWVkIG91dCB3aGVuIHRlc3Rpbmc6ICIgKyBtZXNzYWdlKTsK
KworICAgICAgICBhd2FpdCB3YWl0Rm9yKDEwMCk7CisgICAgICAgIHJldHVybiBjaGVja0ZvclNv
dW5kKGV4cGVjdGVkLCBtZXNzYWdlLCArK2NvdW50KTsKKyAgICB9CisKICAgICBwcm9taXNlX3Rl
c3QoKHRlc3QpID0+IHsKICAgICAgICAgaWYgKHdpbmRvdy50ZXN0UnVubmVyKQogICAgICAgICAg
ICAgdGVzdFJ1bm5lci5zZXRVc2VyTWVkaWFQZXJtaXNzaW9uKHRydWUpOwogCiAgICAgICAgIHJl
dHVybiBuYXZpZ2F0b3IubWVkaWFEZXZpY2VzLmdldFVzZXJNZWRpYSh7YXVkaW86IHRydWV9KS50
aGVuKChsb2NhbFN0cmVhbSkgPT4gewogICAgICAgICAgICAgdmFyIHJlbW90ZVRyYWNrOwotICAg
ICAgICAgICAgdmFyIHJlbW90ZVN0cmVhbTsKICAgICAgICAgICAgIHJldHVybiBuZXcgUHJvbWlz
ZSgocmVzb2x2ZSwgcmVqZWN0KSA9PiB7CiAgICAgICAgICAgICAgICAgY3JlYXRlQ29ubmVjdGlv
bnMoKGZpcnN0Q29ubmVjdGlvbikgPT4gewogICAgICAgICAgICAgICAgICAgICBmaXJzdENvbm5l
Y3Rpb24uYWRkVHJhY2sobG9jYWxTdHJlYW0uZ2V0QXVkaW9UcmFja3MoKVswXSwgbG9jYWxTdHJl
YW0pOwpAQCAtMjgsMTYgKzQ0LDEyIEBACiAgICAgICAgICAgICAgICAgICAgIH07CiAgICAgICAg
ICAgICAgICAgfSk7CiAgICAgICAgICAgICB9KS50aGVuKCgpID0+IHsKLSAgICAgICAgICAgICAg
ICByZXR1cm4gYW5hbHlzZUF1ZGlvKHJlbW90ZVN0cmVhbSwgMjAwLCBjb250ZXh0KS50aGVuKChy
ZXN1bHRzKSA9PiB7Ci0gICAgICAgICAgICAgICAgICAgIGFzc2VydF90cnVlKHJlc3VsdHMuaGVh
cmRIdW0sICJoZWFyZCBodW0gZnJvbSByZW1vdGUgZW5hYmxlZCB0cmFjayIpOwotICAgICAgICAg
ICAgICAgIH0pOworICAgICAgICAgICAgICAgIHJldHVybiBjaGVja0ZvclNvdW5kKHRydWUsICJz
aG91bGQgaGVhciBodW0gZnJvbSByZW1vdGUgZW5hYmxlZCB0cmFjayIpOwogICAgICAgICAgICAg
fSkudGhlbigoKSA9PiB7CiAgICAgICAgICAgICAgICAgcmVtb3RlVHJhY2suZW5hYmxlZCA9IGZh
bHNlOwogICAgICAgICAgICAgICAgIHJldHVybiB3YWl0Rm9yKDEwMCk7CiAgICAgICAgICAgICB9
KS50aGVuKCgpID0+IHsKLSAgICAgICAgICAgICAgICByZXR1cm4gYW5hbHlzZUF1ZGlvKHJlbW90
ZVN0cmVhbSwgMjAwLCBjb250ZXh0KS50aGVuKChyZXN1bHRzKSA9PiB7Ci0gICAgICAgICAgICAg
ICAgICAgIGFzc2VydF9mYWxzZShyZXN1bHRzLmhlYXJkSHVtLCAibm90IGhlYXJkIGh1bSBmcm9t
IHJlbW90ZSBkaXNhYmxlZCB0cmFjayIpOwotICAgICAgICAgICAgICAgIH0pOworICAgICAgICAg
ICAgICAgIHJldHVybiBjaGVja0ZvclNvdW5kKGZhbHNlLCAic2hvdWxkIG5vdCBoZWFyIGh1bSBm
cm9tIHJlbW90ZSBkaXNhYmxlZCB0cmFjayIpOwogICAgICAgICAgICAgfSkudGhlbigoKSA9PiB7
CiAgICAgICAgICAgICAgICAgcmV0dXJuIGNvbnRleHQuY2xvc2UoKTsKICAgICAgICAgICAgIH0p
Owo=
</data>

          </attachment>
      

    </bug>

</bugzilla>