172638 2017-05-26 02:33:17 -0700 [CMake] Pass -fdiagnostics-color=always to GCC when building with Ninja 2017-05-30 20:20:54 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aperez aperez achristensen commit-queue lforschler mcatanzaro webkit-bug-importer ysuzuki oldest_to_newest 1313085 0 aperez 2017-05-26 02:33:17 -0700 It would be nice to make GCC generate colored warning/error messages when building with Ninja. In “OptionsCommon.cmake” there is code to enable this for Clang, and it should be possible to do something similar for GCC. 1313088 1 311346 aperez 2017-05-26 02:36:04 -0700 Created attachment 311346 Patch 1313089 2 311346 ysuzuki 2017-05-26 02:38:20 -0700 Comment on attachment 311346 Patch r=me, nice 1313092 3 311346 commit-queue 2017-05-26 03:16:09 -0700 Comment on attachment 311346 Patch Clearing flags on attachment: 311346 Committed r217485: <http://trac.webkit.org/changeset/217485> 1313093 4 commit-queue 2017-05-26 03:16:11 -0700 All reviewed patches have been landed. Closing bug. 1314013 5 webkit-bug-importer 2017-05-30 20:20:54 -0700 <rdar://problem/32479694> 311346 2017-05-26 02:36:04 -0700 2017-05-26 03:16:09 -0700 Patch bug-172638-20170526113602.patch text/plain 1953 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjE3NDgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0NvbW1vbi5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCmluZGV4 IGU3N2M3MDc2Zjg1NWMzOGFhNmUzMTliZTczODZhM2JkNWE1ZmRiOTcuLmI4OTUwM2NlNGU1NGM0 NDIzY2RjMDIzMWMxNTFkNmRlNzlmMDVlMzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRp b25zQ29tbW9uLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCkBA IC00Myw5ICs0MywxOCBAQCBpZiAoQ09NUElMRVJfSVNfR0NDX09SX0NMQU5HKQogICAgIHNldChD TUFLRV9DWFhfRkxBR1MgIiR7Q01BS0VfQ1hYX0ZMQUdTfSAtc3RkPWMrKzF5IikKIGVuZGlmICgp CiAKLWlmIChDT01QSUxFUl9JU19DTEFORyBBTkQgQ01BS0VfR0VORVJBVE9SIFNUUkVRVUFMICJO aW5qYSIpCi0gICAgc2V0KENNQUtFX0NfRkxBR1MgIiR7Q01BS0VfQ19GTEFHU30gLWZjb2xvci1k aWFnbm9zdGljcyIpCi0gICAgc2V0KENNQUtFX0NYWF9GTEFHUyAiJHtDTUFLRV9DWFhfRkxBR1N9 IC1mY29sb3ItZGlhZ25vc3RpY3MiKQoraWYgKENNQUtFX0dFTkVSQVRPUiBTVFJFUVVBTCAiTmlu amEiKQorICAgIGlmIChDT01QSUxFUl9JU19DTEFORykKKyAgICAgICAgc2V0KENNQUtFX0NfRkxB R1MgIiR7Q01BS0VfQ19GTEFHU30gLWZjb2xvci1kaWFnbm9zdGljcyIpCisgICAgICAgIHNldChD TUFLRV9DWFhfRkxBR1MgIiR7Q01BS0VfQ1hYX0ZMQUdTfSAtZmNvbG9yLWRpYWdub3N0aWNzIikK KyAgICBlbHNlICgpCisgICAgICAgIGlmIChDTUFLRV9DT01QSUxFUl9JU19HTlVDQykKKyAgICAg ICAgICAgIHNldChDTUFLRV9DX0ZMQUdTICIke0NNQUtFX0NfRkxBR1N9IC1mZGlhZ25vc3RpY3Mt Y29sb3I9YWx3YXlzIikKKyAgICAgICAgZW5kaWYgKCkKKyAgICAgICAgaWYgKENNQUtFX0NPTVBJ TEVSX0lTX0dOVUNYWCkKKyAgICAgICAgICAgIHNldChDTUFLRV9DWFhfRkxBR1MgIiR7Q01BS0Vf Q1hYX0ZMQUdTfSAtZmRpYWdub3N0aWNzLWNvbG9yPWFsd2F5cyIpCisgICAgICAgIGVuZGlmICgp CisgICAgZW5kaWYgKCkKIGVuZGlmICgpCiAKIGlmIChXSU4zMiBBTkQgQ09NUElMRVJfSVNfR0ND X09SX0NMQU5HKQpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IGQyZmFj NzRkMzFlOTQyNGU5ZjdlMDc4ZWY5ZmQ1NTRhODA0ZDUxZWYuLjZkYTY4ZTEzM2Q0OWQzZjhiNzM1 M2JkNDVkODk5ZjIyMjVkODc1YWYgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxNSBAQAorMjAxNy0wNS0yNiAgQWRyaWFuIFBlcmV6IGRlIENhc3RybyAg PGFwZXJlekBpZ2FsaWEuY29tPgorCisgICAgICAgIFtDTWFrZV0gUGFzcyAtZmRpYWdub3N0aWNz LWNvbG9yPWFsd2F5cyB0byBHQ0Mgd2hlbiBidWlsZGluZyB3aXRoIE5pbmphCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzI2MzgKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgb2xkZXN0IHZlcnNpb24g b2YgR0NDIHN1cHBvcnRlZCBmb3IgYnVpbGRpbmcgV2ViS2l0IGlzIDQuOSwgd2hpY2ggYWxyZWFk eSBhY2NlcHRzCisgICAgICAgIC1mZGlhZ25vc3RpY3MtY29sb3I9LCB0aGVyZWZvcmUgaXQgaXMg bm90IG5lZWRlZCB0byBjaGVjayB0aGUgY29tcGlsZXIgdmVyc2lvbi4KKworICAgICAgICAqIFNv dXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlOgorCiAyMDE3LTA1LTI1ICBEb24gT2xtc3Rl YWQgIDxkb24ub2xtc3RlYWRAYW0uc29ueS5jb20+CiAKICAgICAgICAgW0NNYWtlXVtXaW5dIFVz ZSBXVEZfQ1BVIG5vdCBNU0NWX0NYWF9BUkNISVRFQ1RVUkVfSUQgd2hlbiBkZXRlcm1pbmluZyBs aWIgZGlyZWN0b3JpZXMK