<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>172629</bug_id>
          
          <creation_ts>2017-05-25 21:16:04 -0700</creation_ts>
          <short_desc>Fix MediaDeviceInfo&apos;s extended attributes so they make sense</short_desc>
          <delta_ts>2017-05-30 20:21:03 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Sam Weinig">sam</reporter>
          <assigned_to name="Sam Weinig">sam</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>dbates</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1313033</commentid>
    <comment_count>0</comment_count>
    <who name="Sam Weinig">sam</who>
    <bug_when>2017-05-25 21:16:04 -0700</bug_when>
    <thetext>Fix MediaDeviceInfo&apos;s extended attributes so they make sense</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1313034</commentid>
    <comment_count>1</comment_count>
      <attachid>311333</attachid>
    <who name="Sam Weinig">sam</who>
    <bug_when>2017-05-25 21:19:15 -0700</bug_when>
    <thetext>Created attachment 311333
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1313044</commentid>
    <comment_count>2</comment_count>
      <attachid>311333</attachid>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2017-05-25 21:48:23 -0700</bug_when>
    <thetext>Comment on attachment 311333
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311333&amp;action=review

&gt; Source/WebCore/Modules/mediastream/MediaDeviceInfo.idl:-37
&gt; -    // FIXME 169871: missing serializer

Can we close bug #169871?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1313046</commentid>
    <comment_count>3</comment_count>
    <who name="Sam Weinig">sam</who>
    <bug_when>2017-05-25 22:11:28 -0700</bug_when>
    <thetext>(In reply to Daniel Bates from comment #2)
&gt; Comment on attachment 311333 [details]
&gt; Patch
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=311333&amp;action=review
&gt; 
&gt; &gt; Source/WebCore/Modules/mediastream/MediaDeviceInfo.idl:-37
&gt; &gt; -    // FIXME 169871: missing serializer
&gt; 
&gt; Can we close bug #169871?

No. It looks to be an umbrella bug. I&apos;ll let Jon decide if its done.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1313051</commentid>
    <comment_count>4</comment_count>
      <attachid>311333</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-05-25 22:39:16 -0700</bug_when>
    <thetext>Comment on attachment 311333
Patch

Clearing flags on attachment: 311333

Committed r217476: &lt;http://trac.webkit.org/changeset/217476&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1313052</commentid>
    <comment_count>5</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-05-25 22:39:17 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1314016</commentid>
    <comment_count>6</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2017-05-30 20:21:03 -0700</bug_when>
    <thetext>&lt;rdar://problem/32479701&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>311333</attachid>
            <date>2017-05-25 21:19:15 -0700</date>
            <delta_ts>2017-05-25 22:39:16 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-172629-20170525211914.patch</filename>
            <type>text/plain</type>
            <size>4613</size>
            <attacher name="Sam Weinig">sam</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxNzQ3MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n
ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE3LTA1LTI1ICBTYW0gV2Vp
bmlnICA8c2FtQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IE1lZGlhRGV2aWNlSW5mbydzIGV4
dGVuZGVkIGF0dHJpYnV0ZXMgc28gdGhleSBtYWtlIHNlbnNlCisgICAgICAgIGh0dHBzOi8vYnVn
cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzI2MjkKKworICAgICAgICBSZXZpZXdlZCBi
eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNZWRpYURldmljZUluZm8uaWRsIGhhZCBib3Ro
IGEgQ29uc3RydWN0b3IgYW5kIE5vSW50ZXJmYWNlT2JqZWN0LCB3aGljaAorICAgICAgICBkb2Vz
bid0IHJlYWxseSBtYWtlIHNlbnNlLiBFaXRoZXIgd2F5LCB0aGUgc3BlYyBzYXlzIGl0IHNob3Vs
ZCBoYXZlIAorICAgICAgICBuZWl0aGVyLCBzbyByZW1vdmUgYm90aC4gQW5kLCB3aGlsZSB3ZXJl
IHRoZXJlLCBhZGQgbWlzc2luZyBzZXJpYWxpemVyLgorCisgICAgICAgIFRlc3Q6IGZhc3QvbWVk
aWFzdHJlYW0vbWVkaWEtZGV2aWNlLWluZm8uaHRtbAorCisgICAgICAgICogTW9kdWxlcy9tZWRp
YXN0cmVhbS9NZWRpYURldmljZUluZm8uaWRsOgorCiAyMDE3LTA1LTI1ICBaYWxhbiBCdWp0YXMg
IDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgRnJhbWUncyBjb21wb3NpdGVkIGNvbnRlbnQg
aXMgdmlzaWJsZSB3aGVuIHRoZSBmcmFtZSBoYXMgdmlzaWJpbGl0eTogaGlkZGVuLgpJbmRleDog
U291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9NZWRpYURldmljZUluZm8uaWRsCj09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vTWVkaWFEZXZp
Y2VJbmZvLmlkbAkocmV2aXNpb24gMjE3NDcyKQorKysgU291cmNlL1dlYkNvcmUvTW9kdWxlcy9t
ZWRpYXN0cmVhbS9NZWRpYURldmljZUluZm8uaWRsCSh3b3JraW5nIGNvcHkpCkBAIC0yNSwxNiAr
MjUsMTMgQEAKIAogWwogICAgIENvbmRpdGlvbmFsPU1FRElBX1NUUkVBTSwKLSAgICBDb25zdHJ1
Y3RvcihET01TdHJpbmcgZGV2aWNlSWQsIERPTVN0cmluZyBsYWJlbCwgRE9NU3RyaW5nIGdyb3Vw
SWQsIE1lZGlhRGV2aWNlS2luZCBraW5kKSwKICAgICBKU0dlbmVyYXRlVG9KU09iamVjdCwKLSAg
ICBOb0ludGVyZmFjZU9iamVjdCwKIF0gaW50ZXJmYWNlIE1lZGlhRGV2aWNlSW5mbyB7CiAgICAg
cmVhZG9ubHkgYXR0cmlidXRlIERPTVN0cmluZyBkZXZpY2VJZDsKICAgICByZWFkb25seSBhdHRy
aWJ1dGUgTWVkaWFEZXZpY2VLaW5kIGtpbmQ7CiAgICAgcmVhZG9ubHkgYXR0cmlidXRlIERPTVN0
cmluZyBsYWJlbDsKICAgICByZWFkb25seSBhdHRyaWJ1dGUgRE9NU3RyaW5nIGdyb3VwSWQ7Ci0K
LSAgICAvLyBGSVhNRSAxNjk4NzE6IG1pc3Npbmcgc2VyaWFsaXplcgorICAgIHNlcmlhbGl6ZXIg
PSB7YXR0cmlidXRlfTsKIH07CiAKIC8vIEZJWE1FIDE2OTg3MTogbWlzc2luZyBJbnB1dERldmlj
ZUluZm8KSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRU
ZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxNzQ3MikKKysrIExheW91dFRlc3RzL0NoYW5nZUxv
Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE3LTA1LTI1ICBTYW0gV2Vpbmln
ICA8c2FtQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IE1lZGlhRGV2aWNlSW5mbydzIGV4dGVu
ZGVkIGF0dHJpYnV0ZXMgc28gdGhleSBtYWtlIHNlbnNlCisgICAgICAgIGh0dHBzOi8vYnVncy53
ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzI2MjkKKworICAgICAgICBSZXZpZXdlZCBieSBO
T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZhc3QvbWVkaWFzdHJlYW0vbWVkaWEtZGV2aWNl
LWluZm8tZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L21lZGlhc3RyZWFtL21l
ZGlhLWRldmljZS1pbmZvLmh0bWw6IEFkZGVkLgorICAgICAgICBUZXN0IHRoYXQgTWVkaWFEZXZp
Y2VJbmZvIGhhcyB0aGUgZXhwZWN0ZWQgcHJvcGVydGllcyBhbmQgdGhhdAorICAgICAgICB0aGUg
c2VyaWFsaXplciB3b3Jrcy4KKwogMjAxNy0wNS0yNSAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBw
bGUuY29tPgogCiAgICAgICAgIEZyYW1lJ3MgY29tcG9zaXRlZCBjb250ZW50IGlzIHZpc2libGUg
d2hlbiB0aGUgZnJhbWUgaGFzIHZpc2liaWxpdHk6IGhpZGRlbi4KSW5kZXg6IExheW91dFRlc3Rz
L2Zhc3QvbWVkaWFzdHJlYW0vbWVkaWEtZGV2aWNlLWluZm8tZXhwZWN0ZWQudHh0Cj09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvbWVkaWFzdHJlYW0vbWVkaWEtZGV2aWNlLWluZm8tZXhw
ZWN0ZWQudHh0CShub25leGlzdGVudCkKKysrIExheW91dFRlc3RzL2Zhc3QvbWVkaWFzdHJlYW0v
bWVkaWEtZGV2aWNlLWluZm8tZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEs
MyBAQAorCitQQVNTIFRlc3QgcHJvcGVydGllcyBvZiBNZWRpYURldmljZUluZm8gCisKSW5kZXg6
IExheW91dFRlc3RzL2Zhc3QvbWVkaWFzdHJlYW0vbWVkaWEtZGV2aWNlLWluZm8uaHRtbAo9PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L21lZGlhc3RyZWFtL21lZGlhLWRldmljZS1pbmZv
Lmh0bWwJKG5vbmV4aXN0ZW50KQorKysgTGF5b3V0VGVzdHMvZmFzdC9tZWRpYXN0cmVhbS9tZWRp
YS1kZXZpY2UtaW5mby5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsNDAgQEAKKzwhRE9D
VFlQRSBodG1sPgorPGh0bWw+Cis8aGVhZD4KKyAgICA8bWV0YSBjaGFyc2V0PSJ1dGYtOCI+Cisg
ICAgPHRpdGxlPlRlc3QgcGFzc2luZyBjYXB0dXJlIGRldmljZSBJRHMgdG8gZ2V0VXNlck1lZGlh
PC90aXRsZT4KKyAgICA8c2NyaXB0IHNyYz0iLi4vLi4vcmVzb3VyY2VzL3Rlc3RoYXJuZXNzLmpz
Ij48L3NjcmlwdD4KKyAgICA8c2NyaXB0IHNyYz0iLi4vLi4vcmVzb3VyY2VzL3Rlc3RoYXJuZXNz
cmVwb3J0LmpzIj48L3NjcmlwdD4KKyAgICA8c2NyaXB0PgorICAgIHZhciBkZXZpY2VzID0gW107
CisKKyAgICBpZiAod2luZG93LnRlc3RSdW5uZXIpCisgICAgICAgIHRlc3RSdW5uZXIuc2V0VXNl
ck1lZGlhUGVybWlzc2lvbih0cnVlKTsKKworICAgIHByb21pc2VfdGVzdCgodGVzdCkgPT4gewor
ICAgICAgICByZXR1cm4gbmF2aWdhdG9yLm1lZGlhRGV2aWNlcy5lbnVtZXJhdGVEZXZpY2VzKCkK
KyAgICAgICAgICAgIC50aGVuKChkZXZpY2VzKSA9PiB7CisgICAgICAgICAgICAgICAgYXNzZXJ0
X2dyZWF0ZXJfdGhhbihkZXZpY2VzLmxlbmd0aCwgMCk7CisgICAgICAgICAgICAgICAgbGV0IGRl
dmljZSA9IGRldmljZXNbMF07CisgICAgICAgICAgICAgICAgCisgICAgICAgICAgICAgICAgYXNz
ZXJ0X3RydWUoZGV2aWNlIGluc3RhbmNlb2YgTWVkaWFEZXZpY2VJbmZvKTsKKyAgICAgICAgICAg
ICAgICBhc3NlcnRfY2xhc3Nfc3RyaW5nKGRldmljZSwgIk1lZGlhRGV2aWNlSW5mbyIpOworICAg
ICAgICAgICAgICAgIGFzc2VydF90cnVlKCdkZXZpY2VJZCcgaW4gZGV2aWNlKTsKKyAgICAgICAg
ICAgICAgICBhc3NlcnRfdHJ1ZSgna2luZCcgaW4gZGV2aWNlKTsKKyAgICAgICAgICAgICAgICBh
c3NlcnRfdHJ1ZSgnbGFiZWwnIGluIGRldmljZSk7CisgICAgICAgICAgICAgICAgYXNzZXJ0X3Ry
dWUoJ2dyb3VwSWQnIGluIGRldmljZSk7CisgICAgICAgICAgICAgICAgYXNzZXJ0X3RydWUoJ3Rv
SlNPTicgaW4gZGV2aWNlKTsKKyAgICAgICAgICAgICAgICAKKyAgICAgICAgICAgICAgICBsZXQg
c2VyaWFsaXplZFJlc3VsdCA9IGRldmljZS50b0pTT04oKTsKKyAgICAgICAgICAgICAgICBhc3Nl
cnRfZXF1YWxzKHNlcmlhbGl6ZWRSZXN1bHRbJ2RldmljZUlkJ10sIGRldmljZS5kZXZpY2VJZCk7
CisgICAgICAgICAgICAgICAgYXNzZXJ0X2VxdWFscyhzZXJpYWxpemVkUmVzdWx0WydraW5kJ10s
IGRldmljZS5raW5kKTsKKyAgICAgICAgICAgICAgICBhc3NlcnRfZXF1YWxzKHNlcmlhbGl6ZWRS
ZXN1bHRbJ2xhYmVsJ10sIGRldmljZS5sYWJlbCk7CisgICAgICAgICAgICAgICAgYXNzZXJ0X2Vx
dWFscyhzZXJpYWxpemVkUmVzdWx0Wydncm91cElkJ10sIGRldmljZS5ncm91cElkKTsKKyAgICAg
ICAgICAgIH0pOworICAgIH0sICJUZXN0IHByb3BlcnRpZXMgb2YgTWVkaWFEZXZpY2VJbmZvIik7
CisKKyAgICA8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorPC9ib2R5PgorPC9odG1sPgo=
</data>

          </attachment>
      

    </bug>

</bugzilla>