172625 2017-05-25 17:21:26 -0700 Gracefully handle missing localStorage support in results.html 2017-05-25 19:56:16 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham ap bfulgham cdumez commit-queue lforschler ryanhaddad simon.fraser thorton webkit-bug-importer zalan oldest_to_newest 1312978 0 bfulgham 2017-05-25 17:21:26 -0700 The 'results.html' file displays test output, and provides local storage of user settings as a convenience. If localStorage is blocked due to security settings, the page throws SecurityError DOMExceptions, and shows all test failures (including those that are expected) making it difficult to review test results. This patch makes missing localStorage a non-fatal error, using the default settings if it cannot load (or save) customizations made by the user. 1312979 1 bfulgham 2017-05-25 17:21:35 -0700 <rdar://problem/32118243> 1312981 2 311320 bfulgham 2017-05-25 17:25:22 -0700 Created attachment 311320 Patch 1312999 3 311320 ap 2017-05-25 18:40:37 -0700 Comment on attachment 311320 Patch r=me, assuming that it fixes the issue. 1313013 4 311320 commit-queue 2017-05-25 19:56:15 -0700 Comment on attachment 311320 Patch Clearing flags on attachment: 311320 Committed r217470: <http://trac.webkit.org/changeset/217470> 1313014 5 commit-queue 2017-05-25 19:56:16 -0700 All reviewed patches have been landed. Closing bug. 311320 2017-05-25 17:25:22 -0700 2017-05-25 19:56:15 -0700 Patch bug-172625-20170525172522.patch text/plain 1807 bfulgham SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDIxNzQ1OSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE3LTA1LTI1ICBCcmVudCBGdWxnaGFtICA8 YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIEdyYWNlZnVsbHkgaGFuZGxlIG1pc3Npbmcg bG9jYWxTdG9yYWdlIHN1cHBvcnQgaW4gcmVzdWx0cy5odG1sCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzI2MjUKKyAgICAgICAgPHJkYXI6Ly9wcm9i bGVtLzMyMTE4MjQzPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEhhbmRsZSB0aGUgY2FzZSB3aGVyZSBsb2NhbFN0b3JhZ2UgZ2VuZXJhdGVzIGEgU2Vj dXJpdHlFcnJvciBET01FeGNlcHRpb24sIHRyZWF0aW5nIHRoaXMKKyAgICAgICAgYXMgYSBub24t ZmF0YWwgZXJyb3IuCisKKyAgICAgICAgKiBmYXN0L2hhcm5lc3MvcmVzdWx0cy5odG1sOgorICAg ICAgICAoT3B0aW9uV3JpdGVyLnNhdmUpOiBUcmVhdCAiU2VjdXJpdHlFcnJvciIgYXMgYW4gZXhw ZWN0ZWQgY29uZGl0aW9uLgorICAgICAgICAoT3B0aW9uV3JpdGVyLmFwcGx5KTogRGl0dG8uCisK IDIwMTctMDUtMjUgIEtlaXRoIE1pbGxlciAgPGtlaXRoX21pbGxlckBhcHBsZS5jb20+CiAKICAg ICAgICAgRGF0ZSBzaG91bGQgdXNlIGhpc3RvcmljYWwgZGF0YSBpZiBpdCdzIGF2YWlsYWJsZS4K SW5kZXg6IExheW91dFRlc3RzL2Zhc3QvaGFybmVzcy9yZXN1bHRzLmh0bWwKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gTGF5b3V0VGVzdHMvZmFzdC9oYXJuZXNzL3Jlc3VsdHMuaHRtbAkocmV2aXNpb24gMjE3NDMx KQorKysgTGF5b3V0VGVzdHMvZmFzdC9oYXJuZXNzL3Jlc3VsdHMuaHRtbAkod29ya2luZyBjb3B5 KQpAQCAtMTI5NywxMiArMTI5NywyNCBAQCBPcHRpb25Xcml0ZXIuc2F2ZSA9IGZ1bmN0aW9uKCkK ICAgICAgICAgdmFyIG9wdGlvbiA9IG9wdGlvbnNbaV07CiAgICAgICAgIGRhdGFbb3B0aW9uLmlk XSA9IG9wdGlvbi5jaGVja2VkOwogICAgIH0KLSAgICBsb2NhbFN0b3JhZ2Uuc2V0SXRlbShPcHRp b25Xcml0ZXIuX2tleSwgSlNPTi5zdHJpbmdpZnkoZGF0YSkpOworICAgIHRyeSB7CisgICAgICAg IGxvY2FsU3RvcmFnZS5zZXRJdGVtKE9wdGlvbldyaXRlci5fa2V5LCBKU09OLnN0cmluZ2lmeShk YXRhKSk7CisgICAgfSBjYXRjaCAoZXJyKSB7CisgICAgICAgIGlmIChlcnIubmFtZSAhPSAiU2Vj dXJpdHlFcnJvciIpCisgICAgICAgICAgICB0aHJvdyBlcnI7CisgICAgfQogfQogCiBPcHRpb25X cml0ZXIuYXBwbHkgPSBmdW5jdGlvbigpCiB7Ci0gICAgdmFyIGpzb24gPSBsb2NhbFN0b3JhZ2Uu Z2V0SXRlbShPcHRpb25Xcml0ZXIuX2tleSk7CisgICAgdmFyIGpzb247CisgICAgdHJ5IHsKKyAg ICAgICAganNvbiA9IGxvY2FsU3RvcmFnZS5nZXRJdGVtKE9wdGlvbldyaXRlci5fa2V5KTsKKyAg ICB9IGNhdGNoIChlcnIpIHsKKyAgICAgICBpZiAoZXJyLm5hbWUgIT0gIlNlY3VyaXR5RXJyb3Ii KQorICAgICAgICAgIHRocm93IGVycjsKKyAgICB9CisKICAgICBpZiAoIWpzb24pIHsKICAgICAg ICAgdXBkYXRlQWxsT3B0aW9ucygpOwogICAgICAgICByZXR1cm47Cg==