172622 2017-05-25 16:42:04 -0700 Web Inspector: Reloading the page after switching from the Resource tab switches back 2017-05-30 20:21:07 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi commit-queue inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1312959 0 hi 2017-05-25 16:42:04 -0700 * STEPS TO REPRODUCE 1. Inspect <https://webkit.org> 2. Show the Resources tab 3. Show the Console tab 4. Cmd+R to reload the page * EXPECTED Console tab stays visible * ACTUAL Debugger tab is shown 1312960 1 311316 hi 2017-05-25 16:45:10 -0700 Created attachment 311316 Patch 1313221 2 311316 joepeck 2017-05-26 13:25:21 -0700 Comment on attachment 311316 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=311316&action=review > Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js:433 > + if (!this.visible) > + return; Why don't other sidebars do this as well? Storage does. But why not Debugger/Search? I suggest solving it for other tabs as well before it pops up on them. Great sleuthing. 1313224 3 311370 hi 2017-05-26 13:36:41 -0700 Created attachment 311370 Patch 1313241 4 311370 commit-queue 2017-05-26 14:14:36 -0700 Comment on attachment 311370 Patch Clearing flags on attachment: 311370 Committed r217505: <http://trac.webkit.org/changeset/217505> 1313242 5 commit-queue 2017-05-26 14:14:41 -0700 All reviewed patches have been landed. Closing bug. 1314017 6 webkit-bug-importer 2017-05-30 20:21:07 -0700 <rdar://problem/32479702> 311316 2017-05-25 16:45:10 -0700 2017-05-26 13:36:41 -0700 Patch bug-172622-20170525164509.patch text/plain 1590 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDM3NmUyY2I0NjFmOTQ4ZjhlZDQ0ZTViOTFlNGUy YTA5ZGE3YzE2NzAuLjQ0NGNlOWNjMGMzMjQ3YzIyYjUxNWRjNzQ5NTZjNDUwZTdmNDhlM2UgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE3LTA1LTI1ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBS ZWxvYWRpbmcgdGhlIHBhZ2UgYWZ0ZXIgc3dpdGNoaW5nIGZyb20gdGhlIFJlc291cmNlIHRhYiBz d2l0Y2hlcyBiYWNrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNzI2MjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvUmVzb3VyY2VTaWRlYmFyUGFuZWwuanM6CisgICAg ICAgIChXZWJJbnNwZWN0b3IuUmVzb3VyY2VTaWRlYmFyUGFuZWwucHJvdG90eXBlLl90cmVlU2Vs ZWN0aW9uRGlkQ2hhbmdlKToKKyAgICAgICAgRG9uJ3Qgc2hvdyB0aGUgbmV3bHkgc2VsZWN0ZWQg dHJlZSBlbGVtZW50J3MgcmVwcmVzZW50ZWQgb2JqZWN0IGlmIHRoZSBzaWRlYmFyIGlzIG5vdCB2 aXNpYmxlLgorCiAyMDE3LTA1LTI1ICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNv bnkuY29tPgogCiAgICAgICAgIFtHVEtdIFdlYiBJbnNwZWN0b3I6IEFkZCBMaXN0U3R5bGVQb3Np dGlvbkluc2lkZS5zdmcgYW5kIExpc3RTdHlsZVBvc2l0aW9uT3V0c2lkZS5zdmcKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Jlc291cmNlU2lk ZWJhclBhbmVsLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv UmVzb3VyY2VTaWRlYmFyUGFuZWwuanMKaW5kZXggNmRlMGU4ZDNjOTFkNTFmZmYzYzRmYWU4ZGU0 NTEzMWI1NWFlNjYyNi4uZWYyMWUxNTgyZTkxNzg5Y2JjZjJmYzAzNjJkYjFiODY3YzYyMTlkYyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvUmVz b3VyY2VTaWRlYmFyUGFuZWwuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvUmVzb3VyY2VTaWRlYmFyUGFuZWwuanMKQEAgLTQyOSw2ICs0MjksOSBAQCBX ZWJJbnNwZWN0b3IuUmVzb3VyY2VTaWRlYmFyUGFuZWwgPSBjbGFzcyBSZXNvdXJjZVNpZGViYXJQ YW5lbCBleHRlbmRzIFdlYkluc3BlYwogCiAgICAgX3RyZWVTZWxlY3Rpb25EaWRDaGFuZ2UoZXZl bnQpCiAgICAgeworICAgICAgICBpZiAoIXRoaXMudmlzaWJsZSkKKyAgICAgICAgICAgIHJldHVy bjsKKwogICAgICAgICBsZXQgdHJlZUVsZW1lbnQgPSBldmVudC5kYXRhLnNlbGVjdGVkRWxlbWVu dDsKICAgICAgICAgaWYgKCF0cmVlRWxlbWVudCkKICAgICAgICAgICAgIHJldHVybjsK 311370 2017-05-26 13:36:41 -0700 2017-05-26 14:14:36 -0700 Patch 172622.diff text/plain 3050 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDM3NmUyY2I0NjFmLi5kNzFjZDY2NWMxNCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTctMDUtMjYgIERldmlu IFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFJl bG9hZGluZyB0aGUgcGFnZSBhZnRlciBzd2l0Y2hpbmcgZnJvbSB0aGUgUmVzb3VyY2UgdGFiIHN3 aXRjaGVzIGJhY2sKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE3MjYyMgorCisgICAgICAgIFJldmlld2VkIGJ5IEpvc2VwaCBQZWNvcmFyby4KKworICAg ICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvRGVidWdnZXJTaWRlYmFyUGFuZWwuanM6CisgICAg ICAgIChXZWJJbnNwZWN0b3IuRGVidWdnZXJTaWRlYmFyUGFuZWwucHJvdG90eXBlLl90cmVlU2Vs ZWN0aW9uRGlkQ2hhbmdlKToKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1Jlc291cmNl U2lkZWJhclBhbmVsLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlJlc291cmNlU2lkZWJhclBh bmVsLnByb3RvdHlwZS5fdHJlZVNlbGVjdGlvbkRpZENoYW5nZSk6CisgICAgICAgICogVXNlcklu dGVyZmFjZS9WaWV3cy9TZWFyY2hTaWRlYmFyUGFuZWwuanM6CisgICAgICAgIChXZWJJbnNwZWN0 b3IuU2VhcmNoU2lkZWJhclBhbmVsLnByb3RvdHlwZS5fdHJlZVNlbGVjdGlvbkRpZENoYW5nZSk6 CisgICAgICAgIERvbid0IHNob3cgdGhlIG5ld2x5IHNlbGVjdGVkIHRyZWUgZWxlbWVudCdzIHJl cHJlc2VudGVkIG9iamVjdCBpZiB0aGUgc2lkZWJhciBpcyBub3QgdmlzaWJsZS4KKwogMjAxNy0w NS0yNSAgRnVqaWkgSGlyb25vcmkgIDxIaXJvbm9yaS5GdWppaUBzb255LmNvbT4KIAogICAgICAg ICBbR1RLXSBXZWIgSW5zcGVjdG9yOiBBZGQgTGlzdFN0eWxlUG9zaXRpb25JbnNpZGUuc3ZnIGFu ZCBMaXN0U3R5bGVQb3NpdGlvbk91dHNpZGUuc3ZnCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9EZWJ1Z2dlclNpZGViYXJQYW5lbC5qcyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RlYnVnZ2VyU2lkZWJhclBh bmVsLmpzCmluZGV4IDVkNDk5ZmUyMDY5Li5mMTEyNjQ5MjM1YyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRGVidWdnZXJTaWRlYmFyUGFuZWwu anMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRGVidWdn ZXJTaWRlYmFyUGFuZWwuanMKQEAgLTgyMyw2ICs4MjMsOSBAQCBXZWJJbnNwZWN0b3IuRGVidWdn ZXJTaWRlYmFyUGFuZWwgPSBjbGFzcyBEZWJ1Z2dlclNpZGViYXJQYW5lbCBleHRlbmRzIFdlYklu c3BlYwogCiAgICAgX3RyZWVTZWxlY3Rpb25EaWRDaGFuZ2UoZXZlbnQpCiAgICAgeworICAgICAg ICBpZiAoIXRoaXMudmlzaWJsZSkKKyAgICAgICAgICAgIHJldHVybjsKKwogICAgICAgICBsZXQg dHJlZUVsZW1lbnQgPSBldmVudC5kYXRhLnNlbGVjdGVkRWxlbWVudDsKICAgICAgICAgaWYgKCF0 cmVlRWxlbWVudCkKICAgICAgICAgICAgIHJldHVybjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Jlc291cmNlU2lkZWJhclBhbmVsLmpzIGIv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvUmVzb3VyY2VTaWRlYmFy UGFuZWwuanMKaW5kZXggNmRlMGU4ZDNjOTEuLmVmMjFlMTU4MmU5IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9SZXNvdXJjZVNpZGViYXJQYW5l bC5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9SZXNv dXJjZVNpZGViYXJQYW5lbC5qcwpAQCAtNDI5LDYgKzQyOSw5IEBAIFdlYkluc3BlY3Rvci5SZXNv dXJjZVNpZGViYXJQYW5lbCA9IGNsYXNzIFJlc291cmNlU2lkZWJhclBhbmVsIGV4dGVuZHMgV2Vi SW5zcGVjCiAKICAgICBfdHJlZVNlbGVjdGlvbkRpZENoYW5nZShldmVudCkKICAgICB7CisgICAg ICAgIGlmICghdGhpcy52aXNpYmxlKQorICAgICAgICAgICAgcmV0dXJuOworCiAgICAgICAgIGxl dCB0cmVlRWxlbWVudCA9IGV2ZW50LmRhdGEuc2VsZWN0ZWRFbGVtZW50OwogICAgICAgICBpZiAo IXRyZWVFbGVtZW50KQogICAgICAgICAgICAgcmV0dXJuOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU2VhcmNoU2lkZWJhclBhbmVsLmpzIGIv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU2VhcmNoU2lkZWJhclBh bmVsLmpzCmluZGV4IDRjZmE4MWI2NTA3Li43ODYzZmI2ZmYzYyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU2VhcmNoU2lkZWJhclBhbmVsLmpz CisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NlYXJjaFNp ZGViYXJQYW5lbC5qcwpAQCAtMzUxLDYgKzM1MSw5IEBAIFdlYkluc3BlY3Rvci5TZWFyY2hTaWRl YmFyUGFuZWwgPSBjbGFzcyBTZWFyY2hTaWRlYmFyUGFuZWwgZXh0ZW5kcyBXZWJJbnNwZWN0b3Iu CiAKICAgICBfdHJlZVNlbGVjdGlvbkRpZENoYW5nZShldmVudCkKICAgICB7CisgICAgICAgIGlm ICghdGhpcy52aXNpYmxlKQorICAgICAgICAgICAgcmV0dXJuOworCiAgICAgICAgIGxldCB0cmVl RWxlbWVudCA9IGV2ZW50LmRhdGEuc2VsZWN0ZWRFbGVtZW50OwogICAgICAgICBpZiAoIXRyZWVF bGVtZW50IHx8IHRyZWVFbGVtZW50IGluc3RhbmNlb2YgV2ViSW5zcGVjdG9yLkZvbGRlclRyZWVF bGVtZW50KQogICAgICAgICAgICAgcmV0dXJuOwo=