172618 2017-05-25 16:06:49 -0700 Building with GCC 7.1.x spews lots of “warning: this use of "defined" may not be portable [-Wexpansion-to-defined]“ 2017-05-25 20:12:17 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED DUPLICATE 167643 P2 Normal --- 1 aperez aperez achristensen lforschler mcatanzaro ysuzuki oldest_to_newest 1312938 0 aperez 2017-05-25 16:06:49 -0700 This happens for all the expansions of: - #if ENABLE(FOO) - #if PLATFORM(FOO) - #if CPU(FOO) - #if USE(FOO) - #if HAVE(FOO) - ... For example: ../../Source/WTF/wtf/Platform.h:807:1: warning: this use of "defined" may not be portable [-Wexpansion-to-defined] #if (CPU(X86_64) || CPU(ARM64)) && HAVE(FAST_TLS) ^~~~~~~~~~~~~ It seems that the -Wexpansion-to-defined existed before in GCC, but the warning is now enabled by default in version 7.1.x of the compiler. WebKit source code makes extensive use of this kind of expansions, so probably it'd be better to silence these warnings. 1312940 1 311307 aperez 2017-05-25 16:10:42 -0700 Created attachment 311307 Patch 1313015 2 mcatanzaro 2017-05-25 19:57:32 -0700 I know you already have a patch here and normally I'd favor the bug with the patch, but there's good discussion in bug #167643 so please reattach it there. My concern is that these macros are all undefined behavior, so we should consider eliminating them. *** This bug has been marked as a duplicate of bug 167643 *** 1313017 3 311307 mcatanzaro 2017-05-25 20:12:17 -0700 Comment on attachment 311307 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=311307&action=review > Source/cmake/OptionsCommon.cmake:78 > + if (CMAKE_C_COMPILER_VERSION VERSION_GREATER_EQUAL "7.1.0") > + set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wno-expansion-to-defined") > + endif () No need to check compiler version, just enable it unconditionally. Look for wherever our other warning flags are used; we probably don't need to add a new line, just add it to wherever the other ones are. 311307 2017-05-25 16:10:42 -0700 2017-05-25 19:57:40 -0700 Patch bug-172618-20170526011040.patch text/plain 1921 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjE3NDU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0NvbW1vbi5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCmluZGV4 IGU3N2M3MDc2Zjg1NWMzOGFhNmUzMTliZTczODZhM2JkNWE1ZmRiOTcuLjA4ZGFlMDk0ZGNlZjc0 ZDRkZGNhNjIxNjE5MWU0YTYxMTgxNGYyNzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRp b25zQ29tbW9uLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCkBA IC03MywxMSArNzMsMTcgQEAgZW5kbWFjcm8oKQogaWYgKENNQUtFX0NPTVBJTEVSX0lTX0dOVUND KQogICAgREVURVJNSU5FX0dDQ19TWVNURU1fSU5DTFVERV9ESVJTKCJjIiAiJHtDTUFLRV9DX0NP TVBJTEVSfSIgIiR7Q01BS0VfQ19GTEFHU30iIFNZU1RFTV9JTkNMVURFX0RJUlMpCiAgICBzZXQo Q01BS0VfQ19JTVBMSUNJVF9JTkNMVURFX0RJUkVDVE9SSUVTICR7Q01BS0VfQ19JTVBMSUNJVF9J TkNMVURFX0RJUkVDVE9SSUVTfSAke1NZU1RFTV9JTkNMVURFX0RJUlN9KQorICAgaWYgKENNQUtF X0NfQ09NUElMRVJfVkVSU0lPTiBWRVJTSU9OX0dSRUFURVJfRVFVQUwgIjcuMS4wIikKKyAgICAg c2V0KENNQUtFX0NfRkxBR1MgIiR7Q01BS0VfQ19GTEFHU30gLVduby1leHBhbnNpb24tdG8tZGVm aW5lZCIpCisgICBlbmRpZiAoKQogZW5kaWYgKCkKIAogaWYgKENNQUtFX0NPTVBJTEVSX0lTX0dO VUNYWCkKICAgIERFVEVSTUlORV9HQ0NfU1lTVEVNX0lOQ0xVREVfRElSUygiYysrIiAiJHtDTUFL RV9DWFhfQ09NUElMRVJ9IiAiJHtDTUFLRV9DWFhfRkxBR1N9IiBTWVNURU1fSU5DTFVERV9ESVJT KQogICAgc2V0KENNQUtFX0NYWF9JTVBMSUNJVF9JTkNMVURFX0RJUkVDVE9SSUVTICR7Q01BS0Vf Q1hYX0lNUExJQ0lUX0lOQ0xVREVfRElSRUNUT1JJRVN9ICR7U1lTVEVNX0lOQ0xVREVfRElSU30p CisgICBpZiAoQ01BS0VfQ1hYX0NPTVBJTEVSX1ZFUlNJT04gVkVSU0lPTl9HUkVBVEVSX0VRVUFM ICI3LjEuMCIpCisgICAgIHNldChDTUFLRV9DWFhfRkxBR1MgIiR7Q01BS0VfQ1hYX0ZMQUdTfSAt V25vLWV4cGFuc2lvbi10by1kZWZpbmVkIikKKyAgIGVuZGlmICgpCiBlbmRpZiAoKQogCiAjIERl dGVjdCBDb3J0ZXgtQTUzIGNvcmUgaWYgQ1BVIGlzIEFSTTY0IGFuZCBPUyBpcyBMaW51eC4KZGlm ZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBkMmZhYzc0ZDMxZTk0MjRlOWY3 ZTA3OGVmOWZkNTU0YTgwNGQ1MWVmLi44YWFmZmZlZGE2OTE0ZjNjMjM3OTVmNTk4YjQ0MGVjY2Vm MDQzMDg2IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MTIgQEAKKzIwMTctMDUtMjUgIEFkcmlhbiBQZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlh LmNvbT4KKworICAgICAgICBCdWlsZGluZyB3aXRoIEdDQyA3LjEueCBzcGV3cyBsb3RzIG9mICd3 YXJuaW5nOiB0aGlzIHVzZSBvZiAiZGVmaW5lZCIgbWF5IG5vdCBiZSBwb3J0YWJsZSBbLVdleHBh bnNpb24tdG8tZGVmaW5lZF0nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNzI2MTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlOiBQYXNzIC1Xbm8t ZXhwYW5zaW9uLXRvLWRlZmluZWQgd2hlbiBHQ0MgdmVyc2lvbiBpcyA3LjEuMCBvciBuZXdlci4K KwogMjAxNy0wNS0yNSAgRG9uIE9sbXN0ZWFkICA8ZG9uLm9sbXN0ZWFkQGFtLnNvbnkuY29tPgog CiAgICAgICAgIFtDTWFrZV1bV2luXSBVc2UgV1RGX0NQVSBub3QgTVNDVl9DWFhfQVJDSElURUNU VVJFX0lEIHdoZW4gZGV0ZXJtaW5pbmcgbGliIGRpcmVjdG9yaWVzCg==