172615 2017-05-25 15:24:46 -0700 ASSERT(m_websiteDataStore->websiteDataStore().sessionID() == m_sessionID) in PageConfiguration::sessionID() 2017-05-25 15:33:32 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 171408 1 cdumez cdumez achristensen beidson ggaren webkit-bug-importer oldest_to_newest 1312918 0 cdumez 2017-05-25 15:24:46 -0700 ASSERT(m_websiteDataStore->websiteDataStore().sessionID() == m_sessionID) is sometimes hit in PageConfiguration::sessionID(). 1312919 1 cdumez 2017-05-25 15:25:00 -0700 <rdar://problem/32277488> 1312920 2 311302 cdumez 2017-05-25 15:27:37 -0700 Created attachment 311302 Patch 1312925 3 311302 cdumez 2017-05-25 15:33:02 -0700 Comment on attachment 311302 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=311302&action=review > Source/WebKit2/UIProcess/API/APIPageConfiguration.cpp:158 > + RELEASE_ASSERT(!m_websiteDataStore || m_websiteDataStore->websiteDataStore().sessionID() == m_sessionID || m_sessionID == SessionID::legacyPrivateSessionID()); Didn't mean to make this a RELEASE_ASSERT. Will fix before landing. 1312926 4 cdumez 2017-05-25 15:33:32 -0700 Committed r217455: <http://trac.webkit.org/changeset/217455> 311302 2017-05-25 15:27:37 -0700 2017-05-25 15:31:25 -0700 Patch bug-172615-20170525152736.patch text/plain 2332 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjE3NDQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNGU2Y2IxNGQ1NzhjOWEz ZjU4YzhlYjk2NDFhNjQ1OWFiNzBkNGQ0My4uMDgzNGVjMGVlNzkxYzE1ZDdkZDQzNTI0MjQzMGU3 NjMxYTc3NWNkZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE3LTA1LTI1ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQVNTRVJUKG1fd2Vic2l0ZURh dGFTdG9yZS0+d2Vic2l0ZURhdGFTdG9yZSgpLnNlc3Npb25JRCgpID09IG1fc2Vzc2lvbklEKSBp biBQYWdlQ29uZmlndXJhdGlvbjo6c2Vzc2lvbklEKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MjYxNQorICAgICAgICA8cmRhcjovL3Byb2JsZW0v MzIyNzc0ODg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgRml4IGFzc2VydGlvbiBhZGRlZCBpbiByMjE1OTIzIHRvIHRha2UgaW50byBhY2NvdW50IHRo ZSBmYWN0IHRoYXQgdGhlIFBhZ2VDb25maWd1cmF0aW9uJ3Mgc2Vzc2lvbklECisgICAgICAgIGlz IFNlc3Npb25JRDo6bGVnYWN5UHJpdmF0ZVNlc3Npb25JRCgpIHdoZW4gcHJpdmF0ZSBicm93c2lu ZyBpcyBlbmFibGVkLCBpbnN0ZWFkIG9mIGJlaW5nIHRoZQorICAgICAgICBXZWJzaXRlRGF0YVN0 b3JlJ3Mgc2Vzc2lvbklELgorCisgICAgICAgIFNlZSBjb2RlIGluIFdlYlByb2Nlc3NQb29sOjpj cmVhdGVXZWJQYWdlKCk6CisgICAgICAgICIiIgorICAgICAgICBwYWdlQ29uZmlndXJhdGlvbi0+ c2V0U2Vzc2lvbklEKHBhZ2VDb25maWd1cmF0aW9uLT5wcmVmZXJlbmNlcygpLT5wcml2YXRlQnJv d3NpbmdFbmFibGVkKCkgPyBTZXNzaW9uSUQ6OmxlZ2FjeVByaXZhdGVTZXNzaW9uSUQoKSA6IG1f d2Vic2l0ZURhdGFTdG9yZS0+d2Vic2l0ZURhdGFTdG9yZSgpLnNlc3Npb25JRCgpKTsKKyAgICAg ICAgIiIiCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0FQSVBhZ2VDb25maWd1cmF0aW9uLmNw cDoKKyAgICAgICAgKEFQSTo6UGFnZUNvbmZpZ3VyYXRpb246OnNlc3Npb25JRCk6CisKIDIwMTct MDUtMjUgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIGNvbS5h cHBsZS5jb3JlbWVkaWEudmlkZW9lbmNvZGVyIFhQQyBzZXJ2aWNlIHNob3VsZCBiZSBhbGxvd2Vk IGJ5IFdlYlByb2Nlc3Mgc2FuZGJveApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9BUElQYWdlQ29uZmlndXJhdGlvbi5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL0FQSVBhZ2VDb25maWd1cmF0aW9uLmNwcAppbmRleCBhMGFjZTllMDc4MmVkMmEwMjNi ODQ4ZGQyNTExY2UzY2I2MTI0ZGVkLi5jMmY5Y2QzMGU4MTlhOWZlZDFmZDNmNmNiMjlkMzViODIw YTNlNDRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0FQSVBhZ2VD b25maWd1cmF0aW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0FQSVBh Z2VDb25maWd1cmF0aW9uLmNwcApAQCAtMzMsNiArMzMsNyBAQAogI2luY2x1ZGUgIldlYlByb2Nl c3NQb29sLmgiCiAjaW5jbHVkZSAiV2ViVXNlckNvbnRlbnRDb250cm9sbGVyUHJveHkuaCIKIAor dXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CiB1c2luZyBuYW1lc3BhY2UgV2ViS2l0OwogCiBuYW1l c3BhY2UgQVBJIHsKQEAgLTE1NCwxMCArMTU1LDcgQEAgdm9pZCBQYWdlQ29uZmlndXJhdGlvbjo6 c2V0V2Vic2l0ZURhdGFTdG9yZShBUEk6OldlYnNpdGVEYXRhU3RvcmUqIHdlYnNpdGVEYXRhU3QK IAogV2ViQ29yZTo6U2Vzc2lvbklEIFBhZ2VDb25maWd1cmF0aW9uOjpzZXNzaW9uSUQoKQogewot I2lmICFBU1NFUlRfRElTQUJMRUQKLSAgICBpZiAobV93ZWJzaXRlRGF0YVN0b3JlKQotICAgICAg ICBBU1NFUlQobV93ZWJzaXRlRGF0YVN0b3JlLT53ZWJzaXRlRGF0YVN0b3JlKCkuc2Vzc2lvbklE KCkgPT0gbV9zZXNzaW9uSUQpOwotI2VuZGlmCisgICAgUkVMRUFTRV9BU1NFUlQoIW1fd2Vic2l0 ZURhdGFTdG9yZSB8fCBtX3dlYnNpdGVEYXRhU3RvcmUtPndlYnNpdGVEYXRhU3RvcmUoKS5zZXNz aW9uSUQoKSA9PSBtX3Nlc3Npb25JRCB8fCBtX3Nlc3Npb25JRCA9PSBTZXNzaW9uSUQ6OmxlZ2Fj eVByaXZhdGVTZXNzaW9uSUQoKSk7CiAKICAgICByZXR1cm4gbV9zZXNzaW9uSUQ7CiB9Cg==