172595 2017-05-25 09:17:14 -0700 Clang warns about (intended) returning pointer to stack location in WTF/wtf/ThreadingPthreads.cpp 2017-05-30 20:21:38 -0700 1 1 1 Unclassified WebKit Web Template Framework Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aperez aperez benjamin buildbot cdumez cmarcelo commit-queue dbates keith_miller mark.lam mcatanzaro webkit-bug-importer ysuzuki oldest_to_newest 1312661 0 aperez 2017-05-25 09:17:14 -0700 When building with Clang (at least on GNU/Linux), the warning is: ../../Source/WTF/wtf/ThreadingPthreads.cpp:105:13: warning: address of stack memory associated with local variable 'stackLocation' returned [-Wreturn-stack-address] return &stackLocation; ^~~~~~~~~~~~~ 1 warning generated. It is possible to use a #pragma to silence this warning (as done for GCC). I'm making a patch to silence this warning, because in here returning a pointer to the stack is precisely what's intended. 1312662 1 311226 aperez 2017-05-25 09:20:13 -0700 Created attachment 311226 Patch 1312670 2 311226 mark.lam 2017-05-25 09:37:20 -0700 Comment on attachment 311226 Patch r=me 1312700 3 311226 commit-queue 2017-05-25 10:07:19 -0700 Comment on attachment 311226 Patch Clearing flags on attachment: 311226 Committed r217431: <http://trac.webkit.org/changeset/217431> 1312701 4 commit-queue 2017-05-25 10:07:20 -0700 All reviewed patches have been landed. Closing bug. 1314025 5 webkit-bug-importer 2017-05-30 20:21:38 -0700 <rdar://problem/32479723> 311226 2017-05-25 09:20:13 -0700 2017-05-25 10:07:19 -0700 Patch bug-172595-20170525182012.patch text/plain 1777 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjE3NDI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDc0Y2FhZjY4OWY3MjExMjExNjBkMjA3 YzJjNDc5ZDhlMTU4MDgzMzAuLjhmN2E2ZjMxNjlmNDc4ZTQ3MmUzODBkMThhMGRkZTZiNGI1NjNl NjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTctMDUtMjUgIEFkcmlhbiBQZXJleiBkZSBDYXN0 cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBDbGFuZyB3YXJucyBhYm91dCAoaW50 ZW5kZWQpIHJldHVybmluZyBwb2ludGVyIHRvIHN0YWNrIGxvY2F0aW9uIGluIFdURi93dGYvVGhy ZWFkaW5nUHRocmVhZHMuY3BwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNzI1OTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIHd0Zi9UaHJlYWRpbmdQdGhyZWFkcy5jcHA6IFVzZSBhICNwcmFnbWEgdG8g c2lsZW5jZSBDbGFuZyB3YXJuaW5nIGFib3V0IHJldHVybmluZyBhCisgICAgICAgIHBvaW50ZXIg dG8gdGhlIHN0YWNrICh3aGljaCBpcyBpbnRlbmRlZCkKKwogMjAxNy0wNS0yNSAgRGF2aWQgS2ls emVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04gKHIyMTc0MTYp OiBVc2luZyAjcHJhZ21hIG9uY2UgaW4gV1RGU3RyaW5nLmggYnJva2UgdGhlIGJ1aWxkCmRpZmYg LS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9UaHJlYWRpbmdQdGhyZWFkcy5jcHAgYi9Tb3VyY2UvV1RG L3d0Zi9UaHJlYWRpbmdQdGhyZWFkcy5jcHAKaW5kZXggZDM0ZDc5OGYyOWJmODk5MDA0MmRhNTE4 YTljZmI3YTE2M2E4NjgyZC4uZjkwNGE5MzkzMDYwMGM0MDBjNDY3N2JiZTI3ZGIxYWU5ZDhjYTQ0 YiAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvVGhyZWFkaW5nUHRocmVhZHMuY3BwCisrKyBi L1NvdXJjZS9XVEYvd3RmL1RocmVhZGluZ1B0aHJlYWRzLmNwcApAQCAtOTksNiArOTksMTEgQEAg c3RhdGljIFN0YXRpY1dvcmRMb2NrIGdsb2JhbFN1c3BlbmRMb2NrOwogI3ByYWdtYSBHQ0MgZGlh Z25vc3RpYyBpZ25vcmVkICItV3JldHVybi1sb2NhbC1hZGRyIgogI2VuZGlmIC8vIENPTVBJTEVS KEdDQykKIAorI2lmIENPTVBJTEVSKENMQU5HKQorI3ByYWdtYSBjbGFuZyBkaWFnbm9zdGljIHB1 c2gKKyNwcmFnbWEgY2xhbmcgZGlhZ25vc3RpYyBpZ25vcmVkICItV3JldHVybi1zdGFjay1hZGRy ZXNzIgorI2VuZGlmIC8vIENPTVBJTEVSKENMQU5HKQorCiBzdGF0aWMgVU5VU0VEX0ZVTkNUSU9O IE5FVkVSX0lOTElORSB2b2lkKiBnZXRBcHByb3hpbWF0ZVN0YWNrUG9pbnRlcigpCiB7CiAgICAg dm9sYXRpbGUgdm9pZCogc3RhY2tMb2NhdGlvbiA9IG51bGxwdHI7CkBAIC0xMDksNiArMTE0LDEw IEBAIHN0YXRpYyBVTlVTRURfRlVOQ1RJT04gTkVWRVJfSU5MSU5FIHZvaWQqIGdldEFwcHJveGlt YXRlU3RhY2tQb2ludGVyKCkKICNwcmFnbWEgR0NDIGRpYWdub3N0aWMgcG9wCiAjZW5kaWYgLy8g Q09NUElMRVIoR0NDKQogCisjaWYgQ09NUElMRVIoQ0xBTkcpCisjcHJhZ21hIGNsYW5nIGRpYWdu b3N0aWMgcG9wCisjZW5kaWYgLy8gQ09NUElMRVIoQ0xBTkcpCisKIHN0YXRpYyBVTlVTRURfRlVO Q1RJT04gYm9vbCBpc09uQWx0ZXJuYXRpdmVTaWduYWxTdGFjaygpCiB7CiAgICAgc3RhY2tfdCBz dGFjayB7IH07Cg==