17259 2008-02-09 10:56:44 -0800 Element::recalcStyle() needlessly null-checks the result of styleForElement() 2008-02-09 16:17:05 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 mitz webkit-unassigned oldest_to_newest 69928 0 mitz 2008-02-09 10:56:44 -0800 Element::recalcStyle() needlessly null-checks the result of styleForElement(). 69929 1 19019 mitz 2008-02-09 10:58:09 -0800 Created attachment 19019 Remove unneeded null checks 69975 2 19019 sam 2008-02-09 15:58:12 -0800 Comment on attachment 19019 Remove unneeded null checks This looks good to me, but as discussed, a better word than redundant should be used to describe why the null checks aren't needed. Just stating that styleForElement() cannot return null should be sufficient. 69979 3 mitz 2008-02-09 16:17:05 -0800 Fixed in <http://trac.webkit.org/projects/webkit/changeset/30117>. 19019 2008-02-09 10:58:09 -0800 2008-02-09 15:58:12 -0800 Remove unneeded null checks recalcStyle-null-checks.diff text/plain 1964 mitz SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzMDEwOSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTIgQEAKKzIwMDgtMDItMDkgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNv bT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAtIHJl bW92ZSByZWR1bmRhbnQgbnVsbCBjaGVja3MKKworICAgICAgICAqIGRvbS9FbGVtZW50LmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkVsZW1lbnQ6OnJlY2FsY1N0eWxlKToKKwogMjAwOC0wMi0wNyAg S2V2aW4gT2xsaXZpZXIgPGtldmlub0B0aGVvbGxpdmllcnMuY29tPgogCiAgICAgICAgIFJldmll d2VkIGJ5IEVyaWMgU2VpZGVsLCBBZGFtIFJvYmVuLgpJbmRleDogV2ViQ29yZS9kb20vRWxlbWVu dC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9kb20vRWxlbWVudC5jcHAJKHJldmlzaW9uIDMw MTA5KQorKysgV2ViQ29yZS9kb20vRWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTcyNyw3 ICs3MjcsNyBAQCB2b2lkIEVsZW1lbnQ6OnJlY2FsY1N0eWxlKFN0eWxlQ2hhbmdlIGNoCiAgICAg ICAgICAgICByZXR1cm47CiAgICAgICAgIH0KIAotICAgICAgICBpZiAoY3VycmVudFN0eWxlICYm IG5ld1N0eWxlKSB7CisgICAgICAgIGlmIChjdXJyZW50U3R5bGUpIHsKICAgICAgICAgICAgIC8v IFByZXNlcnZlICJhZmZlY3RlZCBieSIgYml0cyB0aGF0IHdlcmUgcHJvcGFnYXRlZCB0byB1cyBm cm9tIGRlc2NlbmRhbnRzIGluIHRoZSBjYXNlIHdoZXJlIHdlIGRpZG4ndCBkbyBhIGZ1bGwKICAg ICAgICAgICAgIC8vIHN0eWxlIGNoYW5nZSAoZS5nLiwgb25seSBpbmxpbmUgc3R5bGUgY2hhbmdl ZCkuCiAgICAgICAgICAgICBpZiAoY3VycmVudFN0eWxlLT5hZmZlY3RlZEJ5SG92ZXJSdWxlcygp KQpAQCAtNzQ0LDEwICs3NDQsOSBAQCB2b2lkIEVsZW1lbnQ6OnJlY2FsY1N0eWxlKFN0eWxlQ2hh bmdlIGNoCiAgICAgICAgICAgICAgICAgbmV3U3R5bGUtPnNldENoaWxkcmVuQWZmZWN0ZWRCeUxh c3RDaGlsZFJ1bGVzKCk7CiAgICAgICAgIH0KIAotICAgICAgICBpZiAoY2ggIT0gTm9DaGFuZ2Up IHsKLSAgICAgICAgICAgIGlmIChuZXdTdHlsZSkKLSAgICAgICAgICAgICAgICBzZXRSZW5kZXJT dHlsZShuZXdTdHlsZSk7Ci0gICAgICAgIH0gZWxzZSBpZiAoY2hhbmdlZCgpICYmIG5ld1N0eWxl ICYmIChkb2N1bWVudCgpLT51c2VzU2libGluZ1J1bGVzKCkgfHwgZG9jdW1lbnQoKS0+dXNlc0Rl c2NlbmRhbnRSdWxlcygpKSkgeworICAgICAgICBpZiAoY2ggIT0gTm9DaGFuZ2UpCisgICAgICAg ICAgICBzZXRSZW5kZXJTdHlsZShuZXdTdHlsZSk7CisgICAgICAgIGVsc2UgaWYgKGNoYW5nZWQo KSAmJiAoZG9jdW1lbnQoKS0+dXNlc1NpYmxpbmdSdWxlcygpIHx8IGRvY3VtZW50KCktPnVzZXNE ZXNjZW5kYW50UnVsZXMoKSkpIHsKICAgICAgICAgICAgIC8vIEFsdGhvdWdoIG5vIGNoYW5nZSBv Y2N1cnJlZCwgd2UgdXNlIHRoZSBuZXcgc3R5bGUgc28gdGhhdCB0aGUgY291c2luIHN0eWxlIHNo YXJpbmcgY29kZSB3b24ndCBnZXQKICAgICAgICAgICAgIC8vIGZvb2xlZCBpbnRvIGJlbGlldmlu ZyB0aGlzIHN0eWxlIGlzIHRoZSBzYW1lLiAgVGhpcyBpcyBvbmx5IG5lY2Vzc2FyeSBpZiB0aGUg ZG9jdW1lbnQgYWN0dWFsbHkgdXNlcwogICAgICAgICAgICAgLy8gc2libGluZy9kZXNjZW5kYW50 IHJ1bGVzLCBzaW5jZSBvdGhlcndpc2UgaXQgaXNuJ3QgcG9zc2libGUgZm9yIGFuY2VzdG9yIHN0 eWxlcyB0byBhZmZlY3Qgc2hhcmluZyBvZgo=