172546 2017-05-24 10:30:16 -0700 [WK2] Remove workaround to disable zooming to the focus rect while performing a data interaction 2017-05-30 20:24:06 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh bdakin buildbot commit-queue megan_gardner thorton webkit-bug-importer oldest_to_newest 1312301 0 wenson_hsieh 2017-05-24 10:30:16 -0700 Remove a now-unnecessary workaround to prevent scrolling when performing a data interaction operation in editable content. 1312303 1 311130 wenson_hsieh 2017-05-24 10:36:44 -0700 Created attachment 311130 Patch 1312306 2 buildbot 2017-05-24 10:39:03 -0700 Attachment 311130 did not pass style-queue: ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1149: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1150: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1151: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1152: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1153: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1154: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1155: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 7 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1312331 3 311130 commit-queue 2017-05-24 11:38:56 -0700 Comment on attachment 311130 Patch Clearing flags on attachment: 311130 Committed r217375: <http://trac.webkit.org/changeset/217375> 1312332 4 commit-queue 2017-05-24 11:38:57 -0700 All reviewed patches have been landed. Closing bug. 1312339 5 wenson_hsieh 2017-05-24 11:47:36 -0700 <rdar://problem/31949588> 1314041 6 webkit-bug-importer 2017-05-30 20:24:06 -0700 <rdar://problem/32479771> 311130 2017-05-24 10:36:44 -0700 2017-05-24 11:38:56 -0700 Patch bug-172546-20170524103643.patch text/plain 3560 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjE3MzY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNDE2M2UwYWRhMzA0MWIw ZDM4MTk4MDQ2MTg4YjhmZDcyNzE2Y2YyNi4uMzljMWQ2ZTQ3ZjIwOTcwZWMyY2U2MDQ3NDk2MDQ3 YmRkZDFjMmNiNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE3LTA1LTI0ICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIFtXSzJdIFJlbW92 ZSB3b3JrYXJvdW5kIHRvIGRpc2FibGUgem9vbWluZyB0byB0aGUgZm9jdXMgcmVjdCB3aGlsZSBw ZXJmb3JtaW5nIGEgZGF0YSBpbnRlcmFjdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcyNTQ2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlcyBhIG5vdy11bm5lY2Vzc2FyeSB3b3JrYXJvdW5k IHRvIHByZXZlbnQgc2Nyb2xsaW5nIHdoZW4gcGVyZm9ybWluZyBhIGRhdGEgaW50ZXJhY3Rpb24g b3BlcmF0aW9uIGluCisgICAgICAgIGVkaXRhYmxlIGNvbnRlbnQuCisKKyAgICAgICAgKiBVSVBy b2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbToKKyAgICAgICAgKC1bV0tDb250 ZW50VmlldyBfZGlzcGxheUZvcm1Ob2RlSW5wdXRWaWV3XSk6CisKIDIwMTctMDUtMjMgIEpvaG4g V2lsYW5kZXIgIDx3aWxhbmRlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmVzb3VyY2UgTG9hZCBT dGF0aXN0aWNzOiBEb24ndCBpbmNsdWRlIEhTVFMgY2FjaGUgZGF0YSBpbiB3ZWJzaXRlIGRhdGEg cmVtb3ZhbApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRl bnRWaWV3SW50ZXJhY3Rpb24ubW0gYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29u dGVudFZpZXdJbnRlcmFjdGlvbi5tbQppbmRleCA2NmYwOGYxOTZkNDI1NGMwYTZlNjcyOTNiMjFk MTc1ZjJiNDIyNjNjLi41MzZkZjllNTgwOWE2ZTBiZDkxMDVlNjBiZmFmZTU3ZDYzM2ZjOTY1IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRl cmFjdGlvbi5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZp ZXdJbnRlcmFjdGlvbi5tbQpAQCAtMTE0MywyMyArMTE0MywxNiBAQCAtIChCT09MKV9yZXF1aXJl c0tleWJvYXJkUmVzZXRPblJlbG9hZAogCiAtICh2b2lkKV9kaXNwbGF5Rm9ybU5vZGVJbnB1dFZp ZXcKIHsKLSAgICBCT09MIHNob3VsZFpvb21Ub0ZvY3VzUmVjdCA9IFlFUzsKLSNpZiBFTkFCTEUo REFUQV9JTlRFUkFDVElPTikKLSAgICAvLyBGSVhNRTogV2UgbmVlZCB0byB0ZWFjaCBXS1dlYlZp ZXcgdG8gcHJvcGVybHkgem9vbSBhbmQgc2Nyb2xsIGR1cmluZyBhIGRhdGEgaW50ZXJhY3Rpb24g b3BlcmF0aW9uLgotICAgIHNob3VsZFpvb21Ub0ZvY3VzUmVjdCA9ICFfZGF0YUludGVyYWN0aW9u U3RhdGUuaXNQZXJmb3JtaW5nT3BlcmF0aW9uOwotI2VuZGlmCi0gICAgaWYgKHNob3VsZFpvb21U b0ZvY3VzUmVjdCkgewotICAgICAgICAvLyBJbiBjYXNlIHVzZXIgc2NhbGluZyBpcyBmb3JjZSBl bmFibGVkLCBkbyBub3QgdXNlIHRoYXQgc2NhbGluZyB3aGVuIHpvb21pbmcgaW4gd2l0aCBhbiBp bnB1dCBmaWVsZC4KLSAgICAgICAgLy8gWm9vbWluZyBhYm92ZSB0aGUgcGFnZSdzIGRlZmF1bHQg c2NhbGUgZmFjdG9yIHNob3VsZCBvbmx5IGhhcHBlbiB3aGVuIHRoZSB1c2VyIHBlcmZvcm1zIGl0 LgotICAgICAgICBbc2VsZiBfem9vbVRvRm9jdXNSZWN0Ol9hc3Npc3RlZE5vZGVJbmZvcm1hdGlv bi5lbGVtZW50UmVjdAotICAgICAgICAgICAgICAgICBzZWxlY3Rpb25SZWN0OiBfZGlkQWNjZXNz b3J5VGFiSW5pdGlhdGVGb2N1cyA/IEludFJlY3QoKSA6IF9hc3Npc3RlZE5vZGVJbmZvcm1hdGlv bi5zZWxlY3Rpb25SZWN0Ci0gICAgICAgICAgICAgICAgICAgaW5zaWRlRml4ZWQ6X2Fzc2lzdGVk Tm9kZUluZm9ybWF0aW9uLmluc2lkZUZpeGVkUG9zaXRpb24KLSAgICAgICAgICAgICAgICAgICAg ICBmb250U2l6ZTpfYXNzaXN0ZWROb2RlSW5mb3JtYXRpb24ubm9kZUZvbnRTaXplCi0gICAgICAg ICAgICAgICAgICBtaW5pbXVtU2NhbGU6X2Fzc2lzdGVkTm9kZUluZm9ybWF0aW9uLm1pbmltdW1T Y2FsZUZhY3RvcgotICAgICAgICAgICAgICAgICAgbWF4aW11bVNjYWxlOl9hc3Npc3RlZE5vZGVJ bmZvcm1hdGlvbi5tYXhpbXVtU2NhbGVGYWN0b3JJZ25vcmluZ0Fsd2F5c1NjYWxhYmxlCi0gICAg ICAgICAgICAgICAgICBhbGxvd1NjYWxpbmc6KF9hc3Npc3RlZE5vZGVJbmZvcm1hdGlvbi5hbGxv d3NVc2VyU2NhbGluZ0lnbm9yaW5nQWx3YXlzU2NhbGFibGUgJiYgIVVJQ3VycmVudFVzZXJJbnRl cmZhY2VJZGlvbUlzUGFkKCkpCi0gICAgICAgICAgICAgICAgICAgZm9yY2VTY3JvbGw6W3NlbGYg cmVxdWlyZXNBY2Nlc3NvcnlWaWV3XV07Ci0gICAgfQorICAgIC8vIEluIGNhc2UgdXNlciBzY2Fs aW5nIGlzIGZvcmNlIGVuYWJsZWQsIGRvIG5vdCB1c2UgdGhhdCBzY2FsaW5nIHdoZW4gem9vbWlu ZyBpbiB3aXRoIGFuIGlucHV0IGZpZWxkLgorICAgIC8vIFpvb21pbmcgYWJvdmUgdGhlIHBhZ2Un cyBkZWZhdWx0IHNjYWxlIGZhY3RvciBzaG91bGQgb25seSBoYXBwZW4gd2hlbiB0aGUgdXNlciBw ZXJmb3JtcyBpdC4KKyAgICBbc2VsZiBfem9vbVRvRm9jdXNSZWN0Ol9hc3Npc3RlZE5vZGVJbmZv cm1hdGlvbi5lbGVtZW50UmVjdAorICAgICAgICAgICAgIHNlbGVjdGlvblJlY3Q6X2RpZEFjY2Vz c29yeVRhYkluaXRpYXRlRm9jdXMgPyBJbnRSZWN0KCkgOiBfYXNzaXN0ZWROb2RlSW5mb3JtYXRp b24uc2VsZWN0aW9uUmVjdAorICAgICAgICAgICAgICAgaW5zaWRlRml4ZWQ6X2Fzc2lzdGVkTm9k ZUluZm9ybWF0aW9uLmluc2lkZUZpeGVkUG9zaXRpb24KKyAgICAgICAgICAgICAgICAgIGZvbnRT aXplOl9hc3Npc3RlZE5vZGVJbmZvcm1hdGlvbi5ub2RlRm9udFNpemUKKyAgICAgICAgICAgICAg bWluaW11bVNjYWxlOl9hc3Npc3RlZE5vZGVJbmZvcm1hdGlvbi5taW5pbXVtU2NhbGVGYWN0b3IK KyAgICAgICAgICAgICAgbWF4aW11bVNjYWxlOl9hc3Npc3RlZE5vZGVJbmZvcm1hdGlvbi5tYXhp bXVtU2NhbGVGYWN0b3JJZ25vcmluZ0Fsd2F5c1NjYWxhYmxlCisgICAgICAgICAgICAgIGFsbG93 U2NhbGluZzooX2Fzc2lzdGVkTm9kZUluZm9ybWF0aW9uLmFsbG93c1VzZXJTY2FsaW5nSWdub3Jp bmdBbHdheXNTY2FsYWJsZSAmJiAhVUlDdXJyZW50VXNlckludGVyZmFjZUlkaW9tSXNQYWQoKSkK KyAgICAgICAgICAgICAgIGZvcmNlU2Nyb2xsOltzZWxmIHJlcXVpcmVzQWNjZXNzb3J5Vmlld11d OwogCiAgICAgX2RpZEFjY2Vzc29yeVRhYkluaXRpYXRlRm9jdXMgPSBOTzsKICAgICBbc2VsZiBf ZW5zdXJlRm9ybUFjY2Vzc29yeVZpZXddOwo=