172540 2017-05-24 08:22:39 -0700 [Win] Create unique network storage session for each DRT. 2017-05-30 20:23:49 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan achristensen bfulgham commit-queue lforschler webkit-bug-importer oldest_to_newest 1312256 0 pvollan 2017-05-24 08:22:39 -0700 During layout testing, each DRT instance should have its own network storage session. 1312257 1 311119 pvollan 2017-05-24 08:27:31 -0700 Created attachment 311119 Patch 1312264 2 311119 bfulgham 2017-05-24 08:46:48 -0700 Comment on attachment 311119 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=311119&action=review Wow -- I wonder how many problems this has caused in Windows testing over the years!?! Thanks for fixing this. r=me. > Source/WebCore/platform/network/cf/NetworkStorageSessionCFNet.cpp:95 > + session = adoptCF(wkCreatePrivateStorageSession(sessionName.createCFString().get(), defaultStorageSession().platformSession())); It's weird that we have NetworkStorageSession::defaultStorageSession() and NetworkStorageSession::defaultNetworkStorageSession(). How does anyone know which one to use? It looks like 'defaultNetworkStorageSession' just returns the (potentially uninitialized) storage session, while 'defaultStorageSession' builds a new one if it doesn't exist. Maybe this was some kind of optimization, where you only needed to call the more expensive version at launch or something? 1312267 3 pvollan 2017-05-24 08:53:30 -0700 (In reply to Brent Fulgham from comment #2) > Comment on attachment 311119 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=311119&action=review > > Wow -- I wonder how many problems this has caused in Windows testing over > the years!?! Thanks for fixing this. r=me. > > > Source/WebCore/platform/network/cf/NetworkStorageSessionCFNet.cpp:95 > > + session = adoptCF(wkCreatePrivateStorageSession(sessionName.createCFString().get(), defaultStorageSession().platformSession())); > > It's weird that we have NetworkStorageSession::defaultStorageSession() and > NetworkStorageSession::defaultNetworkStorageSession(). How does anyone know > which one to use? > > It looks like 'defaultNetworkStorageSession' just returns the (potentially > uninitialized) storage session, while 'defaultStorageSession' builds a new > one if it doesn't exist. > > Maybe this was some kind of optimization, where you only needed to call the > more expensive version at launch or something? Yes, I had to use defaultStorageSession the first time, otherwise it would crash. Thanks for reviewing! 1312276 4 311119 commit-queue 2017-05-24 09:22:16 -0700 Comment on attachment 311119 Patch Clearing flags on attachment: 311119 Committed r217370: <http://trac.webkit.org/changeset/217370> 1312277 5 commit-queue 2017-05-24 09:22:18 -0700 All reviewed patches have been landed. Closing bug. 1314037 6 webkit-bug-importer 2017-05-30 20:23:49 -0700 <rdar://problem/32479766> 311119 2017-05-24 08:27:31 -0700 2017-05-24 09:22:16 -0700 Patch bug-172540-20170524082731.patch text/plain 5735 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxNzM2MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE3LTA1LTI0ICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2luXSBDcmVhdGUgdW5p cXVlIG5ldHdvcmsgc3RvcmFnZSBzZXNzaW9uIGZvciBlYWNoIERSVC4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MjU0MAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIER1cmluZyBsYXlvdXQgdGVzdGluZywg ZWFjaCBEUlQgaW5zdGFuY2Ugc2hvdWxkIGhhdmUgaXRzIG93biBuZXR3b3JrIHN0b3JhZ2Ugc2Vz c2lvbi4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvY2YvTmV0d29ya1N0b3JhZ2VTZXNz aW9uQ0ZOZXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TmV0d29ya1N0b3JhZ2VTZXNzaW9uOjpz d2l0Y2hUb05ld1Rlc3RpbmdTZXNzaW9uKToKKwogMjAxNy0wNS0yNCAgQW50b2luZSBRdWludCAg PGdyYW91dHNAYXBwbGUuY29tPgogCiAgICAgICAgIFttYWMtd2sxXSBMYXlvdXRUZXN0IG1lZGlh L21vZGVybi1tZWRpYS1jb250cm9scy9haXJwbGF5LWJ1dHRvbi9haXJwbGF5LWJ1dHRvbi5odG1s IGlzIGEgZmxha3kgdGltZW91dApJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29y ay9jZi9OZXR3b3JrU3RvcmFnZVNlc3Npb25DRk5ldC5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jZi9OZXR3b3JrU3RvcmFnZVNlc3Npb25DRk5ldC5j cHAJKHJldmlzaW9uIDIxNzM2MCkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsv Y2YvTmV0d29ya1N0b3JhZ2VTZXNzaW9uQ0ZOZXQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05Miw3 ICs5Miw3IEBAIHZvaWQgTmV0d29ya1N0b3JhZ2VTZXNzaW9uOjpzd2l0Y2hUb05ld1QKICNpZiBQ TEFURk9STShDT0NPQSkKICAgICBzZXNzaW9uID0gYWRvcHRDRih3a0NyZWF0ZVByaXZhdGVTdG9y YWdlU2Vzc2lvbihzZXNzaW9uTmFtZS5jcmVhdGVDRlN0cmluZygpLmdldCgpKSk7CiAjZWxzZQot ICAgIHNlc3Npb24gPSBhZG9wdENGKHdrQ3JlYXRlUHJpdmF0ZVN0b3JhZ2VTZXNzaW9uKHNlc3Np b25OYW1lLmNyZWF0ZUNGU3RyaW5nKCkuZ2V0KCksIGRlZmF1bHROZXR3b3JrU3RvcmFnZVNlc3Np b24oKS0+cGxhdGZvcm1TZXNzaW9uKCkpKTsKKyAgICBzZXNzaW9uID0gYWRvcHRDRih3a0NyZWF0 ZVByaXZhdGVTdG9yYWdlU2Vzc2lvbihzZXNzaW9uTmFtZS5jcmVhdGVDRlN0cmluZygpLmdldCgp LCBkZWZhdWx0U3RvcmFnZVNlc3Npb24oKS5wbGF0Zm9ybVNlc3Npb24oKSkpOwogI2VuZGlmCiAK ICAgICBSZXRhaW5QdHI8Q0ZIVFRQQ29va2llU3RvcmFnZVJlZj4gY29va2llU3RvcmFnZTsKSW5k ZXg6IFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxNzM2MCkKKysrIFNvdXJjZS9XZWJLaXQvd2lu L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE3LTA1LTI0ICBQ ZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2luXSBDcmVh dGUgdW5pcXVlIG5ldHdvcmsgc3RvcmFnZSBzZXNzaW9uIGZvciBlYWNoIERSVC4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MjU0MAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIER1cmluZyBsYXlvdXQgdGVz dGluZywgZWFjaCBEUlQgaW5zdGFuY2Ugc2hvdWxkIGhhdmUgaXRzIG93biBuZXR3b3JrIHN0b3Jh Z2Ugc2Vzc2lvbi4KKworICAgICAgICAqIEludGVyZmFjZXMvSVdlYlByZWZlcmVuY2VzUHJpdmF0 ZS5pZGw6CisgICAgICAgICogV2ViUHJlZmVyZW5jZXMuY3BwOgorICAgICAgICAoV2ViUHJlZmVy ZW5jZXM6OnN3aXRjaE5ldHdvcmtMb2FkZXJUb05ld1Rlc3RpbmdTZXNzaW9uKToKKyAgICAgICAg KiBXZWJQcmVmZXJlbmNlcy5oOgorCiAyMDE3LTA1LTI0ICBGdWppaSBIaXJvbm9yaSAgPEhpcm9u b3JpLkZ1amlpQHNvbnkuY29tPgogCiAgICAgICAgIFtXaW5DYWlyb10gQWNjZWxlcmF0ZWRDb21w b3NpdGluZ0NvbnRleHQuaDogZXJyb3IgQzM2Njg6ICdBY2NlbGVyYXRlZENvbXBvc2l0aW5nQ29u dGV4dDo6cGFpbnRDb250ZW50cyc6IG1ldGhvZCB3aXRoIG92ZXJyaWRlIHNwZWNpZmllciAnb3Zl cnJpZGUnIGRpZCBub3Qgb3ZlcnJpZGUgYW55IGJhc2UgY2xhc3MgbWV0aG9kcwpJbmRleDogU291 cmNlL1dlYktpdC93aW4vV2ViUHJlZmVyZW5jZXMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJLaXQvd2luL1dlYlByZWZlcmVuY2VzLmNwcAkocmV2aXNpb24gMjE3MzYwKQorKysgU291cmNl L1dlYktpdC93aW4vV2ViUHJlZmVyZW5jZXMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMDE5LDYg KzIwMTksMTIgQEAgSFJFU1VMVCBXZWJQcmVmZXJlbmNlczo6Y2xlYXJOZXR3b3JrTG9hZAogICAg IHJldHVybiBTX09LOwogfQogCitIUkVTVUxUIFdlYlByZWZlcmVuY2VzOjpzd2l0Y2hOZXR3b3Jr TG9hZGVyVG9OZXdUZXN0aW5nU2Vzc2lvbigpCit7CisgICAgTmV0d29ya1N0b3JhZ2VTZXNzaW9u Ojpzd2l0Y2hUb05ld1Rlc3RpbmdTZXNzaW9uKCk7CisgICAgcmV0dXJuIFNfT0s7Cit9CisKIEhS RVNVTFQgV2ViUHJlZmVyZW5jZXM6OnNldEFwcGxpY2F0aW9uSWQoQlNUUiBhcHBsaWNhdGlvbklk KQogewogICAgIG1fYXBwbGljYXRpb25JZCA9IFN0cmluZyhhcHBsaWNhdGlvbklkKS5jcmVhdGVD RlN0cmluZygpOwpJbmRleDogU291cmNlL1dlYktpdC93aW4vV2ViUHJlZmVyZW5jZXMuaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L3dpbi9XZWJQcmVmZXJlbmNlcy5oCShyZXZpc2lvbiAy MTczNjApCisrKyBTb3VyY2UvV2ViS2l0L3dpbi9XZWJQcmVmZXJlbmNlcy5oCSh3b3JraW5nIGNv cHkpCkBAIC0yNTIsNiArMjUyLDcgQEAgcHVibGljOgogICAgIHZpcnR1YWwgSFJFU1VMVCBTVERN RVRIT0RDQUxMVFlQRSBsaW5rUHJlbG9hZEVuYWJsZWQoX091dF8gQk9PTCopOwogICAgIHZpcnR1 YWwgSFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQRSBzZXRMaW5rUHJlbG9hZEVuYWJsZWQoQk9PTCk7 CiAgICAgdmlydHVhbCBIUkVTVUxUIFNURE1FVEhPRENBTExUWVBFIGNsZWFyTmV0d29ya0xvYWRl clNlc3Npb24oKTsKKyAgICB2aXJ0dWFsIEhSRVNVTFQgU1RETUVUSE9EQ0FMTFRZUEUgc3dpdGNo TmV0d29ya0xvYWRlclRvTmV3VGVzdGluZ1Nlc3Npb24oKTsKIAogICAgIC8vIFdlYlByZWZlcmVu Y2VzCiAKSW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL0ludGVyZmFjZXMvSVdlYlByZWZlcmVuY2Vz UHJpdmF0ZS5pZGwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC93aW4vSW50ZXJmYWNlcy9J V2ViUHJlZmVyZW5jZXNQcml2YXRlLmlkbAkocmV2aXNpb24gMjE3MzYwKQorKysgU291cmNlL1dl YktpdC93aW4vSW50ZXJmYWNlcy9JV2ViUHJlZmVyZW5jZXNQcml2YXRlLmlkbAkod29ya2luZyBj b3B5KQpAQCAtMTk4LDQgKzE5OCw1IEBAIGludGVyZmFjZSBJV2ViUHJlZmVyZW5jZXNQcml2YXRl NCA6IElXZWIKICAgICBIUkVTVUxUIGxpbmtQcmVsb2FkRW5hYmxlZChbb3V0LCByZXR2YWxdIEJP T0wqKTsKICAgICBIUkVTVUxUIHNldExpbmtQcmVsb2FkRW5hYmxlZChbaW5dIEJPT0wgZW5hYmxl ZCk7CiAgICAgSFJFU1VMVCBjbGVhck5ldHdvcmtMb2FkZXJTZXNzaW9uKCk7CisgICAgSFJFU1VM VCBzd2l0Y2hOZXR3b3JrTG9hZGVyVG9OZXdUZXN0aW5nU2Vzc2lvbigpOwogfQpJbmRleDogVG9v bHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0NoYW5nZUxvZwkocmV2aXNpb24gMjE3 MzY3KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTctMDUtMjQgIFBlciBBcm5lIFZvbGxhbiAgPHB2b2xsYW5AYXBwbGUuY29tPgorCisgICAg ICAgIFtXaW5dIENyZWF0ZSB1bmlxdWUgbmV0d29yayBzdG9yYWdlIHNlc3Npb24gZm9yIGVhY2gg RFJULgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcy NTQwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRHVy aW5nIGxheW91dCB0ZXN0aW5nLCBlYWNoIERSVCBpbnN0YW5jZSBzaG91bGQgaGF2ZSBpdHMgb3du IG5ldHdvcmsgc3RvcmFnZSBzZXNzaW9uLgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvd2lu L0R1bXBSZW5kZXJUcmVlLmNwcDoKKyAgICAgICAgKHByZXBhcmVDb25zaXN0ZW50VGVzdGluZ0Vu dmlyb25tZW50KToKKwogMjAxNy0wNS0yNCAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFw cGxlLmNvbT4KIAogICAgICAgICBSZXNwZWN0IGltYWdlIFVUSXMgd2hlbiB3cml0aW5nIHRvIGl0 ZW0gcHJvdmlkZXJzIHdoZW4gYmVnaW5uaW5nIGRhdGEgaW50ZXJhY3Rpb24gb24gYW4gaW1hZ2UK SW5kZXg6IFRvb2xzL0R1bXBSZW5kZXJUcmVlL3dpbi9EdW1wUmVuZGVyVHJlZS5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gVG9vbHMvRHVtcFJlbmRlclRyZWUvd2luL0R1bXBSZW5kZXJUcmVlLmNwcAkocmV2 aXNpb24gMjE3MzYwKQorKysgVG9vbHMvRHVtcFJlbmRlclRyZWUvd2luL0R1bXBSZW5kZXJUcmVl LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTQ2NCw2ICsxNDY0LDkgQEAgc3RhdGljIHZvaWQgcHJl cGFyZUNvbnNpc3RlbnRUZXN0aW5nRW52aQogICAgIEFTU0VSVChzdGFuZGFyZFByZWZlcmVuY2Vz UHJpdmF0ZSk7CiAgICAgc3RhbmRhcmRQcmVmZXJlbmNlcy0+c2V0QXV0b3NhdmVzKEZBTFNFKTsK IAorICAgIENPTVB0cjxJV2ViUHJlZmVyZW5jZXNQcml2YXRlND4gcHJlZnNQcml2YXRlNChRdWVy eSwgc3RhbmRhcmRQcmVmZXJlbmNlcyk7CisgICAgcHJlZnNQcml2YXRlNC0+c3dpdGNoTmV0d29y a0xvYWRlclRvTmV3VGVzdGluZ1Nlc3Npb24oKTsKKwogICAgIHN0YW5kYXJkUHJlZmVyZW5jZXMt PnNldEphdmFTY3JpcHRFbmFibGVkKFRSVUUpOwogICAgIHN0YW5kYXJkUHJlZmVyZW5jZXMtPnNl dERlZmF1bHRGb250U2l6ZSgxNik7CiAjaWYgVVNFKENHKQo=