172535 2017-05-23 22:08:51 -0700 [WinCairo] AcceleratedCompositingContext.h: error C3668: 'AcceleratedCompositingContext::paintContents': method with override specifier 'override' did not override any base class methods 2017-05-30 20:25:30 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 172485 1 fujii fujii achristensen annulen bfulgham commit-queue pvollan simon.fraser webkit-bug-importer oldest_to_newest 1312192 0 fujii 2017-05-23 22:08:51 -0700 WinCairo build are broken since Bug 172485. > source\webkit\win\webcoresupport\AcceleratedCompositingContext.h(55): error C3668: 'AcceleratedCompositingContext::paintContents': method with override specifier 'override' did not override any base class methods 1312201 1 simon.fraser 2017-05-23 22:41:45 -0700 Probably need to add a GraphicsLayerPaintFlags as the last argument. With no EWS, I did not see this before committing. 1312205 2 311101 fujii 2017-05-23 23:01:37 -0700 Created attachment 311101 Patch Thank you. 1312233 3 311101 commit-queue 2017-05-24 02:50:24 -0700 Comment on attachment 311101 Patch Clearing flags on attachment: 311101 Committed r217360: <http://trac.webkit.org/changeset/217360> 1312234 4 commit-queue 2017-05-24 02:50:25 -0700 All reviewed patches have been landed. Closing bug. 1314056 5 webkit-bug-importer 2017-05-30 20:25:30 -0700 <rdar://problem/32479805> 311101 2017-05-23 23:01:37 -0700 2017-05-24 02:50:24 -0700 Patch bug-172535-20170524150136.patch text/plain 2769 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjE3MzE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3dp bi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L3dpbi9DaGFuZ2VMb2cKaW5kZXggZDZlNzdkYmFj MzZkZWU3YzQyYTU5ZDFhMmI4NzA0YzdkMjBmOTIzMy4uNWIyMjMyNDY3ZjdjZjU5ZjRkNmNhNTM0 ZWRkZjgwNzA1NWFmMTAxYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC93aW4vQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE3 LTA1LTIzICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAg ICAgIFtXaW5DYWlyb10gQWNjZWxlcmF0ZWRDb21wb3NpdGluZ0NvbnRleHQuaDogZXJyb3IgQzM2 Njg6ICdBY2NlbGVyYXRlZENvbXBvc2l0aW5nQ29udGV4dDo6cGFpbnRDb250ZW50cyc6IG1ldGhv ZCB3aXRoIG92ZXJyaWRlIHNwZWNpZmllciAnb3ZlcnJpZGUnIGRpZCBub3Qgb3ZlcnJpZGUgYW55 IGJhc2UgY2xhc3MgbWV0aG9kcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTcyNTM1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9BY2NlbGVyYXRlZENvbXBvc2l0aW5nQ29udGV4 dC5jcHA6CisgICAgICAgIChBY2NlbGVyYXRlZENvbXBvc2l0aW5nQ29udGV4dDo6cGFpbnRDb250 ZW50cyk6IEFwcGVuZCB0aGUgZmlmdGggYXJndW1lbnQuCisgICAgICAgICogV2ViQ29yZVN1cHBv cnQvQWNjZWxlcmF0ZWRDb21wb3NpdGluZ0NvbnRleHQuaDogRGl0dG8uCisKIDIwMTctMDUtMTQg IFBlciBBcm5lIFZvbGxhbiAgPHB2b2xsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtXaW5dIGZh c3QvY29va2llcy9sb2NhbC1maWxlLWNhbi1zZXQtY29va2llcy5odG1sIGlzIGZsYWt5LgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC93aW4vV2ViQ29yZVN1cHBvcnQvQWNjZWxlcmF0ZWRDb21w b3NpdGluZ0NvbnRleHQuY3BwIGIvU291cmNlL1dlYktpdC93aW4vV2ViQ29yZVN1cHBvcnQvQWNj ZWxlcmF0ZWRDb21wb3NpdGluZ0NvbnRleHQuY3BwCmluZGV4IDlkNjY3MWI0NDgyNWQzYzU4YTEx YWViMjRhM2I4ZDUzOWU3OGJhYTEuLmNmYWE3YTdlMGZmNWU4MjAxZmUxYmEyZDhkYzY0N2YwMTgz M2Y1MWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvd2luL1dlYkNvcmVTdXBwb3J0L0FjY2Vs ZXJhdGVkQ29tcG9zaXRpbmdDb250ZXh0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L3dpbi9XZWJD b3JlU3VwcG9ydC9BY2NlbGVyYXRlZENvbXBvc2l0aW5nQ29udGV4dC5jcHAKQEAgLTQwMyw3ICs0 MDMsNyBAQCB2b2lkIEFjY2VsZXJhdGVkQ29tcG9zaXRpbmdDb250ZXh0OjpsYXllckZsdXNoVGlt ZXJGaXJlZCgpCiAgICAgICAgIHNjaGVkdWxlTGF5ZXJGbHVzaCgpOwogfQogCi12b2lkIEFjY2Vs ZXJhdGVkQ29tcG9zaXRpbmdDb250ZXh0OjpwYWludENvbnRlbnRzKGNvbnN0IEdyYXBoaWNzTGF5 ZXIqLCBHcmFwaGljc0NvbnRleHQmIGNvbnRleHQsIEdyYXBoaWNzTGF5ZXJQYWludGluZ1BoYXNl LCBjb25zdCBGbG9hdFJlY3QmIHJlY3RUb1BhaW50KQordm9pZCBBY2NlbGVyYXRlZENvbXBvc2l0 aW5nQ29udGV4dDo6cGFpbnRDb250ZW50cyhjb25zdCBHcmFwaGljc0xheWVyKiwgR3JhcGhpY3ND b250ZXh0JiBjb250ZXh0LCBHcmFwaGljc0xheWVyUGFpbnRpbmdQaGFzZSwgY29uc3QgRmxvYXRS ZWN0JiByZWN0VG9QYWludCwgR3JhcGhpY3NMYXllclBhaW50RmxhZ3MpCiB7CiAgICAgY29udGV4 dC5zYXZlKCk7CiAgICAgY29udGV4dC5jbGlwKHJlY3RUb1BhaW50KTsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvd2luL1dlYkNvcmVTdXBwb3J0L0FjY2VsZXJhdGVkQ29tcG9zaXRpbmdDb250 ZXh0LmggYi9Tb3VyY2UvV2ViS2l0L3dpbi9XZWJDb3JlU3VwcG9ydC9BY2NlbGVyYXRlZENvbXBv c2l0aW5nQ29udGV4dC5oCmluZGV4IDM1MWJlNzJhM2M0MmI0N2ZkYjExZTc3ZTRmNzQ0OWM4NmVl ZDYxNzQuLmUzMjM1YzNmYjc5ZjEyMTA2Mjg3M2JjMTY1ZTZlNGYyZjcwN2Y2YmUgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvd2luL1dlYkNvcmVTdXBwb3J0L0FjY2VsZXJhdGVkQ29tcG9zaXRp bmdDb250ZXh0LmgKKysrIGIvU291cmNlL1dlYktpdC93aW4vV2ViQ29yZVN1cHBvcnQvQWNjZWxl cmF0ZWRDb21wb3NpdGluZ0NvbnRleHQuaApAQCAtNTIsNyArNTIsNyBAQCBwdWJsaWM6CiAgICAg Ym9vbCBlbmFibGVkKCk7CiAKICAgICAvLyBHcmFwaGljc0xheWVyQ2xpZW50Ci0gICAgdm9pZCBw YWludENvbnRlbnRzKGNvbnN0IFdlYkNvcmU6OkdyYXBoaWNzTGF5ZXIqLCBXZWJDb3JlOjpHcmFw aGljc0NvbnRleHQmLCBXZWJDb3JlOjpHcmFwaGljc0xheWVyUGFpbnRpbmdQaGFzZSwgY29uc3Qg V2ViQ29yZTo6RmxvYXRSZWN0JiByZWN0VG9QYWludCkgb3ZlcnJpZGU7CisgICAgdm9pZCBwYWlu dENvbnRlbnRzKGNvbnN0IFdlYkNvcmU6OkdyYXBoaWNzTGF5ZXIqLCBXZWJDb3JlOjpHcmFwaGlj c0NvbnRleHQmLCBXZWJDb3JlOjpHcmFwaGljc0xheWVyUGFpbnRpbmdQaGFzZSwgY29uc3QgV2Vi Q29yZTo6RmxvYXRSZWN0JiByZWN0VG9QYWludCwgV2ViQ29yZTo6R3JhcGhpY3NMYXllclBhaW50 RmxhZ3MpIG92ZXJyaWRlOwogICAgIGZsb2F0IGRldmljZVNjYWxlRmFjdG9yKCkgY29uc3Qgb3Zl cnJpZGU7CiAKICAgICB2b2lkIGluaXRpYWxpemUoKTsK