172524 2017-05-23 14:17:44 -0700 Resource Load Statistics: Change grandfathering default to one hour 2017-05-24 10:37:01 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wilander wilander bfulgham buildbot cdumez commit-queue dbates japhet webkit-bug-importer wilander oldest_to_newest 1312045 0 wilander 2017-05-23 14:17:44 -0700 We should only grandfather website data records for one hour to start with. If more is needed we can bump it up again. 1312046 1 webkit-bug-importer 2017-05-23 14:18:22 -0700 <rdar://problem/32360462> 1312047 2 311051 wilander 2017-05-23 14:22:04 -0700 Created attachment 311051 Patch 1312150 3 311051 bfulgham 2017-05-23 17:51:54 -0700 Comment on attachment 311051 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=311051&action=review r=me > Source/WebKit2/UIProcess/WebResourceLoadStatisticsManager.cpp:152 > + WebCore::ResourceLoadObserver::sharedObserver().setGrandfatheringTime(3600); Weird that we can't use "grandfatheringTime" here, instead of a magic number. 1312289 4 wilander 2017-05-24 10:08:39 -0700 (In reply to Brent Fulgham from comment #3) > Comment on attachment 311051 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=311051&action=review > > r=me > > > Source/WebKit2/UIProcess/WebResourceLoadStatisticsManager.cpp:152 > > + WebCore::ResourceLoadObserver::sharedObserver().setGrandfatheringTime(3600); > > Weird that we can't use "grandfatheringTime" here, instead of a magic number. Thanks for the review! grandfatheringTime in ResourceLoadStatisticsStore.cpp is the variable that's changed so we'd have to introduce a constant. 1312304 5 311051 commit-queue 2017-05-24 10:37:00 -0700 Comment on attachment 311051 Patch Clearing flags on attachment: 311051 Committed r217372: <http://trac.webkit.org/changeset/217372> 1312305 6 commit-queue 2017-05-24 10:37:01 -0700 All reviewed patches have been landed. Closing bug. 311051 2017-05-23 14:22:04 -0700 2017-05-24 10:37:00 -0700 Patch bug-172524-20170523142158.patch text/plain 4327 wilander SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxNzI4OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE3LTA1LTIzICBKb2huIFdp bGFuZGVyICA8d2lsYW5kZXJAYXBwbGUuY29tPgorCisgICAgICAgIFJlc291cmNlIExvYWQgU3Rh dGlzdGljczogQ2hhbmdlIGdyYW5kZmF0aGVyaW5nIGRlZmF1bHQgdG8gb25lIGhvdXIKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MjUyNAorICAgICAg ICA8cmRhcjovL3Byb2JsZW0vMzIzNjA0NjI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQ292ZXJlZCBieSBleGlzdGluZyB0ZXN0LgorCisgICAgICAg ICogbG9hZGVyL1Jlc291cmNlTG9hZFN0YXRpc3RpY3NTdG9yZS5jcHA6CisKIDIwMTctMDUtMjMg IENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBy b2xsIG91dCByMjE1MjI5CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvUmVzb3VyY2VMb2Fk U3RhdGlzdGljc1N0b3JlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9sb2FkZXIv UmVzb3VyY2VMb2FkU3RhdGlzdGljc1N0b3JlLmNwcAkocmV2aXNpb24gMjE3Mjg5KQorKysgU291 cmNlL1dlYkNvcmUvbG9hZGVyL1Jlc291cmNlTG9hZFN0YXRpc3RpY3NTdG9yZS5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTM5LDEwICszOSwxMSBAQAogbmFtZXNwYWNlIFdlYkNvcmUgewogCiBzdGF0 aWMgY29uc3QgYXV0byBzdGF0aXN0aWNzTW9kZWxWZXJzaW9uID0gNDsKLXN0YXRpYyBjb25zdCBh dXRvIHNlY29uZHNQZXJEYXkgPSAyNCAqIDM2MDA7CitzdGF0aWMgY29uc3QgYXV0byBzZWNvbmRz UGVySG91ciA9IDM2MDA7CitzdGF0aWMgY29uc3QgYXV0byBzZWNvbmRzUGVyRGF5ID0gMjQgKiBz ZWNvbmRzUGVySG91cjsKIHN0YXRpYyBhdXRvIHRpbWVUb0xpdmVVc2VySW50ZXJhY3Rpb24gPSAz MCAqIHNlY29uZHNQZXJEYXk7CiBzdGF0aWMgYXV0byB0aW1lVG9MaXZlQ29va2llUGFydGl0aW9u RnJlZSA9IDEgKiBzZWNvbmRzUGVyRGF5Owotc3RhdGljIGF1dG8gZ3JhbmRmYXRoZXJpbmdUaW1l ID0gMyAqIHNlY29uZHNQZXJEYXk7CitzdGF0aWMgYXV0byBncmFuZGZhdGhlcmluZ1RpbWUgPSAx ICogc2Vjb25kc1BlckhvdXI7CiBzdGF0aWMgYXV0byBtaW5pbXVtVGltZUJldHdlZWVuRGF0YVJl Y29yZHNSZW1vdmFsID0gNjA7CiAKIFJlZjxSZXNvdXJjZUxvYWRTdGF0aXN0aWNzU3RvcmU+IFJl c291cmNlTG9hZFN0YXRpc3RpY3NTdG9yZTo6Y3JlYXRlKCkKSW5kZXg6IFNvdXJjZS9XZWJLaXQy L0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cJKHJldmlz aW9uIDIxNzMwMCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE1IEBACisyMDE3LTA1LTIzICBKb2huIFdpbGFuZGVyICA8d2lsYW5kZXJAYXBw bGUuY29tPgorCisgICAgICAgIFJlc291cmNlIExvYWQgU3RhdGlzdGljczogQ2hhbmdlIGdyYW5k ZmF0aGVyaW5nIGRlZmF1bHQgdG8gb25lIGhvdXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MjUyNAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzIz NjA0NjI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBTaGFyZWQvV2ViUHJlZmVyZW5jZXNEZWZpbml0aW9ucy5oOgorICAgICAgICAqIFVJUHJvY2Vz cy9XZWJSZXNvdXJjZUxvYWRTdGF0aXN0aWNzTWFuYWdlci5jcHA6CisgICAgICAgIChXZWJLaXQ6 OldlYlJlc291cmNlTG9hZFN0YXRpc3RpY3NNYW5hZ2VyOjpyZXNldFRvQ29uc2lzdGVudFN0YXRl KToKKwogMjAxNy0wNS0yMiAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4K IAogICAgICAgICBTbmFwc2hvdHRpbmcgdmlhIC1yZW5kZXJJbkNvbnRleHQ6IHNob3VsZCBkbyBz eW5jaHJvbm91cyBpbWFnZSBkZWNvZGVzCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvV2Vi UHJlZmVyZW5jZXNEZWZpbml0aW9ucy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1No YXJlZC9XZWJQcmVmZXJlbmNlc0RlZmluaXRpb25zLmgJKHJldmlzaW9uIDIxNzI4OSkKKysrIFNv dXJjZS9XZWJLaXQyL1NoYXJlZC9XZWJQcmVmZXJlbmNlc0RlZmluaXRpb25zLmgJKHdvcmtpbmcg Y29weSkKQEAgLTI4Nyw3ICsyODcsNyBAQAogICAgIG1hY3JvKFJlc291cmNlTG9hZFN0YXRpc3Rp Y3NUaW1lVG9MaXZlVXNlckludGVyYWN0aW9uLCByZXNvdXJjZUxvYWRTdGF0aXN0aWNzVGltZVRv TGl2ZVVzZXJJbnRlcmFjdGlvbiwgRG91YmxlLCBkb3VibGUsIDI1OTIwMDAsICIiLCAiIikgXAog ICAgIG1hY3JvKFJlc291cmNlTG9hZFN0YXRpc3RpY3NUaW1lVG9MaXZlQ29va2llUGFydGl0aW9u RnJlZSwgcmVzb3VyY2VMb2FkU3RhdGlzdGljc1RpbWVUb0xpdmVDb29raWVQYXJ0aXRpb25GcmVl LCBEb3VibGUsIGRvdWJsZSwgODY0MDAsICIiLCAiIikgXAogICAgIG1hY3JvKFJlc291cmNlTG9h ZFN0YXRpc3RpY3NSZWR1Y2VkVGltZXN0YW1wUmVzb2x1dGlvbiwgcmVzb3VyY2VMb2FkU3RhdGlz dGljc1JlZHVjZWRUaW1lc3RhbXBSZXNvbHV0aW9uLCBEb3VibGUsIGRvdWJsZSwgMzYwMCwgIiIs ICIiKSBcCi0gICAgbWFjcm8oUmVzb3VyY2VMb2FkU3RhdGlzdGljc0dyYW5kZmF0aGVyaW5nVGlt ZSwgcmVzb3VyY2VMb2FkU3RhdGlzdGljc0dyYW5kZmF0aGVyaW5nVGltZSwgRG91YmxlLCBkb3Vi bGUsIDI1OTIwMCwgIiIsICIiKSBcCisgICAgbWFjcm8oUmVzb3VyY2VMb2FkU3RhdGlzdGljc0dy YW5kZmF0aGVyaW5nVGltZSwgcmVzb3VyY2VMb2FkU3RhdGlzdGljc0dyYW5kZmF0aGVyaW5nVGlt ZSwgRG91YmxlLCBkb3VibGUsIDM2MDAsICIiLCAiIikgXAogXAogCiAjZGVmaW5lIEZPUl9FQUNI X1dFQktJVF9VSU5UMzJfUFJFRkVSRU5DRShtYWNybykgXApJbmRleDogU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL1dlYlJlc291cmNlTG9hZFN0YXRpc3RpY3NNYW5hZ2VyLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUmVzb3VyY2VMb2FkU3RhdGlzdGljc01h bmFnZXIuY3BwCShyZXZpc2lvbiAyMTcyODkpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv V2ViUmVzb3VyY2VMb2FkU3RhdGlzdGljc01hbmFnZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0x NDksNiArMTQ5LDcgQEAgdm9pZCBXZWJSZXNvdXJjZUxvYWRTdGF0aXN0aWNzTWFuYWdlcjo6cgog ICAgIFdlYkNvcmU6OlJlc291cmNlTG9hZE9ic2VydmVyOjpzaGFyZWRPYnNlcnZlcigpLnNldFRp bWVUb0xpdmVVc2VySW50ZXJhY3Rpb24oMjU5MjAwMCk7CiAgICAgV2ViQ29yZTo6UmVzb3VyY2VM b2FkT2JzZXJ2ZXI6OnNoYXJlZE9ic2VydmVyKCkuc2V0VGltZVRvTGl2ZUNvb2tpZVBhcnRpdGlv bkZyZWUoODY0MDApOwogICAgIFdlYkNvcmU6OlJlc291cmNlTG9hZE9ic2VydmVyOjpzaGFyZWRP YnNlcnZlcigpLnNldE1pbmltdW1UaW1lQmV0d2VlZW5EYXRhUmVjb3Jkc1JlbW92YWwoNjApOwor ICAgIFdlYkNvcmU6OlJlc291cmNlTG9hZE9ic2VydmVyOjpzaGFyZWRPYnNlcnZlcigpLnNldEdy YW5kZmF0aGVyaW5nVGltZSgzNjAwKTsKICAgICBXZWJSZXNvdXJjZUxvYWRTdGF0aXN0aWNzU3Rv cmU6OnNldE5vdGlmeVBhZ2VzV2hlbkRhdGFSZWNvcmRzV2VyZVNjYW5uZWQoZmFsc2UpOwogICAg IFdlYlJlc291cmNlTG9hZFN0YXRpc3RpY3NTdG9yZTo6c2V0U2hvdWxkQ2xhc3NpZnlSZXNvdXJj ZXNCZWZvcmVEYXRhUmVjb3Jkc1JlbW92YWwodHJ1ZSk7CiAgICAgV2ViQ29yZTo6UmVzb3VyY2VM b2FkT2JzZXJ2ZXI6OnNoYXJlZE9ic2VydmVyKCkuY2xlYXJJbk1lbW9yeVN0b3JlKCk7Cg==