172508 2017-05-23 10:29:07 -0700 CFGSimplificationPhase should not merge a block with itself 2017-05-23 11:49:20 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam benjamin commit-queue fpizlo ggaren gskachkov jfbastien keith_miller mark.lam msaboff ticaiolima webkit-bug-importer ysuzuki oldest_to_newest 1311923 0 saam 2017-05-23 10:29:07 -0700 except it tries to, and will have a very bad time. Test: ``` function bar() {} noInline(bar); function baz() { } function foo() { if (typeof baz !== "undefined") { } else { while (true) bar(); } } noInline(foo); for (let i = 0; i < 10000; ++i) foo(); ``` 1311924 1 saam 2017-05-23 10:29:47 -0700 <rdar://problem/28424006> 1311933 2 webkit-bug-importer 2017-05-23 10:53:58 -0700 <rdar://problem/32355021> 1311936 3 311026 saam 2017-05-23 11:06:58 -0700 Created attachment 311026 patch 1311939 4 311026 keith_miller 2017-05-23 11:09:23 -0700 Comment on attachment 311026 patch r=me. 1311972 5 311026 commit-queue 2017-05-23 11:49:19 -0700 Comment on attachment 311026 patch Clearing flags on attachment: 311026 Committed r217287: <http://trac.webkit.org/changeset/217287> 1311973 6 commit-queue 2017-05-23 11:49:20 -0700 All reviewed patches have been landed. Closing bug. 311026 2017-05-23 11:06:58 -0700 2017-05-23 11:49:19 -0700 patch c-backup.diff text/plain 6519 saam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMTcyODIpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE2IEBACisyMDE3LTA1LTIzICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUu Y29tPgorCisgICAgICAgIENGR1NpbXBsaWZpY2F0aW9uUGhhc2Ugc2hvdWxkIG5vdCBtZXJnZSBh IGJsb2NrIHdpdGggaXRzZWxmCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNzI1MDgKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI4NDI0MDA2PgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogc3RyZXNzL2Rv bnQtY3Jhc2gtaW4tY2ZnLXNpbXBsaWZpY2F0aW9uLmpzOiBBZGRlZC4KKyAgICAgICAgKGJhcik6 CisgICAgICAgIChiYXopOgorICAgICAgICAoZm9vKToKKwogMjAxNy0wNS0yMCAgWXVzdWtlIFN1 enVraSAgPHV0YXRhbmUudGVhQGdtYWlsLmNvbT4KIAogICAgICAgICBbRlRMXSBTdXBwb3J0IEdl dEJ5VmFsIHdpdGggQXJyYXlTdG9yYWdlIGFuZCBTbG93UHV0QXJyYXlTdG9yYWdlCkluZGV4OiBK U1Rlc3RzL3N0cmVzcy9kb250LWNyYXNoLWluLWNmZy1zaW1wbGlmaWNhdGlvbi5qcwo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBKU1Rlc3RzL3N0cmVzcy9kb250LWNyYXNoLWluLWNmZy1zaW1wbGlmaWNhdGlvbi5q cwkobm9uZXhpc3RlbnQpCisrKyBKU1Rlc3RzL3N0cmVzcy9kb250LWNyYXNoLWluLWNmZy1zaW1w bGlmaWNhdGlvbi5qcwkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDE3IEBACitmdW5jdGlvbiBi YXIoKSB7fQorbm9JbmxpbmUoYmFyKTsKKworZnVuY3Rpb24gYmF6KCkgeyB9CisKK2Z1bmN0aW9u IGZvbygpIHsKKyAgICBpZiAodHlwZW9mIGJheiAhPT0gInVuZGVmaW5lZCIpIHsKKyAgICB9IGVs c2UgeworICAgICAgICAvLyBUaGUgdGVzdCBoZXJlIGlzIHRvIG1ha2Ugc3VyZSB0aGF0IHdlIGRv bid0IG1lcmdlIHRoaXMgYmFzaWMgYmxvY2sKKyAgICAgICAgLy8gd2l0aCBpdHNlbGYuIElmIHdl IGRpZCwgd2UnZCBpbmZpbml0ZSBsb29wIGluIHRoZSBjb21waWxlciBhbmQgZXZlbnR1YWxseQor ICAgICAgICAvLyBjcmFzaCBkdWUgdG8gT09NIHdoZW4gZ3Jvd2luZyBhIFZlY3Rvci4KKyAgICAg ICAgd2hpbGUgKHRydWUpIGJhcigpOworICAgIH0KK30KK25vSW5saW5lKGZvbyk7Citmb3IgKGxl dCBpID0gMDsgaSA8IDEwMDAwOyArK2kpCisgICAgZm9vKCk7CkluZGV4OiBTb3VyY2UvSmF2YVNj cmlwdENvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9D aGFuZ2VMb2cJKHJldmlzaW9uIDIxNzE5OCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFu Z2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwzMyBAQAorMjAxNy0wNS0yMyAgU2FhbSBC YXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4KKworICAgICAgICBDRkdTaW1wbGlmaWNhdGlvblBo YXNlIHNob3VsZCBub3QgbWVyZ2UgYSBibG9jayB3aXRoIGl0c2VsZgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcyNTA4CisgICAgICAgIDxyZGFyOi8v cHJvYmxlbS8yODQyNDAwNj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBDRkdTaW1wbGlmaWNhdGlvblBoYXNlIGNhbiBydW4gaW50byBvciBjcmVhdGUg SVIgdGhhdCBlbmRzIHVwIHdpdGggYQorICAgICAgICBibG9jayB0aGF0IGhhcyBhIEp1bXAgdG8g aXRzZWxmLCBhbmQgbm8gb3RoZXIgcHJlZGVjZXNzb3JzLiBJdCBzaG91bGQKKyAgICAgICAgZ3Jh Y2VmdWxseSBoYW5kbGUgc3VjaCBJUi4gQmVmb3JlIHRoaXMgcGF0Y2gsIGl0IHdvdWxkIG5vdC4g VGhlIG9ubHkgY3JpdGVyaWEKKyAgICAgICAgZm9yIG1lcmdpbmcgJ2Jsb2NrJyB3aXRoICd0YXJn ZXRCbG9jaycgdXNlZCB0byBiZSB0aGF0ICd0YXJnZXRCbG9jay5wcmVkZWNlc3NvcnMuc2l6ZSgp ID09IDEnLgorICAgICAgICBUaGUgY29kZSBpcyB3cml0dGVuIGluIHN1Y2ggYSB3YXkgdGhhdCBp ZiB3ZSBtZXJnZSBhIGJsb2NrIHdpdGggaXRzZWxmLCB3ZQorICAgICAgICB3aWxsIGluZmluaXRl IGxvb3AgdW50aWwgd2UgcnVuIG91dCBvZiBtZW1vcnkuCisgICAgICAgIAorICAgICAgICBNZXJn aW5nIGEgYmxvY2sgd2l0aCBpdHNlbGYgZG9lcyBub3QgbWFrZSBzZW5zZSBmb3IgYSBmZXcgcmVh c29ucy4gRmlyc3QsCisgICAgICAgIHdlJ3JlIGpvaW5pbmcgdGhlIGNvbnRlbnRzIG9mIHR3byBi bG9ja3MuIFdoYXQgaXMgdGhlIGRlZmluaXRpb24gb2Ygam9pbmluZworICAgICAgICBhIGJsb2Nr IHdpdGggaXRzZWxmPyBJIHN1cHBvc2Ugd2UgY291bGQgc2ltcGx5IHVucm9sbCB0aGlzIHNlbGYg bG9vcAorICAgICAgICBvbmUgbGV2ZWwsIGJ1dCB0aGF0IHdvdWxkIG5vdCBiZSB3aXNlIGJlY2F1 c2UgdGhpcyBzZWxmIGxvb3AgaXMgYnkgZGVmaW5pdGlvbgorICAgICAgICB1bnJlYWNoYWJsZSB1 bmxlc3MgaXQncyB0aGUgcm9vdCBibG9jayBpbiB0aGUgZ3JhcGggKHdoaWNoIEkgdGhpbmsgaXMK KyAgICAgICAgaW52YWxpZCBJUiBzaW5jZSB3ZSdkIG5ldmVyIGdlbmVyYXRlIGJ5dGVjb2RlIHRo YXQgd291bGQgZG8gdGhpcykuCisgICAgICAgIAorICAgICAgICBUaGlzIHBhdGNoIGVtcGxveXMg YW4gZWFzeSBmaXg6IHdlIGNhbid0IG1lcmdlIGEgYmxvY2sgd2l0aCBpdHNlbGYuCisKKyAgICAg ICAgKiBkZmcvREZHQ0ZHU2ltcGxpZmljYXRpb25QaGFzZS5jcHA6CisgICAgICAgIChKU0M6OkRG Rzo6Q0ZHU2ltcGxpZmljYXRpb25QaGFzZTo6Y2FuTWVyZ2VCbG9ja3MpOgorICAgICAgICAoSlND OjpERkc6OkNGR1NpbXBsaWZpY2F0aW9uUGhhc2U6OnJ1bik6CisgICAgICAgIChKU0M6OkRGRzo6 Q0ZHU2ltcGxpZmljYXRpb25QaGFzZTo6Y29udmVydFRvSnVtcCk6CisgICAgICAgIChKU0M6OkRG Rzo6Q0ZHU2ltcGxpZmljYXRpb25QaGFzZTo6bWVyZ2VCbG9ja3MpOgorCiAyMDE3LTA1LTIxICBT YWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgogCiAgICAgICAgIFdlIG92ZXJ3cml0ZSB0 aGUgY2FsbGVlIHNhdmUgc3BhY2Ugb24gdGhlIHN0YWNrIHdoZW4gdGhyb3dpbmcgc3RhY2sgb3Zl cmZsb3cgZnJvbSB3YXNtCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0NGR1Np bXBsaWZpY2F0aW9uUGhhc2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9kZmcvREZHQ0ZHU2ltcGxpZmljYXRpb25QaGFzZS5jcHAJKHJldmlzaW9uIDIxNzE5OCkKKysr IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQ0ZHU2ltcGxpZmljYXRpb25QaGFzZS5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTQzLDYgKzQzLDExIEBAIHB1YmxpYzoKICAgICAgICAgOiBQaGFz ZShncmFwaCwgIkNGRyBzaW1wbGlmaWNhdGlvbiIpCiAgICAgewogICAgIH0KKworICAgIGJvb2wg Y2FuTWVyZ2VCbG9ja3MoQmFzaWNCbG9jayogYmxvY2ssIEJhc2ljQmxvY2sqIHRhcmdldEJsb2Nr KQorICAgIHsKKyAgICAgICAgcmV0dXJuIHRhcmdldEJsb2NrLT5wcmVkZWNlc3NvcnMuc2l6ZSgp ID09IDEgJiYgdGFyZ2V0QmxvY2sgIT0gYmxvY2s7CisgICAgfQogICAgIAogICAgIGJvb2wgcnVu KCkKICAgICB7CkBAIC02MSwxMSArNjYsMTUgQEAgcHVibGljOgogICAgICAgICAgICAgICAgIGlm ICghYmxvY2spCiAgICAgICAgICAgICAgICAgICAgIGNvbnRpbnVlOwogICAgICAgICAgICAgICAg IEFTU0VSVChibG9jay0+aXNSZWFjaGFibGUpOworCisgICAgICAgICAgICAgICAgYXV0byBjYW5N ZXJnZVdpdGhCbG9jayA9IFsmXSAoQmFzaWNCbG9jayogdGFyZ2V0QmxvY2spIHsKKyAgICAgICAg ICAgICAgICAgICAgcmV0dXJuIGNhbk1lcmdlQmxvY2tzKGJsb2NrLCB0YXJnZXRCbG9jayk7Cisg ICAgICAgICAgICAgICAgfTsKICAgICAgICAgICAgIAogICAgICAgICAgICAgICAgIHN3aXRjaCAo YmxvY2stPnRlcm1pbmFsKCktPm9wKCkpIHsKICAgICAgICAgICAgICAgICBjYXNlIEp1bXA6IHsK ICAgICAgICAgICAgICAgICAgICAgLy8gU3VjY2Vzc29yIHdpdGggb25lIHByZWRlY2Vzc29yIC0+ IG1lcmdlLgotICAgICAgICAgICAgICAgICAgICBpZiAoYmxvY2stPnN1Y2Nlc3NvcigwKS0+cHJl ZGVjZXNzb3JzLnNpemUoKSA9PSAxKSB7CisgICAgICAgICAgICAgICAgICAgIGlmIChjYW5NZXJn ZVdpdGhCbG9jayhibG9jay0+c3VjY2Vzc29yKDApKSkgewogICAgICAgICAgICAgICAgICAgICAg ICAgQVNTRVJUKGJsb2NrLT5zdWNjZXNzb3IoMCktPnByZWRlY2Vzc29yc1swXSA9PSBibG9jayk7 CiAgICAgICAgICAgICAgICAgICAgICAgICBpZiAoZXh0cmVtZUxvZ2dpbmcpCiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgbV9ncmFwaC5kdW1wKCk7CkBAIC05Myw3ICsxMDIsNyBAQCBwdWJs aWM6CiAgICAgICAgICAgICAgICAgICAgICAgICBib29sIGNvbmRpdGlvbiA9IGJyYW5jaENvbmRp dGlvbihibG9jay0+Y2ZhQnJhbmNoRGlyZWN0aW9uKTsKICAgICAgICAgICAgICAgICAgICAgICAg IEJhc2ljQmxvY2sqIHRhcmdldEJsb2NrID0gYmxvY2stPnN1Y2Nlc3NvckZvckNvbmRpdGlvbihj b25kaXRpb24pOwogICAgICAgICAgICAgICAgICAgICAgICAgQmFzaWNCbG9jayogamV0dGlzb25l ZEJsb2NrID0gYmxvY2stPnN1Y2Nlc3NvckZvckNvbmRpdGlvbighY29uZGl0aW9uKTsKLSAgICAg ICAgICAgICAgICAgICAgICAgIGlmICh0YXJnZXRCbG9jay0+cHJlZGVjZXNzb3JzLnNpemUoKSA9 PSAxKSB7CisgICAgICAgICAgICAgICAgICAgICAgICBpZiAoY2FuTWVyZ2VXaXRoQmxvY2sodGFy Z2V0QmxvY2spKSB7CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaWYgKGV4dHJlbWVMb2dn aW5nKQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBtX2dyYXBoLmR1bXAoKTsKICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBtX2dyYXBoLmRldGhyZWFkKCk7CkBAIC0xNzcsNyAr MTg2LDcgQEAgcHVibGljOgogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBqZXR0aXNv bmVkQmxvY2tzLmFwcGVuZChzdWNjZXNzb3IpOwogICAgICAgICAgICAgICAgICAgICAgICAgfQog ICAgICAgICAgICAgICAgICAgICAgICAgCi0gICAgICAgICAgICAgICAgICAgICAgICBpZiAodGFy Z2V0QmxvY2stPnByZWRlY2Vzc29ycy5zaXplKCkgPT0gMSkgeworICAgICAgICAgICAgICAgICAg ICAgICAgaWYgKGNhbk1lcmdlV2l0aEJsb2NrKHRhcmdldEJsb2NrKSkgewogICAgICAgICAgICAg ICAgICAgICAgICAgICAgIGlmIChleHRyZW1lTG9nZ2luZykKICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgbV9ncmFwaC5kdW1wKCk7CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg bV9ncmFwaC5kZXRocmVhZCgpOwpAQCAtMjU1LDcgKzI2NCw3IEBAIHByaXZhdGU6CiAgICAgewog ICAgICAgICBBU1NFUlQodGFyZ2V0QmxvY2spOwogICAgICAgICBBU1NFUlQodGFyZ2V0QmxvY2st PmlzUmVhY2hhYmxlKTsKLSAgICAgICAgaWYgKHRhcmdldEJsb2NrLT5wcmVkZWNlc3NvcnMuc2l6 ZSgpID09IDEpIHsKKyAgICAgICAgaWYgKGNhbk1lcmdlQmxvY2tzKGJsb2NrLCB0YXJnZXRCbG9j aykpIHsKICAgICAgICAgICAgIG1fZ3JhcGguZGV0aHJlYWQoKTsKICAgICAgICAgICAgIG1lcmdl QmxvY2tzKGJsb2NrLCB0YXJnZXRCbG9jaywgbm9CbG9ja3MoKSk7CiAgICAgICAgIH0gZWxzZSB7 CkBAIC0zMTgsNiArMzI3LDcgQEAgcHJpdmF0ZToKICAgICAgICAgQmFzaWNCbG9jayogZmlyc3RC bG9jaywgQmFzaWNCbG9jayogc2Vjb25kQmxvY2ssCiAgICAgICAgIFZlY3RvcjxCYXNpY0Jsb2Nr KiwgMT4gamV0dGlzb25lZEJsb2NrcykKICAgICB7CisgICAgICAgIFJFTEVBU0VfQVNTRVJUKGNh bk1lcmdlQmxvY2tzKGZpcnN0QmxvY2ssIHNlY29uZEJsb2NrKSk7CiAgICAgICAgIC8vIFRoaXMg d2lsbCBhZGQgYWxsIG9mIHRoZSBub2RlcyBpbiBzZWNvbmRCbG9jayB0byBmaXJzdEJsb2NrLCBi dXQgaW4gc28gZG9pbmcKICAgICAgICAgLy8gaXQgd2lsbCBhbHNvIGVuc3VyZSB0aGF0IGFueSBH ZXRMb2NhbHMgZnJvbSB0aGUgc2Vjb25kIGJsb2NrIHRoYXQgcmVmZXIgdG8KICAgICAgICAgLy8g U2V0TG9jYWxzIGluIHRoZSBmaXJzdCBibG9jayBhcmUgcmVsaW5rZWQuIElmIGpldHRpc29uZWRC bG9jayBpcyBub3QgTm9CbG9jaywK