172460 2017-05-22 12:03:03 -0700 Need a way to allow WKWebView to load request with ShouldOpenExternalURLsPolicy::ShouldAllow. 2017-05-22 15:41:07 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 yongjun_zhang yongjun_zhang achristensen andersca bdakin beidson commit-queue ggaren mitz sam thorton yongjun_zhang oldest_to_newest 1311475 0 yongjun_zhang 2017-05-22 12:03:03 -0700 Currently, by default, [WKWebView loadRequest:] will set ShouldOpenExternalURLsPolicy to be ShouldNotAllow. It would be nice if a WebKit client can ask WKWebView to load request with ShouldOpenExternalURLsPolicy being ShouldAllow. 1311476 1 yongjun_zhang 2017-05-22 12:03:30 -0700 rdar://problem/30741139 1311483 2 310898 yongjun_zhang 2017-05-22 12:11:04 -0700 Created attachment 310898 Patch. 1311508 3 310898 achristensen 2017-05-22 12:53:21 -0700 Comment on attachment 310898 Patch. Sure, but I see no reason why this SPI should be iOS-only. 1311537 4 yongjun_zhang 2017-05-22 13:40:33 -0700 (In reply to Alex Christensen from comment #3) > Comment on attachment 310898 [details] > Patch. > > Sure, but I see no reason why this SPI should be iOS-only. Currently, this is only needed for iOS. We can certainly expand this to macOS if needed in the future. We did have the C SPI version in WKPagePrivate.h WKPageLoadURLWithShouldOpenExternalURLsPolicy, and it seems like no one is using it right now. 1311538 5 thorton 2017-05-22 13:42:00 -0700 (In reply to Yongjun Zhang from comment #4) > (In reply to Alex Christensen from comment #3) > > Comment on attachment 310898 [details] > > Patch. > > > > Sure, but I see no reason why this SPI should be iOS-only. > > Currently, this is only needed for iOS. We can certainly expand this to > macOS if needed in the future. This isn't how we should add things to a cross-platform framework. We should add to both platforms unless we have a good reason *not* to. > We did have the C SPI version in WKPagePrivate.h > WKPageLoadURLWithShouldOpenExternalURLsPolicy, and it seems like no one is > using it right now. 1311580 6 310922 yongjun_zhang 2017-05-22 14:37:05 -0700 Created attachment 310922 Patch, add this SPI for both iOS and macOS. Address review comment, adding _loadRequest:shouldOpenExternalURLs: as an SPI for both iOS and macOS. 1311623 7 310922 commit-queue 2017-05-22 15:41:05 -0700 Comment on attachment 310922 Patch, add this SPI for both iOS and macOS. Clearing flags on attachment: 310922 Committed r217252: <http://trac.webkit.org/changeset/217252> 1311624 8 commit-queue 2017-05-22 15:41:07 -0700 All reviewed patches have been landed. Closing bug. 310898 2017-05-22 12:11:04 -0700 2017-05-22 14:37:05 -0700 Patch. shouldLoadExternalURL.patch text/plain 3077 yongjun_zhang Y29tbWl0IGQzNTc4YmM2NTZiMTQzNWIzNjNjNzkzYjVkMTI5MmY2NjViMjdmZmYKQXV0aG9yOiBZ b25nanVuIFpoYW5nIDx5b25nanVuX3poYW5nQGFwcGxlLmNvbT4KRGF0ZTogICBNb24gTWF5IDIy IDExOjU1OjQ4IDIwMTcgLTA3MDAKCiAgICBOZWVkIGEgd2F5IHRvIGFsbG93IFdLV2ViVmlldyB0 byBsb2FkIHJlcXVlc3Qgd2l0aCBTaG91bGRPcGVuRXh0ZXJuYWxVUkxzUG9saWN5OjpTaG91bGRB bGxvdy4KICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzI0NjAK CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cKaW5kZXggNzIyNzk3OWM5MTAuLjYxNTgwNWY3NTAxIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTggQEAKKzIwMTctMDUtMjIgIFlvbmdqdW4gWmhhbmcgIDx5b25nanVuX3poYW5nQGFw cGxlLmNvbT4KKworICAgICAgICBOZWVkIGEgd2F5IHRvIGFsbG93IFdLV2ViVmlldyB0byBsb2Fk IHJlcXVlc3Qgd2l0aCBTaG91bGRPcGVuRXh0ZXJuYWxVUkxzUG9saWN5OjpTaG91bGRBbGxvdy4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MjQ2MAor CisgICAgICAgIEFkZCBhbiBuZXcgbWV0aG9kIFtXS1dlYlZpZXcgX2xvYWRSZXF1ZXN0OnNob3Vs ZE9wZW5FeHRlcm5hbFVSTHM6XSB0byBXS1dlYlZpZXc7IGEgV2ViS2l0IGNsaWVudAorICAgICAg ICBjYW4gdXNlIHRoaXMgdG8gbG9hZCByZXF1ZXN0IHRoYXQgYWxsb3dzIG9wZW5pbmcgZXh0ZXJu YWwgVVJMcy4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tOgorICAgICAgICAoLVtXS1dlYlZp ZXcgX2xvYWRSZXF1ZXN0OnNob3VsZE9wZW5FeHRlcm5hbFVSTHM6XSk6IFdoZW4gY2FsbGluZyBX ZWJQYWdlUHJveHk6OmxvYWRSZXF1ZXN0LCBhbHNvCisgICAgICAgICAgICBzZXQgU2hvdWxkT3Bl bkV4dGVybmFsVVJMc1BvbGljeSBiYXNlZCBvbiB0aGUgdmFsdWUgb2Ygc2hvdWxkT3BlbkV4dGVy bmFsVVJMcy4KKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlld1ByaXZhdGUu aDogQWRkIFtXS1dlYlZpZXcgX2xvYWRSZXF1ZXN0OnNob3VsZE9wZW5FeHRlcm5hbFVSTHM6XS4K KwogMjAxNy0wNS0yMiAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGlnYWxpYS5jb20+ CiAKICAgICAgICAgLVdyZXR1cm4tdHlwZSB3YXJuaW5nIHRyaWdnZXJlZCBieSBXS1BhZ2UuY3Bw OjIyNzcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tX ZWJWaWV3Lm1tIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcu bW0KaW5kZXggM2ZlNzg5MjZlNDQuLjk3ZTZiYzEwODMyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbQpAQCAtNTAxNiw2ICs1MDE2LDE1IEBA IC0gKHZvaWQpc2V0U2VtYW50aWNDb250ZW50QXR0cmlidXRlOihVSVNlbWFudGljQ29udGVudEF0 dHJpYnV0ZSljb250ZW50QXR0cmlidXRlCiAgICAgX3BhZ2UtPnNldFVzZXJJbnRlcmZhY2VMYXlv dXREaXJlY3Rpb24odG9Vc2VySW50ZXJmYWNlTGF5b3V0RGlyZWN0aW9uKGNvbnRlbnRBdHRyaWJ1 dGUpKTsKIH0KIAorLSAoV0tOYXZpZ2F0aW9uICopX2xvYWRSZXF1ZXN0OihOU1VSTFJlcXVlc3Qg KilyZXF1ZXN0IHNob3VsZE9wZW5FeHRlcm5hbFVSTHM6KEJPT0wpc2hvdWxkT3BlbkV4dGVybmFs VVJMcworeworICAgIGF1dG8gbmF2aWdhdGlvbiA9IF9wYWdlLT5sb2FkUmVxdWVzdChyZXF1ZXN0 LCBzaG91bGRPcGVuRXh0ZXJuYWxVUkxzID8gV2ViQ29yZTo6U2hvdWxkT3BlbkV4dGVybmFsVVJM c1BvbGljeTo6U2hvdWxkQWxsb3cgOiBXZWJDb3JlOjpTaG91bGRPcGVuRXh0ZXJuYWxVUkxzUG9s aWN5OjpTaG91bGROb3RBbGxvdyk7CisgICAgaWYgKCFuYXZpZ2F0aW9uKQorICAgICAgICByZXR1 cm4gbmlsOworCisgICAgcmV0dXJuIFt3cmFwcGVyKCpuYXZpZ2F0aW9uLmxlYWtSZWYoKSkgYXV0 b3JlbGVhc2VdOworfQorCiAjZWxzZSAvLyAjaWYgUExBVEZPUk0oSU9TKQogCiAjcHJhZ21hIG1h cmsgLSBPUyBYLXNwZWNpZmljIG1ldGhvZHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3UHJpdmF0ZS5oIGIvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXdQcml2YXRlLmgKaW5kZXggMTRiZTJjM2Q0ZTcuLmMz OTU0OGYyMzdhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29h L1dLV2ViVmlld1ByaXZhdGUuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0Nv Y29hL1dLV2ViVmlld1ByaXZhdGUuaApAQCAtMjE2LDYgKzIxNiw4IEBAIHR5cGVkZWYgTlNfRU5V TShOU0ludGVnZXIsIF9XS0ltbWVkaWF0ZUFjdGlvblR5cGUpIHsKIC0gKHZvaWQpX2FjY2Vzc2li aWxpdHlSZXRyaWV2ZVNwZWFrU2VsZWN0aW9uQ29udGVudDsKIC0gKHZvaWQpX2FjY2Vzc2liaWxp dHlEaWRHZXRTcGVha1NlbGVjdGlvbkNvbnRlbnQ6KE5TU3RyaW5nICopY29udGVudDsKIAorLSAo V0tOYXZpZ2F0aW9uICopX2xvYWRSZXF1ZXN0OihOU1VSTFJlcXVlc3QgKilyZXF1ZXN0IHNob3Vs ZE9wZW5FeHRlcm5hbFVSTHM6KEJPT0wpc2hvdWxkT3BlbkV4dGVybmFsVVJMcyBXS19BUElfQVZB SUxBQkxFKGlvcyhXS19JT1NfVEJBKSk7CisKICNlbHNlCiBAcHJvcGVydHkgKHJlYWRvbmx5KSBO U0NvbG9yICpfcGFnZUV4dGVuZGVkQmFja2dyb3VuZENvbG9yOwogQHByb3BlcnR5IChub25hdG9t aWMsIHNldHRlcj1fc2V0RHJhd3NCYWNrZ3JvdW5kOikgQk9PTCBfZHJhd3NCYWNrZ3JvdW5kOwo= 310922 2017-05-22 14:37:05 -0700 2017-05-22 15:41:05 -0700 Patch, add this SPI for both iOS and macOS. shouldLoadExternalURL.patch text/plain 3372 yongjun_zhang Y29tbWl0IGIzZjNhZTk2N2IyNmM2MzMyM2E5MmE4NGJkNWM1NGVmNGEyMDdlYzUKQXV0aG9yOiBZ b25nanVuIFpoYW5nIDx5b25nanVuX3poYW5nQGFwcGxlLmNvbT4KRGF0ZTogICBNb24gTWF5IDIy IDExOjU1OjQ4IDIwMTcgLTA3MDAKCiAgICBOZWVkIGEgd2F5IHRvIGFsbG93IFdLV2ViVmlldyB0 byBsb2FkIHJlcXVlc3Qgd2l0aCBTaG91bGRPcGVuRXh0ZXJuYWxVUkxzUG9saWN5OjpTaG91bGRB bGxvdy4KICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzI0NjAK CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cKaW5kZXggNzIyNzk3OWM5MTAuLjYxNTgwNWY3NTAxIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTggQEAKKzIwMTctMDUtMjIgIFlvbmdqdW4gWmhhbmcgIDx5b25nanVuX3poYW5nQGFw cGxlLmNvbT4KKworICAgICAgICBOZWVkIGEgd2F5IHRvIGFsbG93IFdLV2ViVmlldyB0byBsb2Fk IHJlcXVlc3Qgd2l0aCBTaG91bGRPcGVuRXh0ZXJuYWxVUkxzUG9saWN5OjpTaG91bGRBbGxvdy4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MjQ2MAor CisgICAgICAgIEFkZCBhbiBuZXcgbWV0aG9kIFtXS1dlYlZpZXcgX2xvYWRSZXF1ZXN0OnNob3Vs ZE9wZW5FeHRlcm5hbFVSTHM6XSB0byBXS1dlYlZpZXc7IGEgV2ViS2l0IGNsaWVudAorICAgICAg ICBjYW4gdXNlIHRoaXMgdG8gbG9hZCByZXF1ZXN0IHRoYXQgYWxsb3dzIG9wZW5pbmcgZXh0ZXJu YWwgVVJMcy4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tOgorICAgICAgICAoLVtXS1dlYlZp ZXcgX2xvYWRSZXF1ZXN0OnNob3VsZE9wZW5FeHRlcm5hbFVSTHM6XSk6IFdoZW4gY2FsbGluZyBX ZWJQYWdlUHJveHk6OmxvYWRSZXF1ZXN0LCBhbHNvCisgICAgICAgICAgICBzZXQgU2hvdWxkT3Bl bkV4dGVybmFsVVJMc1BvbGljeSBiYXNlZCBvbiB0aGUgdmFsdWUgb2Ygc2hvdWxkT3BlbkV4dGVy bmFsVVJMcy4KKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlld1ByaXZhdGUu aDogQWRkIFtXS1dlYlZpZXcgX2xvYWRSZXF1ZXN0OnNob3VsZE9wZW5FeHRlcm5hbFVSTHM6XS4K KwogMjAxNy0wNS0yMiAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGlnYWxpYS5jb20+ CiAKICAgICAgICAgLVdyZXR1cm4tdHlwZSB3YXJuaW5nIHRyaWdnZXJlZCBieSBXS1BhZ2UuY3Bw OjIyNzcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tX ZWJWaWV3Lm1tIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcu bW0KaW5kZXggM2ZlNzg5MjZlNDQuLmZhYjMyZGFmYjJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbQpAQCAtMzcwMiw2ICszNzAyLDE1IEBA IC0gKFdLTmF2aWdhdGlvbiAqKV9sb2FkRGF0YTooTlNEYXRhICopZGF0YSBNSU1FVHlwZTooTlNT dHJpbmcgKilNSU1FVHlwZSBjaGFyYWN0CiAgICAgcmV0dXJuIFt3cmFwcGVyKCpuYXZpZ2F0aW9u LmxlYWtSZWYoKSkgYXV0b3JlbGVhc2VdOwogfQogCistIChXS05hdmlnYXRpb24gKilfbG9hZFJl cXVlc3Q6KE5TVVJMUmVxdWVzdCAqKXJlcXVlc3Qgc2hvdWxkT3BlbkV4dGVybmFsVVJMczooQk9P TClzaG91bGRPcGVuRXh0ZXJuYWxVUkxzCit7CisgICAgYXV0byBuYXZpZ2F0aW9uID0gX3BhZ2Ut PmxvYWRSZXF1ZXN0KHJlcXVlc3QsIHNob3VsZE9wZW5FeHRlcm5hbFVSTHMgPyBXZWJDb3JlOjpT aG91bGRPcGVuRXh0ZXJuYWxVUkxzUG9saWN5OjpTaG91bGRBbGxvdyA6IFdlYkNvcmU6OlNob3Vs ZE9wZW5FeHRlcm5hbFVSTHNQb2xpY3k6OlNob3VsZE5vdEFsbG93KTsKKyAgICBpZiAoIW5hdmln YXRpb24pCisgICAgICAgIHJldHVybiBuaWw7CisKKyAgICByZXR1cm4gW3dyYXBwZXIoKm5hdmln YXRpb24ubGVha1JlZigpKSBhdXRvcmVsZWFzZV07Cit9CisKIC0gKE5TQXJyYXkgKilfY2VydGlm aWNhdGVDaGFpbgogewogICAgIGlmIChXZWJLaXQ6OldlYkZyYW1lUHJveHkqIG1haW5GcmFtZSA9 IF9wYWdlLT5tYWluRnJhbWUoKSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvQ29jb2EvV0tXZWJWaWV3UHJpdmF0ZS5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9Db2NvYS9XS1dlYlZpZXdQcml2YXRlLmgKaW5kZXggMTRiZTJjM2Q0ZTcuLjkyZWU4NmMz NTRlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2Vi Vmlld1ByaXZhdGUuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dL V2ViVmlld1ByaXZhdGUuaApAQCAtMTAzLDYgKzEwMyw3IEBAIHR5cGVkZWYgTlNfRU5VTShOU0lu dGVnZXIsIF9XS0ltbWVkaWF0ZUFjdGlvblR5cGUpIHsKIAogLSAodm9pZClfbG9hZEFsdGVybmF0 ZUhUTUxTdHJpbmc6KE5TU3RyaW5nICopc3RyaW5nIGJhc2VVUkw6KE5TVVJMICopYmFzZVVSTCBm b3JVbnJlYWNoYWJsZVVSTDooTlNVUkwgKil1bnJlYWNoYWJsZVVSTDsKIC0gKFdLTmF2aWdhdGlv biAqKV9sb2FkRGF0YTooTlNEYXRhICopZGF0YSBNSU1FVHlwZTooTlNTdHJpbmcgKilNSU1FVHlw ZSBjaGFyYWN0ZXJFbmNvZGluZ05hbWU6KE5TU3RyaW5nICopY2hhcmFjdGVyRW5jb2RpbmdOYW1l IGJhc2VVUkw6KE5TVVJMICopYmFzZVVSTCB1c2VyRGF0YTooaWQpdXNlckRhdGEgV0tfQVBJX0FW QUlMQUJMRShtYWNvc3goMTAuMTIpLCBpb3MoMTAuMCkpOworLSAoV0tOYXZpZ2F0aW9uICopX2xv YWRSZXF1ZXN0OihOU1VSTFJlcXVlc3QgKilyZXF1ZXN0IHNob3VsZE9wZW5FeHRlcm5hbFVSTHM6 KEJPT0wpc2hvdWxkT3BlbkV4dGVybmFsVVJMcyBXS19BUElfQVZBSUxBQkxFKG1hY29zeChXS19N QUNfVEJBKSwgaW9zKFdLX0lPU19UQkEpKTsKIAogQHByb3BlcnR5IChub25hdG9taWMsIHJlYWRv bmx5KSBOU0FycmF5ICpfY2VydGlmaWNhdGVDaGFpbiBXS19BUElfREVQUkVDQVRFRF9XSVRIX1JF UExBQ0VNRU5UKCJjZXJ0aWZpY2F0ZUNoYWluIiwgbWFjb3N4KDEwLjEwLCAxMC4xMSksIGlvcyg4 LjAsIDkuMCkpOwogQHByb3BlcnR5IChub25hdG9taWMsIHJlYWRvbmx5KSBOU1VSTCAqX2NvbW1p dHRlZFVSTDsK