172455 2017-05-22 09:55:37 -0700 FTL stack overflow handling should not assume that B3 never selects callee-saves in the prologue 2017-05-22 11:22:21 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo ggaren jfbastien keith_miller mark.lam msaboff saam ysuzuki oldest_to_newest 1311400 0 fpizlo 2017-05-22 09:55:37 -0700 In one bizarre case, B3 used a callee-save for the CodeBlock constant created in the prologue before the stack overflow check. 1311405 1 310890 fpizlo 2017-05-22 09:58:53 -0700 Created attachment 310890 the patch 1311406 2 310890 fpizlo 2017-05-22 09:59:51 -0700 Comment on attachment 310890 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=310890&action=review > Source/JavaScriptCore/heap/Subspace.cpp:56 > + > + I'll revert 1311407 3 310890 mark.lam 2017-05-22 10:06:33 -0700 Comment on attachment 310890 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=310890&action=review r=me with comment. > Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:233 > + // OOPS! Need bug URL. Please add bug url before landing. > Source/JavaScriptCore/heap/Subspace.cpp:220 > +ALWAYS_INLINE void Subspace::didAllocate(void* ptr) > +{ > + UNUSED_PARAM(ptr); > + > + // This is useful for logging allocations, or doing other kinds of debugging hacks. Just make > + // sure you JSC_forceGCSlowPaths=true. > +} > + This set of changes (while useful) seems totally unrelated to this patch. Did you intend to include it? 1311410 4 fpizlo 2017-05-22 10:11:19 -0700 (In reply to Mark Lam from comment #3) > Comment on attachment 310890 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=310890&action=review > > r=me with comment. > > > Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:233 > > + // OOPS! Need bug URL. > > Please add bug url before landing. Ooops! I filed it: https://bugs.webkit.org/show_bug.cgi?id=172456 > > > Source/JavaScriptCore/heap/Subspace.cpp:220 > > +ALWAYS_INLINE void Subspace::didAllocate(void* ptr) > > +{ > > + UNUSED_PARAM(ptr); > > + > > + // This is useful for logging allocations, or doing other kinds of debugging hacks. Just make > > + // sure you JSC_forceGCSlowPaths=true. > > +} > > + > > This set of changes (while useful) seems totally unrelated to this patch. > Did you intend to include it? Yeah. This bug looked like a GC bug until for the first ~2 hours that I spent on it. Every time I run into a GC bug, the first thing I do is instrument every allocation site. I finally decided to do it the "right" way. 1311411 5 fpizlo 2017-05-22 10:14:52 -0700 Landed in http://trac.webkit.org/changeset/217221/webkit 1311450 6 310890 saam 2017-05-22 11:22:21 -0700 Comment on attachment 310890 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=310890&action=review > Source/JavaScriptCore/ChangeLog:10 > + The FTL needs to run B3's callee-save register restoration before it runs the exception > + handler's callee-save register restoration. This exposes B3's callee-save register > + algorithm in AssemblyHelpers so that the FTL can call it. Nice. I actually realized this bug when reading the FTL overflow code when doing wasm overflow. I should have file a bug when I thought this could be an issue. An alternative way to solve this, and is what I did for wasm, which is unwind from the top frame (not the caller frame of the top frame), and just let the unwinder restore the callee saves. I concluded this was safe for wasm/JS because the caller is responsible for ensuring that the callee's FP is not overflowed. 310890 2017-05-22 09:58:53 -0700 2017-05-22 10:06:33 -0700 the patch blah.patch text/plain 7821 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjE3MjE5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI4IEBA CisyMDE3LTA1LTIyICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg RlRMIHN0YWNrIG92ZXJmbG93IGhhbmRsaW5nIHNob3VsZCBub3QgYXNzdW1lIHRoYXQgQjMgbmV2 ZXIgc2VsZWN0cyBjYWxsZWUtc2F2ZXMgaW4gdGhlIHByb2xvZ3VlCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzI0NTUKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIFRoZSBGVEwgbmVlZHMgdG8g cnVuIEIzJ3MgY2FsbGVlLXNhdmUgcmVnaXN0ZXIgcmVzdG9yYXRpb24gYmVmb3JlIGl0IHJ1bnMg dGhlIGV4Y2VwdGlvbgorICAgICAgICBoYW5kbGVyJ3MgY2FsbGVlLXNhdmUgcmVnaXN0ZXIgcmVz dG9yYXRpb24uICBUaGlzIGV4cG9zZXMgQjMncyBjYWxsZWUtc2F2ZSByZWdpc3RlcgorICAgICAg ICBhbGdvcml0aG0gaW4gQXNzZW1ibHlIZWxwZXJzIHNvIHRoYXQgdGhlIEZUTCBjYW4gY2FsbCBp dC4KKworICAgICAgICAqIGIzL2Fpci9BaXJHZW5lcmF0ZS5jcHA6CisgICAgICAgIChKU0M6OkIz OjpBaXI6OmdlbmVyYXRlKToKKyAgICAgICAgKiBmdGwvRlRMTG93ZXJERkdUb0IzLmNwcDoKKyAg ICAgICAgKEpTQzo6RlRMOjpERkc6Okxvd2VyREZHVG9CMzo6bG93ZXIpOiBGaXggdGhlIGJ1Zy4K KyAgICAgICAgKiBoZWFwL1N1YnNwYWNlLmNwcDogQWRkZWQgc29tZSBkZWJ1Z2dpbmcgc3VwcG9y dC4KKyAgICAgICAgKEpTQzo6U3Vic3BhY2U6OmFsbG9jYXRlKToKKyAgICAgICAgKEpTQzo6U3Vi c3BhY2U6OnRyeUFsbG9jYXRlKToKKyAgICAgICAgKEpTQzo6U3Vic3BhY2U6OmRpZEFsbG9jYXRl KToKKyAgICAgICAgKiBoZWFwL1N1YnNwYWNlLmg6CisgICAgICAgICogaml0L0Fzc2VtYmx5SGVs cGVycy5oOgorICAgICAgICAoSlNDOjpBc3NlbWJseUhlbHBlcnM6OmFkZHJlc3NGb3IpOgorICAg ICAgICAoSlNDOjpBc3NlbWJseUhlbHBlcnM6OmVtaXRTYXZlKToKKyAgICAgICAgKEpTQzo6QXNz ZW1ibHlIZWxwZXJzOjplbWl0UmVzdG9yZSk6CisKIDIwMTctMDUtMjAgIFl1c3VrZSBTdXp1a2kg IDx1dGF0YW5lLnRlYUBnbWFpbC5jb20+CiAKICAgICAgICAgW0ZUTF0gU3VwcG9ydCBHZXRCeVZh bCB3aXRoIEFycmF5U3RvcmFnZSBhbmQgU2xvd1B1dEFycmF5U3RvcmFnZQpJbmRleDogU291cmNl L0phdmFTY3JpcHRDb3JlL2IzL2Fpci9BaXJHZW5lcmF0ZS5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL2IzL2Fpci9BaXJHZW5lcmF0ZS5jcHAJKHJldmlzaW9uIDIxNzEz NSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9iMy9haXIvQWlyR2VuZXJhdGUuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC0xNjgsMTAgKzE2OCw2IEBAIHZvaWQgZ2VuZXJhdGUoQ29kZSYgY29kZSwg Q0NhbGxIZWxwZXJzJiAKIAogICAgIERpc2FsbG93TWFjcm9TY3JhdGNoUmVnaXN0ZXJVc2FnZSBk aXNhbGxvd1NjcmF0Y2goaml0KTsKIAotICAgIGF1dG8gYXJnRm9yID0gWyZdIChjb25zdCBSZWdp c3RlckF0T2Zmc2V0JiBlbnRyeSkgLT4gQ0NhbGxIZWxwZXJzOjpBZGRyZXNzIHsKLSAgICAgICAg cmV0dXJuIENDYWxsSGVscGVyczo6QWRkcmVzcyhHUFJJbmZvOjpjYWxsRnJhbWVSZWdpc3Rlciwg ZW50cnkub2Zmc2V0KCkpOwotICAgIH07Ci0gICAgCiAgICAgLy8gQW5kIG5vdywgd2UgZ2VuZXJh dGUgY29kZS4KICAgICBHZW5lcmF0aW9uQ29udGV4dCBjb250ZXh0OwogICAgIGNvbnRleHQuY29k ZSA9ICZjb2RlOwpAQCAtMjIyLDEyICsyMTgsNyBAQCB2b2lkIGdlbmVyYXRlKENvZGUmIGNvZGUs IENDYWxsSGVscGVycyYgCiAgICAgICAgICAgICAgICAgaml0LmFkZFB0cihDQ2FsbEhlbHBlcnM6 OlRydXN0ZWRJbW0zMigtY29kZS5mcmFtZVNpemUoKSksIE1hY3JvQXNzZW1ibGVyOjpzdGFja1Bv aW50ZXJSZWdpc3Rlcik7CiAgICAgICAgICAgICB9CiAgICAgICAgICAgICAKLSAgICAgICAgICAg IGZvciAoY29uc3QgUmVnaXN0ZXJBdE9mZnNldCYgZW50cnkgOiBjb2RlLmNhbGxlZVNhdmVSZWdp c3RlckF0T2Zmc2V0TGlzdCgpKSB7Ci0gICAgICAgICAgICAgICAgaWYgKGVudHJ5LnJlZygpLmlz R1BSKCkpCi0gICAgICAgICAgICAgICAgICAgIGppdC5zdG9yZVB0cihlbnRyeS5yZWcoKS5ncHIo KSwgYXJnRm9yKGVudHJ5KSk7Ci0gICAgICAgICAgICAgICAgZWxzZQotICAgICAgICAgICAgICAg ICAgICBqaXQuc3RvcmVEb3VibGUoZW50cnkucmVnKCkuZnByKCksIGFyZ0ZvcihlbnRyeSkpOwot ICAgICAgICAgICAgfQorICAgICAgICAgICAgaml0LmVtaXRTYXZlKGNvZGUuY2FsbGVlU2F2ZVJl Z2lzdGVyQXRPZmZzZXRMaXN0KCkpOwogCiAgICAgICAgICAgICBpZiAoZGlzYXNzZW1ibGVyKQog ICAgICAgICAgICAgICAgIGRpc2Fzc2VtYmxlci0+ZW5kRW50cnlwb2ludChqaXQpOyAKQEAgLTI1 OSwxMiArMjUwLDcgQEAgdm9pZCBnZW5lcmF0ZShDb2RlJiBjb2RlLCBDQ2FsbEhlbHBlcnMmIAog ICAgICAgICAgICAgLy8gaGF2ZSB0aGlzIG92ZXJyaWRlLgogICAgICAgICAgICAgYXV0byBzdGFy dCA9IGppdC5sYWJlbElnbm9yaW5nV2F0Y2hwb2ludHMoKTsKICAgICAgICAgICAgIGlmIChjb2Rl LmZyYW1lU2l6ZSgpKSB7Ci0gICAgICAgICAgICAgICAgZm9yIChjb25zdCBSZWdpc3RlckF0T2Zm c2V0JiBlbnRyeSA6IGNvZGUuY2FsbGVlU2F2ZVJlZ2lzdGVyQXRPZmZzZXRMaXN0KCkpIHsKLSAg ICAgICAgICAgICAgICAgICAgaWYgKGVudHJ5LnJlZygpLmlzR1BSKCkpCi0gICAgICAgICAgICAg ICAgICAgICAgICBqaXQubG9hZFB0cihhcmdGb3IoZW50cnkpLCBlbnRyeS5yZWcoKS5ncHIoKSk7 Ci0gICAgICAgICAgICAgICAgICAgIGVsc2UKLSAgICAgICAgICAgICAgICAgICAgICAgIGppdC5s b2FkRG91YmxlKGFyZ0ZvcihlbnRyeSksIGVudHJ5LnJlZygpLmZwcigpKTsKLSAgICAgICAgICAg ICAgICB9CisgICAgICAgICAgICAgICAgaml0LmVtaXRSZXN0b3JlKGNvZGUuY2FsbGVlU2F2ZVJl Z2lzdGVyQXRPZmZzZXRMaXN0KCkpOwogICAgICAgICAgICAgICAgIGppdC5lbWl0RnVuY3Rpb25F cGlsb2d1ZSgpOwogICAgICAgICAgICAgfSBlbHNlCiAgICAgICAgICAgICAgICAgaml0LmVtaXRG dW5jdGlvbkVwaWxvZ3VlV2l0aEVtcHR5RnJhbWUoKTsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9mdGwvRlRMTG93ZXJERkdUb0IzLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNj cmlwdENvcmUvZnRsL0ZUTExvd2VyREZHVG9CMy5jcHAJKHJldmlzaW9uIDIxNzEzNSkKKysrIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93ZXJERkdUb0IzLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtMjI2LDYgKzIyNiwxMyBAQCBwdWJsaWM6CiAgICAgICAgICAgICAgICAgICAgIEFsbG93 TWFjcm9TY3JhdGNoUmVnaXN0ZXJVc2FnZSBhbGxvd1NjcmF0Y2goaml0KTsKIAogICAgICAgICAg ICAgICAgICAgICBzdGFja092ZXJmbG93LmxpbmsoJmppdCk7CisgICAgICAgICAgICAgICAgICAg IAorICAgICAgICAgICAgICAgICAgICAvLyBGSVhNRTogV2Ugd291bGQgbm90IGhhdmUgdG8gZG8g dGhpcyBpZiB0aGUgc3RhY2sgY2hlY2sgd2FzIHBhcnQgb2YgdGhlIEFpcgorICAgICAgICAgICAg ICAgICAgICAvLyBwcm9sb2d1ZS4gVGhlbiwgd2Ugd291bGQga25vdyB0aGF0IHRoZXJlIGlzIG5v IHdheSBmb3IgdGhlIGNhbGxlZS1zYXZlcyB0bworICAgICAgICAgICAgICAgICAgICAvLyBnZXQg Y2xvYmJlcmVkLgorICAgICAgICAgICAgICAgICAgICAvLyBPT1BTISBOZWVkIGJ1ZyBVUkwuCisg ICAgICAgICAgICAgICAgICAgIGppdC5lbWl0UmVzdG9yZShwYXJhbXMucHJvYygpLmNhbGxlZVNh dmVSZWdpc3RlckF0T2Zmc2V0TGlzdCgpKTsKKyAgICAgICAgICAgICAgICAgICAgCiAgICAgICAg ICAgICAgICAgICAgIGppdC5zdG9yZTMyKAogICAgICAgICAgICAgICAgICAgICAgICAgTWFjcm9B c3NlbWJsZXI6OlRydXN0ZWRJbW0zMihjYWxsU2l0ZUluZGV4LmJpdHMoKSksCiAgICAgICAgICAg ICAgICAgICAgICAgICBDQ2FsbEhlbHBlcnM6OnRhZ0ZvcihWaXJ0dWFsUmVnaXN0ZXIoQ2FsbEZy YW1lU2xvdDo6YXJndW1lbnRDb3VudCkpKTsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9o ZWFwL1N1YnNwYWNlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVh cC9TdWJzcGFjZS5jcHAJKHJldmlzaW9uIDIxNzEzNSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9oZWFwL1N1YnNwYWNlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTIsNiArNTIsOCBAQCBzdHJ1 Y3QgRGVzdHJveUZ1bmMgewogICAgIH0KIH07CiAKKworCiB9IC8vIGFub255bW91cyBuYW1lc3Bh Y2UKIAogU3Vic3BhY2U6OlN1YnNwYWNlKENTdHJpbmcgbmFtZSwgSGVhcCYgaGVhcCwgQWxsb2Nh dG9yQXR0cmlidXRlcyBhdHRyaWJ1dGVzKQpAQCAtOTgsNiArMTAwLDcgQEAgdm9pZCogU3Vic3Bh Y2U6OmFsbG9jYXRlKHNpemVfdCBzaXplKQogICAgICAgICByZXN1bHQgPSBhbGxvY2F0b3ItPmFs bG9jYXRlKCk7CiAgICAgZWxzZQogICAgICAgICByZXN1bHQgPSBhbGxvY2F0ZVNsb3cobnVsbHB0 ciwgc2l6ZSk7CisgICAgZGlkQWxsb2NhdGUocmVzdWx0KTsKICAgICByZXR1cm4gcmVzdWx0Owog fQogCkBAIC0xMDgsNiArMTExLDcgQEAgdm9pZCogU3Vic3BhY2U6OmFsbG9jYXRlKEdDRGVmZXJy YWxDb250ZQogICAgICAgICByZXN1bHQgPSBhbGxvY2F0b3ItPmFsbG9jYXRlKGRlZmVycmFsQ29u dGV4dCk7CiAgICAgZWxzZQogICAgICAgICByZXN1bHQgPSBhbGxvY2F0ZVNsb3coZGVmZXJyYWxD b250ZXh0LCBzaXplKTsKKyAgICBkaWRBbGxvY2F0ZShyZXN1bHQpOwogICAgIHJldHVybiByZXN1 bHQ7CiB9CiAKQEAgLTExOCw2ICsxMjIsNyBAQCB2b2lkKiBTdWJzcGFjZTo6dHJ5QWxsb2NhdGUo c2l6ZV90IHNpemUpCiAgICAgICAgIHJlc3VsdCA9IGFsbG9jYXRvci0+dHJ5QWxsb2NhdGUoKTsK ICAgICBlbHNlCiAgICAgICAgIHJlc3VsdCA9IHRyeUFsbG9jYXRlU2xvdyhudWxscHRyLCBzaXpl KTsKKyAgICBkaWRBbGxvY2F0ZShyZXN1bHQpOwogICAgIHJldHVybiByZXN1bHQ7CiB9CiAKQEAg LTEyOCw2ICsxMzMsNyBAQCB2b2lkKiBTdWJzcGFjZTo6dHJ5QWxsb2NhdGUoR0NEZWZlcnJhbENv CiAgICAgICAgIHJlc3VsdCA9IGFsbG9jYXRvci0+dHJ5QWxsb2NhdGUoZGVmZXJyYWxDb250ZXh0 KTsKICAgICBlbHNlCiAgICAgICAgIHJlc3VsdCA9IHRyeUFsbG9jYXRlU2xvdyhkZWZlcnJhbENv bnRleHQsIHNpemUpOworICAgIGRpZEFsbG9jYXRlKHJlc3VsdCk7CiAgICAgcmV0dXJuIHJlc3Vs dDsKIH0KIApAQCAtMjA0LDUgKzIxMCwxMyBAQCB2b2lkKiBTdWJzcGFjZTo6dHJ5QWxsb2NhdGVT bG93KEdDRGVmZXJyCiAgICAgcmV0dXJuIGFsbG9jYXRpb24tPmNlbGwoKTsKIH0KIAorQUxXQVlT X0lOTElORSB2b2lkIFN1YnNwYWNlOjpkaWRBbGxvY2F0ZSh2b2lkKiBwdHIpCit7CisgICAgVU5V U0VEX1BBUkFNKHB0cik7CisgICAgCisgICAgLy8gVGhpcyBpcyB1c2VmdWwgZm9yIGxvZ2dpbmcg YWxsb2NhdGlvbnMsIG9yIGRvaW5nIG90aGVyIGtpbmRzIG9mIGRlYnVnZ2luZyBoYWNrcy4gSnVz dCBtYWtlCisgICAgLy8gc3VyZSB5b3UgSlNDX2ZvcmNlR0NTbG93UGF0aHM9dHJ1ZS4KK30KKwog fSAvLyBuYW1lc3BhY2UgSlNDCiAKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL1N1 YnNwYWNlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvU3Vic3Bh Y2UuaAkocmV2aXNpb24gMjE3MTM1KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvU3Vi c3BhY2UuaAkod29ya2luZyBjb3B5KQpAQCAtOTQsNiArOTQsOCBAQCBwcml2YXRlOgogICAgIHZv aWQqIGFsbG9jYXRlU2xvdyhHQ0RlZmVycmFsQ29udGV4dCosIHNpemVfdCk7CiAgICAgdm9pZCog dHJ5QWxsb2NhdGVTbG93KEdDRGVmZXJyYWxDb250ZXh0Kiwgc2l6ZV90KTsKICAgICAKKyAgICB2 b2lkIGRpZEFsbG9jYXRlKHZvaWQqKTsKKyAgICAKICAgICBNYXJrZWRTcGFjZSYgbV9zcGFjZTsK ICAgICAKICAgICBDU3RyaW5nIG1fbmFtZTsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9q aXQvQXNzZW1ibHlIZWxwZXJzLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3Jl L2ppdC9Bc3NlbWJseUhlbHBlcnMuaAkocmV2aXNpb24gMjE3MTM1KQorKysgU291cmNlL0phdmFT Y3JpcHRDb3JlL2ppdC9Bc3NlbWJseUhlbHBlcnMuaAkod29ya2luZyBjb3B5KQpAQCAtMjI5LDYg KzIyOSwzMSBAQCBwdWJsaWM6CiAgICAgICAgIHN0b3JlMzIoVHJ1c3RlZEltbTMyKHZhbHVlLnBh eWxvYWQoKSksIGFkZHJlc3Mud2l0aE9mZnNldChQYXlsb2FkT2Zmc2V0KSk7CiAjZW5kaWYKICAg ICB9CisgICAgCisgICAgQWRkcmVzcyBhZGRyZXNzRm9yKGNvbnN0IFJlZ2lzdGVyQXRPZmZzZXQm IGVudHJ5KQorICAgIHsKKyAgICAgICAgcmV0dXJuIEFkZHJlc3MoR1BSSW5mbzo6Y2FsbEZyYW1l UmVnaXN0ZXIsIGVudHJ5Lm9mZnNldCgpKTsKKyAgICB9CisgICAgCisgICAgdm9pZCBlbWl0U2F2 ZShjb25zdCBSZWdpc3RlckF0T2Zmc2V0TGlzdCYgbGlzdCkKKyAgICB7CisgICAgICAgIGZvciAo Y29uc3QgUmVnaXN0ZXJBdE9mZnNldCYgZW50cnkgOiBsaXN0KSB7CisgICAgICAgICAgICBpZiAo ZW50cnkucmVnKCkuaXNHUFIoKSkKKyAgICAgICAgICAgICAgICBzdG9yZVB0cihlbnRyeS5yZWco KS5ncHIoKSwgYWRkcmVzc0ZvcihlbnRyeSkpOworICAgICAgICAgICAgZWxzZQorICAgICAgICAg ICAgICAgIHN0b3JlRG91YmxlKGVudHJ5LnJlZygpLmZwcigpLCBhZGRyZXNzRm9yKGVudHJ5KSk7 CisgICAgICAgIH0KKyAgICB9CisgICAgCisgICAgdm9pZCBlbWl0UmVzdG9yZShjb25zdCBSZWdp c3RlckF0T2Zmc2V0TGlzdCYgbGlzdCkKKyAgICB7CisgICAgICAgIGZvciAoY29uc3QgUmVnaXN0 ZXJBdE9mZnNldCYgZW50cnkgOiBsaXN0KSB7CisgICAgICAgICAgICBpZiAoZW50cnkucmVnKCku aXNHUFIoKSkKKyAgICAgICAgICAgICAgICBsb2FkUHRyKGFkZHJlc3NGb3IoZW50cnkpLCBlbnRy eS5yZWcoKS5ncHIoKSk7CisgICAgICAgICAgICBlbHNlCisgICAgICAgICAgICAgICAgbG9hZERv dWJsZShhZGRyZXNzRm9yKGVudHJ5KSwgZW50cnkucmVnKCkuZnByKCkpOworICAgICAgICB9Cisg ICAgfQogCiAgICAgdm9pZCBlbWl0U2F2ZUNhbGxlZVNhdmVzRm9yKENvZGVCbG9jayogY29kZUJs b2NrKQogICAgIHsK