172433 2017-05-21 17:46:45 -0700 Do no enter Subversion-specific logic when parsing Git-based Trac data. 2017-05-22 17:32:14 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jmarcell webkit-unassigned kocsen_chung lforschler oldest_to_newest 1311181 0 jmarcell 2017-05-21 17:46:45 -0700 Do no enter Subversion-specific logic when parsing Git-based Trac data. 1311182 1 310822 jmarcell 2017-05-21 17:47:52 -0700 Created attachment 310822 Patch 1311183 2 310823 jmarcell 2017-05-21 17:49:49 -0700 Created attachment 310823 Patch 1311186 3 310823 ap 2017-05-21 18:20:43 -0700 Comment on attachment 310823 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=310823&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:182 > + // Note: we have an overidden timeline.rss that adds git branches to the Trac timeline RSS output (rdar://problem/23853623) I suggest removing "Note:", as every comment is a note. Please also add a period in the end to make it a proper sentence. 1311393 4 kocsen_chung 2017-05-22 09:34:31 -0700 👍, thanks Jason. 1311685 5 jmarcell 2017-05-22 17:32:14 -0700 Committed r217259 to https://svn.webkit.org/repository/webkit/trunk. https://trac.webkit.org/r217259 310822 2017-05-21 17:47:52 -0700 2017-05-21 17:49:48 -0700 Patch bug-172433-20170521174754.patch text/plain 2510 jmarcell U3VidmVyc2lvbiBSZXZpc2lvbjogMjE3MTk4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjg1NWZlYTc1MGUxMGUzM2YzYmEzMmJmZDY3ZDQ3MzA2 NGRhMmRlNC4uZmU3ZDhmZWMxMDczYjkxMzgwNjFlOWQ0NzViZmJmYjA4NzMyMjQ0YyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE3LTA1LTIxICBKYXNvbiBNYXJjZWxsICA8am1hcmNlbGxAYXBwbGUuY29tPgorCisg ICAgICAgIERvIG5vIGVudGVyIFN1YnZlcnNpb24tc3BlY2lmaWMgbG9naWMgd2hlbiBwYXJzaW5n IEdpdC1iYXNlZCBUcmFjIGRhdGEuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNzI0MzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmln L3B1YmxpY19odG1sL2Rhc2hib2FyZC9TY3JpcHRzL1RyYWMuanM6CisgICAgICAgIChUcmFjLnBy b3RvdHlwZS5fY29udmVydENvbW1pdEluZm9FbGVtZW50VG9PYmplY3QpOgorCiAyMDE3LTA1LTIw ICBUaW5nLVdlaSBMYW4gIDxsYW50dzQ0QGdtYWlsLmNvbT4KIAogICAgICAgICBbR1RLXSBndGtk b2MtZml4eHJlZiBuZWVkcyAtLW1vZHVsZSBhcmd1bWVudCB0byB3b3JrCmRpZmYgLS1naXQgYS9U b29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRt bC9kYXNoYm9hcmQvU2NyaXB0cy9UcmFjLmpzIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVp bGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1NjcmlwdHMvVHJhYy5q cwppbmRleCBiZjA1NmI1MGY1OWU1NTY1NDU5YTk1NTNlMDlkNjc1Y2RlYzkzMzdlLi4wOGEyNGYw ZGZkZWM4MDNlMjE4YmVjNTllMjliZTg3NTQyNmNlNzI1IDEwMDY0NAotLS0gYS9Ub29scy9CdWls ZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9h cmQvU2NyaXB0cy9UcmFjLmpzCisrKyBiL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndl YmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rhc2hib2FyZC9TY3JpcHRzL1RyYWMuanMKQEAg LTE3OSw2ICsxNzksOSBAQCBUcmFjLnByb3RvdHlwZSA9IHsKICAgICAgICAgaWYgKHRpdGxlLmZp cnN0Q2hpbGQgJiYgdGl0bGUuZmlyc3RDaGlsZC5ub2RlVHlwZSA9PSBOb2RlLlRFWFRfTk9ERSAm JiB0aXRsZS5maXJzdENoaWxkLnRleHRDb250ZW50Lmxlbmd0aCA+IDAgJiYgdGl0bGUuZmlyc3RD aGlsZC50ZXh0Q29udGVudFswXSA9PSAiXG4iKQogICAgICAgICAgICAgdGl0bGUuZmlyc3RDaGls ZC50ZXh0Q29udGVudCA9IHRpdGxlLmZpcnN0Q2hpbGQudGV4dENvbnRlbnQuc3Vic3RyaW5nKDEp OwogCisgICAgICAgIC8vIE5vdGU6IHdlIGhhdmUgYW4gb3ZlcmlkZGVuIHRpbWVsaW5lLnJzcyB0 aGF0IGFkZHMgZ2l0IGJyYW5jaGVzIHRvIHRoZSBUcmFjIHRpbWVsaW5lIFJTUyBvdXRwdXQgKHJk YXI6Ly9wcm9ibGVtLzIzODUzNjIzKQorICAgICAgICB2YXIgZ2l0QnJhbmNoZXMgPSBkb2MuZXZh bHVhdGUoIi4vYnJhbmNoZXMiLCBjb21taXRFbGVtZW50LCBudWxsLCBYUGF0aFJlc3VsdC5TVFJJ TkdfVFlQRSkuc3RyaW5nVmFsdWU7CisKICAgICAgICAgdmFyIHJlc3VsdCA9IHsKICAgICAgICAg ICAgIHJldmlzaW9uTnVtYmVyOiByZXZpc2lvbk51bWJlciwKICAgICAgICAgICAgIGxpbms6IGxp bmssCkBAIC0xOTAsNyArMTkzLDcgQEAgVHJhYy5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICBi cmFuY2hlczogW10KICAgICAgICAgfTsKIAotICAgICAgICBpZiAocmVzdWx0LmNvbnRhaW5zQnJh bmNoTG9jYXRpb24pIHsKKyAgICAgICAgaWYgKHJlc3VsdC5jb250YWluc0JyYW5jaExvY2F0aW9u ICYmICFnaXRCcmFuY2hlcykgewogICAgICAgICAgICAgY29uc29sZS5hc3NlcnQobG9jYXRpb25b bG9jYXRpb24ubGVuZ3RoIC0gMV0gIT09ICIvIik7CiAgICAgICAgICAgICBsb2NhdGlvbiA9IGxv Y2F0aW9uICs9ICIvIjsKICAgICAgICAgICAgIGlmIChsb2NhdGlvbi5zdGFydHNXaXRoKCJ0YWdz LyIpKQpAQCAtMjEwLDcgKzIxMyw2IEBAIFRyYWMucHJvdG90eXBlID0gewogICAgICAgICAgICAg fQogICAgICAgICB9CiAKLSAgICAgICAgdmFyIGdpdEJyYW5jaGVzID0gZG9jLmV2YWx1YXRlKCIu L2JyYW5jaGVzIiwgY29tbWl0RWxlbWVudCwgbnVsbCwgWFBhdGhSZXN1bHQuU1RSSU5HX1RZUEUp LnN0cmluZ1ZhbHVlOwogICAgICAgICBpZiAoZ2l0QnJhbmNoZXMpIHsKICAgICAgICAgICAgIHJl c3VsdC5jb250YWluc0JyYW5jaExvY2F0aW9uID0gdHJ1ZTsKICAgICAgICAgICAgIHJlc3VsdC5i cmFuY2hlcyA9IHJlc3VsdC5icmFuY2hlcy5jb25jYXQoZ2l0QnJhbmNoZXMuc3BsaXQoIiwgIikp Owo= 310823 2017-05-21 17:49:49 -0700 2017-05-21 18:20:43 -0700 Patch bug-172433-20170521174951.patch text/plain 2545 jmarcell U3VidmVyc2lvbiBSZXZpc2lvbjogMjE3MTk4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjg1NWZlYTc1MGUxMGUzM2YzYmEzMmJmZDY3ZDQ3MzA2 NGRhMmRlNC4uMWM3NGQyNzg0YTQ2ZmY2ZmU4OTYzMzQ4Y2VhMzM1YmRiM2FlZGJiMyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDE3LTA1LTIxICBKYXNvbiBNYXJjZWxsICA8am1hcmNlbGxAYXBwbGUuY29tPgorCisg ICAgICAgIERvIG5vIGVudGVyIFN1YnZlcnNpb24tc3BlY2lmaWMgbG9naWMgd2hlbiBwYXJzaW5n IEdpdC1iYXNlZCBUcmFjIGRhdGEuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNzI0MzMKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzMyMjM0MTg4Pgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQnVpbGRT bGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJk L1NjcmlwdHMvVHJhYy5qczoKKyAgICAgICAgKFRyYWMucHJvdG90eXBlLl9jb252ZXJ0Q29tbWl0 SW5mb0VsZW1lbnRUb09iamVjdCk6CisKIDIwMTctMDUtMjAgIFRpbmctV2VpIExhbiAgPGxhbnR3 NDRAZ21haWwuY29tPgogCiAgICAgICAgIFtHVEtdIGd0a2RvYy1maXh4cmVmIG5lZWRzIC0tbW9k dWxlIGFyZ3VtZW50IHRvIHdvcmsKZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0 L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rhc2hib2FyZC9TY3JpcHRzL1Ry YWMuanMgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9w dWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0cy9UcmFjLmpzCmluZGV4IGJmMDU2YjUwZjU5ZTU1 NjU0NTlhOTU1M2UwOWQ2NzVjZGVjOTMzN2UuLjA4YTI0ZjBkZmRlYzgwM2UyMThiZWM1OWUyOWJl ODc1NDI2Y2U3MjUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndl YmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rhc2hib2FyZC9TY3JpcHRzL1RyYWMuanMKKysr IGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGlj X2h0bWwvZGFzaGJvYXJkL1NjcmlwdHMvVHJhYy5qcwpAQCAtMTc5LDYgKzE3OSw5IEBAIFRyYWMu cHJvdG90eXBlID0gewogICAgICAgICBpZiAodGl0bGUuZmlyc3RDaGlsZCAmJiB0aXRsZS5maXJz dENoaWxkLm5vZGVUeXBlID09IE5vZGUuVEVYVF9OT0RFICYmIHRpdGxlLmZpcnN0Q2hpbGQudGV4 dENvbnRlbnQubGVuZ3RoID4gMCAmJiB0aXRsZS5maXJzdENoaWxkLnRleHRDb250ZW50WzBdID09 ICJcbiIpCiAgICAgICAgICAgICB0aXRsZS5maXJzdENoaWxkLnRleHRDb250ZW50ID0gdGl0bGUu Zmlyc3RDaGlsZC50ZXh0Q29udGVudC5zdWJzdHJpbmcoMSk7CiAKKyAgICAgICAgLy8gTm90ZTog d2UgaGF2ZSBhbiBvdmVyaWRkZW4gdGltZWxpbmUucnNzIHRoYXQgYWRkcyBnaXQgYnJhbmNoZXMg dG8gdGhlIFRyYWMgdGltZWxpbmUgUlNTIG91dHB1dCAocmRhcjovL3Byb2JsZW0vMjM4NTM2MjMp CisgICAgICAgIHZhciBnaXRCcmFuY2hlcyA9IGRvYy5ldmFsdWF0ZSgiLi9icmFuY2hlcyIsIGNv bW1pdEVsZW1lbnQsIG51bGwsIFhQYXRoUmVzdWx0LlNUUklOR19UWVBFKS5zdHJpbmdWYWx1ZTsK KwogICAgICAgICB2YXIgcmVzdWx0ID0gewogICAgICAgICAgICAgcmV2aXNpb25OdW1iZXI6IHJl dmlzaW9uTnVtYmVyLAogICAgICAgICAgICAgbGluazogbGluaywKQEAgLTE5MCw3ICsxOTMsNyBA QCBUcmFjLnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgIGJyYW5jaGVzOiBbXQogICAgICAgICB9 OwogCi0gICAgICAgIGlmIChyZXN1bHQuY29udGFpbnNCcmFuY2hMb2NhdGlvbikgeworICAgICAg ICBpZiAocmVzdWx0LmNvbnRhaW5zQnJhbmNoTG9jYXRpb24gJiYgIWdpdEJyYW5jaGVzKSB7CiAg ICAgICAgICAgICBjb25zb2xlLmFzc2VydChsb2NhdGlvbltsb2NhdGlvbi5sZW5ndGggLSAxXSAh PT0gIi8iKTsKICAgICAgICAgICAgIGxvY2F0aW9uID0gbG9jYXRpb24gKz0gIi8iOwogICAgICAg ICAgICAgaWYgKGxvY2F0aW9uLnN0YXJ0c1dpdGgoInRhZ3MvIikpCkBAIC0yMTAsNyArMjEzLDYg QEAgVHJhYy5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICB9CiAgICAgICAgIH0KIAotICAgICAg ICB2YXIgZ2l0QnJhbmNoZXMgPSBkb2MuZXZhbHVhdGUoIi4vYnJhbmNoZXMiLCBjb21taXRFbGVt ZW50LCBudWxsLCBYUGF0aFJlc3VsdC5TVFJJTkdfVFlQRSkuc3RyaW5nVmFsdWU7CiAgICAgICAg IGlmIChnaXRCcmFuY2hlcykgewogICAgICAgICAgICAgcmVzdWx0LmNvbnRhaW5zQnJhbmNoTG9j YXRpb24gPSB0cnVlOwogICAgICAgICAgICAgcmVzdWx0LmJyYW5jaGVzID0gcmVzdWx0LmJyYW5j aGVzLmNvbmNhdChnaXRCcmFuY2hlcy5zcGxpdCgiLCAiKSk7Cg==