172416 2017-05-20 10:31:45 -0700 make-new-script-test should create tests that use js-test.js, not js-test-pre.js 2017-05-20 11:15:11 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap commit-queue dbates lforschler oldest_to_newest 1311016 0 ap 2017-05-20 10:31:45 -0700 It is easier to use js-test in most cases. As I'm updating tests that misuse js-test-pre, I'm finding lots of convoluted and/or incorrect test code. 1311017 1 310774 ap 2017-05-20 10:33:26 -0700 Created attachment 310774 proposed patch 1311018 2 310774 dbates 2017-05-20 10:47:22 -0700 Comment on attachment 310774 proposed patch OK. 1311021 3 310774 commit-queue 2017-05-20 11:15:10 -0700 Comment on attachment 310774 proposed patch Clearing flags on attachment: 310774 Committed r217186: <http://trac.webkit.org/changeset/217186> 1311022 4 commit-queue 2017-05-20 11:15:11 -0700 All reviewed patches have been landed. Closing bug. 310774 2017-05-20 10:33:26 -0700 2017-05-20 11:15:10 -0700 proposed patch make-new-script-test.txt text/plain 1629 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIxNzE4NSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEyIEBACisyMDE3LTA1LTIwICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIG1ha2UtbmV3LXNjcmlwdC10ZXN0IHNob3VsZCBjcmVhdGUgdGVzdHMgdGhh dCB1c2UganMtdGVzdC5qcywgbm90IGpzLXRlc3QtcHJlLmpzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzI0MTYKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvbWFrZS1uZXctc2NyaXB0LXRl c3Q6CisKIDIwMTctMDUtMTkgIEZ1amlpIEhpcm9ub3JpICA8SGlyb25vcmkuRnVqaWlAc29ueS5j b20+CiAKICAgICAgICAgW1dpbl0gZXJyb3IgTE5LMjAwNTogV2ViQ29yZTo6SlNOb2RlOjpjaGVj a1N1YkNsYXNzUGF0Y2hwb2ludCgpIGFscmVhZHkgZGVmaW5lZCBpbiBXZWJLaXQubGliCkluZGV4 OiBUb29scy9TY3JpcHRzL21ha2UtbmV3LXNjcmlwdC10ZXN0Cj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xz L1NjcmlwdHMvbWFrZS1uZXctc2NyaXB0LXRlc3QJKHJldmlzaW9uIDIxNjgyNikKKysrIFRvb2xz L1NjcmlwdHMvbWFrZS1uZXctc2NyaXB0LXRlc3QJKHdvcmtpbmcgY29weSkKQEAgLTIzLDcgKzIz LDcgQEAKICMgKElOQ0xVRElORyBORUdMSUdFTkNFIE9SIE9USEVSV0lTRSkgQVJJU0lORyBJTiBB TlkgV0FZIE9VVCBPRiBUSEUgVVNFIE9GCiAjIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNF RCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCiAKLSMgU2NyaXB0IHRvIGNyZWF0 ZSBhIG5ldyBIVE1MIGZpbGUgZm9yIGEgbW9ub2xpdGhpYyB0ZXN0IHVzaW5nIGpzLXRlc3QgbWFj aGluZXJ5LgorIyBTY3JpcHQgdG8gY3JlYXRlIGEgbmV3IEhUTUwgZmlsZSB1c2luZyBqcy10ZXN0 IG1hY2hpbmVyeS4KIAogdXNlIHN0cmljdDsKIApAQCAtOTYsNyArOTYsNyBAQCBzdWIgd3JpdGVU ZXN0RmlsZQogPGh0bWw+CiA8aGVhZD4KIDxtZXRhIGNoYXJzZXQ9InV0Zi04Ij4KLTxzY3JpcHQg c3JjPSIkcGF0aFRvU2hhcmVkU291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8c2Ny aXB0IHNyYz0iJHBhdGhUb1NoYXJlZFNvdXJjZXMvanMtdGVzdC5qcyI+PC9zY3JpcHQ+CiA8L2hl YWQ+CiA8Ym9keT4KIDxzY3JpcHQ+CkBAIC0xMDYsNyArMTA2LDYgQEAgZGVzY3JpcHRpb24oIlRF U1QgREVTQ1JJUFRJT04gSEVSRSIpOwogLy8gWW91ciB0ZXN0IHNjcmlwdCBoZXJlLiBGZWVsIGZy ZWUgdG8gbW9kaWZ5IHN1cnJvdW5kaW5nIEhUTUwgY29kZSBpZiBuZWNlc3NhcnkuCiAKIDwvc2Ny aXB0PgotPHNjcmlwdCBzcmM9IiRwYXRoVG9TaGFyZWRTb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+ PC9zY3JpcHQ+CiA8L2JvZHk+CiA8L2h0bWw+CiBFT0YK